[HDInsight] Support the latest azure monitor api #14496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 22 commits
October 10, 2020 15:56
…i in 2015-03-01-preview
|
Hi, @aim-for-better Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Swagger Generation Artifacts
|
|
NewApiVersionRequired reason: |
|
Hi, @aim-for-better your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @leni-msft |
This was referenced May 20, 2021
This was referenced May 20, 2021
JeffreyRichter
added
the
Approved-BreakingChange
JeffreyRichter
approved these changes
May 24, 2021
leni-msft
approved these changes
May 25, 2021
Thanks~ |
|
Hi @RamyasreeChakka , Thanks for your review. Our backend only returns 202 for the put request without any schema. |
| "in": "body", | ||
| "required": true, | ||
| "schema": { | ||
| "$ref": "#/definitions/AzureMonitorRequest" |
There was a problem hiding this comment.
The PUT request body doesn't match the ARM standard pattern at all. I see properties workspaceId, primaryKey are exposed at top-level instead of having them under properties envelope. For more details, refer RPC here https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/resource-api-reference.md#resource-request-properties-envelope
However, I understand the swagger already defined the extensions API and this PR is just adding an instance of extension resource. I would give the exception for this reason and sign off.
I would recommend to have a workItem/task on your side to correct the request/response formats in future new API versions.
There was a problem hiding this comment.
Hi @RamyasreeChakka, Thanks for your comment and approval.
it seems that the we follow the rule: the workspaceId and primaryKey under that properties of the AzureMonitorRequest definion. Could you please help me understand better about this rule so that our service can satisfy the ARM standard pattern next time?
"AzureMonitorRequest":
{
"description": "The azure monitor parameters.",
"properties":
{
"workspaceId": {
"description": "The Log Analytics workspace ID.",
"type": "string"
},
"primaryKey": {
"description": "The Log Analytics workspace key.",
"type": "string"
},
"selectedConfigurations": {
"description": "The selected configurations.",
"$ref": "#/definitions/AzureMonitorSelectedConfigurations"
}
}
}
RamyasreeChakka
added
ARMSignedOff
This was referenced May 27, 2021
Closed
Closed
11 tasks
|
/azp run |
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* Add networkProperties and clusterId * Add Azure Monitor API * Add azure monitor examples and modify descriptions and add related api in 2015-03-01-preview Co-authored-by: Zhenyu Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
This PR supports GET, PUT and DELETE of the API "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.HDInsight/clusters/{clusterName}/extensions/azureMonitor"
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Now it is.
As soon as possible, ETA is 5/27/2021
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.