Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL Flexible Server GA Swagger API changes #14653

Merged
merged 9 commits into from
Jun 8, 2021
Merged

PostgreSQL Flexible Server GA Swagger API changes #14653

merged 9 commits into from
Jun 8, 2021

Conversation

xunsun-commits
Copy link
Contributor

@xunsun-commits xunsun-commits commented Jun 3, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?

    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
    2021 May.

  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
    2021 June.

  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.

    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @xunsun-commits Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 3, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 52 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ R1003 - ListInOperationName Since operation 'LocationBasedCapabilities_Execute' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L916
    ⚠️ R1003 - ListInOperationName Since operation 'VirtualNetworkSubnetUsage_Execute' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L958
    ⚠️ R1003 - ListInOperationName Since operation 'LocationBasedCapabilities_Execute' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L916
    ⚠️ R1003 - ListInOperationName Since operation 'VirtualNetworkSubnetUsage_Execute' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L958
    ⚠️ R1005 - GetInOperationName 'GET' operation 'LocationBasedCapabilities_Execute' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L916
    ⚠️ R1005 - GetInOperationName 'GET' operation 'LocationBasedCapabilities_Execute' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L916
    ⚠️ R1006 - PutInOperationName 'PUT' operation 'Configurations_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L813
    ⚠️ R1006 - PutInOperationName 'PUT' operation 'Configurations_Put' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L813
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L1002
    ⚠️ R2029 - PageableOperation Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension.
    Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1002


    The following errors/warnings exist before current PR submission:

    Rule Message
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable
    Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1885
    ⚠️ R3018 - EnumInsteadOfBoolean Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: nameAvailable
    Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L1885
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/postgresql/resource-manager/readme.md
    tag: specification/postgresql/resource-manager/readme.md#tag-package-2020-01-01
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 182 Errors, 0 Warnings failed [Detail]
    The following breaking changes are detected by comparison with the latest stable version:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSQL/servers/{serverName}' removed or restructured?
    Old: Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json#L37:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSQL/servers' removed or restructured?
    Old: Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json#L244:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.DBForPostgreSQL/servers' removed or restructured?
    Old: Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json#L286:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSQL/servers/{serverName}/replicas' removed or restructured?
    Old: Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json#L325:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSQL/servers/{serverName}/restart' removed or restructured?
    Old: Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json#L370:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSQL/servers/{serverName}/firewallRules/{firewallRuleName}' removed or restructured?
    Old: Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json#L413:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSQL/servers/{serverName}/firewallRules' removed or restructured?
    Old: Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json#L567:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSQL/servers/{serverName}/virtualNetworkRules/{virtualNetworkRuleName}' removed or restructured?
    Old: Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json#L612:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSQL/servers/{serverName}/virtualNetworkRules' removed or restructured?
    Old: Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json#L757:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.DBForPostgreSQL/servers/{serverName}/databases/{databaseName}' removed or restructured?
    Old: Microsoft.DBforPostgreSQL/stable/2017-12-01/postgresql.json#L799:5


    The following breaking changes are detected by comparison with latest preview version:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'StorageProfile' removed or renamed?
    New: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L1035:3
    Old: Microsoft.DBforPostgreSQL/preview/2020-02-14-preview/postgresql.json#L968:3
    1006 - RemovedDefinition The new version is missing a definition that was found in the old version. Was 'StorageProfile' removed or renamed?
    New: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1035:3
    Old: Microsoft.DBforPostgreSQL/preview/2020-02-14-preview/postgresql.json#L968:3
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'haState' renamed or removed?
    New: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L1237:7
    Old: Microsoft.DBforPostgreSQL/preview/2020-02-14-preview/postgresql.json#L1169:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'displayName' renamed or removed?
    New: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L1237:7
    Old: Microsoft.DBforPostgreSQL/preview/2020-02-14-preview/postgresql.json#L1169:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'storageProfile' renamed or removed?
    New: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L1237:7
    Old: Microsoft.DBforPostgreSQL/preview/2020-02-14-preview/postgresql.json#L1169:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'publicNetworkAccess' renamed or removed?
    New: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L1237:7
    Old: Microsoft.DBforPostgreSQL/preview/2020-02-14-preview/postgresql.json#L1169:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'haEnabled' renamed or removed?
    New: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L1237:7
    Old: Microsoft.DBforPostgreSQL/preview/2020-02-14-preview/postgresql.json#L1169:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'sourceServerName' renamed or removed?
    New: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L1237:7
    Old: Microsoft.DBforPostgreSQL/preview/2020-02-14-preview/postgresql.json#L1169:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'sourceSubscriptionId' renamed or removed?
    New: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L1237:7
    Old: Microsoft.DBforPostgreSQL/preview/2020-02-14-preview/postgresql.json#L1169:7
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'sourceResourceGroupName' renamed or removed?
    New: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/postgresql.json#L1237:7
    Old: Microsoft.DBforPostgreSQL/preview/2020-02-14-preview/postgresql.json#L1169:7
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"postgresql/resource-manager/readme.md",
    "tag":"package-2021-06-01",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"postgresql/resource-manager/readme.md",
    "tag":"package-2021-06-01",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"postgresql/resource-manager/readme.md",
    "tag":"package-2021-06-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"postgresql/resource-manager/readme.md",
    "tag":"package-2021-06-01-preview",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"postgresql/resource-manager/readme.md",
    "tag":"package-2021-06-01-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 3, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-rdbms - 8.1.0b4
    ️✔️azure-sdk-for-go - postgresql/mgmt/2021-06-01/postgresqlflexibleservers - v55.1.0
    ️✔️azure-sdk-for-go - postgresql/mgmt/2020-01-01/postgresql - v55.1.0
    ️✔️azure-sdk-for-go - postgresql/mgmt/2017-12-01/postgresql - v55.1.0
    ️✔️azure-sdk-for-go - preview/postgresql/mgmt/2021-06-01-preview/postgresqlflexibleservers - v55.1.0
    ️✔️azure-sdk-for-go - preview/postgresql/mgmt/2020-11-05-preview/postgresqlflexibleservers - v55.1.0
    ️✔️azure-sdk-for-go - preview/postgresql/mgmt/2020-02-14-preview/postgresqlflexibleservers - v55.1.0
    ️✔️azure-sdk-for-go - preview/postgresql/mgmt/2017-12-01-preview/postgresql - v55.1.0
    ️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 261d0e3. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] 2021-06-08 00:46:27 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-postgresql;1.0.0;1.1.0-beta.1"
      cmderr	[generate.py] 2021-06-08 00:46:27 WARNING [VERSION][Not Implement] set to current version "1.1.0-beta.1" by default
      cmderr	[generate.py] 2021-06-08 00:46:27 INFO autorest --version=3.1.3 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/postgresql/azure-resourcemanager-postgresql --java.namespace=com.azure.resourcemanager.postgresql   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL ../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md
      cmderr	[generate.py] 2021-06-08 00:46:58 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-postgresql
      cmderr	[generate.py] 2021-06-08 00:46:58 INFO [POM][Process] dealing with pom.xml
      cmderr	[generate.py] 2021-06-08 00:46:58 INFO [POM][Skip] pom already has module azure-resourcemanager-postgresql
      cmderr	[generate.py] 2021-06-08 00:46:58 INFO [POM][Success] Write to pom.xml
      cmderr	[generate.py] 2021-06-08 00:46:58 INFO [POM][Process] dealing with root pom
      cmderr	[generate.py] 2021-06-08 00:46:58 INFO [POM][Skip] pom already has module sdk/postgresql
      cmderr	[generate.py] 2021-06-08 00:46:58 INFO [POM][Success] Write to root pom
    • ️✔️azure-resourcemanager-postgresql [View full logs]  [Release SDK Changes]
      cmderr	[Inst] 2021-06-08 00:49:28 DEBUG Got artifact_id: azure-resourcemanager-postgresql
      cmderr	[Inst] 2021-06-08 00:49:28 DEBUG Got artifact: pom.xml
      cmderr	[Inst] 2021-06-08 00:49:28 DEBUG Got artifact: azure-resourcemanager-postgresql-1.1.0-beta.1-sources.jar
      cmderr	[Inst] 2021-06-08 00:49:28 DEBUG Got artifact: azure-resourcemanager-postgresql-1.1.0-beta.1-javadoc.jar
      cmderr	[Inst] 2021-06-08 00:49:28 DEBUG Got artifact: azure-resourcemanager-postgresql-1.1.0-beta.1.jar
      cmderr	[Inst] 2021-06-08 00:49:28 DEBUG Match jar package: azure-resourcemanager-postgresql-1.1.0-beta.1.jar
      cmderr	[Inst] 2021-06-08 00:49:28 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14653/azure-sdk-for-java/azure-resourcemanager-postgresql/azure-resourcemanager-postgresql-1.1.0-beta.1.jar\" -o azure-resourcemanager-postgresql-1.1.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-postgresql -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-postgresql-1.1.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
      ```"}
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 261d0e3. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️postgresql/mgmt/2021-06-01/postgresqlflexibleservers [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️postgresql/mgmt/2020-01-01/postgresql [View full logs]  [Release SDK Changes]
      Only show 18 items here, please refer to log for details.
      info	[Changelog] - New struct `RecoverableServerProperties`
      info	[Changelog] - New struct `RecoverableServerResource`
      info	[Changelog] - New struct `RecoverableServersClient`
      info	[Changelog] - New struct `ServerBasedPerformanceTierClient`
      info	[Changelog] - New struct `ServerParametersClient`
      info	[Changelog] - New struct `ServerParametersListUpdateConfigurationsFuture`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResult`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
      info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 60 additive change(s).
      info	[Changelog]
    • ️✔️postgresql/mgmt/2017-12-01/postgresql [View full logs]  [Release SDK Changes]
      Only show 18 items here, please refer to log for details.
      info	[Changelog] - New struct `RecoverableServerProperties`
      info	[Changelog] - New struct `RecoverableServerResource`
      info	[Changelog] - New struct `RecoverableServersClient`
      info	[Changelog] - New struct `ServerBasedPerformanceTierClient`
      info	[Changelog] - New struct `ServerParametersClient`
      info	[Changelog] - New struct `ServerParametersListUpdateConfigurationsFuture`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResult`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
      info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 60 additive change(s).
      info	[Changelog]
    • ️✔️preview/postgresql/mgmt/2021-06-01-preview/postgresqlflexibleservers [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️preview/postgresql/mgmt/2020-11-05-preview/postgresqlflexibleservers [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New struct `ServerPropertiesPrivateDNSZoneArguments`
      info	[Changelog] - New field `PrivateDNSZoneArguments` in struct `ServerProperties`
      info	[Changelog] - New field `SourceSubscriptionID` in struct `ServerProperties`
      info	[Changelog] - New field `SourceResourceGroupName` in struct `ServerProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
      info	[Changelog]
    • ️✔️preview/postgresql/mgmt/2020-02-14-preview/postgresqlflexibleservers [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New struct `ServerPropertiesPrivateDNSZoneArguments`
      info	[Changelog] - New field `PrivateDNSZoneArguments` in struct `ServerProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 3 additive change(s).
      info	[Changelog]
    • ️✔️preview/postgresql/mgmt/2017-12-01-preview/postgresql [View full logs]  [Release SDK Changes]
      Only show 18 items here, please refer to log for details.
      info	[Changelog] - New struct `RecoverableServerProperties`
      info	[Changelog] - New struct `RecoverableServerResource`
      info	[Changelog] - New struct `RecoverableServersClient`
      info	[Changelog] - New struct `ServerBasedPerformanceTierClient`
      info	[Changelog] - New struct `ServerParametersClient`
      info	[Changelog] - New struct `ServerParametersListUpdateConfigurationsFuture`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResult`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultIterator`
      info	[Changelog] - New struct `ServerSecurityAlertPolicyListResultPage`
      info	[Changelog] - New field `MinBackupRetentionDays` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MinLargeStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxLargeStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MinStorageMB` in struct `PerformanceTierProperties`
      info	[Changelog] - New field `MaxBackupRetentionDays` in struct `PerformanceTierProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 60 additive change(s).
      info	[Changelog]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 261d0e3. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/postgresql/resource-manager/readme.md
    • ️✔️@azure/arm-postgresql [View full logs]  [Release SDK Changes]
      cmderr	[npmPack] loaded rollup.config.js with warnings
      cmderr	[npmPack] (!) Unused external imports
      cmderr	[npmPack] default imported from external module 'rollup' but never used
      cmderr	[npmPack] ./esm/postgreSQLManagementClient.js → ./dist/arm-postgresql.js...
      cmderr	[npmPack] created ./dist/arm-postgresql.js in 449ms
    ️️✔️ azure-resource-manager-schemas succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 261d0e3. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️postgresql [View full logs]  [Release Schema Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 3, 2021
    @openapi-workflow-bot
    Copy link

    Hi, @xunsun-commits your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). cc @ArcturusZhang

    Copy link
    Member

    @majastrz majastrz left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Signed off from ARM side. @ArcturusZhang I went by the linter results to determine whether the breaking changes review is required. It looks like it passed.

    … package-2020-01-01. Reason is that the CSharp md file hasn't support flexible server yet, so the CSharp build will fail in latest version.
    @ArcturusZhang
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @ArcturusZhang ArcturusZhang merged commit 261d0e3 into Azure:master Jun 8, 2021
    This was referenced Jun 8, 2021
    @DaeunYim DaeunYim mentioned this pull request Jun 9, 2021
    26 tasks
    asager pushed a commit to asager/azure-rest-api-specs that referenced this pull request Jun 24, 2021
    * Copy existing files from 2020-02-14-preview to 2021-06-01-preview and 2021-06-01
    
    * Copy existing Databases API files from 2020-11-05-preview to 2021-06-01
    
    * Copy existing VNET API files from 2021-03-31-privatepreview to 2021-06-01
    
    * Copy existing ServerRestartWithFailover.json file from Azure@905c382 to 2021-06-01-preview and 2021-06-01
    
    * Copy remaining existing change of restartWithFailover
    
    * Update files of 2021-06-01 and 2021-06-01-preview to the latest API
    
    * Revert readme.md's PostgreSQLManagementClient default version back to package-2020-01-01. Reason is that the CSharp md file hasn't support flexible server yet, so the CSharp build will fail in latest version.
    
    * As customer requested, add PUT to configurations API
    
    * Fixed 2021-06-01-preview some examples use 2020-02-14-preview
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    * Copy existing files from 2020-02-14-preview to 2021-06-01-preview and 2021-06-01
    
    * Copy existing Databases API files from 2020-11-05-preview to 2021-06-01
    
    * Copy existing VNET API files from 2021-03-31-privatepreview to 2021-06-01
    
    * Copy existing ServerRestartWithFailover.json file from Azure@905c382 to 2021-06-01-preview and 2021-06-01
    
    * Copy remaining existing change of restartWithFailover
    
    * Update files of 2021-06-01 and 2021-06-01-preview to the latest API
    
    * Revert readme.md's PostgreSQLManagementClient default version back to package-2020-01-01. Reason is that the CSharp md file hasn't support flexible server yet, so the CSharp build will fail in latest version.
    
    * As customer requested, add PUT to configurations API
    
    * Fixed 2021-06-01-preview some examples use 2020-02-14-preview
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants