Add Cert and Domain Registration APIs. Fix publishingcredentialpolici… #14738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es collection API response. Add networkconfig API verbs for sites and slots
|
Hi, @naveedaz Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
| Guid used in model definition 'CloningInfo' for property 'correlationId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Web/stable/2021-01-15/CommonDefinitions.json#L520 |
|
| Guid used in model definition 'Operation' for property 'geoMasterOperationId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Web/stable/2021-01-15/CommonDefinitions.json#L1661 |
|
| Guid used in model definition 'Site' for property 'inProgressOperationId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Web/stable/2021-01-15/CommonDefinitions.json#L2126 |
|
| Guid used in model definition 'Recommendation' for property 'recommendationId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Web/stable/2021-01-15/Recommendations.json#L761 |
|
| Guid used in model definition 'RecommendationRule' for property 'recommendationId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Web/stable/2021-01-15/Recommendations.json#L939 |
|
| Guid used in model definition 'SitePatchResource' for property 'inProgressOperationId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.Web/stable/2021-01-15/WebApps.json#L25391 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: lightTheme Location: Microsoft.CertificateRegistration/stable/2021-01-15/AppServiceCertificateOrders.json#L1671 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: forceHardDeleteDomain Location: Microsoft.DomainRegistration/stable/2021-01-15/Domains.json#L325 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: available Location: Microsoft.DomainRegistration/stable/2021-01-15/Domains.json#L1011 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: includePrivacy Location: Microsoft.DomainRegistration/stable/2021-01-15/TopLevelDomains.json#L234 |
The following errors/warnings exist before current PR submission:
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
"readme":"web/resource-manager/readme.md", "tag":"default", "details":"swagger-document/compose - FAILED" |
|
"readme":"web/resource-manager/readme.md", "tag":"default", "details":"Error: '$.paths["/subscriptions/subscriptionId/providers/Microsoft.Web/hostingEnvironments"].get.parameters' has incompatible values (---- $ref: '#/parameters/subscriptionIdParameter'- name: api-version in: query description: API Version required: true type: string enum: - '2021-01-15', ---" |
| Per the Noun_Verb convention for Operation Ids, the noun 'DeletedWebApps' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-01-15/DeletedWebApps.json#L106 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Diagnostics' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-01-15/Diagnostics.json#L281 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Diagnostics' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-01-15/Diagnostics.json#L334 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Diagnostics' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-01-15/Diagnostics.json#L954 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Diagnostics' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-01-15/Diagnostics.json#L1014 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Recommendations' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-01-15/Recommendations.json#L102 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Recommendations' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-01-15/Recommendations.json#L405 |
|
| Per the Noun_Verb convention for Operation Ids, the noun 'Recommendations' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Web/stable/2021-01-15/Recommendations.json#L712 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 70 Errors, 0 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.10)
- current:stable/2021-01-15/AppServiceCertificateOrders.json compared with base:stable/2021-01-01/AppServiceCertificateOrders.json
- current:stable/2021-01-15/CertificateOrdersDiagnostics.json compared with base:stable/2021-01-01/CertificateOrdersDiagnostics.json
- current:stable/2021-01-15/CertificateRegistrationProvider.json compared with base:stable/2021-01-01/CertificateRegistrationProvider.json
- current:stable/2021-01-15/DomainRegistrationProvider.json compared with base:stable/2021-01-01/DomainRegistrationProvider.json
- current:stable/2021-01-15/Domains.json compared with base:stable/2021-01-01/Domains.json
- current:stable/2021-01-15/TopLevelDomains.json compared with base:stable/2021-01-01/TopLevelDomains.json
Only 10 items are listed, please refer to log for more details.
️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
|:speech_balloon: AutorestCore/Exception|"readme":"web/resource-manager/readme.md",
"tag":"package-2021-01",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"web/resource-manager/readme.md",
"tag":"package-2021-01",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"web/resource-manager/readme.md",
"tag":"package-2021-01-15",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"web/resource-manager/readme.md",
"tag":"package-2021-01-15",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
The following errors/warnings exist before current PR submission:
|:speech_balloon: AutorestCore/Exception|"readme":"web/resource-manager/readme.md",
"tag":"package-2021-01",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
Swagger Generation Artifacts
|
This was referenced Jun 9, 2021
This was referenced Jun 9, 2021
weidongxu-microsoft
approved these changes
Jun 10, 2021
|
You can merge without review if target is not master. |
|
@weidongxu-microsoft |
|
I think you can ignore both. LintDiff does not have new error (but have some new warning you might want to double check). "Cross-Version Breaking Changes" is kind of false alert here as it just report on "type: object" changes (which in previous version is implicit as object). |
|
Thanks @weidongxu-microsoft. Please merge. |
weidongxu-microsoft
pushed a commit
that referenced
this pull request
Jun 24, 2021
* Adds base for updating Microsoft.Web from version stable/2021-01-01 to version 2021-01-15 * Updates readme * Updates API version in new specs and examples * Add Cert and Domain Registration APIs. Fix publishingcredentialpolici… (#14738) * Add Cert and Domain Registration APIs. Fix publishingcredentialpolicies collection API response. Add networkconfig API verbs for sites and slots * Fix examples * Fix issue R4037 * Fix lintDiff issues * Fix more issues Co-authored-by: Naveed Aziz <[email protected]> * Add x-ms-pageable for ListBasicPublishingCredentialsPolicies APIs (#14960) Co-authored-by: Naveed Aziz <[email protected]>
26 tasks
weidongxu-microsoft
pushed a commit
that referenced
this pull request
Jul 14, 2021
* Adds base for updating Microsoft.Web from version stable/2021-01-01 to version 2021-01-15 * Updates readme * Updates API version in new specs and examples * Add Cert and Domain Registration APIs. Fix publishingcredentialpolici… (#14738) * Add Cert and Domain Registration APIs. Fix publishingcredentialpolicies collection API response. Add networkconfig API verbs for sites and slots * Fix examples * Fix issue R4037 * Fix lintDiff issues * Fix more issues Co-authored-by: Naveed Aziz <[email protected]> * Add x-ms-pageable for ListBasicPublishingCredentialsPolicies APIs (#14960) Co-authored-by: Naveed Aziz <[email protected]> (cherry picked from commit d9249ed)
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* Adds base for updating Microsoft.Web from version stable/2021-01-01 to version 2021-01-15 * Updates readme * Updates API version in new specs and examples * Add Cert and Domain Registration APIs. Fix publishingcredentialpolici… (Azure#14738) * Add Cert and Domain Registration APIs. Fix publishingcredentialpolicies collection API response. Add networkconfig API verbs for sites and slots * Fix examples * Fix issue R4037 * Fix lintDiff issues * Fix more issues Co-authored-by: Naveed Aziz <[email protected]> * Add x-ms-pageable for ListBasicPublishingCredentialsPolicies APIs (Azure#14960) Co-authored-by: Naveed Aziz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…es collection API response. Add networkconfig API verbs for sites and slots
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.