Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new version 2021-06-01-preview to support datasource auth crede… #14792

Conversation

vikramkotturu
Copy link
Contributor

…ntials input.

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @vikramkotturu Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 14, 2021

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 15 Warnings warning [Detail]
    The following errors/warnings are introduced by current PR:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    ⚠️ R1001 - OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'BackupInstances' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L1797
    ⚠️ R1003 - ListInOperationName Since operation 'BackupVaults_GetResourcesInSubscription' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L27
    ⚠️ R1003 - ListInOperationName Since operation 'BackupVaults_GetResourcesInResourceGroup' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L190
    ⚠️ R1003 - ListInOperationName Since operation 'RecoveryPoints_GetList' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L1239
    ⚠️ R1007 - PatchInOperationName 'PATCH' operation 'BackupVaults_Patch' should use method name 'Update'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L392
    ⚠️ R2066 - PostOperationIdContainsUrlVerb OperationId should contain the verb: 'findrestorabletimeranges' in:'FindRestorableTimeRanges_Post'. Consider updating the operationId
    Location: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L2000
    ⚠️ R4000 - ParameterDescriptionRequired 'backupPolicyName' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L759
    ⚠️ R4000 - ParameterDescriptionRequired 'backupInstanceName' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L1546
    ⚠️ R4000 - ParameterDescriptionRequired 'backupInstanceName' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L1613
    ⚠️ R4000 - ParameterDescriptionRequired 'backupInstanceName' parameter lacks 'description' property. Consider adding a 'description' element. Accurate description is essential for maintaining reference documentation.
    Location: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L1680


    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    R4037 - MissingTypeObject The schema 'AzureBackupFindRestorableTimeRangesRequestResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L2414
    R4037 - MissingTypeObject The schema 'AzureBackupFindRestorableTimeRangesResponseResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L2444
    R4037 - MissingTypeObject The schema 'AzureBackupRecoveryPointResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L2705
    R4037 - MissingTypeObject The schema 'BackupInstanceResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L3002
    R4037 - MissingTypeObject The schema 'BackupVaultResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L3125
    R4037 - MissingTypeObject The schema 'BaseBackupPolicyResource' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L3185
    R4037 - MissingTypeObject The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L3383
    R4037 - MissingTypeObject The schema 'Error' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L3813
    R4037 - MissingTypeObject The schema 'ErrorAdditionalInfo' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L3849
    R4037 - MissingTypeObject The schema 'additionalDetails' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L4069
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 34 Errors, 0 Warnings failed [Detail]
    The following breaking changes are detected by comparison with the latest stable version:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    1008 - ModifiedOperationId The operation id has been changed from 'BackupVaults_GetInSubscription' to 'BackupVaults_GetResourcesInSubscription'. This will impact generated code.
    New: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L22:7
    Old: Microsoft.DataProtection/stable/2021-01-01/dataprotection.json#L22:7
    1008 - ModifiedOperationId The operation id has been changed from 'OperationStatus_Get' to 'GetOperationStatus'. This will impact generated code.
    New: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L134:7
    Old: Microsoft.DataProtection/stable/2021-01-01/dataprotection.json#L134:7
    1008 - ModifiedOperationId The operation id has been changed from 'BackupVaults_GetInResourceGroup' to 'BackupVaults_GetResourcesInResourceGroup'. This will impact generated code.
    New: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L185:7
    Old: Microsoft.DataProtection/stable/2021-01-01/dataprotection.json#L185:7
    1008 - ModifiedOperationId The operation id has been changed from 'BackupVaults_Update' to 'BackupVaults_Patch'. This will impact generated code.
    New: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L387:7
    Old: Microsoft.DataProtection/stable/2021-01-01/dataprotection.json#L387:7
    1008 - ModifiedOperationId The operation id has been changed from 'BackupVaultOperationResults_Get' to 'GetOperationResultPatch'. This will impact generated code.
    New: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L445:7
    Old: Microsoft.DataProtection/stable/2021-01-01/dataprotection.json#L445:7
    1008 - ModifiedOperationId The operation id has been changed from 'DataProtection_CheckFeatureSupport' to 'CheckFeatureSupport'. This will impact generated code.
    New: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L553:7
    Old: Microsoft.DataProtection/stable/2021-01-01/dataprotection.json#L553:7
    1008 - ModifiedOperationId The operation id has been changed from 'DataProtectionOperations_List' to 'Operations_List'. This will impact generated code.
    New: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L607:7
    Old: Microsoft.DataProtection/stable/2021-01-01/dataprotection.json#L607:7
    1008 - ModifiedOperationId The operation id has been changed from 'RecoveryPoints_List' to 'RecoveryPoints_GetList'. This will impact generated code.
    New: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L1234:7
    Old: Microsoft.DataProtection/stable/2021-01-01/dataprotection.json#L1240:7
    1008 - ModifiedOperationId The operation id has been changed from 'RecoveryPoints_Get' to 'RecoveryPoint_Get'. This will impact generated code.
    New: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L1304:7
    Old: Microsoft.DataProtection/stable/2021-01-01/dataprotection.json#L1310:7
    1008 - ModifiedOperationId The operation id has been changed from 'BackupInstances_ValidateForRestore' to 'BackupInstances_ValidateRestore'. This will impact generated code.
    New: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L1868:7
    Old: Microsoft.DataProtection/stable/2021-01-01/dataprotection.json#L1530:7


    The following breaking changes are detected by comparison with latest preview version:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    1008 - ModifiedOperationId The operation id has been changed from 'BackupVaults_GetInSubscription' to 'BackupVaults_GetResourcesInSubscription'. This will impact generated code.
    New: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L22:7
    Old: Microsoft.DataProtection/preview/2021-02-01-preview/dataprotection.json#L22:7
    1008 - ModifiedOperationId The operation id has been changed from 'OperationStatus_Get' to 'GetOperationStatus'. This will impact generated code.
    New: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L134:7
    Old: Microsoft.DataProtection/preview/2021-02-01-preview/dataprotection.json#L134:7
    1008 - ModifiedOperationId The operation id has been changed from 'BackupVaults_GetInResourceGroup' to 'BackupVaults_GetResourcesInResourceGroup'. This will impact generated code.
    New: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L185:7
    Old: Microsoft.DataProtection/preview/2021-02-01-preview/dataprotection.json#L185:7
    1008 - ModifiedOperationId The operation id has been changed from 'BackupVaults_Update' to 'BackupVaults_Patch'. This will impact generated code.
    New: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L387:7
    Old: Microsoft.DataProtection/preview/2021-02-01-preview/dataprotection.json#L387:7
    1008 - ModifiedOperationId The operation id has been changed from 'BackupVaultOperationResults_Get' to 'GetOperationResultPatch'. This will impact generated code.
    New: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L445:7
    Old: Microsoft.DataProtection/preview/2021-02-01-preview/dataprotection.json#L445:7
    1008 - ModifiedOperationId The operation id has been changed from 'DataProtection_CheckFeatureSupport' to 'CheckFeatureSupport'. This will impact generated code.
    New: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L553:7
    Old: Microsoft.DataProtection/preview/2021-02-01-preview/dataprotection.json#L553:7
    1008 - ModifiedOperationId The operation id has been changed from 'DataProtectionOperations_List' to 'Operations_List'. This will impact generated code.
    New: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L607:7
    Old: Microsoft.DataProtection/preview/2021-02-01-preview/dataprotection.json#L607:7
    1008 - ModifiedOperationId The operation id has been changed from 'RecoveryPoints_List' to 'RecoveryPoints_GetList'. This will impact generated code.
    New: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L1234:7
    Old: Microsoft.DataProtection/preview/2021-02-01-preview/dataprotection.json#L1240:7
    1008 - ModifiedOperationId The operation id has been changed from 'RecoveryPoints_Get' to 'RecoveryPoint_Get'. This will impact generated code.
    New: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L1304:7
    Old: Microsoft.DataProtection/preview/2021-02-01-preview/dataprotection.json#L1310:7
    1008 - ModifiedOperationId The operation id has been changed from 'BackupInstances_ValidateForRestore' to 'BackupInstances_ValidateRestore'. This will impact generated code.
    New: Microsoft.DataProtection/preview/2021-06-01-preview/dataprotection.json#L1868:7
    Old: Microsoft.DataProtection/preview/2021-02-01-preview/dataprotection.json#L1874:7
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"dataprotection/resource-manager/readme.md",
    "tag":"package-2021-06-preview",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"dataprotection/resource-manager/readme.md",
    "tag":"package-2021-06-preview",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"dataprotection/resource-manager/readme.md",
    "tag":"package-2021-06-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 14, 2021

    Swagger pipeline restarted successfully, please wait for status update in this comment.

    @ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jun 14, 2021
    @ghost
    Copy link

    ghost commented Jun 14, 2021

    Thank you for your contribution vikramkotturu! We will review the pull request and get back to you soon.

    @ghost
    Copy link

    ghost commented Jun 14, 2021

    CLA assistant check
    All CLA requirements met.

    {
    "swagger": "2.0",
    "info": {
    "version": "2021-06-01-preview",
    Copy link
    Contributor Author

    @vikramkotturu vikramkotturu Jun 15, 2021

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated version @ Line 4

    "type": "object",
    "x-ms-discriminator-value": "AdhocBasedTriggerContext"
    },
    "AuthCredentials": {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Added AuthCredentials type starting @ line 2320

    "type": "string",
    "readOnly": true
    },
    "datasourceAuthCredentials": {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Added datasourceAuthCredentials starting @ line 2993

    "$ref": "#/definitions/DatasourceSet",
    "description": "Information of target DS Set"
    },
    "datasourceAuthCredentials": {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Added datasourceAuthCredentials starting @ line 4059

    "$ref": "#/definitions/DatasourceSet",
    "description": "Information of target DS Set"
    },
    "datasourceAuthCredentials": {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    added datasourceAuthCredentials starting @ 4423

    "type": "object",
    "x-ms-discriminator-value": "ScheduleBasedTriggerContext"
    },
    "SecretStoreBasedAuthCredentials": {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    added SecretStoreBasedAuthCredentials defenition starting @ line 4650

    },
    "x-ms-discriminator-value": "SecretStoreBasedAuthCredentials"
    },
    "SecretStoreResource": {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    added SecretStoreResource starting @ line 4669

    @@ -0,0 +1,20 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,32 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,48 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,39 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,51 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,67 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,150 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    1. updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    2. Added datasourceAuthCredentials @ line number 30

    @@ -0,0 +1,19 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,19 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,19 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,19 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,17 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,200 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,13 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,109 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,112 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,19 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,19 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,33 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,35 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,59 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,56 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,39 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,43 @@
    {
    "parameters": {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,74 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @@ -0,0 +1,76 @@
    {
    Copy link
    Contributor Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    updated all instances of version 2021-02-01-preview to 2021-06-01-preview in file.

    @vikramkotturu vikramkotturu force-pushed the users/vikottur/ws01_datasource_auth branch from 3fe5da2 to 7a4eda1 Compare June 22, 2021 13:01
    @vikramkotturu
    Copy link
    Contributor Author

    Created a different pull request for changes abandoning this #14932

    @vikramkotturu
    Copy link
    Contributor Author

    abandoning this as I created a new one for same changes that is cleaner #14932

    @vikramkotturu vikramkotturu deleted the users/vikottur/ws01_datasource_auth branch June 22, 2021 14:04
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    CI-BreakingChange-Go customer-reported Issues that are reported by GitHub users external to the Azure organization. WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants