[Service Fabric] adding api version 2021-06-01 #14838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @a-santamaria Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ServiceFabric/stable/2021-06-01/cluster.json#L344 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ServiceFabric/stable/2021-06-01/cluster.json#L384 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ServiceFabric/stable/2021-06-01/cluster.json#L418 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.ServiceFabric/stable/2021-06-01/cluster.json#L455 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.ServiceFabric/stable/2021-06-01/application.json#L166 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.ServiceFabric/stable/2021-06-01/application.json#L364 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.ServiceFabric/stable/2021-06-01/application.json#L614 |
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.ServiceFabric/stable/2021-06-01/application.json#L873 |
|
The integer type does not have a format, please add it. Location: Microsoft.ServiceFabric/stable/2021-06-01/cluster.json#L1839 |
|
The integer type does not have a format, please add it. Location: Microsoft.ServiceFabric/stable/2021-06-01/application.json#L1234 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌Cross-Version Breaking Changes: 267 Errors, 8 Warnings failed [Detail]
- Compared Swaggers (Based on Oad v0.8.11)
- current:stable/2021-06-01/application.json compared with base:preview/2020-12-01-preview/application.json
- current:stable/2021-06-01/cluster.json compared with base:preview/2020-12-01-preview/cluster.json
- current:stable/2021-06-01/application.json compared with base:stable/2020-03-01/application.json
- current:stable/2021-06-01/cluster.json compared with base:stable/2020-03-01/cluster.json
Only 10 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.ServiceFabric/operations' removed or restructured? Old: Microsoft.ServiceFabric/stable/2020-03-01/application.json#L37:5 |
|
The new version is removing enum value(s) '2020-03-01' from the old version. Old: Microsoft.ServiceFabric/stable/2020-03-01/application.json#L81:9 |
|
The new version is removing enum value(s) '2020-03-01' from the old version. Old: Microsoft.ServiceFabric/stable/2020-03-01/application.json#L125:9 |
|
The new version is removing enum value(s) '2020-03-01' from the old version. Old: Microsoft.ServiceFabric/stable/2020-03-01/application.json#L179:9 |
|
The new version is removing enum value(s) '2020-03-01' from the old version. Old: Microsoft.ServiceFabric/stable/2020-03-01/application.json#L226:9 |
|
The new version is removing enum value(s) '2020-03-01' from the old version. Old: Microsoft.ServiceFabric/stable/2020-03-01/application.json#L269:9 |
|
The new version is removing enum value(s) '2020-03-01' from the old version. Old: Microsoft.ServiceFabric/stable/2020-03-01/application.json#L316:9 |
|
The new version is removing enum value(s) '2020-03-01' from the old version. Old: Microsoft.ServiceFabric/stable/2020-03-01/application.json#L374:9 |
|
The new version is removing enum value(s) '2020-03-01' from the old version. Old: Microsoft.ServiceFabric/stable/2020-03-01/application.json#L424:9 |
|
The new version is removing enum value(s) '2020-03-01' from the old version. Old: Microsoft.ServiceFabric/stable/2020-03-01/application.json#L470:9 |
The following breaking changes are detected by comparison with latest preview version:
Only 10 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️[Staging] SDK Track2 Validation: 4 Warnings warning [Detail]
- The following tags are being changed in this PR
| Rule | Message |
|---|---|
| "readme":"servicefabric/resource-manager/readme.md", "tag":"package-2021-06", "details":"Schema 'Cluster' has an allOf list with an empty object schema as a parent, removing it." |
|
| "readme":"servicefabric/resource-manager/readme.md", "tag":"package-2021-06", "details":"Schema 'NamedPartitionSchemeDescription' has an allOf list with an empty object schema as a parent, removing it." |
|
| "readme":"servicefabric/resource-manager/readme.md", "tag":"package-2021-06", "details":"Schema 'UniformInt64RangePartitionSchemeDescription' has an allOf list with an empty object schema as a parent, removing it." |
|
| "readme":"servicefabric/resource-manager/readme.md", "tag":"package-2021-06", "details":"The schema 'components·1jzyk61·schemas·cluster·allof·0' has no type or format information whatsoever. Location:\n file:///home/vsts/work/1/azure-rest-api-specs/specification/servicefabric/resource-manager/Microsoft.ServiceFabric/stable/2021-06-01/cluster.json#/components/schemas/components·1jzyk61·schemas·cluster·allof·0" |
|
| 💬 AutorestCore/Exception | "readme":"servicefabric/resource-manager/readme.md", "tag":"package-2021-06", "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"servicefabric/resource-manager/readme.md", "tag":"package-2021-06", "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)" |
| 💬 AutorestCore/Exception | "readme":"servicefabric/resource-manager/readme.md", "tag":"package-2021-06", "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)" |
️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi, @a-santamaria your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
This was referenced Jun 16, 2021
chiragg4u
reviewed
Jun 16, 2021
...on/servicefabric/resource-manager/Microsoft.ServiceFabric/stable/2021-06-01/application.json
Show resolved
Hide resolved
chiragg4u
reviewed
Jun 16, 2021
...on/servicefabric/resource-manager/Microsoft.ServiceFabric/stable/2021-06-01/application.json
Show resolved
Hide resolved
chiragg4u
reviewed
Jun 16, 2021
...cation/servicefabric/resource-manager/Microsoft.ServiceFabric/stable/2021-06-01/cluster.json
Show resolved
Hide resolved
|
Thank you for copying the existing version into new folder for first commit. It helps in reviewing the change. Changes looks good from ARM perspective, signedoff, please follow the process given @ https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/212/Swagger-PR-Review to continue |
chiragg4u
added
ARMSignedOff
This was referenced Jun 18, 2021
leni-msft
added
Approved-BreakingChange
|
Hi @a-santamaria, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
@a-santamaria please follow the Action in above comment to request cross-version breaking changes approval for |
@leni-msft I removed those responses added. I added them by mistake. |
leni-msft
added
Approved-BreakingChange
leni-msft
approved these changes
Jun 23, 2021
This was referenced Jun 23, 2021
[ReleasePR track2_azure-mgmt-servicefabric] Update readme.python.md
Azure/azure-sdk-for-python#19406
Closed
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Jun 23, 2021
mkarmark
pushed a commit
to mkarmark/azure-rest-api-specs
that referenced
this pull request
Jul 21, 2021
* initiall commit with previous stable version 2020-03-01 * update to version 2021-06-01 * update examples with 2021-06-01 api * fix automation errors * remove operation definitions from app * use systemData from common-types * add type * update vmInstanceCount description and min * adding missing az params * adding missing cluster parameters * remove 200 from app delete operations * remove default respopnse from clusterVersions Co-authored-by: Alfredo Santamaria Gomez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Please ensure to add changelog with this PR by answering the following questions.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.