Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GA API version (2021-07-01) #14937

Merged
merged 12 commits into from
Jul 9, 2021
Merged

Added GA API version (2021-07-01) #14937

merged 12 commits into from
Jul 9, 2021

Conversation

shaileshsk94
Copy link
Contributor

@shaileshsk94 shaileshsk94 commented Jun 22, 2021

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Please ensure to add changelog with this PR by answering the following questions.

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet.
  3. When you expect to publish swagger? Please provide date, or month to public if date is not available yet.
  4. If it's an update to existing version, please select SDKs of specific language and CLIs that require refresh after swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No, no need to refresh for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
    • Adding a new service
  • Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

Shailesh Kelkar and others added 4 commits May 13, 2021 17:02
…ResourceGroupName

- Adds default value for publicNetworkAccess property.
- Adds "x-ms-mutability" attribute for managedResourceGroupName property.
@openapi-workflow-bot
Copy link

Hi, @shaileshsk94 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-workflow-bot
    Copy link

    [Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 22, 2021

    Swagger Validation Report

    ️🔄BreakingChange inProgress [Detail]
    ️🔄LintDiff inProgress [Detail]
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️⌛SemanticValidation pending [Detail]
    ️⌛Cross-Version Breaking Changes pending [Detail]
    ️⌛CredScan pending [Detail]
    ️🔄[Staging] SDK Track2 Validation inProgress [Detail]
    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️🔄[Staging] SpellCheck inProgress [Detail]
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 22, 2021

    Swagger Generation Artifacts

    ️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌[Staging] SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-python-track2 - track2_azure-mgmt-purview - 1.0.0b1
    +	Removed operation PrivateEndpointConnectionsOperations.create_or_update
    ️✔️azure-sdk-for-go - purview/mgmt/2021-07-01/purview - Approved - v55.5.0
    azure-sdk-for-go - preview/purview/mgmt/2020-12-01-preview/purview - Approved - v55.5.0
    +	Field `*AccountProperties` of struct `AccountUpdateParameters` has been removed
    +	Field `*PrivateLinkResourceProperties` of struct `PrivateLinkResource` has been removed
    +	Function `*AccountUpdateParameters.UnmarshalJSON` has been removed
    +	Function `*DeletedAccount.UnmarshalJSON` has been removed
    +	Function `*PrivateLinkResource.UnmarshalJSON` has been removed
    +	Function `DeletedAccount.MarshalJSON` has been removed
    +	Function `DeletedAccountProperties.MarshalJSON` has been removed
    +	Function `DeletedAccountPropertiesModel.MarshalJSON` has been removed
    +	Function `PrivateEndpointConnectionsClient.CreateOrUpdateSender` return value(s) have been changed from `(*http.Response, error)` to `(PrivateEndpointConnectionsCreateOrUpdateFuture, error)`
    +	Function `PrivateEndpointConnectionsClient.CreateOrUpdate` return value(s) have been changed from `(PrivateEndpointConnection, error)` to `(PrivateEndpointConnectionsCreateOrUpdateFuture, error)`
    +	Struct `DeletedAccountList` has been removed
    +	Struct `DeletedAccountPropertiesModel` has been removed
    +	Struct `DeletedAccountProperties` has been removed
    +	Struct `DeletedAccount` has been removed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d1bf50c. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    • ️✔️track2_azure-mgmt-purview [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Model PrivateLinkResource has a new parameter properties
      info	[Changelog]   - Model Account has a new parameter managed_resource_group_name
      info	[Changelog]   - Model Account has a new parameter system_data
      info	[Changelog]   - Model TrackedResource has a new parameter system_data
      info	[Changelog]   - Added operation PrivateEndpointConnectionsOperations.begin_create_or_update
      info	[Changelog]   - Added operation AccountsOperations.add_root_collection_admin
      info	[Changelog]
      info	[Changelog] **Breaking changes**
      info	[Changelog]
      info	[Changelog]   - Model PrivateLinkResource no longer has parameter group_id
      info	[Changelog]   - Model PrivateLinkResource no longer has parameter required_members
      info	[Changelog]   - Model PrivateLinkResource no longer has parameter required_zone_names
      info	[Changelog]   - Model AccountUpdateParameters has a new signature
      info	[Changelog]   - Removed operation PrivateEndpointConnectionsOperations.create_or_update
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from d1bf50c. SDK Automation 14.0.0
      command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️purview/mgmt/2021-07-01/purview [View full logs]  [Release SDK Changes]
      info	[Changelog] This is a new package
    • ️✔️preview/purview/mgmt/2020-12-01-preview/purview [View full logsBreaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `PrivateEndpointConnectionsClient.CreateOrUpdate` return value(s) have been changed from `(PrivateEndpointConnection, error)` to `(PrivateEndpointConnectionsCreateOrUpdateFuture, error)`
      info	[Changelog] - Function `PrivateEndpointConnectionsClient.CreateOrUpdateSender` return value(s) have been changed from `(*http.Response, error)` to `(PrivateEndpointConnectionsCreateOrUpdateFuture, error)`
      info	[Changelog] - Function `*AccountUpdateParameters.UnmarshalJSON` has been removed
      info	[Changelog] - Function `*DeletedAccount.UnmarshalJSON` has been removed
      info	[Changelog] - Function `DeletedAccountPropertiesModel.MarshalJSON` has been removed
      info	[Changelog] - Function `DeletedAccount.MarshalJSON` has been removed
      info	[Changelog] - Function `*PrivateLinkResource.UnmarshalJSON` has been removed
      info	[Changelog] - Function `DeletedAccountProperties.MarshalJSON` has been removed
      info	[Changelog] - Struct `DeletedAccount` has been removed
      info	[Changelog] - Struct `DeletedAccountList` has been removed
      info	[Changelog] - Struct `DeletedAccountProperties` has been removed
      info	[Changelog] - Struct `DeletedAccountPropertiesModel` has been removed
      info	[Changelog] - Field `*AccountProperties` of struct `AccountUpdateParameters` has been removed
      info	[Changelog] - Field `*PrivateLinkResourceProperties` of struct `PrivateLinkResource` has been removed
      info	[Changelog]
      info	[Changelog] ### New Content
      info	[Changelog]
      info	[Changelog] - New const `LastModifiedByTypeKey`
      info	[Changelog] - New const `User`
      info	[Changelog] - New const `Canceled`
      info	[Changelog] - New const `Application`
      info	[Changelog] - New const `LastModifiedByTypeManagedIdentity`
      info	[Changelog] - New const `ManagedIdentity`
      info	[Changelog] - New const `LastModifiedByTypeUser`
      info	[Changelog] - New const `LastModifiedByTypeApplication`
      info	[Changelog] - New const `Key`
      info	[Changelog] - New function `PossibleCreatedByTypeValues() []CreatedByType`
      info	[Changelog] - New function `SystemData.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `*PrivateEndpointConnectionsCreateOrUpdateFuture.UnmarshalJSON([]byte) error`
      info	[Changelog] - New function `PossibleLastModifiedByTypeValues() []LastModifiedByType`
      info	[Changelog] - New function `AccountPropertiesSystemData.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New struct `AccountPropertiesSystemData`
      info	[Changelog] - New struct `PrivateEndpointConnectionsCreateOrUpdateFuture`
      info	[Changelog] - New struct `SystemData`
      info	[Changelog] - New field `SystemData` in struct `AccountProperties`
      info	[Changelog] - New field `ManagedResourceGroupName` in struct `AccountProperties`
      info	[Changelog] - New field `Properties` in struct `PrivateLinkResource`
      info	[Changelog] - New field `Properties` in struct `AccountUpdateParameters`
      info	[Changelog]
      info	[Changelog] Total 18 breaking change(s), 23 additive change(s).
      info	[Changelog]
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from d1bf50c. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]
      cmderr	[initScript.sh]  The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh]  so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh]
      cmderr	[initScript.sh]  This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	Skip detect changed packages
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 22, 2021
    @openapi-workflow-bot
    Copy link

    Hi, @shaileshsk94 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    Copy link
    Member

    @ArcturusZhang ArcturusZhang left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Changes in readme.go.md LGTM

    @openapi-workflow-bot
    Copy link

    Hi @shaileshsk94, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

    @filizt
    Copy link
    Contributor

    filizt commented Jun 23, 2021

    @shaileshsk94 looks like you're updating an old API version with a new path. For that, you need to get approval from Breaking Changes Review board (which is different than ARM API Review Board). The instructions for that is pasted by the openapi bot above.

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jun 25, 2021

    Swagger Validation Report

    ️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L671:7
    Old: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L671:7
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:

    Only 10 items are listed, please refer to log for more details.

    Rule Message
    R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Purview/stable/2021-07-01/purview.json#L672
    R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Purview/stable/2021-07-01/purview.json#L720
    R4009 - RequiredReadOnlySystemData The response of operation:'Accounts_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L117
    R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L623
    R4009 - RequiredReadOnlySystemData The response of operation:'Accounts_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L158
    R4009 - RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L671
    R4009 - RequiredReadOnlySystemData The response of operation:'Accounts_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L260
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Purview/stable/2021-07-01/purview.json#L1409
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Purview/stable/2021-07-01/purview.json#L1759
    ⚠️ R2001 - AvoidNestedProperties Consider using x-ms-client-flatten to provide a better end user experience
    Location: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L1369
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️❌Cross-Version Breaking Changes: 2 Errors, 0 Warnings failed [Detail]
    The following breaking changes are detected by comparison with latest preview version:
    Rule Message
    1033 - RemovedProperty The new version is missing a property found in the old version. Was 'systemData' renamed or removed?
    New: Microsoft.Purview/stable/2021-07-01/purview.json#L1052:7
    Old: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L1002:7
    1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Purview/stable/2021-07-01/purview.json#L720:7
    Old: Microsoft.Purview/preview/2020-12-01-preview/purview.json#L671:7
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    The following errors/warnings are introduced by current PR:

    |:speech_balloon: AutorestCore/Exception|"readme":"purview/resource-manager/readme.md",
    "tag":"package-2020-12-01-preview",
    "details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"purview/resource-manager/readme.md",
    "tag":"package-2020-12-01-preview",
    "details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"purview/resource-manager/readme.md",
    "tag":"package-2021-07-01",
    "details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
    |:speech_balloon: AutorestCore/Exception|"readme":"purview/resource-manager/readme.md",
    "tag":"package-2021-07-01",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|


    The following errors/warnings exist before current PR submission:

    |:speech_balloon: AutorestCore/Exception|"readme":"purview/resource-manager/readme.md",
    "tag":"package-2020-12-01-preview",
    "details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

    ️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @jianyexi
    Copy link
    Contributor

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    Copy link
    Contributor Author

    @shaileshsk94 shaileshsk94 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @pilor
    we don't use OpenApi for swagger generation as of now (as we are on older version of .net core 2.1). We generate swagger using legacy and systemData is not present in the acceptable list of top level properties.

    For POST rootCollectionAdmin API,
    this is one off API supported for data plane lockout mitigation scenario.
    So, we don't expose APIs to list or remove root collection admin.
    Root collection is a data plane concept specifically for Azure Purview.
    Thus, it will not impact ability to create account (partial config etc) via template.

    @JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Jun 30, 2021
    @pilor pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jul 8, 2021
    @jianyexi
    Copy link
    Contributor

    jianyexi commented Jul 8, 2021

    @ArcturusZhang could you approve go SDK breaking change ?

    @ArcturusZhang ArcturusZhang added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Jul 8, 2021
    @filizt filizt removed their assignment Jul 8, 2021
    @jianyexi jianyexi merged commit d1bf50c into Azure:master Jul 9, 2021
    jianyexi added a commit that referenced this pull request Jul 9, 2021
    jianyexi added a commit that referenced this pull request Jul 9, 2021
    jianyexi added a commit that referenced this pull request Jul 18, 2021
    jianyexi pushed a commit that referenced this pull request Jul 18, 2021
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    * Fixed swagger validation warnings for publicNetworkAccess and managedResourceGroupName
    
    - Adds default value for publicNetworkAccess property.
    - Adds "x-ms-mutability" attribute for managedResourceGroupName property.
    
    * Ran prettier check to fix warnings
    
    * Added GA api-version (2021-07-01)
    
    * Addressed typo
    
    * Removed AddRootCollectionAdmin API from preview version
    
    * Updated private endpoint connection approval operation as a long running operation
    
    * Fixed swagger breaking changes for long running operation
    
    * Updated long running operation for preview api-version
    
    * removed vscode settings json changes
    
    * Updated systemData and added Canceled provisioning state
    
    * Updated Go SDK output folder path
    
    Co-authored-by: Shailesh Kelkar <[email protected]>
    mkarmark pushed a commit to mkarmark/azure-rest-api-specs that referenced this pull request Jul 21, 2021
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    7 participants