[eventhubs] Increase MaximumThroughputUnits to 40 #15619

mikhailshilkov · 2021-08-11T12:23:40Z

The actual limit on maximum Throughput Units is 40 (and the API / UI will allow you to select up to 40): https://docs.microsoft.com/en-us/azure/event-hubs/event-hubs-quotas#basic-vs-standard-vs-premium-vs-dedicated-tiers but the API spec states that the limit is 20. This PR increases it to 40 for all API versions.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify: Relax validation to allow the full range of legit values
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2021-08-11T12:23:42Z

Hi, @mikhailshilkov Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-workflow-bot · 2021-08-11T12:23:43Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2021-08-11T12:23:44Z

Swagger Validation Report

️❌BreakingChange: 8 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.0)
- current:preview/2018-01-01-preview/namespaces-preview.json compared with base:preview/2018-01-01-preview/namespaces-preview.json
- current:preview/2021-01-01-preview/namespaces-preview.json compared with base:preview/2021-01-01-preview/namespaces-preview.json
- current:preview/2021-06-01-preview/namespaces-preview.json compared with base:preview/2021-06-01-preview/namespaces-preview.json
- current:stable/2017-04-01/namespaces.json compared with base:stable/2017-04-01/namespaces.json

Rule	Message
`❌` 1024 - ConstraintIsStronger	The new version has a more constraining 'maximum' value than the previous one. New: Microsoft.EventHub/preview/2018-01-01-preview/namespaces-preview.json#L653:13 Old: Microsoft.EventHub/preview/2018-01-01-preview/namespaces-preview.json#L653:13
`❌` 1024 - ConstraintIsStronger	The new version has a more constraining 'maximum' value than the previous one. New: Microsoft.EventHub/preview/2021-01-01-preview/namespaces-preview.json#L652:13 Old: Microsoft.EventHub/preview/2021-01-01-preview/namespaces-preview.json#L652:13
`❌` 1024 - ConstraintIsStronger	The new version has a more constraining 'maximum' value than the previous one. New: Microsoft.EventHub/preview/2021-06-01-preview/namespaces-preview.json#L652:13 Old: Microsoft.EventHub/preview/2021-06-01-preview/namespaces-preview.json#L652:13
`❌` 1024 - ConstraintIsStronger	The new version has a more constraining 'maximum' value than the previous one. New: Microsoft.EventHub/stable/2017-04-01/namespaces.json#L470:13 Old: Microsoft.EventHub/stable/2017-04-01/namespaces.json#L470:13
`❌` 1036 - ConstraintChanged	The new version has a different 'maximum' value than the previous one. New: Microsoft.EventHub/preview/2018-01-01-preview/namespaces-preview.json#L653:13 Old: Microsoft.EventHub/preview/2018-01-01-preview/namespaces-preview.json#L653:13
`❌` 1036 - ConstraintChanged	The new version has a different 'maximum' value than the previous one. New: Microsoft.EventHub/preview/2021-01-01-preview/namespaces-preview.json#L652:13 Old: Microsoft.EventHub/preview/2021-01-01-preview/namespaces-preview.json#L652:13
`❌` 1036 - ConstraintChanged	The new version has a different 'maximum' value than the previous one. New: Microsoft.EventHub/preview/2021-06-01-preview/namespaces-preview.json#L652:13 Old: Microsoft.EventHub/preview/2021-06-01-preview/namespaces-preview.json#L652:13
`❌` 1036 - ConstraintChanged	The new version has a different 'maximum' value than the previous one. New: Microsoft.EventHub/stable/2017-04-01/namespaces.json#L470:13 Old: Microsoft.EventHub/stable/2017-04-01/namespaces.json#L470:13

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R2026 - AvoidAnonymousTypes	Inline/anonymous models must not be used, instead define a schema with a model name in the 'definitions' section and refer to it. This allows operations to share the models. Location: Microsoft.EventHub/preview/2021-01-01-preview/namespaces-preview.json#L759
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.EventHub/preview/2018-01-01-preview/disasterRecoveryConfigs.json#L217
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.EventHub/stable/2017-04-01/disasterRecoveryConfigs.json#L217
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.EventHub/preview/2021-06-01-preview/disasterRecoveryConfigs.json#L217
`❌` R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.EventHub/preview/2021-01-01-preview/disasterRecoveryConfigs.json#L217
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L214
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L204
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L214
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L204
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L214
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L204
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L214
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L204
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L214
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L204
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L214
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L204
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L214
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L204
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L214
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: resource-manager/common/v1/definitions.json#L204
`❌` R4017 - TopLevelResourcesListBySubscription	The top-level resource 'Cluster' does not have list by subscription operation, please add it. Location: Microsoft.EventHub/preview/2018-01-01-preview/Clusters-preview.json#L330
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.EventHub/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.EventHub/preview/2018-01-01-preview/operations.json#L37
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.EventHub/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.EventHub/stable/2017-04-01/operations.json#L37
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.EventHub/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.EventHub/preview/2021-06-01-preview/operations.json#L37
`❌` R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.EventHub/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.EventHub/preview/2021-01-01-preview/operations.json#L37
`❌` R4037 - MissingTypeObject	The schema 'AvailableClustersList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2018-01-01-preview/AvailableClusterRegions-preview.json#L75
`❌` R4037 - MissingTypeObject	The schema 'AvailableCluster' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2018-01-01-preview/AvailableClusterRegions-preview.json#L87
`❌` R4037 - MissingTypeObject	The schema 'Cluster' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2018-01-01-preview/Clusters-preview.json#L330
`❌` R4037 - MissingTypeObject	The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2018-01-01-preview/Clusters-preview.json#L336

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️[Staging] SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

The following errors/warnings are introduced by current PR:

|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"package-2017-04",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"package-2017-04",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|

The following errors/warnings exist before current PR submission:

|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"package-2017-04",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"package-2021-01-preview",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"package-2021-01-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"package-2021-06-preview",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"package-2021-06-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"package-2018-01-preview",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"package-2018-01-preview",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|
|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"profile-hybrid-2020-09-01",
"details":"> Loading AutoRest extension '@microsoft.azure/openapi-validator' (1.8.0->1.8.0)"|
|:speech_balloon: AutorestCore/Exception|"readme":"eventhub/resource-manager/readme.md",
"tag":"profile-hybrid-2020-09-01",
"details":"> Loading AutoRest extension '@autorest/modelerfour' (4.15.456->4.15.456)"|

️️✔️[Staging] PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️[Staging] SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️[Staging] Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2021-08-11T12:23:44Z

Swagger Generation Artifacts

️️✔️[Staging] ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️[Staging] SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-eventhub - 9.0.0
️✔️azure-sdk-for-go - eventhub/mgmt/2017-04-01/eventhub - v56.1.0
️✔️azure-sdk-for-go - eventhub/mgmt/2015-08-01/eventhub - v56.1.0
️✔️azure-sdk-for-go - preview/eventhub/mgmt/2018-01-01-preview/eventhub - v56.1.0

️⌛ azure-sdk-for-net pending [Detail]

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs] Generate from 6d0a788abad2441939f0aeef95561e4058131c8c. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-eventhub [View full logs] [Preview SDK Changes]
- azure_mgmt_eventhub-5.0.0-py2.py3-none-any.whl
- azure-mgmt-eventhub-5.0.0.zip
```
info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model EHNamespace has a new parameter status
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from 6d0a788abad2441939f0aeef95561e4058131c8c. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-eventhub [View full logs] [Preview SDK Changes]
- azure_mgmt_eventhub-9.0.0-py2.py3-none-any.whl
- azure-mgmt-eventhub-9.0.0.zip
```
info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model EHNamespace has a new parameter status
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 6d0a788abad2441939f0aeef95561e4058131c8c. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2021-08-11 12:28:51 INFO [VERSION][Not Found] cannot find version for "com.azure.resourcemanager:azure-resourcemanager-eventhubs-generated"
cmderr	[generate.py] 2021-08-11 12:28:51 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.1"
cmderr	[generate.py] 2021-08-11 12:28:51 INFO autorest --version=3.4.5 --use=@autorest/[email protected] --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/eventhubs/azure-resourcemanager-eventhubs-generated --java.namespace=com.azure.resourcemanager.eventhubs.generated   --java --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/eventhub/resource-manager/readme.md
cmderr	[generate.py] 2021-08-11 12:29:22 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2021-08-11 12:29:22 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2021-08-11 12:29:22 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2021-08-11 12:29:22 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2021-08-11 12:29:22 INFO [POM][Skip] pom already has module sdk/eventhubs
cmderr	[generate.py] 2021-08-11 12:29:22 INFO [POM][Success] Write to root pom
cmderr	[generate.py] Traceback (most recent call last):
cmderr	[generate.py]   File "eng/versioning/update_versions.py", line 126, in update_versions
cmderr	[generate.py]     raise ValueError('Invalid version type: {} for module: {}.\nFile={}\nLine={}'.format(version_type, module_name, target_file, line))
cmderr	[generate.py] ValueError: Invalid version type: external for module: org.apache.maven:maven-core.
cmderr	[generate.py] File=./eng/bomgenerator/pom.xml
cmderr	[generate.py] Line=      <version>3.5.4</version> <!-- {x-version-update;org.apache.maven:maven-core;external} -->

️✔️azure-resourcemanager-eventhubs-generated [View full logs] [Preview SDK Changes]

cmderr	[Inst] 2021-08-11 12:31:11 DEBUG Got artifact_id: azure-resourcemanager-eventhubs-generated
cmderr	[Inst] 2021-08-11 12:31:11 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2021-08-11 12:31:11 DEBUG Got artifact: azure-resourcemanager-eventhubs-generated-1.0.0-beta.1-javadoc.jar
cmderr	[Inst] 2021-08-11 12:31:11 DEBUG Got artifact: azure-resourcemanager-eventhubs-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-08-11 12:31:11 DEBUG Match jar package: azure-resourcemanager-eventhubs-generated-1.0.0-beta.1.jar
cmderr	[Inst] 2021-08-11 12:31:11 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/15619/azure-sdk-for-java/azure-resourcemanager-eventhubs-generated/azure-resourcemanager-eventhubs-generated-1.0.0-beta.1.jar\" -o azure-resourcemanager-eventhubs-generated-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-eventhubs-generated -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-eventhubs-generated-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 6d0a788abad2441939f0aeef95561e4058131c8c. SDK Automation 14.0.0

command	sh ./initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️eventhub/mgmt/2017-04-01/eventhub [View full logs] [Preview SDK Changes]
```
info	[Changelog] No exported changes
```
️✔️eventhub/mgmt/2015-08-01/eventhub [View full logs]
```
info	[Changelog] No exported changes
```

️✔️preview/eventhub/mgmt/2018-01-01-preview/eventhub [View full logs]

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] ### New Content
info	[Changelog]
info	[Changelog] - New field `Status` in struct `EHNamespaceProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).
info	[Changelog]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 6d0a788abad2441939f0aeef95561e4058131c8c. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	autorest --version=V2 --typescript --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js/azure-sdk-for-js ../../azure-rest-api-specs/specification/eventhub/resource-manager/readme.md

️✔️@azure/arm-eventhub [View full logs] [Preview SDK Changes]

azure-arm-eventhub-3.3.1.tgz

cmderr	[npmPack] loaded rollup.config.js with warnings
cmderr	[npmPack] (!) Unused external imports
cmderr	[npmPack] default imported from external module 'rollup' but never used
cmderr	[npmPack] ./esm/eventHubManagementClient.js → ./dist/arm-eventhub.js...
cmderr	[npmPack] created ./dist/arm-eventhub.js in 423ms

️❌ azure-resource-manager-schemas failed [Detail]

❌Failed [Logs] Generate from 6d0a788abad2441939f0aeef95561e4058131c8c. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /home/vsts/work/1/s/azure-resource-manager-schemas/generator/specs.ts:29
cmderr	[generateScript.sh]         throw new Error(`Unable to find readme '${readme}' in specs repo`);
cmderr	[generateScript.sh]               ^
cmderr	[generateScript.sh] Error: Unable to find readme '/home/vsts/work/1/s/azure-resource-manager-schemas_tmp/schm_azspc/specification/EnterpriseKnowledgeGraph/resource-manager/readme.md' in specs repo
cmderr	[generateScript.sh]     at Object.validateAndReturnReadmePath (/home/vsts/work/1/s/azure-resource-manager-schemas/generator/specs.ts:29:15)
cmderr	[generateScript.sh]     at /home/vsts/work/1/s/azure-resource-manager-schemas/generator/cmd/generateall.ts:48:24
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Skip package processing as generation is failed

_{Posted by Swagger Pipeline | How to fix these errors?}

ghost · 2021-08-11T12:23:45Z

Thank you for your contribution mikhailshilkov! We will review the pull request and get back to you soon.

openapi-workflow-bot · 2021-08-11T12:25:35Z

Hi @mikhailshilkov, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

mikhailshilkov · 2021-08-11T12:33:00Z

Is increasing a maximum value considered a breaking change? The action shows "The new version has a more constraining 'maximum' value than the previous one." which seems wrong. Anyway, I think the API does allow the full range.

ghost · 2021-08-29T16:01:54Z

Hi, @mikhailshilkov. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

mikhailshilkov · 2021-08-31T08:20:42Z

Please review this PR

ghost · 2021-09-19T16:02:31Z

Hi, @mikhailshilkov. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

mikhailshilkov · 2021-09-20T13:23:59Z

Fixed in #15233

[eventhubs] Increase MaximumThroughputUnits to 40

6b73d75

mikhailshilkov requested a review from v-Ajnava as a code owner August 11, 2021 12:23

openapi-assignment-bot bot assigned ruowan Aug 11, 2021

ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Aug 11, 2021

mikhailshilkov mentioned this pull request Aug 11, 2021

EventHubNamespace validation: API docs mismatched with actual API enforcement pulumi/pulumi-azure-native#1057

Closed

openapi-pipeline-app bot added the BreakingChangeReviewRequired label Aug 11, 2021

ghost added the no-recent-activity label Aug 29, 2021

ghost removed the no-recent-activity label Aug 31, 2021

ghost added the no-recent-activity label Sep 19, 2021

mikhailshilkov closed this Sep 20, 2021

tombuildsstuff mentioned this pull request Mar 28, 2024

Update ci-fix.md: dedup breaking changes guidance #28441

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[eventhubs] Increase MaximumThroughputUnits to 40 #15619

[eventhubs] Increase MaximumThroughputUnits to 40 #15619

mikhailshilkov commented Aug 11, 2021

openapi-workflow-bot bot commented Aug 11, 2021

openapi-workflow-bot bot commented Aug 11, 2021

openapi-pipeline-app bot commented Aug 11, 2021 •

edited

Loading

openapi-pipeline-app bot commented Aug 11, 2021 •

edited

Loading

Breaking Changes Tracking

ghost commented Aug 11, 2021

openapi-workflow-bot bot commented Aug 11, 2021

mikhailshilkov commented Aug 11, 2021

ghost commented Aug 29, 2021

mikhailshilkov commented Aug 31, 2021

ghost commented Sep 19, 2021

mikhailshilkov commented Sep 20, 2021

[eventhubs] Increase MaximumThroughputUnits to 40 #15619

[eventhubs] Increase MaximumThroughputUnits to 40 #15619

Conversation

mikhailshilkov commented Aug 11, 2021

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Aug 11, 2021

openapi-workflow-bot bot commented Aug 11, 2021

openapi-pipeline-app bot commented Aug 11, 2021 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Aug 11, 2021 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

ghost commented Aug 11, 2021

openapi-workflow-bot bot commented Aug 11, 2021

mikhailshilkov commented Aug 11, 2021

ghost commented Aug 29, 2021

mikhailshilkov commented Aug 31, 2021

ghost commented Sep 19, 2021

mikhailshilkov commented Sep 20, 2021

openapi-pipeline-app bot commented Aug 11, 2021 •

edited

Loading

openapi-pipeline-app bot commented Aug 11, 2021 •

edited

Loading