DiskRP Swagger changes for Remote Restore Point scenarios #16636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukodava
requested review from
dkulkarni-ms,
grizzlytheodore,
haagha,
hyonholee,
madewithsmiles,
MS-syh2qs and
Sandido
as code owners
|
Hi, @sukodava Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
Please provide x-ms-examples describing minimum/maximum property set for response/request payloads for operations. Location: Microsoft.Compute/stable/2021-07-01/compute.json#L36 |
|
Model definition 'SubResourceWithColocationStatus' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.Compute/stable/2021-07-01/compute.json#L8622 |
|
Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'SubResourceWithColocationStatus' has extra properties ['colocationStatus']. Location: Microsoft.Compute/stable/2021-07-01/compute.json#L8628 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L49 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L100 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L151 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L188 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L225 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L257 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L297 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L339 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L390 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L447 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L489 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L535 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L565 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L605 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L661 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L718 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L755 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L807 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L844 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L872 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L930 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L995 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L1040 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L1103 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L1147 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L1175 |
|
The response is defined but without a default error response implementation.Consider adding it.' Location: Microsoft.Compute/stable/2021-07-01/compute.json#L1210 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2021-08-01 |
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️Cross-Version Breaking Changes: 18 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.9.1)
- current:stable/2021-08-01/disk.json compared with base:stable/2021-04-01/disk.json
- current:stable/2021-08-01/disk.json compared with base:preview/2016-04-30-preview/disk.json
️🔄SDK Track2 Validation inProgress [Detail]
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
ghost
added
the
This was referenced Nov 2, 2021
shahja1
approved these changes
Nov 22, 2021
specification/compute/resource-manager/Microsoft.Compute/stable/2021-08-01/disk.json
Show resolved
Hide resolved
…zure-rest-api-specs into dev/sukodava/diskRpSwagger
haagha
requested changes
Dec 2, 2021
| "publicNetworkAccess": "Disabled", | ||
| "replicationState": "Succeeded", | ||
| "completionPercent": 100, | ||
| "sourceResourceLocation": "eastus2" |
There was a problem hiding this comment.
Suggested change
| "sourceResourceLocation": "eastus2" | |
| "sourceResourceLocation": "eastus2" |
There was a problem hiding this comment.
please fix this to fix prettier check
ArcturusZhang
pushed a commit
that referenced
this pull request
Dec 28, 2021
* new folder and files added for diskRP 2021-08-01 * Adding Location header to LRO responses examples * Add supportedCapabilities in SnapshotUpdateProperties model (#16768) * Add supportedCapabilities in SnapshotUpdateProperties model * Add an example for update acceleratedNetwork on snapshots * Fix example model * clean up * DiskRP swagger changes for TVM and CVM of version 2021-08-01 (#16671) * DiskRP swagger changes for TVM and CVM of version 2021-08-01 * adding examples for CVM * fix errors * fix errors * fix unreferences example file * fix for: additional properties not allowed error * fix spell check error * fix spell check for secureVMDiskEncryptionSetId property * fix prettier check * addressing comment * addressing comments * DiskRP Swagger changes for Remote Restore Point scenarios (#16636) * RRP changes * Fix prettier * including communityGallery.json in package * suppress bodytoplevelproperties Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: LU WU <[email protected]> Co-authored-by: anshulsolanki21 <[email protected]> Co-authored-by: sukodava <[email protected]>
LeiWang3
pushed a commit
to LeiWang3/azure-rest-api-specs
that referenced
this pull request
Mar 31, 2022
* new folder and files added for diskRP 2021-08-01 * Adding Location header to LRO responses examples * Add supportedCapabilities in SnapshotUpdateProperties model (Azure#16768) * Add supportedCapabilities in SnapshotUpdateProperties model * Add an example for update acceleratedNetwork on snapshots * Fix example model * clean up * DiskRP swagger changes for TVM and CVM of version 2021-08-01 (Azure#16671) * DiskRP swagger changes for TVM and CVM of version 2021-08-01 * adding examples for CVM * fix errors * fix errors * fix unreferences example file * fix for: additional properties not allowed error * fix spell check error * fix spell check for secureVMDiskEncryptionSetId property * fix prettier check * addressing comment * addressing comments * DiskRP Swagger changes for Remote Restore Point scenarios (Azure#16636) * RRP changes * Fix prettier * including communityGallery.json in package * suppress bodytoplevelproperties Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: LU WU <[email protected]> Co-authored-by: anshulsolanki21 <[email protected]> Co-authored-by: sukodava <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label “WaitForARMFeedback” will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.