remove Operations_List from Microsoft.Insights 2020-06-02-preview livetoken_API.json #17243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @cataggar Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is missing a path that was found in the old version. Was path '/providers/microsoft.insights/operations' removed or restructured? Old: Microsoft.Insights/preview/2020-06-02-preview/livetoken_API.json#L39:5 |
️⚠️LintDiff: 0 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/components/{resourceName}/linkedStorageAccounts/{storageType}' Location: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L37 |
|
Resource provider naming must follow the pascal case. Path: '/{resourceUri}/providers/microsoft.insights/generatelivetoken' Location: Microsoft.Insights/preview/2020-06-02-preview/livetoken_API.json#L39 |
|
Tracked resource 'Workbook' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well. Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L473 |
|
The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/stable/2015-05-01/analyticsItems_API.json#L37 |
|
The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/stable/2015-05-01/analyticsItems_API.json#L85 |
|
The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L37 |
|
The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/preview/2020-06-02-preview/livetoken_API.json#L39 |
|
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Insights/stable/2015-05-01/aiOperations_API.json#L50 |
|
The nested resource 'ComponentLinkedStorageAccounts' does not have list operation, please add it. Location: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L240 |
|
The response schema of operations API '/providers/Microsoft.Insights/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Insights/stable/2015-05-01/aiOperations_API.json#L31 |
|
The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/aiOperations_API.json#L92 |
|
The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/aiOperations_API.json#L111 |
|
The schema 'AnnotationsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/componentAnnotations_API.json#L244 |
|
The schema 'ApplicationInsightsComponentAPIKeyListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/componentApiKeys_API.json#L209 |
|
The schema 'WorkItemConfigurationsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/componentWorkItemConfigs_API.json#L290 |
|
The schema 'ApplicationInsightsComponentFavorite' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/favorites_API.json#L240 |
|
The schema 'ApplicationInsightsWebTestLocationsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTestLocations_API.json#L75 |
|
The schema 'WebtestsResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTests_API.json#L285 |
|
The schema 'tags' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTests_API.json#L310 |
|
The schema 'TagsResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTests_API.json#L323 |
|
The schema 'tags' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTests_API.json#L325 |
|
The schema 'webTestListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTests_API.json#L334 |
|
The schema 'WebTest' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTests_API.json#L353 |
|
The schema 'WebTestProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTests_API.json#L381 |
|
The schema 'WorkbookTemplateResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json#L252 |
|
The schema 'WorkbookTemplatesListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json#L291 |
|
The schema 'WorkbookTemplate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json#L303 |
|
The schema 'WorkbookTemplateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json#L318 |
|
The schema 'WorkbookTemplateGallery' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json#L357 |
|
The schema 'WorkbookTemplateLocalizedGallery' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json#L383 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/applicationinsights/resource-manager/readme.md tag: specification/applicationinsights/resource-manager/readme.md#tag-package-2021-11-01 |
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
|
Hi @cataggar, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Jan 5, 2022
|
Removing the Go workaround should remove the breaking change. |
|
Looks like the Operation_List models are different. This won't work. Trying #17246. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #17215. An identical definition of
Operations_Listis already in:Microsoft.Insights/stable/2015-05-01/aiOperations_API.json
This just removes the duplicate.