-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove Operations_List from Microsoft.Insights 2020-06-02-preview livetoken_API.json #17243
Conversation
Hi, @cataggar Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
Rule | Message |
---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/providers/microsoft.insights/operations' removed or restructured? Old: Microsoft.Insights/preview/2020-06-02-preview/livetoken_API.json#L39:5 |
️⚠️
LintDiff: 0 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
- Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/components/{resourceName}/linkedStorageAccounts/{storageType}' Location: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L37 |
R3020 - PathResourceProviderNamePascalCase |
Resource provider naming must follow the pascal case. Path: '/{resourceUri}/providers/microsoft.insights/generatelivetoken' Location: Microsoft.Insights/preview/2020-06-02-preview/livetoken_API.json#L39 |
R3026 - TrackedResourcePatchOperation |
Tracked resource 'Workbook' must have patch operation that at least supports the update of tags. It's strongly recommended that the PATCH operation supports update of all mutable properties as well. Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L473 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/stable/2015-05-01/analyticsItems_API.json#L37 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/stable/2015-05-01/analyticsItems_API.json#L85 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L37 |
R3030 - PathResourceProviderMatchNamespace |
The last resource provider 'microsoft.insights' doesn't match the namespace. Location: Microsoft.Insights/preview/2020-06-02-preview/livetoken_API.json#L39 |
R4007 - DefaultErrorResponseSchema |
the default error response schema does not correspond to the schema documented at https://github.com/Azure/azure-resource-manager-rpc/blob/master/v1.0/common-api-details.md#error-response-content. Location: Microsoft.Insights/stable/2015-05-01/aiOperations_API.json#L50 |
R4015 - NestedResourcesMustHaveListOperation |
The nested resource 'ComponentLinkedStorageAccounts' does not have list operation, please add it. Location: Microsoft.Insights/preview/2020-03-01-preview/componentLinkedStorageAccounts_API.json#L240 |
R4018 - OperationsApiResponseSchema |
The response schema of operations API '/providers/Microsoft.Insights/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.Insights/stable/2015-05-01/aiOperations_API.json#L31 |
R4037 - MissingTypeObject |
The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/aiOperations_API.json#L92 |
R4037 - MissingTypeObject |
The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/aiOperations_API.json#L111 |
R4037 - MissingTypeObject |
The schema 'AnnotationsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/componentAnnotations_API.json#L244 |
R4037 - MissingTypeObject |
The schema 'ApplicationInsightsComponentAPIKeyListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/componentApiKeys_API.json#L209 |
R4037 - MissingTypeObject |
The schema 'WorkItemConfigurationsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/componentWorkItemConfigs_API.json#L290 |
R4037 - MissingTypeObject |
The schema 'ApplicationInsightsComponentFavorite' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/favorites_API.json#L240 |
R4037 - MissingTypeObject |
The schema 'ApplicationInsightsWebTestLocationsListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTestLocations_API.json#L75 |
R4037 - MissingTypeObject |
The schema 'WebtestsResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTests_API.json#L285 |
R4037 - MissingTypeObject |
The schema 'tags' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTests_API.json#L310 |
R4037 - MissingTypeObject |
The schema 'TagsResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTests_API.json#L323 |
R4037 - MissingTypeObject |
The schema 'tags' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTests_API.json#L325 |
R4037 - MissingTypeObject |
The schema 'webTestListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTests_API.json#L334 |
R4037 - MissingTypeObject |
The schema 'WebTest' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTests_API.json#L353 |
R4037 - MissingTypeObject |
The schema 'WebTestProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2015-05-01/webTests_API.json#L381 |
R4037 - MissingTypeObject |
The schema 'WorkbookTemplateResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json#L252 |
R4037 - MissingTypeObject |
The schema 'WorkbookTemplatesListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json#L291 |
R4037 - MissingTypeObject |
The schema 'WorkbookTemplate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json#L303 |
R4037 - MissingTypeObject |
The schema 'WorkbookTemplateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json#L318 |
R4037 - MissingTypeObject |
The schema 'WorkbookTemplateGallery' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json#L357 |
R4037 - MissingTypeObject |
The schema 'WorkbookTemplateLocalizedGallery' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Insights/stable/2020-11-20/workbookTemplates_API.json#L383 |
️⚠️
Avocado: 1 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/applicationinsights/resource-manager/readme.md tag: specification/applicationinsights/resource-manager/readme.md#tag-package-2021-11-01 |
️️✔️
~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Generation Artifacts
|
Hi @cataggar, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Removing the Go workaround should remove the breaking change. |
Looks like the Operation_List models are different. This won't work. Trying #17246. |
This is to fix #17215. An identical definition of
Operations_List
is already in:Microsoft.Insights/stable/2015-05-01/aiOperations_API.json
This just removes the duplicate.