New API spec for peering microsoft.peering 2022 01 01 #17280

jjsridharan · 2022-01-07T16:38:19Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…01 to version 2022-01-01

openapi-workflow-bot · 2022-01-07T16:38:22Z

Hi, @jjsridharan Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-workflow-bot · 2022-01-07T16:38:23Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2022-01-07T16:38:23Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
- peering/resource-manager/readme.md tag:package-2022-01-01
Linted configuring files (Based on target branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
- peering/resource-manager/readme.md tag:default

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'PeerAsns_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2022-01-01/peering.json#L301
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'PeerAsns_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2022-01-01/peering.json#L342
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'RegisteredAsns_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2022-01-01/peering.json#L558
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'RegisteredAsns_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2022-01-01/peering.json#L613
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'RegisteredPrefixes_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2022-01-01/peering.json#L793
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'RegisteredPrefixes_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2022-01-01/peering.json#L848
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'Peerings_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2022-01-01/peering.json#L1028
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'Peerings_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2022-01-01/peering.json#L1076
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'Peerings_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2022-01-01/peering.json#L1193
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'ConnectionMonitorTests_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2022-01-01/peering.json#L1425
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'ConnectionMonitorTests_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2022-01-01/peering.json#L1480
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'Prefixes_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2022-01-01/peering.json#L1745
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'Prefixes_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2022-01-01/peering.json#L1807
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'PeeringServices_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2022-01-01/peering.json#L2033
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'PeeringServices_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2022-01-01/peering.json#L2081
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'PeeringServices_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2022-01-01/peering.json#L2192
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Peering/stable/2022-01-01/peering.json#L2604
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Peering/stable/2022-01-01/peering.json#L2644
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Peering/stable/2022-01-01/peering.json#L2900
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Peering/stable/2022-01-01/peering.json#L2981
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Peering/stable/2022-01-01/peering.json#L3028
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Peering/stable/2022-01-01/peering.json#L3079
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Peering/stable/2022-01-01/peering.json#L3234
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Peering/stable/2022-01-01/peering.json#L3241
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Peering/stable/2022-01-01/peering.json#L3254
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Peering/stable/2022-01-01/peering.json#L3522
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.Peering/stable/2022-01-01/peering.json#L3800
⚠️ R2066 - PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'lookingglass' in:'LookingGlass_Invoke'. Consider updating the operationId Location: Microsoft.Peering/stable/2022-01-01/peering.json#L189
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isPrimaryRegion Location: Microsoft.Peering/stable/2022-01-01/peering.json#L2422
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: useForPeeringService Location: Microsoft.Peering/stable/2022-01-01/peering.json#L2611

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️⚠️Cross-Version Breaking Changes: 7 Warnings warning [Detail]

Compared Swaggers (Based on Oad v0.9.3)
- current:stable/2022-01-01/peering.json compared with base:stable/2021-06-01/peering.json
- current:stable/2022-01-01/peering.json compared with base:preview/2020-01-01-preview/peering.json

The following breaking changes are detected by comparison with latest preview version:

Rule	Message
⚠️ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Peering/CheckServiceProviderAvailability' removed or restructured? Old: Microsoft.Peering/preview/2020-01-01-preview/peering.json#L19:5
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.Peering/stable/2022-01-01/peering.json#L2525:9 Old: Microsoft.Peering/preview/2020-01-01-preview/peering.json#L1964:9
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.Peering/stable/2022-01-01/peering.json#L2538:9 Old: Microsoft.Peering/preview/2020-01-01-preview/peering.json#L1976:9
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.Peering/stable/2022-01-01/peering.json#L2551:9 Old: Microsoft.Peering/preview/2020-01-01-preview/peering.json#L1988:9
⚠️ 1029 - ReadonlyPropertyChanged	The read only property has changed from 'false' to 'true'. New: Microsoft.Peering/stable/2022-01-01/peering.json#L3090:9 Old: Microsoft.Peering/preview/2020-01-01-preview/peering.json#L2402:9
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'code' renamed or removed? New: Microsoft.Peering/stable/2022-01-01/peering.json#L4061:7 Old: Microsoft.Peering/preview/2020-01-01-preview/peering.json#L3183:7
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'message' renamed or removed? New: Microsoft.Peering/stable/2022-01-01/peering.json#L4061:7 Old: Microsoft.Peering/preview/2020-01-01-preview/peering.json#L3183:7

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

peering/resource-manager/readme.md#package-2022-01-01

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-01-07T16:38:24Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-go-track2 - armpeering - 0.4.0
❌azure-sdk-for-python-track2 - track2_azure-mgmt-peering - Approved - 1.0.0

️✔️azure-sdk-for-go - peering/mgmt/2022-01-01/peering - v61.6.0
️✔️azure-sdk-for-go - peering/mgmt/2021-06-01/peering - v61.6.0
️✔️azure-sdk-for-go - peering/mgmt/2021-01-01/peering - v61.6.0
️✔️azure-sdk-for-go - peering/mgmt/2020-10-01/peering - v61.6.0
️✔️azure-sdk-for-go - peering/mgmt/2020-04-01/peering - v61.6.0
️✔️azure-sdk-for-go - preview/peering/mgmt/2020-01-01-preview/peering - v61.6.0
️✔️azure-sdk-for-go - preview/peering/mgmt/2019-09-01-preview/peering - v61.6.0
️✔️azure-sdk-for-go - preview/peering/mgmt/2019-08-01-preview/peering - v61.6.0
❌azure-sdk-for-js - track2_@azure/arm-peering - 3.0.0

+	Operation LegacyPeerings.list has a new signature
+	Operation LookingGlass.invoke has a new signature
+	Operation PeeringLocations.list has a new signature
+	Removed Enum KnownLegacyPeeringsKind
+	Removed Enum KnownLookingGlassCommand
+	Removed Enum KnownLookingGlassSourceType
+	Removed Enum KnownPeeringLocationsDirectPeeringType
+	Removed Enum KnownPeeringLocationsKind

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from bb4175d. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.3.1 -> 8.5.2
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.2>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-peering [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation PeeringServicesOperations.initialize_connection_monitor
info	[Changelog]   - Added operation PrefixesOperations.create_or_update
info	[Changelog]   - Added operation PrefixesOperations.delete
info	[Changelog]   - Added operation PrefixesOperations.get
info	[Changelog]   - Added operation group CdnPeeringPrefixesOperations
info	[Changelog]   - Added operation group ConnectionMonitorTestsOperations
info	[Changelog]   - Added operation group LookingGlassOperations
info	[Changelog]   - Added operation group PeeringServiceCountriesOperations
info	[Changelog]   - Added operation group ReceivedRoutesOperations
info	[Changelog]   - Added operation group RegisteredAsnsOperations
info	[Changelog]   - Added operation group RegisteredPrefixesOperations
info	[Changelog]   - Model DirectConnection has a new parameter error_message
info	[Changelog]   - Model DirectConnection has a new parameter microsoft_tracking_id
info	[Changelog]   - Model ErrorResponse has a new parameter error
info	[Changelog]   - Model ExchangeConnection has a new parameter error_message
info	[Changelog]   - Model Operation has a new parameter service_specification
info	[Changelog]   - Model PeerAsn has a new parameter error_message
info	[Changelog]   - Model PeerAsn has a new parameter peer_contact_detail
info	[Changelog]   - Model PeeringService has a new parameter log_analytics_workspace_properties
info	[Changelog]   - Model PeeringService has a new parameter provider_backup_peering_location
info	[Changelog]   - Model PeeringService has a new parameter provider_primary_peering_location
info	[Changelog]   - Model PeeringService has a new parameter sku
info	[Changelog]   - Model PeeringServicePrefix has a new parameter error_message
info	[Changelog]   - Model PeeringServicePrefix has a new parameter events
info	[Changelog]   - Model PeeringServicePrefix has a new parameter peering_service_prefix_key
info	[Changelog]   - Model PeeringServiceProvider has a new parameter peering_locations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model ErrorResponse no longer has parameter code
info	[Changelog]   - Model ErrorResponse no longer has parameter message
info	[Changelog]   - Model PeerAsn no longer has parameter peer_contact_info
info	[Changelog]   - Operation LegacyPeeringsOperations.list has a new signature
info	[Changelog]   - Operation PeeringServiceLocationsOperations.list has a new signature
info	[Changelog]   - Operation PrefixesOperations.list_by_peering_service has a new signature
info	[Changelog]   - Removed operation group PeeringServicePrefixesOperations

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from bb4175d. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2022-02-25 11:17:09 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-peering;1.0.0-beta.1;1.0.0-beta.2"
cmderr	[generate.py] 2022-02-25 11:17:09 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
cmderr	[generate.py] 2022-02-25 11:17:09 INFO autorest --version=3.6.6 --use=@autorest/[email protected] --java --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/peering/azure-resourcemanager-peering --java.namespace=com.azure.resourcemanager.peering   --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/peering/resource-manager/readme.md
cmderr	[generate.py] 2022-02-25 11:17:40 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-peering
cmderr	[generate.py] 2022-02-25 11:17:40 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2022-02-25 11:17:40 INFO [POM][Skip] pom already has module azure-resourcemanager-peering
cmderr	[generate.py] 2022-02-25 11:17:40 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2022-02-25 11:17:40 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2022-02-25 11:17:40 INFO [POM][Skip] pom already has module sdk/peering
cmderr	[generate.py] 2022-02-25 11:17:40 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-peering [View full logs] [Release SDK Changes]

cmderr	[Inst] 2022-02-25 11:19:27 DEBUG Got artifact_id: azure-resourcemanager-peering
cmderr	[Inst] 2022-02-25 11:19:27 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2022-02-25 11:19:27 DEBUG Got artifact: azure-resourcemanager-peering-1.0.0-beta.2.jar
cmderr	[Inst] 2022-02-25 11:19:27 DEBUG Match jar package: azure-resourcemanager-peering-1.0.0-beta.2.jar
cmderr	[Inst] 2022-02-25 11:19:27 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17280/azure-sdk-for-java/azure-resourcemanager-peering/azure-resourcemanager-peering-1.0.0-beta.2.jar\" -o azure-resourcemanager-peering-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-peering -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-peering-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from bb4175d. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️peering/mgmt/2022-01-01/peering [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
info	[Changelog]
```
️✔️peering/mgmt/2021-06-01/peering [View full logs]
```
info	[Changelog] This is a new package
info	[Changelog]
```
️✔️peering/mgmt/2021-01-01/peering [View full logs]
```
info	[Changelog] This is a new package
info	[Changelog]
```

️✔️peering/mgmt/2020-10-01/peering [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️peering/mgmt/2020-04-01/peering [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/peering/mgmt/2020-01-01-preview/peering [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/peering/mgmt/2019-09-01-preview/peering [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/peering/mgmt/2019-08-01-preview/peering [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from bb4175d. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armpeering [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `PeeringLocationsDirectPeeringTypeEdgeZoneForOperators`
info	[Changelog] - New const `DirectPeeringTypeEdgeZoneForOperators`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 2 additive change(s).

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from bb4175d. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/peering/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.Peering [View full logs] [Release SDK Changes]

cmdout	[msbuild] /home/vsts/work/1/s/azure-sdk-for-net/sdk/peering/Microsoft.Azure.Management.Peering/tests/PeeringTests.cs(827,17): error CS0200: Property or indexer 'PeerAsn.ValidationState' cannot be assigned to -- it is read only [/home/vsts/work/1/s/azure-sdk-for-net/sdk/peering/Microsoft.Azure.Management.Peering/tests/Microsoft.Azure.Management.Peering.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/peering/Microsoft.Azure.Management.Peering/tests/PeeringTests.cs(827,17): error CS0200: Property or indexer 'PeerAsn.ValidationState' cannot be assigned to -- it is read only [/home/vsts/work/1/s/azure-sdk-for-net/sdk/peering/Microsoft.Azure.Management.Peering/tests/Microsoft.Azure.Management.Peering.Tests.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from bb4175d. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] npm WARN deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-peering [View full logs] [Release SDK Changes]

azure-arm-peering-2.1.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Enum KnownDirectPeeringType has a new value EdgeZoneForOperators
info	[Changelog]   - Enum KnownPeeringLocationsDirectPeeringType has a new value EdgeZoneForOperators
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from bb4175d. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️peering [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

jjsridharan · 2022-01-07T16:43:39Z

Diff spec: https://portal.azure-devex-tools.com/tools/diff/eyJzb3VyY2VVcmwiOiJodHRwczovL2dpdGh1Yi5jb20vampzcmlkaGFyYW4vYXp1cmUtcmVzdC1hcGktc3BlY3MvYmxvYi9kZXYtcGVlcmluZy1NaWNyb3NvZnQuUGVlcmluZy0yMDIyLTAxLTAxL3NwZWNpZmljYXRpb24vcGVlcmluZy9yZXNvdXJjZS1tYW5hZ2VyL01pY3Jvc29mdC5QZWVyaW5nL3N0YWJsZS8yMDIxLTA2LTAxL3BlZXJpbmcuanNvbiIsInRhcmdldFVybCI6Imh0dHBzOi8vZ2l0aHViLmNvbS9qanNyaWRoYXJhbi9henVyZS1yZXN0LWFwaS1zcGVjcy9ibG9iL2Rldi1wZWVyaW5nLU1pY3Jvc29mdC5QZWVyaW5nLTIwMjItMDEtMDEvc3BlY2lmaWNhdGlvbi9wZWVyaW5nL3Jlc291cmNlLW1hbmFnZXIvTWljcm9zb2Z0LlBlZXJpbmcvc3RhYmxlLzIwMjItMDEtMDEvcGVlcmluZy5qc29uIn0=

zhenglaizhang · 2022-01-10T03:26:46Z

@jjsridharan the API Readiness Check failed, is the api version already deployed?

jjsridharan · 2022-01-10T05:52:03Z

@zhenglaizhang No, not yet. Is this mandatory for PR to get merged? (We will be deploying the new version in 1-2 weeks' time frame).

raych1 · 2022-01-14T04:51:00Z

/azp run

azure-pipelines · 2022-01-14T04:51:10Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-workflow-bot · 2022-01-14T05:23:13Z

Hi, @jjsridharan your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

leni-msft · 2022-01-14T05:26:22Z

@zhenglaizhang Zhenglai Zhang FTE No, not yet. Is this mandatory for PR to get merged? (We will be deploying the new version in 1-2 weeks' time frame).

yes, PR can not be merged until your service is deployed. Merging swagger to main branch means API release. But service deployment doesn't block PR review. Currently this PR is waiting for ARM review.

If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

jjsridharan · 2022-01-14T13:31:06Z

/azp run

azure-pipelines · 2022-01-14T13:32:14Z

Azure Pipelines successfully started running 1 pipeline(s).

j5lim

Approved from ARM side.

jjsridharan · 2022-01-25T07:16:17Z

/azp run

azure-pipelines · 2022-01-25T07:16:27Z

Azure Pipelines successfully started running 1 pipeline(s).

leni-msft · 2022-01-25T07:57:29Z

@qiaozha @ArcturusZhang @msyyc pls check the sdk breaking changes.

jjsridharan · 2022-02-07T06:13:47Z

@ArcturusZhang can you please review/approve this PR ?

specification/peering/resource-manager/Microsoft.Peering/stable/2022-01-01/peering.json

…into dev-peering-Microsoft.Peering-2022-01-01

ArcturusZhang

LGTM now - the go breaking changes are resolved

* Adding 2022-01-01 version for Peering * update Peering spec for 2022-01-01 * updating 2022-01-01 Peering spec * update swagger examples * Adds base for updating Microsoft.Peering from version stable/2021-06-01 to version 2022-01-01 * Updates readme * Updates API version in new specs and examples * Creating new API spec version 2022-01-01 for Peering * Fix staging lint issues * update as per comment - updating x-ms-enum names Co-authored-by: Sridharan J <[email protected]>

Sridharan J and others added 8 commits January 6, 2022 19:12

Adding 2022-01-01 version for Peering

09d6c8c

update Peering spec for 2022-01-01

572985c

updating 2022-01-01 Peering spec

f3abb54

update swagger examples

de42a3b

Adds base for updating Microsoft.Peering from version stable/2021-06-…

bffea2d

…01 to version 2022-01-01

Updates readme

734d2aa

Updates API version in new specs and examples

f0825a0

Creating new API spec version 2022-01-01 for Peering

dbc8633

jjsridharan requested a review from ArcturusZhang as a code owner January 7, 2022 16:38

openapi-assignment-bot bot assigned leni-msft Jan 7, 2022

openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 14, 2022

j5lim approved these changes Jan 18, 2022

View reviewed changes

Fix staging lint issues

648cf22

openapi-pipeline-app bot added CI-BreakingChange-JavaScript and removed CI-FixRequiredOnFailure labels Jan 20, 2022

msyyc added the Approved-SdkBreakingChange-Python label Jan 26, 2022

leni-msft approved these changes Feb 7, 2022

View reviewed changes

ArcturusZhang reviewed Feb 22, 2022

View reviewed changes

jjsridharan requested a review from ArcturusZhang February 23, 2022 11:40

Sridharan J added 2 commits February 25, 2022 11:25

Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs …

201ad60

…into dev-peering-Microsoft.Peering-2022-01-01

update as per comment - updating x-ms-enum names

3421ea7

openapi-pipeline-app bot removed the CI-BreakingChange-Go-V2 label Feb 25, 2022

openapi-sdkautomation bot mentioned this pull request Feb 25, 2022

[AutoPR @azure/arm-peering] New API spec for peering microsoft.peering 2022 01 01 AzureSDKAutomation/azure-sdk-for-js#7794

Closed

openapi-pipeline-app bot removed the CI-BreakingChange-JavaScript label Feb 25, 2022

ArcturusZhang approved these changes Feb 25, 2022

View reviewed changes

leni-msft merged commit bb4175d into Azure:main Feb 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New API spec for peering microsoft.peering 2022 01 01 #17280

New API spec for peering microsoft.peering 2022 01 01 #17280

jjsridharan commented Jan 7, 2022 •

edited by leni-msft

Loading

openapi-workflow-bot bot commented Jan 7, 2022

openapi-workflow-bot bot commented Jan 7, 2022

openapi-pipeline-app bot commented Jan 7, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jan 7, 2022 •

edited

Loading

Breaking Changes Tracking

jjsridharan commented Jan 7, 2022

zhenglaizhang commented Jan 10, 2022

jjsridharan commented Jan 10, 2022

raych1 commented Jan 14, 2022

azure-pipelines bot commented Jan 14, 2022

openapi-workflow-bot bot commented Jan 14, 2022

leni-msft commented Jan 14, 2022

jjsridharan commented Jan 14, 2022

azure-pipelines bot commented Jan 14, 2022

j5lim left a comment

jjsridharan commented Jan 25, 2022

azure-pipelines bot commented Jan 25, 2022

leni-msft commented Jan 25, 2022

jjsridharan commented Feb 7, 2022

ArcturusZhang left a comment

New API spec for peering microsoft.peering 2022 01 01 #17280

New API spec for peering microsoft.peering 2022 01 01 #17280

Conversation

jjsridharan commented Jan 7, 2022 • edited by leni-msft Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 7, 2022

openapi-workflow-bot bot commented Jan 7, 2022

openapi-pipeline-app bot commented Jan 7, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 7, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

jjsridharan commented Jan 7, 2022

zhenglaizhang commented Jan 10, 2022

jjsridharan commented Jan 10, 2022

raych1 commented Jan 14, 2022

azure-pipelines bot commented Jan 14, 2022

openapi-workflow-bot bot commented Jan 14, 2022

leni-msft commented Jan 14, 2022

jjsridharan commented Jan 14, 2022

azure-pipelines bot commented Jan 14, 2022

j5lim left a comment

Choose a reason for hiding this comment

jjsridharan commented Jan 25, 2022

azure-pipelines bot commented Jan 25, 2022

leni-msft commented Jan 25, 2022

jjsridharan commented Feb 7, 2022

ArcturusZhang left a comment

Choose a reason for hiding this comment

jjsridharan commented Jan 7, 2022 •

edited by leni-msft

Loading

openapi-pipeline-app bot commented Jan 7, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jan 7, 2022 •

edited

Loading