[Hub Generated] Review request for Microsoft.InstanceMetadataService to add version stable/2018-02-01 #17316

joshdmcc · 2022-01-12T00:35:57Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- [] new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify Adding swagger for old api version
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

… stable/2018-04-02 to version 2018-02-01

openapi-workflow-bot · 2022-01-12T00:35:59Z

Hi, @joshdmcc Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-workflow-bot · 2022-01-12T00:36:00Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2022-01-12T00:36:00Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

Linted configuring files (Based on source branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
Linted configuring files (Based on target branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-01-12T00:36:01Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-go - imds/2019-02-01/imds - v62.1.0

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 5e1adcb. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh]   ERROR: Command errored out with exit status 1:
cmderr	[automation_init.sh]    command: /home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/bin/python -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/home/vsts/work/1/s/azure-sdk-for-python_tmp/pip-install-ptykwxmz/markupsafe_906fc7b2b48d48d69dd292cebba039c0/setup.py'"'"'; __file__='"'"'/home/vsts/work/1/s/azure-sdk-for-python_tmp/pip-install-ptykwxmz/markupsafe_906fc7b2b48d48d69dd292cebba039c0/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /home/vsts/work/1/s/azure-sdk-for-python_tmp/pip-pip-egg-info-bf_v_mku
cmderr	[automation_init.sh]        cwd: /home/vsts/work/1/s/azure-sdk-for-python_tmp/pip-install-ptykwxmz/markupsafe_906fc7b2b48d48d69dd292cebba039c0/
cmderr	[automation_init.sh]   Complete output (30 lines):
cmderr	[automation_init.sh]   Traceback (most recent call last):
cmderr	[automation_init.sh]     File "<string>", line 1, in <module>
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/pip-install-ptykwxmz/markupsafe_906fc7b2b48d48d69dd292cebba039c0/setup.py", line 65, in <module>
cmderr	[automation_init.sh]       run_setup(True)
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/pip-install-ptykwxmz/markupsafe_906fc7b2b48d48d69dd292cebba039c0/setup.py", line 44, in run_setup
cmderr	[automation_init.sh]       ext_modules=ext_modules if with_binary else [],
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/__init__.py", line 129, in setup
cmderr	[automation_init.sh]       return distutils.core.setup(**attrs)
cmderr	[automation_init.sh]     File "/usr/lib/python3.6/distutils/core.py", line 121, in setup
cmderr	[automation_init.sh]       dist.parse_config_files()
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/dist.py", line 494, in parse_config_files
cmderr	[automation_init.sh]       ignore_option_errors=ignore_option_errors)
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/config.py", line 106, in parse_configuration
cmderr	[automation_init.sh]       meta.parse()
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/config.py", line 382, in parse
cmderr	[automation_init.sh]       section_parser_method(section_options)
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/config.py", line 355, in parse_section
cmderr	[automation_init.sh]       self[name] = value
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/config.py", line 173, in __setitem__
cmderr	[automation_init.sh]       value = parser(value)
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/config.py", line 430, in _parse_version
cmderr	[automation_init.sh]       version = self._parse_attr(value)
cmderr	[automation_init.sh]     File "/home/vsts/work/1/s/azure-sdk-for-python_tmp/venv-sdk/lib/python3.6/site-packages/setuptools/config.py", line 305, in _parse_attr
cmderr	[automation_init.sh]       module = import_module(module_name)
cmderr	[automation_init.sh]     File "/usr/lib/python3.6/importlib/__init__.py", line 126, in import_module
cmderr	[automation_init.sh]       return _bootstrap._gcd_import(name[level:], package, level)
cmderr	[automation_init.sh]     File "<frozen importlib._bootstrap>", line 994, in _gcd_import
cmderr	[automation_init.sh]     File "<frozen importlib._bootstrap>", line 971, in _find_and_load
cmderr	[automation_init.sh]     File "<frozen importlib._bootstrap>", line 953, in _find_and_load_unlocked
cmderr	[automation_init.sh]   ModuleNotFoundError: No module named 'markupsafe'
cmderr	[automation_init.sh]   ----------------------------------------
cmderr	[automation_init.sh] WARNING: Discarding https://files.pythonhosted.org/packages/62/0f/52c009332fdadd484e898dc8f2acca0663c1031b3517070fd34ad9c1b64e/MarkupSafe-2.1.0.tar.gz#sha256=80beaf63ddfbc64a0452b841d8036ca0611e049650e20afcb882f5d3c266d65f (from https://pypi.org/simple/markupsafe/) (requires-python:>=3.7). Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
cmderr	[automation_init.sh] opencensus-ext-azure 1.1.3 requires azure-core<2.0.0,>=1.12.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] azure-mgmt-core 1.3.0 requires azure-core<2.0.0,>=1.15.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] azure-identity 1.8.0 requires azure-core<2.0.0,>=1.11.0, but you have azure-core 1.6.0 which is incompatible.
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.3.1 -> 8.5.3
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.3>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️azure-imds [View full logs] [Release SDK Changes]

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 5e1adcb. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2022-03-07 16:09:20 INFO [Skip] readme path does not format as specification/*/resource-manager/readme.md
cmderr	[generate.py] 2022-03-07 16:09:20 INFO [Skip] changed file specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2018-02-01/examples/getIdentityInfo.json
cmderr	[generate.py] 2022-03-07 16:09:20 INFO [Skip] changed file specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2018-02-01/examples/getIdentityToken.json
cmderr	[generate.py] 2022-03-07 16:09:20 INFO [Skip] changed file specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2018-02-01/examples/getInstanceMetadata.json
cmderr	[generate.py] 2022-03-07 16:09:20 INFO [GENERATE] Autorest from JSON ../azure-rest-api-specs/specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2018-02-01/imds.json
cmderr	[generate.py] 2022-03-07 16:09:20 INFO autorest --version=3.6.6 --use=@autorest/[email protected] --java --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/imds/azure-imds-imds --java.namespace=com.azure.imds.imds --low-level-client --sdk-integration --generate-samples --input-file=../azure-rest-api-specs/specification/imds/data-plane/Microsoft.InstanceMetadataService/stable/2018-02-01/imds.json  --artifact-id=azure-imds-imds
cmderr	[generate.py] 2022-03-07 16:09:54 INFO [VERSION][Not Found] cannot find version for "com.azure:azure-imds-imds"
cmderr	[generate.py] 2022-03-07 16:09:54 INFO [CI][Success] Write to ci.yml
cmderr	[generate.py] 2022-03-07 16:09:54 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2022-03-07 16:09:54 INFO [POM][Skip] pom already has module azure-imds-imds
cmderr	[generate.py] 2022-03-07 16:09:54 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2022-03-07 16:09:54 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2022-03-07 16:09:54 INFO [POM][Success] Write to root pom
cmderr	[generate.py] 2022-03-07 16:09:54 INFO mvn --no-transfer-progress clean verify package -f /home/vsts/work/1/s/azure-sdk-for-java/pom.xml -Dmaven.javadoc.skip -Dgpg.skip -Drevapi.skip -pl com.azure:azure-imds-imds -am
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr	[generate.py] 2022-03-07 16:12:25 INFO [Skip] changed file specification/imds/data-plane/readme.md

️✔️azure-imds-imds [View full logs] [Release SDK Changes]

cmderr	[Inst] 2022-03-07 16:12:28 DEBUG Got artifact_id: azure-imds-imds
cmderr	[Inst] 2022-03-07 16:12:28 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2022-03-07 16:12:28 DEBUG Got artifact: azure-imds-imds-1.0.0-beta.1.jar
cmderr	[Inst] 2022-03-07 16:12:28 DEBUG Match jar package: azure-imds-imds-1.0.0-beta.1.jar
cmderr	[Inst] 2022-03-07 16:12:28 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17316/azure-sdk-for-java/azure-imds-imds/azure-imds-imds-1.0.0-beta.1.jar\" -o azure-imds-imds-1.0.0-beta.1.jar\nmvn install:install-file -DgroupId=com.azure -DartifactId=azure-imds-imds -Dversion=1.0.0-beta.0 -Dfile=azure-imds-imds-1.0.0-beta.1.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 5e1adcb. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️imds/2019-02-01/imds [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
info	[Changelog]
```

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 5e1adcb. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] npm WARN deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation

_{Posted by Swagger Pipeline | How to fix these errors?}

ghost · 2022-01-30T16:02:02Z

Hi, @joshdmcc. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

ghost · 2022-02-20T16:02:18Z

Hi, @joshdmcc. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

ghost · 2022-03-07T05:02:05Z

Hi, @joshdmcc. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee.

joshdmcc · 2022-03-07T15:42:58Z

@jhendrixMSFT We're looking to merge this

…to add version stable/2018-02-01 (Azure#17316) * Adds base for updating Microsoft.InstanceMetadataService from version stable/2018-04-02 to version 2018-02-01 * Updates readme * Updates API version in new specs and examples * Back-adding version 2018-02-01 Co-authored-by: jmccarthy <[email protected]>

joshdmcc and others added 4 commits January 11, 2022 16:26

Adds base for updating Microsoft.InstanceMetadataService from version…

35f2040

… stable/2018-04-02 to version 2018-02-01

Updates readme

4597e52

Updates API version in new specs and examples

98bbaa5

Back-adding version 2018-02-01

561472c

joshdmcc marked this pull request as ready for review January 12, 2022 00:35

openapi-assignment-bot bot assigned jhendrixMSFT Jan 12, 2022

ghost added the no-recent-activity label Jan 30, 2022

joshdmcc removed the no-recent-activity label Feb 1, 2022

ghost added the no-recent-activity label Feb 20, 2022

ghost closed this Mar 7, 2022

joshdmcc reopened this Mar 7, 2022

ghost removed the no-recent-activity label Mar 7, 2022

jhendrixMSFT approved these changes Mar 7, 2022

View reviewed changes

jhendrixMSFT merged commit 5e1adcb into Azure:main Mar 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.InstanceMetadataService to add version stable/2018-02-01 #17316

[Hub Generated] Review request for Microsoft.InstanceMetadataService to add version stable/2018-02-01 #17316

joshdmcc commented Jan 12, 2022 •

edited

Loading

openapi-workflow-bot bot commented Jan 12, 2022

openapi-workflow-bot bot commented Jan 12, 2022

openapi-pipeline-app bot commented Jan 12, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jan 12, 2022 •

edited

Loading

Breaking Changes Tracking

ghost commented Jan 30, 2022

ghost commented Feb 20, 2022

ghost commented Mar 7, 2022

joshdmcc commented Mar 7, 2022

[Hub Generated] Review request for Microsoft.InstanceMetadataService to add version stable/2018-02-01 #17316

[Hub Generated] Review request for Microsoft.InstanceMetadataService to add version stable/2018-02-01 #17316

Conversation

joshdmcc commented Jan 12, 2022 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Jan 12, 2022

openapi-workflow-bot bot commented Jan 12, 2022

openapi-pipeline-app bot commented Jan 12, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Jan 12, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

ghost commented Jan 30, 2022

ghost commented Feb 20, 2022

ghost commented Mar 7, 2022

joshdmcc commented Mar 7, 2022

joshdmcc commented Jan 12, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jan 12, 2022 •

edited

Loading

openapi-pipeline-app bot commented Jan 12, 2022 •

edited

Loading