Guest Configuration: Fix S360 Swagger spec correctness and Linter errors

[aashish1987]

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

1. What's the purpose of the update?
   • new service onboarding
   • new API version
   • update existing version for new feature
   • update existing version to fix swagger quality issue in s360
   • Other, please clarify
2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month. - NA
3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. - 1/18
4. If updating an existing version, please select the specific langauge SDKs and CLIs that must be refreshed after the swagger is published.
   • SDK of .NET (need service team to ensure code readiness)
   • SDK of Python
   • SDK of Java
   • SDK of Js
   • SDK of Go
   • PowerShell
   • CLI
   • Terraform
   • No refresh required for updates in this PR

Contribution checklist:

• I commit to follow the Breaking Change Policy of "no breaking changes"
• I have reviewed the documentation for the workflow.
• Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

• Change to data plane APIs
• Adding new properties
• All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

• Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

  • Adding a new service
  • Adding new API(s)
  • Adding a new API version
    -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits.

• Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

• If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

• Removing API(s) in a stable version
• Removing properties in a stable version
• Removing API version(s) in a stable version
• Updating API in a stable or public preview version with Breaking Change Validation errors
• Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

[openapi-workflow-bot]

Hi, @aashish1987 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

[openapi-workflow-bot]

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

[openapi-pipeline-app]

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

• Compared Swaggers (Based on Oad v0.9.1)
  • current:stable/2018-11-20/guestconfiguration.json compared with base:stable/2018-11-20/guestconfiguration.json

Rule	Message
❌ 1045 - AddedOptionalProperty	The new version has a new optional property 'resourceType' that was not found in the old version. New: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L1021:7 Old: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L1021:7

️⚠️LintDiff: 0 Warnings warning [Detail]

• Linted configuring files (Based on source branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
  • guestconfiguration/resource-manager/readme.md tag:package-2018-11-20
• Linted configuring files (Based on target branch, openapi-validator v1.10.1 , classic-openapi-validator v1.1.10 )
  • guestconfiguration/resource-manager/readme.md tag:package-2018-11-20

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
❌ R2020 - RequiredPropertiesMissingInResourceModel	Model definition 'GuestConfigurationAssignment' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L867
❌ R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L184
❌ R4011 - DeleteOperationResponses	The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L624
❌ R4018 - OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.GuestConfiguration/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L811
❌ R4037 - MissingTypeObject	The schema 'GuestConfigurationAssignmentList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L855
❌ R4037 - MissingTypeObject	The schema 'GuestConfigurationAssignment' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L867
❌ R4037 - MissingTypeObject	The schema 'GuestConfigurationNavigation' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L882
❌ R4037 - MissingTypeObject	The schema 'ConfigurationParameter' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L952
❌ R4037 - MissingTypeObject	The schema 'ConfigurationSetting' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L967
❌ R4037 - MissingTypeObject	The schema 'GuestConfigurationAssignmentProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L1020
❌ R4037 - MissingTypeObject	The schema 'GuestConfigurationAssignmentReportList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L1102
❌ R4037 - MissingTypeObject	The schema 'GuestConfigurationAssignmentReport' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L1114
❌ R4037 - MissingTypeObject	The schema 'GuestConfigurationAssignmentReportProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L1133
❌ R4037 - MissingTypeObject	The schema 'AssignmentInfo' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L1187
❌ R4037 - MissingTypeObject	The schema 'VMInfo' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L1201
❌ R4037 - MissingTypeObject	The schema 'ConfigurationInfo' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L1216
❌ R4037 - MissingTypeObject	The schema 'AssignmentReportDetails' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L1231
❌ R4037 - MissingTypeObject	The schema 'AssignmentReportResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L1287
❌ R4037 - MissingTypeObject	The schema 'AssignmentReportResourceComplianceReason' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L1318
❌ R4037 - MissingTypeObject	The schema 'VMSSVMInfo' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L1333
❌ R4037 - MissingTypeObject	The schema 'ErrorResponse' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/common/v1/definitions.json#L27
❌ R4037 - MissingTypeObject	The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/common/v1/definitions.json#L142
❌ R4037 - MissingTypeObject	The schema 'display' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/common/v1/definitions.json#L121
❌ R4037 - MissingTypeObject	The schema 'OperationList' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.GuestConfiguration/common/v1/definitions.json#L154
⚠️ R1003 - ListInOperationName	Since operation 'GuestConfigurationAssignments_SubscriptionList' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L208
⚠️ R1003 - ListInOperationName	Since operation 'GuestConfigurationAssignments_RGList' response has model definition 'x-ms-pageable', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L256
⚠️ R1005 - GetInOperationName	'GET' operation 'GuestConfigurationAssignments_SubscriptionList' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L208
⚠️ R1005 - GetInOperationName	'GET' operation 'GuestConfigurationAssignments_RGList' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L256
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L1126
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.GuestConfiguration/stable/2018-11-20/guestconfiguration.json#L1310

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

• The following tags are being changed in this PR
• guestconfiguration/resource-manager/readme.md#package-2018-11-20

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account. 

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go-track2 - armguestconfiguration - 0.2.0

+	Field `InnerError` of struct `ErrorResponse` has been removed
-	Struct `ErrorResponseError` has been removed
-	Struct `ErrorResponse` has been removed
-	Type of `AssignmentReportResource.Properties` has been changed from `map[string]interface{}` to `interface{}`

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-guestconfig - 1.0.0b1
️✔️azure-sdk-for-go - guestconfiguration/mgmt/2021-01-25/guestconfiguration - v61.1.0
️✔️azure-sdk-for-go - guestconfiguration/mgmt/2020-06-25/guestconfiguration - v61.1.0

️⚠️ azure-sdk-for-python-track2 warning [Detail]

• ⚠️Warning [Logs]Release - Generate from b55d39c. SDK Automation 14.0.0

  command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
  cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
  command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  cmderr	[automation_generate.sh]
  cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.1.2 -> 8.4.0
  cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.4.0>
  cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
  cmderr	[automation_generate.sh] npm notice

• ️✔️track2_azure-mgmt-guestconfig [View full logs]  [Release SDK Changes]
  • azure_mgmt_guestconfig-1.0.0b1-py3-none-any.whl
  • azure-mgmt-guestconfig-1.0.0b1.zip

  info	[Changelog] **Features**
  info	[Changelog]
  info	[Changelog]   - Added operation GuestConfigurationAssignmentsOperations.rg_list
  info	[Changelog]   - Added operation GuestConfigurationAssignmentsOperations.subscription_list
  info	[Changelog]   - Model GuestConfigurationAssignmentProperties has a new parameter parameter_hash
  info	[Changelog]   - Model GuestConfigurationAssignmentProperties has a new parameter resource_type
  info	[Changelog]   - Model GuestConfigurationAssignmentProperties has a new parameter vmss_vm_list
  info	[Changelog]   - Model GuestConfigurationAssignmentReportProperties has a new parameter vmss_resource_id
  info	[Changelog]   - Model GuestConfigurationNavigation has a new parameter configuration_protected_parameter
  info	[Changelog]   - Model GuestConfigurationNavigation has a new parameter content_type

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

• ️✔️Succeeded [Logs]Release - Generate from b55d39c. SDK Automation 14.0.0

  command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
  command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

• ️✔️guestconfiguration/mgmt/2021-01-25/guestconfiguration [View full logs]  [Release SDK Changes]

  info	[Changelog] ### Features Added
  info	[Changelog]
  info	[Changelog] - New function `AssignmentsClient.SubscriptionList(context.Context) (AssignmentList, error)`
  info	[Changelog] - New function `AssignmentsClient.RGList(context.Context, string) (AssignmentList, error)`
  info	[Changelog] - New function `Navigation.MarshalJSON() ([]byte, error)`
  info	[Changelog] - New function `AssignmentsClient.RGListResponder(*http.Response) (AssignmentList, error)`
  info	[Changelog] - New function `AssignmentsClient.SubscriptionListSender(*http.Request) (*http.Response, error)`
  info	[Changelog] - New function `AssignmentsClient.RGListPreparer(context.Context, string) (*http.Request, error)`
  info	[Changelog] - New function `AssignmentsClient.RGListSender(*http.Request) (*http.Response, error)`
  info	[Changelog] - New function `AssignmentsClient.SubscriptionListPreparer(context.Context) (*http.Request, error)`
  info	[Changelog] - New function `AssignmentsClient.SubscriptionListResponder(*http.Response) (AssignmentList, error)`
  info	[Changelog] - New field `ParameterHash` in struct `AssignmentProperties`
  info	[Changelog] - New field `ContentType` in struct `Navigation`
  info	[Changelog] - New field `ConfigurationProtectedParameter` in struct `Navigation`
  info	[Changelog]
  info	[Changelog] Total 0 breaking change(s), 11 additive change(s).

• ️✔️guestconfiguration/mgmt/2020-06-25/guestconfiguration [View full logs] 

  info	[Changelog] ### Features Added
  info	[Changelog]
  info	[Changelog] - New function `AssignmentsClient.RGListPreparer(context.Context, string) (*http.Request, error)`
  info	[Changelog] - New function `AssignmentsClient.SubscriptionListPreparer(context.Context) (*http.Request, error)`
  info	[Changelog] - New function `AssignmentsClient.SubscriptionListSender(*http.Request) (*http.Response, error)`
  info	[Changelog] - New function `Navigation.MarshalJSON() ([]byte, error)`
  info	[Changelog] - New function `AssignmentsClient.RGListSender(*http.Request) (*http.Response, error)`
  info	[Changelog] - New function `AssignmentsClient.SubscriptionList(context.Context) (AssignmentList, error)`
  info	[Changelog] - New function `AssignmentsClient.SubscriptionListResponder(*http.Response) (AssignmentList, error)`
  info	[Changelog] - New function `AssignmentsClient.RGList(context.Context, string) (AssignmentList, error)`
  info	[Changelog] - New function `AssignmentsClient.RGListResponder(*http.Response) (AssignmentList, error)`
  info	[Changelog] - New function `VMSSVMInfo.MarshalJSON() ([]byte, error)`
  info	[Changelog] - New struct `VMSSVMInfo`
  info	[Changelog] - New field `ContentType` in struct `Navigation`
  info	[Changelog] - New field `ConfigurationProtectedParameter` in struct `Navigation`
  info	[Changelog] - New field `ParameterHash` in struct `AssignmentProperties`
  info	[Changelog] - New field `ResourceType` in struct `AssignmentProperties`
  info	[Changelog] - New field `VmssVMList` in struct `AssignmentProperties`
  info	[Changelog] - New field `VmssResourceID` in struct `AssignmentReportProperties`
  info	[Changelog]
  info	[Changelog] Total 0 breaking change(s), 15 additive change(s).

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

• ️✔️Succeeded [Logs]Release - Generate from b55d39c. SDK Automation 14.0.0

  command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
  command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

• ️✔️armguestconfiguration [View full logs]  [Release SDK Changes]

  info	[Changelog] ### Other Changes
  info	[Changelog]
  info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️⚠️ azure-resource-manager-schemas warning [Detail]

• ⚠️Warning [Logs]Release - Generate from b55d39c. Schema Automation 14.0.0

  command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
  cmderr	[initScript.sh] WARN old lockfile
  cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
  cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
  cmderr	[initScript.sh] npm WARN old lockfile
  cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
  cmderr	[initScript.sh] npm WARN old lockfile
  warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
  command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
  warn	No file changes detected after generation

• ️✔️guestconfiguration [View full logs] 

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-workflow-bot]

Hi @aashish1987, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

[openapi-workflow-bot]

Hi @aashish1987, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

[openapi-workflow-bot]

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

[ghost]

Hi, @aashish1987. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

[aashish1987]

waiting for breaking change meeting