Dev IoT Central Microsoft.IotCentral 2021-11-01-preview #17439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…06-01 to version 2021-11-01-preview
|
Hi, @chgennar Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @chgennar your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
Swagger Generation Artifacts
|
|
Hi @chgennar, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Jan 20, 2022
This was referenced Jan 21, 2022
|
@jianyexi to take a look why breaking change tool never complete |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Fixed |
|
The current LintDiff error R4011 is a problem with the LintDiff tool. The owning team has been notified to update the linting rules. Are there any remaining problems blocking this PR from being merged? |
r-delgadillo
approved these changes
Mar 24, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
raych1
approved these changes
Mar 29, 2022
This was referenced Mar 29, 2022
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Mar 29, 2022
visingl
pushed a commit
that referenced
this pull request
Mar 30, 2022
* Adds base for updating Microsoft.IoTCentral from version stable/2021-06-01 to version 2021-11-01-preview * Updates readme * Updates API version in new specs and examples * Initial update of IoT Central r resource definition * Initial work on private endpoint connection apis * more work on the private endpoint apis * removing some comments * updating put api * Adding examples * Fixing example file * Fixing api spec formatting * Formatting examples * Updating use of in App model definition * ... * Getting rid of definition * Referencing the common types Resource Def instead * ... * more updates * more updates * more updates 2:30PM * more updates 4:20 * Adding private link api * fixing the schema used by private link list * Fix private link list example * addressing some comments * marking default responses as error responses * Updating examples * removing body from some example responses * Adding x-ms-identifier * deleting invisible characters * Adding a common privatelinks.json v4 * updating network ruleset properties * forgot to update examples * trying to remove default responses from example files * Rogelio's comments * moving to the more common 'groupId' private link resource name * fixes and a revert of a change for breaking changes * rule fixes * adding list identifier for operations * fixed one rule and broke another * fixing broken validation rules * finishing up changes for ro's comments * updates * adding type to resource def * updating casing of iotApps to IoTApps * changing back to camelCased 'iotApps' * Delete old privatepreview version from repo * patch back to 202 * example fix and suppression * trying another supression config * improving async header documentation * trying to deduplicate schema definitions * updating the status response schemas for long running apis * updating examples * removing status responses from async apis * suppressing another error for networking * Update delete response codes * forgot to update delete operations * Updating response codes for put and delete apis * move from azure-asyncoperation to location header * Captilizing headers in examples * standardizing capitalization of 'IoT' * Adding provisioning state property * Adding 201 response to Application PUT * commit to start validation checks after tooling update * removing location header from put requests * adding azure-asyncoperation header back * adding a better description to the azure-asyncoperation header
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
* Adds base for updating Microsoft.IoTCentral from version stable/2021-06-01 to version 2021-11-01-preview * Updates readme * Updates API version in new specs and examples * Initial update of IoT Central r resource definition * Initial work on private endpoint connection apis * more work on the private endpoint apis * removing some comments * updating put api * Adding examples * Fixing example file * Fixing api spec formatting * Formatting examples * Updating use of in App model definition * ... * Getting rid of definition * Referencing the common types Resource Def instead * ... * more updates * more updates * more updates 2:30PM * more updates 4:20 * Adding private link api * fixing the schema used by private link list * Fix private link list example * addressing some comments * marking default responses as error responses * Updating examples * removing body from some example responses * Adding x-ms-identifier * deleting invisible characters * Adding a common privatelinks.json v4 * updating network ruleset properties * forgot to update examples * trying to remove default responses from example files * Rogelio's comments * moving to the more common 'groupId' private link resource name * fixes and a revert of a change for breaking changes * rule fixes * adding list identifier for operations * fixed one rule and broke another * fixing broken validation rules * finishing up changes for ro's comments * updates * adding type to resource def * updating casing of iotApps to IoTApps * changing back to camelCased 'iotApps' * Delete old privatepreview version from repo * patch back to 202 * example fix and suppression * trying another supression config * improving async header documentation * trying to deduplicate schema definitions * updating the status response schemas for long running apis * updating examples * removing status responses from async apis * suppressing another error for networking * Update delete response codes * forgot to update delete operations * Updating response codes for put and delete apis * move from azure-asyncoperation to location header * Captilizing headers in examples * standardizing capitalization of 'IoT' * Adding provisioning state property * Adding 201 response to Application PUT * commit to start validation checks after tooling update * removing location header from put requests * adding azure-asyncoperation header back * adding a better description to the azure-asyncoperation header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
March 2022
March 2022
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[x] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.