add canFetchContext parameter to individual get request #17708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @vutran01 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] In reply to: 1032845494 In reply to: 1032845494 |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The optional parameter 'canFetchContent' was added in the new version. New: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L143:9 |
️⚠️LintDiff: 0 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
- Linted configuring files (Based on target branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
| Rule | Message |
|---|---|
| 'GET' operation 'Workbooks_RevisionsList' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L337 |
|
| 'GET' operation 'Workbooks_RevisionsList' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L337 |
|
| 'GET' operation 'Workbooks_RevisionGet' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L379 |
|
| 'GET' operation 'Workbooks_RevisionGet' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L379 |
|
| The child tracked resource, 'revisions' with immediate parent 'Workbook', must have a list by immediate parent operation. Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L476 |
|
| The child tracked resource, 'revisions' with immediate parent 'Workbook', must have a list by immediate parent operation. Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L476 |
|
| 'nextLink' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L470 |
|
| 'nextLink' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L470 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: WorkbooksList2 Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L75 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: WorkbooksList2 Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L75 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: WorkbooksList Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L129 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: WorkbooksList Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L129 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: WorkbookGet Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L174 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: WorkbookGet Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L174 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: WorkbookDelete Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L217 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: WorkbookDelete Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L217 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: WorkbookAdd Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L272 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: WorkbookAdd Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L272 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: WorkbookUpdate Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L324 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: WorkbookUpdate Location: Microsoft.Insights/stable/2021-08-01/workbooks_API.json#L324 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/applicationinsights/resource-manager/readme.md tag: specification/applicationinsights/resource-manager/readme.md#tag-package-2022-02-01 |
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. In reply to: 1032845508 In reply to: 1032845508 |
Swagger Generation Artifacts
|
|
NewApiVersionRequired reason: In reply to: 1032848126 In reply to: 1032848126 |
|
Hi @vutran01, Your PR has some issues. Please fix the CI sequentially by following the order of
In reply to: 1032848255 In reply to: 1032848255 |
This was referenced Feb 8, 2022
akning-ms
added
the
Approved-BreakingChange
|
@ArcturusZhang to help check why GO SDK T1 generation failure |
@vutran01 @akning-ms i don't get this. is this implying that EVERY "description" in the whole resource type has to say "application insights" even though a lot of the resource types have nothing to do with application insights? or was the suggestion here to just fix the 3 workbooks, templates, and private workbooks resource types that we own? we don't want the docs to say application insights when these resource types have nothing to do with application insights. |
|
Command 'run
In' is not supported by Azure Pipelines.
See additional documentation. In reply to: 1065584777 |
|
Command 'run
In' is not supported by Azure Pipelines.
See additional documentation. In reply to: 1065584970 |
|
Command 'run
In' is not supported by Azure Pipelines.
See additional documentation. In reply to: 1065585061 |
|
Command 'run
In' is not supported by Azure Pipelines.
See additional documentation. In reply to: 1065585166 In reply to: 1065585166 |
It is due to a limitation for Linter tool which same parameter name has different description, it cause Linter exception and block linter validation. We are improving it in next version. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ArcturusZhang
approved these changes
Mar 14, 2022
This was referenced Mar 14, 2022
[ReleasePR applicationinsights] [Go]Add batch tag 22/03/17
Azure/azure-resource-manager-schemas#1987
Closed
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
* set default tag to package-2021-03-only * new default tag and add only workbooks to release * update package tag with same RP as last package * update tag name * Update readme.python.md * change definition name * remove operations * fix missingtypeobject in workbooks * fix up model validation errors * setup initial repo * add missing canfetchcontent * change kind to only support shared * name needs to be different * fix invalide format examples * enum should not change till a new apiversion * make new param last * change name back to kind * fix up descriptions and examples * fix up examples * ran prettier * update description to remove appinsights * restore back text * restore description * restore Co-authored-by: msyyc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.