Update the label property of request body of find target resource api #17917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be a map with the key of "label".
Right now the request body is defined as:
{
"key":"value"
}
But it should be changed to:
{
"labels":{
"key":"value"
}
}
|
Hi, @peter-li-ms Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The required parameter 'labels' was removed in the new version. Old: Microsoft.ExtendedLocation/preview/2021-08-31-preview/customlocations.json#L423:11 |
|
The required parameter 'parameters' was added in the new version. New: Microsoft.ExtendedLocation/preview/2021-08-31-preview/customlocations.json#L423:11 |
|
The new version removes the 'additionalProperties' element. New: Microsoft.ExtendedLocation/preview/2021-08-31-preview/customlocations.json#L880:5 Old: Microsoft.ExtendedLocation/preview/2021-08-31-preview/customlocations.json#L880:5 |
️⚠️LintDiff: 0 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
- Linted configuring files (Based on target branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
| Rule | Message |
|---|---|
|
The delete operation is defined without a 200 or 204 error response implementation,please add it.' Location: Microsoft.ExtendedLocation/preview/2021-08-31-preview/customlocations.json#L280 |
|
Missing identifier id in array item property Location: Microsoft.ExtendedLocation/preview/2021-08-31-preview/customlocations.json#L784 |
|
Missing identifier id in array item property Location: Microsoft.ExtendedLocation/preview/2021-08-31-preview/customlocations.json#L986 |
| The child tracked resource, 'resourceSyncRules' with immediate parent 'customLocation', must have a list by immediate parent operation. Location: Microsoft.ExtendedLocation/preview/2021-08-31-preview/customlocations.json#L1128 |
|
| Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.ExtendedLocation/preview/2021-08-31-preview/customlocations.json#L932 |
|
| The resource 'EnabledResourceType' does not have get operation, please add it. Location: Microsoft.ExtendedLocation/preview/2021-08-31-preview/customlocations.json#L751 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Custom Location Location: Microsoft.ExtendedLocation/preview/2021-08-31-preview/customlocations.json#L395 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Custom Location Location: Microsoft.ExtendedLocation/preview/2021-08-31-preview/customlocations.json#L542 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
Hi @peter-li-ms, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
Hi @peter-li-ms, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
This was referenced Feb 20, 2022
JeffreyRichter
added
the
Approved-BreakingChange
chunyu3
approved these changes
Feb 24, 2022
This was referenced Feb 24, 2022
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
Mar 7, 2022
…Azure#17917) * Update the label property of request body of find target resource api It should be a map with the key of "label". Right now the request body is defined as: { "key":"value" } But it should be changed to: { "labels":{ "key":"value" } } * Update a description * Fix validation check of example json file for find target resource group api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Already deployed, this is a fix.
Feb-25-2022
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.