Add xms-ids for peering #17964

LinglingTong · 2022-02-23T18:38:33Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify

About this Change

APIs will need to start indicating item uniqueness in arrays. By default, uniqueness is the string property called "id" of items in an array. When that property does not exist, the x-ms-identifiers extension property must be used to specify the identifying property(s) or lack thereof. This pull request is my best guess effort to ease resource providers into the new requirement before it becomes enforced. Compliance and accuracy will need to be owned and maintained by the resource provider going forward.

See https://github.com/Azure/autorest/tree/main/docs/extensions#x-ms-identifiers.

You can also make changes after this PR is checked in. At this point, this annotation is only used by Change Analysis for change computation, so making changes afterwards shouldn’t be a breaking change.

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-02-23T18:38:37Z

Hi, @LinglingTong Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2022-02-23T18:38:38Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

Compared Swaggers (Based on Oad v0.9.3)
- current:stable/2021-06-01/peering.json compared with base:stable/2021-06-01/peering.json

️⚠️LintDiff: 0 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
- peering/resource-manager/readme.md tag:package-2021-06-01
Linted configuring files (Based on target branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
- peering/resource-manager/readme.md tag:package-2021-06-01

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'PeerAsns_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L301
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'PeerAsns_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L342
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'RegisteredAsns_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L557
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'RegisteredAsns_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L612
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'RegisteredPrefixes_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L792
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'RegisteredPrefixes_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L847
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'Peerings_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L1027
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'Peerings_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L1075
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'Peerings_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L1192
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'ConnectionMonitorTests_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L1424
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'ConnectionMonitorTests_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L1479
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'Prefixes_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L1744
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'Prefixes_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L1806
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'PeeringServices_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L2032
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'PeeringServices_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L2080
`❌` R4009 - RequiredReadOnlySystemData	The response of operation:'PeeringServices_Update' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L2191
⚠️ R2066 - PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'lookingglass' in:'LookingGlass_Invoke'. Consider updating the operationId Location: Microsoft.Peering/stable/2021-06-01/peering.json#L189
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isPrimaryRegion Location: Microsoft.Peering/stable/2021-06-01/peering.json#L2421
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: useForPeeringService Location: Microsoft.Peering/stable/2021-06-01/peering.json#L2613
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: useForPeeringService Location: Microsoft.Peering/stable/2021-06-01/peering.json#L2688
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isDataAction Location: Microsoft.Peering/stable/2021-06-01/peering.json#L2934
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: isTestSuccessful Location: Microsoft.Peering/stable/2021-06-01/peering.json#L3639
⚠️ R4014 - AllResourcesMustHaveGetOperation	The resource 'CdnPeeringPrefix' does not have get operation, please add it. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L2386
⚠️ R4014 - AllResourcesMustHaveGetOperation	The resource 'PeeringLocation' does not have get operation, please add it. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L3192
⚠️ R4014 - AllResourcesMustHaveGetOperation	The resource 'PeeringServiceCountry' does not have get operation, please add it. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L3703
⚠️ R4014 - AllResourcesMustHaveGetOperation	The resource 'PeeringServiceLocation' does not have get operation, please add it. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L3730
⚠️ R4014 - AllResourcesMustHaveGetOperation	The resource 'PeeringServiceProvider' does not have get operation, please add it. Location: Microsoft.Peering/stable/2021-06-01/peering.json#L3923

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

peering/resource-manager/readme.md#package-2021-06-01

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-02-23T18:38:38Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-go-track2 - armpeering - 0.3.1
❌azure-sdk-for-python-track2 - track2_azure-mgmt-peering - 1.0.0

️✔️azure-sdk-for-go - peering/mgmt/2021-06-01/peering - v61.6.0
️✔️azure-sdk-for-go - peering/mgmt/2021-01-01/peering - v61.6.0
️✔️azure-sdk-for-go - peering/mgmt/2020-10-01/peering - v61.6.0
️✔️azure-sdk-for-go - peering/mgmt/2020-04-01/peering - v61.6.0
️✔️azure-sdk-for-go - preview/peering/mgmt/2020-01-01-preview/peering - v61.6.0
️✔️azure-sdk-for-go - preview/peering/mgmt/2019-09-01-preview/peering - v61.6.0
️✔️azure-sdk-for-go - preview/peering/mgmt/2019-08-01-preview/peering - v61.6.0

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 3c5def5. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.3.1 -> 8.5.3
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.3>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-peering [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation PeeringServicesOperations.initialize_connection_monitor
info	[Changelog]   - Added operation PrefixesOperations.create_or_update
info	[Changelog]   - Added operation PrefixesOperations.delete
info	[Changelog]   - Added operation PrefixesOperations.get
info	[Changelog]   - Added operation group CdnPeeringPrefixesOperations
info	[Changelog]   - Added operation group ConnectionMonitorTestsOperations
info	[Changelog]   - Added operation group LookingGlassOperations
info	[Changelog]   - Added operation group PeeringServiceCountriesOperations
info	[Changelog]   - Added operation group ReceivedRoutesOperations
info	[Changelog]   - Added operation group RegisteredAsnsOperations
info	[Changelog]   - Added operation group RegisteredPrefixesOperations
info	[Changelog]   - Model DirectConnection has a new parameter error_message
info	[Changelog]   - Model DirectConnection has a new parameter microsoft_tracking_id
info	[Changelog]   - Model ErrorResponse has a new parameter error
info	[Changelog]   - Model ExchangeConnection has a new parameter error_message
info	[Changelog]   - Model Operation has a new parameter service_specification
info	[Changelog]   - Model PeerAsn has a new parameter error_message
info	[Changelog]   - Model PeerAsn has a new parameter peer_contact_detail
info	[Changelog]   - Model PeeringService has a new parameter log_analytics_workspace_properties
info	[Changelog]   - Model PeeringService has a new parameter provider_backup_peering_location
info	[Changelog]   - Model PeeringService has a new parameter provider_primary_peering_location
info	[Changelog]   - Model PeeringService has a new parameter sku
info	[Changelog]   - Model PeeringServicePrefix has a new parameter error_message
info	[Changelog]   - Model PeeringServicePrefix has a new parameter events
info	[Changelog]   - Model PeeringServicePrefix has a new parameter peering_service_prefix_key
info	[Changelog]   - Model PeeringServiceProvider has a new parameter peering_locations
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model ErrorResponse no longer has parameter code
info	[Changelog]   - Model ErrorResponse no longer has parameter message
info	[Changelog]   - Model PeerAsn no longer has parameter peer_contact_info
info	[Changelog]   - Operation LegacyPeeringsOperations.list has a new signature
info	[Changelog]   - Operation PeeringServiceLocationsOperations.list has a new signature
info	[Changelog]   - Operation PrefixesOperations.list_by_peering_service has a new signature
info	[Changelog]   - Removed operation group PeeringServicePrefixesOperations

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 3c5def5. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] 2022-03-07 00:58:36 INFO [VERSION][Found] current version "com.azure.resourcemanager:azure-resourcemanager-peering;1.0.0-beta.1;1.0.0-beta.2"
cmderr	[generate.py] 2022-03-07 00:58:36 INFO [VERSION][Not Found] cannot find stable version, current version "1.0.0-beta.2"
cmderr	[generate.py] 2022-03-07 00:58:36 INFO autorest --version=3.6.6 --use=@autorest/[email protected] --java --java.azure-libraries-for-java-folder=/home/vsts/work/1/s/azure-sdk-for-java --java.output-folder=/home/vsts/work/1/s/azure-sdk-for-java/sdk/peering/azure-resourcemanager-peering --java.namespace=com.azure.resourcemanager.peering   --pipeline.modelerfour.additional-checks=false --pipeline.modelerfour.lenient-model-deduplication=true --azure-arm --verbose --sdk-integration --generate-samples --fluent=lite --java.fluent=lite --java.license-header=MICROSOFT_MIT_SMALL  ../azure-rest-api-specs/specification/peering/resource-manager/readme.md
cmderr	[generate.py] 2022-03-07 00:59:19 INFO [CI][Skip] ci.yml already has module azure-resourcemanager-peering
cmderr	[generate.py] 2022-03-07 00:59:19 INFO [POM][Process] dealing with pom.xml
cmderr	[generate.py] 2022-03-07 00:59:19 INFO [POM][Skip] pom already has module azure-resourcemanager-peering
cmderr	[generate.py] 2022-03-07 00:59:19 INFO [POM][Success] Write to pom.xml
cmderr	[generate.py] 2022-03-07 00:59:19 INFO [POM][Process] dealing with root pom
cmderr	[generate.py] 2022-03-07 00:59:19 INFO [POM][Skip] pom already has module sdk/peering
cmderr	[generate.py] 2022-03-07 00:59:19 INFO [POM][Success] Write to root pom

️✔️azure-resourcemanager-peering [View full logs] [Release SDK Changes]

cmderr	[Inst] 2022-03-07 01:00:28 DEBUG Got artifact_id: azure-resourcemanager-peering
cmderr	[Inst] 2022-03-07 01:00:28 DEBUG Got artifact: pom.xml
cmderr	[Inst] 2022-03-07 01:00:28 DEBUG Got artifact: azure-resourcemanager-peering-1.0.0-beta.2.jar
cmderr	[Inst] 2022-03-07 01:00:28 DEBUG Match jar package: azure-resourcemanager-peering-1.0.0-beta.2.jar
cmderr	[Inst] 2022-03-07 01:00:28 DEBUG output: {"full": "```sh\ncurl -L \"https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/17964/azure-sdk-for-java/azure-resourcemanager-peering/azure-resourcemanager-peering-1.0.0-beta.2.jar\" -o azure-resourcemanager-peering-1.0.0-beta.2.jar\nmvn install:install-file -DgroupId=com.azure.resourcemanager -DartifactId=azure-resourcemanager-peering -Dversion=1.0.0-beta.0 -Dfile=azure-resourcemanager-peering-1.0.0-beta.2.jar -Dpackaging=jar -DgeneratePom=true
```"}

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 3c5def5. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️peering/mgmt/2022-01-01/peering [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
info	[Changelog]
```
️✔️peering/mgmt/2021-06-01/peering [View full logs]
```
info	[Changelog] This is a new package
info	[Changelog]
```
️✔️peering/mgmt/2021-01-01/peering [View full logs]
```
info	[Changelog] This is a new package
info	[Changelog]
```

️✔️peering/mgmt/2020-10-01/peering [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️peering/mgmt/2020-04-01/peering [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/peering/mgmt/2020-01-01-preview/peering [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/peering/mgmt/2019-09-01-preview/peering [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/peering/mgmt/2019-08-01-preview/peering [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 3c5def5. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armpeering [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `PeeringLocationsDirectPeeringTypeEdgeZoneForOperators`
info	[Changelog] - New const `DirectPeeringTypeEdgeZoneForOperators`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 2 additive change(s).

️❌ azure-sdk-for-net failed [Detail]

❌Failed [Logs]Release - Generate from 3c5def5. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/peering/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

❌Microsoft.Azure.Management.Peering [View full logs] [Release SDK Changes]

cmdout	[msbuild]      3>/home/vsts/work/1/s/azure-sdk-for-net/sdk/peering/Microsoft.Azure.Management.Peering/tests/PeeringTests.cs(827,17): error CS0200: Property or indexer 'PeerAsn.ValidationState' cannot be assigned to -- it is read only [/home/vsts/work/1/s/azure-sdk-for-net/sdk/peering/Microsoft.Azure.Management.Peering/tests/Microsoft.Azure.Management.Peering.Tests.csproj]
cmdout	[msbuild]          /home/vsts/work/1/s/azure-sdk-for-net/sdk/peering/Microsoft.Azure.Management.Peering/tests/PeeringTests.cs(827,17): error CS0200: Property or indexer 'PeerAsn.ValidationState' cannot be assigned to -- it is read only [/home/vsts/work/1/s/azure-sdk-for-net/sdk/peering/Microsoft.Azure.Management.Peering/tests/Microsoft.Azure.Management.Peering.Tests.csproj]
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: dotnet

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 3c5def5. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  [email protected]: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh]  @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] notice created a lockfile as package-lock.json. You should commit this file.
cmderr	[automation_init.sh]  @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-peering [View full logs] [Release SDK Changes]

azure-arm-peering-2.1.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Enum KnownDirectPeeringType has a new value EdgeZoneForOperators
info	[Changelog]   - Enum KnownPeeringLocationsDirectPeeringType has a new value EdgeZoneForOperators
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 3c5def5. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️peering [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-02-23T18:38:39Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

changlong-liu · 2022-03-07T00:51:23Z

merging since checked that Python breaking change is not from this PR.

add xms-ids for peering

6f71b10

openapi-assignment-bot bot assigned changlong-liu Feb 23, 2022

openapi-sdkautomation bot mentioned this pull request Feb 23, 2022

[AutoPR track2_azure-mgmt-peering] Add xms-ids for peering AzureSDKAutomation/azure-sdk-for-python#9289

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Feb 23, 2022

changlong-liu approved these changes Mar 7, 2022

View reviewed changes

changlong-liu merged commit 3c5def5 into Azure:main Mar 7, 2022

FredericHeem pushed a commit to grucloud/azure-rest-api-specs that referenced this pull request Mar 7, 2022

add xms-ids for peering (Azure#17964)

4f85fc0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add xms-ids for peering #17964

Add xms-ids for peering #17964

LinglingTong commented Feb 23, 2022

openapi-workflow-bot bot commented Feb 23, 2022

openapi-pipeline-app bot commented Feb 23, 2022 •

edited

Loading

openapi-pipeline-app bot commented Feb 23, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Feb 23, 2022

changlong-liu commented Mar 7, 2022

Add xms-ids for peering #17964

Add xms-ids for peering #17964

Conversation

LinglingTong commented Feb 23, 2022

Changelog

About this Change

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Feb 23, 2022

openapi-pipeline-app bot commented Feb 23, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Feb 23, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Feb 23, 2022

changlong-liu commented Mar 7, 2022

openapi-pipeline-app bot commented Feb 23, 2022 •

edited

Loading

openapi-pipeline-app bot commented Feb 23, 2022 •

edited

Loading