-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated billing information. #18092
Updated billing information. #18092
Conversation
Hi, @daniel-rocha Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
Rule | Message |
---|---|
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was '408' removed or renamed? New: Search/preview/1.0/search.json#L52:3 Old: Search/preview/1.0/search.json#L52:3 |
️️✔️
LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️⌛
CredScan pending [Detail]
️️✔️
SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger pipeline restarted successfully, please wait for status update in this comment. |
Hi @daniel-rocha, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi @daniel-rocha, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Hello reviewers, This is not a true breaking change. What happened here is that examples GetSearchAddressReverse (and Cross Street) and GetSearchPolygon have an example of an HTTP 408 response (time out). oav validate-examples then parses these files, looks up the definition in search.json Swagger and cannot find it, thus failing model validation. This did not happen before, started happening recently, probaby due to some tool update. The reason for the failure is that oav does not seem to support double nesting: search.json $ref pointing to Azure Maps Common.json pointing to Azure Core common.json. What I did was simply move the definition from Azure Maps Common.json into search json, thus removing one layer of nesting, and it worked fine. Probably requires updates to oav to correct it. This is not a breaking change because the definition was only moved from azure maps common to search.json - it was not changed at all. Thanks! |
BreakingChange seems to be a false positive? |
I've been checking with swagger team on the LintDiff problem. But we should be able to merge bypassing it. |
Hi @weidongxu-microsoft I seem to have figured out a way to get it to pass. I will update this PR and hopefully lintdiff will fall in line. Here is what the problem seems to be:
With the lintdiff tool 0.0.26 in the pipeline, this causes a crash, presumably because it cannot find the swagger with the version. I will update the Search readme as I did with Render. This is very new behavior it seems, as many of these Swaggers were updated last week with no problem. The breaking change on the other hand is indeed a false positive. |
False positive on breaking changes |
* Updated billing information. * Fixed schema pointer to correct model validation error * Fixed prettier errors * Standardized 408 definitions. * Fix tag to pass lintdiff * Fixed all preview tags Co-authored-by: Daniel Rocha <[email protected]>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.