[Hub Generated] Review request for Microsoft.DataFactory to add version stable/2018-06-01 #18413

Khalil-Ammar · 2022-03-25T20:13:15Z

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-03-25T20:13:17Z

Hi, @Khalil-Ammar Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-workflow-bot · 2022-03-25T20:13:18Z

[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks.

openapi-pipeline-app · 2022-03-25T20:13:18Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.3)
- current:2018-06-01/entityTypes/Pipeline.json compared with base:2018-06-01/entityTypes/Pipeline.json

Rule	Message
`❌` 1045 - AddedOptionalProperty	The new version has a new optional property 'policy' that was not found in the old version. New: stable/2018-06-01/entityTypes/Pipeline.json#L6040:7 Old: stable/2018-06-01/entityTypes/Pipeline.json#L6040:7

️⚠️LintDiff: 1 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
- datafactory/resource-manager/readme.md tag:package-2018-06
Linted configuring files (Based on target branch, openapi-validator v1.12.1 , classic-openapi-validator v1.2.2 )
- datafactory/resource-manager/readme.md tag:package-2018-06

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: secureInput Location: stable/2018-06-01/entityTypes/Pipeline.json#L6059

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L46
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L46
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L238
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L238
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5263
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5263
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6114
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6114
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6534
`❌` R4013 - IntegerTypeMustHaveFormat	The integer type does not have a format, please add it. Location: stable/2018-06-01/entityTypes/Pipeline.json#L6534
`❌` R4037 - MissingTypeObject	The schema 'ControlActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L197
`❌` R4037 - MissingTypeObject	The schema 'ControlActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L197
`❌` R4037 - MissingTypeObject	The schema 'ExecutionActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L207
`❌` R4037 - MissingTypeObject	The schema 'ExecutionActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L207
`❌` R4037 - MissingTypeObject	The schema 'CopyActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L1536
`❌` R4037 - MissingTypeObject	The schema 'CopyActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L1536
`❌` R4037 - MissingTypeObject	The schema 'CopyActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L1575
`❌` R4037 - MissingTypeObject	The schema 'CopyActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L1575
`❌` R4037 - MissingTypeObject	The schema 'HDInsightHiveActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5193
`❌` R4037 - MissingTypeObject	The schema 'HDInsightHiveActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5193
`❌` R4037 - MissingTypeObject	The schema 'HDInsightHiveActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5212
`❌` R4037 - MissingTypeObject	The schema 'HDInsightHiveActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5212
`❌` R4037 - MissingTypeObject	The schema 'HDInsightPigActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5282
`❌` R4037 - MissingTypeObject	The schema 'HDInsightPigActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5282
`❌` R4037 - MissingTypeObject	The schema 'HDInsightPigActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5301
`❌` R4037 - MissingTypeObject	The schema 'HDInsightPigActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5301
`❌` R4037 - MissingTypeObject	The schema 'HDInsightMapReduceActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5340
`❌` R4037 - MissingTypeObject	The schema 'HDInsightMapReduceActivity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5340
`❌` R4037 - MissingTypeObject	The schema 'HDInsightMapReduceActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5359
`❌` R4037 - MissingTypeObject	The schema 'HDInsightMapReduceActivityTypeProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: stable/2018-06-01/entityTypes/Pipeline.json#L5359

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

datafactory/resource-manager/readme.md#package-2018-06

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-03-25T20:13:19Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-go-track2 - armdatafactory - 0.4.0

️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-datafactory - 2.3.0
❌azure-sdk-for-go - datafactory/mgmt/2018-06-01/datafactory - v63.0.0

+	Function `SQLServerStoredProcedureActivityTypeProperties.MarshalJSON` has been removed
+	Type of `SQLServerStoredProcedureActivityTypeProperties.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`

❌azure-sdk-for-go - preview/datafactory/mgmt/2017-09-01-preview/datafactory - v63.0.0

+	Const `Initial` has been removed
+	Const `Limited` has been removed
+	Const `ManagedIntegrationRuntimeNodeStatusAvailable` has been removed
+	Const `ManagedIntegrationRuntimeNodeStatusRecycling` has been removed
+	Const `ManagedIntegrationRuntimeNodeStatusStarting` has been removed
+	Const `ManagedIntegrationRuntimeNodeStatusUnavailable` has been removed
+	Const `NeedRegistration` has been removed
+	Const `Offline` has been removed
+	Const `Online` type has been changed from `IntegrationRuntimeState` to `DynamicsDeploymentType`
+	Const `Started` type has been changed from `IntegrationRuntimeState` to `TriggerRuntimeState`
+	Const `Starting` type has been changed from `IntegrationRuntimeState` to `ManagedIntegrationRuntimeNodeStatus`
+	Const `Stopped` type has been changed from `IntegrationRuntimeState` to `TriggerRuntimeState`
+	Const `Stopping` has been removed
+	Const `TriggerRuntimeStateDisabled` has been removed
+	Const `TriggerRuntimeStateStarted` has been removed
+	Const `TriggerRuntimeStateStopped` has been removed
+	Type of `AzureSearchIndexSink.WriteBehavior` has been changed from `interface{}` to `AzureSearchIndexWriteBehaviorType`
+	Type of `CassandraSource.ConsistencyLevel` has been changed from `interface{}` to `CassandraSourceReadConsistencyLevels`
+	Type of `DatasetDeflateCompression.Level` has been changed from `interface{}` to `DatasetCompressionLevel`
+	Type of `DatasetGZipCompression.Level` has been changed from `interface{}` to `DatasetCompressionLevel`
+	Type of `DatasetZipDeflateCompression.Level` has been changed from `interface{}` to `DatasetCompressionLevel`
+	Type of `DynamicsLinkedServiceTypeProperties.AuthenticationType` has been changed from `interface{}` to `DynamicsAuthenticationType`
+	Type of `DynamicsLinkedServiceTypeProperties.DeploymentType` has been changed from `interface{}` to `DynamicsDeploymentType`
+	Type of `DynamicsSink.WriteBehavior` has been changed from `interface{}` to `*string`
+	Type of `PolybaseSettings.RejectType` has been changed from `interface{}` to `PolybaseSettingsRejectType`
+	Type of `SalesforceSink.WriteBehavior` has been changed from `interface{}` to `SalesforceSinkWriteBehavior`
+	Type of `SalesforceSource.ReadBehavior` has been changed from `interface{}` to `SalesforceSourceReadBehavior`
+	Type of `SapCloudForCustomerSink.WriteBehavior` has been changed from `interface{}` to `SapCloudForCustomerSinkWriteBehavior`
+	Type of `StoredProcedureParameter.Type` has been changed from `interface{}` to `StoredProcedureParameterType`

️️✔️ azure-sdk-for-net succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from f4d936a. SDK Automation 14.0.0

warn	Skip initScript due to not configured
command	sudo apt-get install -y dotnet-sdk-6.0
command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/datafactory/resource-manager/readme.md
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied
cmderr	[Autorest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.DataFactory [View full logs] [Release SDK Changes]
- Microsoft.Azure.Management.DataFactory.5.4.0.nupkg
- Microsoft.Azure.Management.DataFactory.5.4.0.symbols.nupkg

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from f4d936a. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] notice
cmderr	[automation_generate.sh] npm notice New patch version of npm available! 8.5.0 -> 8.5.5
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.5.5>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-datafactory [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model ExecutePipelineActivity has a new parameter policy
info	[Changelog]   - Model WebActivity has a new parameter disable_cert_validation

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from f4d936a. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] [ForkJoinPool-1-worker-3] INFO com.azure.core.test.implementation.TestingHelpers - Environment variable 'AZURE_TEST_MODE' has not been set yet. Using 'Playback' mode.

️✔️azure-resourcemanager-datafactory [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from f4d936a. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️datafactory/mgmt/2018-06-01/datafactory [View full logs] [Release SDK Changes]

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `SQLServerStoredProcedureActivityTypeProperties.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
info	[Changelog] - Function `SQLServerStoredProcedureActivityTypeProperties.MarshalJSON` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New function `ExecutePipelineActivityPolicy.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*ExecutePipelineActivityPolicy.UnmarshalJSON([]byte) error`
info	[Changelog] - New struct `ExecutePipelineActivityPolicy`
info	[Changelog] - New field `Policy` in struct `ExecutePipelineActivity`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 5 additive change(s).

️✔️preview/datafactory/mgmt/2017-09-01-preview/datafactory [View full logs]

Only show 60 items here, please refer to log for details.

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `ALL`
info	[Changelog] - New const `Optimal`
info	[Changelog] - New const `Date`
info	[Changelog] - New const `Office365`
info	[Changelog] - New const `IntegrationRuntimeStateStarted`
info	[Changelog] - New const `Int`
info	[Changelog] - New const `IntegrationRuntimeStateStopping`
info	[Changelog] - New const `LOCALONE`
info	[Changelog] - New const `EACHQUORUM`
info	[Changelog] - New const `IntegrationRuntimeStateInitial`
info	[Changelog] - New const `LOCALQUORUM`
info	[Changelog] - New const `QueryAll`
info	[Changelog] - New const `SapCloudForCustomerSinkWriteBehaviorInsert`
info	[Changelog] - New const `Upload`
info	[Changelog] - New const `Unavailable`
info	[Changelog] - New const `Available`
info	[Changelog] - New const `IntegrationRuntimeStateNeedRegistration`
info	[Changelog] - New const `IntegrationRuntimeStateStopped`
info	[Changelog] - New const `Percentage`
info	[Changelog] - New const `OnPremisesWithIfd`
info	[Changelog] - New const `String`
info	[Changelog] - New const `SapCloudForCustomerSinkWriteBehaviorUpdate`
info	[Changelog] - New const `Fastest`
info	[Changelog] - New const `Query`
info	[Changelog] - New const `ONE`
info	[Changelog] - New const `Decimal`
info	[Changelog] - New const `Upsert`
info	[Changelog] - New const `IntegrationRuntimeStateOnline`
info	[Changelog] - New const `Merge`
info	[Changelog] - New const `Ifd`
info	[Changelog] - New const `GUID`
info	[Changelog] - New const `Insert`
info	[Changelog] - New const `IntegrationRuntimeStateStarting`
info	[Changelog] - New const `QUORUM`
info	[Changelog] - New const `SERIAL`
info	[Changelog] - New const `Disabled`
info	[Changelog] - New const `IntegrationRuntimeStateOffline`
info	[Changelog] - New const `TWO`
info	[Changelog] - New const `Recycling`
info	[Changelog] - New const `LOCALSERIAL`
info	[Changelog] - New const `THREE`
info	[Changelog] - New const `Boolean`
info	[Changelog] - New const `Int64`
info	[Changelog] - New const `IntegrationRuntimeStateLimited`
info	[Changelog] - New const `Value`
info	[Changelog] - New function `PossibleDynamicsDeploymentTypeValues() []DynamicsDeploymentType`
info	[Changelog] - New function `PossibleSapCloudForCustomerSinkWriteBehaviorValues() []SapCloudForCustomerSinkWriteBehavior`
info	[Changelog] - New function `PossibleSalesforceSinkWriteBehaviorValues() []SalesforceSinkWriteBehavior`
info	[Changelog] - New function `PossibleSalesforceSourceReadBehaviorValues() []SalesforceSourceReadBehavior`
info	[Changelog] - New function `PossiblePolybaseSettingsRejectTypeValues() []PolybaseSettingsRejectType`
info	[Changelog] - New function `PossibleDatasetCompressionLevelValues() []DatasetCompressionLevel`
info	[Changelog] - New function `PossibleDynamicsAuthenticationTypeValues() []DynamicsAuthenticationType`
info	[Changelog] - New function `PossibleAzureSearchIndexWriteBehaviorTypeValues() []AzureSearchIndexWriteBehaviorType`
info	[Changelog] - New function `PossibleCassandraSourceReadConsistencyLevelsValues() []CassandraSourceReadConsistencyLevels`
info	[Changelog] - New function `PossibleStoredProcedureParameterTypeValues() []StoredProcedureParameterType`
info	[Changelog] - New field `DisableCertValidation` in struct `WebActivityTypeProperties`
info	[Changelog]
info	[Changelog] Total 28 breaking change(s), 56 additive change(s).

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from f4d936a. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armdatafactory [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Type of `SQLServerStoredProcedureActivityTypeProperties.StoredProcedureParameters` has been changed from `map[string]*StoredProcedureParameter` to `interface{}`
info	[Changelog] - Function `SQLServerStoredProcedureActivityTypeProperties.MarshalJSON` has been removed
info	[Changelog] - Struct `TypeConversionSettings` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New function `ExecutePipelineActivityPolicy.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*ExecutePipelineActivityPolicy.UnmarshalJSON([]byte) error`
info	[Changelog] - New struct `ExecutePipelineActivityPolicy`
info	[Changelog] - New field `Policy` in struct `ExecutePipelineActivity`
info	[Changelog]
info	[Changelog] Total 4 breaking change(s), 5 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from f4d936a. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] WARN deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] npm WARN deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-datafactory [View full logs] [Release SDK Changes]

azure-arm-datafactory-10.3.0.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added Interface ExecutePipelineActivityPolicy
info	[Changelog]   - Added Type Alias CredentialReferenceType
info	[Changelog]   - Added Type Alias DataFlowReferenceType
info	[Changelog]   - Added Type Alias ManagedVirtualNetworkReferenceType
info	[Changelog]   - Added Type Alias TriggerReferenceType
info	[Changelog]   - Type Alias ExecutePipelineActivity has a new parameter policy
info	[Changelog]   - Type Alias SqlServerStoredProcedureActivity has a new parameter storedProcedureParameters
info	[Changelog]   - Type Alias WebActivity has a new parameter disableCertValidation
info	[Changelog]   - Added Enum KnownCredentialReferenceType
info	[Changelog]   - Added Enum KnownDataFlowReferenceType
info	[Changelog]   - Added Enum KnownManagedVirtualNetworkReferenceType
info	[Changelog]   - Added Enum KnownTriggerReferenceType
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from f4d936a. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

️✔️datafactory [View full logs] [Release Schema Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-03-25T20:15:49Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

openapi-workflow-bot · 2022-03-26T10:06:29Z

Hi @Khalil-Ammar, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.

Khalil-Ammar · 2022-03-29T21:51:11Z

ADF does not consider adding optional properties to stable version as a breaking change. customers will not be impacted negatively by this change. @JeffreyRichter

JeffreyRichter · 2022-03-29T22:00:55Z

Azure's policy is that adding new properties to a service requires a new api-version. ADF is branded Azure and should therefore follow Azure's versioning policies as all other Azure-branded services do and this provides consistent behavior to Azure customers.

leni-msft · 2022-03-31T00:44:38Z

@Khalil-Ammar pls don't commit package-lock.json

Khalil-Ammar · 2022-03-31T01:14:23Z

@leni-msft fixed

…on stable/2018-06-01 (Azure#18413) * add SecureInput policy to ExecutePipelineActivity * restore package-lock.json from main

add SecureInput policy to ExecutePipelineActivity

0a6cc0b

openapi-pipeline-app bot added the NewApiVersionRequired label Mar 25, 2022

openapi-pipeline-app bot added the CI-BreakingChange-Go-V2 label Mar 25, 2022

leni-msft added the BreakingChangeReviewRequired label Mar 26, 2022

Khalil-Ammar marked this pull request as ready for review March 29, 2022 21:33

Khalil-Ammar requested review from Frey-Wang, zhangyd2015 and davidzhaoyue as code owners March 29, 2022 21:33

openapi-assignment-bot bot assigned leni-msft Mar 29, 2022

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Mar 30, 2022

restore package-lock.json from main

abe8253

leni-msft approved these changes Mar 31, 2022

View reviewed changes

leni-msft merged commit f4d936a into Azure:main Mar 31, 2022

Jingshu923 mentioned this pull request Apr 11, 2022

[DataFactory]Added new features into 6.0.0 Azure/azure-sdk-for-net#28135

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Hub Generated] Review request for Microsoft.DataFactory to add version stable/2018-06-01 #18413

[Hub Generated] Review request for Microsoft.DataFactory to add version stable/2018-06-01 #18413

Khalil-Ammar commented Mar 25, 2022 •

edited

Loading

openapi-workflow-bot bot commented Mar 25, 2022

openapi-workflow-bot bot commented Mar 25, 2022

openapi-pipeline-app bot commented Mar 25, 2022 •

edited

Loading

openapi-pipeline-app bot commented Mar 25, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented Mar 25, 2022

openapi-workflow-bot bot commented Mar 26, 2022

Khalil-Ammar commented Mar 29, 2022 •

edited

Loading

JeffreyRichter commented Mar 29, 2022

leni-msft commented Mar 31, 2022

Khalil-Ammar commented Mar 31, 2022

[Hub Generated] Review request for Microsoft.DataFactory to add version stable/2018-06-01 #18413

[Hub Generated] Review request for Microsoft.DataFactory to add version stable/2018-06-01 #18413

Conversation

Khalil-Ammar commented Mar 25, 2022 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Mar 25, 2022

openapi-workflow-bot bot commented Mar 25, 2022

openapi-pipeline-app bot commented Mar 25, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Mar 25, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented Mar 25, 2022

openapi-workflow-bot bot commented Mar 26, 2022

Khalil-Ammar commented Mar 29, 2022 • edited Loading

JeffreyRichter commented Mar 29, 2022

leni-msft commented Mar 31, 2022

Khalil-Ammar commented Mar 31, 2022

Khalil-Ammar commented Mar 25, 2022 •

edited

Loading

openapi-pipeline-app bot commented Mar 25, 2022 •

edited

Loading

openapi-pipeline-app bot commented Mar 25, 2022 •

edited

Loading

Khalil-Ammar commented Mar 29, 2022 •

edited

Loading