Fix S360 items for FSPG swagger #18870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I 2021-06-01, 2021-06-01-preview, and 2021-06-15-privatepreview
… and 2021-06-01 APIs
|
Hi, @xunsun-commits Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The new version is adding a path that was not found in the old version. New: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/Databases.json#L37:5 |
|
The new version is adding a path that was not found in the old version. New: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/Databases.json#L191:5 |
| Rule | Message |
|---|---|
|
The new version has a new read-only property 'supportedHAMode' in response that was not found in the old version. New: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1287:7 Old: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1277:7 |
|
The new version has a new read-only property 'location' in response that was not found in the old version. New: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1048:7 Old: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1048:7 |
|
The new version has a new read-only property 'subscriptionId' in response that was not found in the old version. New: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1048:7 Old: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1048:7 |
️⚠️LintDiff: 0 Warnings warning [Detail]
- Linted configuring files (Based on source branch, openapi-validator v1.12.3 , classic-openapi-validator v1.2.4 )
- Linted configuring files (Based on target branch, openapi-validator v1.12.3 , classic-openapi-validator v1.2.4 )
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The schema 'DatabaseProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/Databases.json#L238 |
|
The schema 'Database' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/Databases.json#L251 |
|
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/preview/2021-06-01-preview/Databases.json#L288 |
|
The schema 'StorageEditionCapability' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1171 |
|
The schema 'CapabilityProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1286 |
|
The schema 'ServerProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1370 |
|
The schema 'Server' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1500 |
|
The schema 'ServerPropertiesForUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1524 |
|
The schema 'ServerForUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1576 |
|
The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1618 |
|
The schema 'Storage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1644 |
|
The schema 'Backup' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1654 |
|
The schema 'Network' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1688 |
|
The schema 'HighAvailability' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1724 |
|
The schema 'FirewallRuleProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1793 |
|
The schema 'FirewallRule' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1812 |
|
The schema 'ConfigurationProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1852 |
|
The schema 'Configuration' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1920 |
|
The schema 'OperationDisplay' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1957 |
|
The schema 'Operation' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1982 |
|
The schema 'NameAvailabilityRequest' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L2042 |
|
The schema 'NameAvailability' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L2058 |
|
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L2120 |
|
Missing identifier id in array item property Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1059 |
|
Missing identifier id in array item property Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1156 |
|
Missing identifier id in array item property Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1178 |
|
Missing identifier id in array item property Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1222 |
|
Missing identifier id in array item property Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1230 |
|
Missing identifier id in array item property Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1254 |
|
Missing identifier id in array item property Location: Microsoft.DBforPostgreSQL/stable/2021-06-01/postgresql.json#L1262 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/postgresql/resource-manager/readme.md tag: specification/postgresql/resource-manager/readme.md#tag-package-2020-01-01 |
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
|
NewApiVersionRequired reason: |
This was referenced Apr 29, 2022
[AutoPR armpostgresqlflexibleservers] Fix S360 items for FSPG swagger
azure-sdk/azure-sdk-for-go#672
Closed
Closed
This was referenced Apr 29, 2022
QingqingYuan2
approved these changes
May 3, 2022
|
Hi @xunsun-commits, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Thanks for providing details of the problems (the links to S360 items) and fixes. That really helped. |
mikekistler
added
the
Approved-BreakingChange
This was referenced May 13, 2022
Merged
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
May 13, 2022
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
* Changed FSPG RestartParameter.failoverMode from string to enum for API 2021-06-01, 2021-06-01-preview, and 2021-06-15-privatepreview * Change enum first letter to lower case * Change to upper case * Fix S360 bugs for swagger FSPG 2020-02-14-preview, 2021-06-01-preview and 2021-06-01 APIs * Fix S360 item by adding default value to backupRetentionDays and maintenanceWindow * Fix s360 bugs * Undo supportedIops change, will change in RP side * Fix NameAvailability and ConfigurationProperties s360 bugs * Fix s360 bug for CloudError * Undo CloudError fix * Fix string default value * Remove server.tags because TrackedResource already has tags * Add missing properties for VirtualNetworkSubnetUsageResult * Add supportedHAMode for CapabilityProperties * Add supportedHAMode into example * Copy Databases.json from 2021-06-01 to 2021-06-01-preview * Change Databases.json to version 2021-06-01-preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
The S360 items and commits for each:
https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=D8F05F92-68CE-4429-9DFE-80E55E0DA821
Add missing properties for VirtualNetworkSubnetUsageResult
https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=6D162090-A44C-4AC3-9DD0-914B9784FDC5
Add supportedHAMode for CapabilityProperties
Add supportedHAMode into example
https://portal.azure-devex-tools.com/amekpis/completeness/detail?errorId=A7EAE548-5E5E-4A0A-9E56-B45B062F5351
Copy Databases.json from 2021-06-01 to 2021-06-01-preview
Change Databases.json to version 2021-06-01-preview
Changelog
Add a changelog entry for this PR by answering the following questions:
What's the purpose of the update?
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
No deployment is needed as this is for s360 fix.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
2022 May.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
This PR only adds new properties and APIs complained by S360, so there should be no breaking change.
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.