Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mipatera 2022 06 01 batch management #18940

Merged
merged 8 commits into from
May 27, 2022
Merged

Conversation

paterasMSFT
Copy link
Contributor

@paterasMSFT paterasMSFT commented May 6, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? 2022-06-01
  3. When do you expect to publish the swagger? May 2022
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @paterasMSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 6, 2022

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    The following errors/warnings exist before current PR submission:
    Rule Message
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'applications' with immediate parent 'BatchAccount', must have a list by immediate parent operation.
    Location: Microsoft.Batch/stable/2022-06-01/BatchManagement.json#L3164
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'versions' with immediate parent 'Application', must have a list by immediate parent operation.
    Location: Microsoft.Batch/stable/2022-06-01/BatchManagement.json#L3198
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'certificates' with immediate parent 'BatchAccount', must have a list by immediate parent operation.
    Location: Microsoft.Batch/stable/2022-06-01/BatchManagement.json#L3661
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'detectors' with immediate parent 'BatchAccount', must have a list by immediate parent operation.
    Location: Microsoft.Batch/stable/2022-06-01/BatchManagement.json#L3759
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'privateLinkResources' with immediate parent 'BatchAccount', must have a list by immediate parent operation.
    Location: Microsoft.Batch/stable/2022-06-01/BatchManagement.json#L3785
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'privateEndpointConnections' with immediate parent 'BatchAccount', must have a list by immediate parent operation.
    Location: Microsoft.Batch/stable/2022-06-01/BatchManagement.json#L3829
    ⚠️ R3010 - TrackedResourceListByImmediateParent The child tracked resource, 'pools' with immediate parent 'BatchAccount', must have a list by immediate parent operation.
    Location: Microsoft.Batch/stable/2022-06-01/BatchManagement.json#L3978
    ️️✔️Avocado succeeded [Detail] [Expand]
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]
    There are no breaking changes.

    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
    Validation passes for SDKTrack2Validation

    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented May 6, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Breaking Changes Tracking

    ️✔️azure-sdk-for-go-track2 - armbatch - 1.1.0
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-batch - 16.1.0
    ️✔️azure-sdk-for-go - batch/mgmt/2022-01-01/batch - v65.0.0
    ️✔️azure-sdk-for-go - batch/mgmt/2021-06-01/batch - v65.0.0
    ️✔️azure-sdk-for-go - batch/mgmt/2021-01-01/batch - v65.0.0
    ️✔️azure-sdk-for-go - batch/mgmt/2020-09-01/batch - v65.0.0
    ️✔️azure-sdk-for-go - batch/mgmt/2020-05-01/batch - v65.0.0
    ️✔️azure-sdk-for-go - batch/mgmt/2020-03-01/batch - v65.0.0
    ️✔️azure-sdk-for-go - batch/mgmt/2019-08-01/batch - v65.0.0
    ️✔️azure-sdk-for-go - batch/mgmt/2019-04-01/batch - v65.0.0
    ️✔️azure-sdk-for-go - batch/mgmt/2018-12-01/batch - v65.0.0
    ️✔️azure-sdk-for-go - batch/mgmt/2017-09-01/batch - v65.0.0
    ️✔️azure-sdk-for-go - batch/mgmt/2017-05-01/batch - v65.0.0
    ️✔️azure-sdk-for-go - batch/mgmt/2017-01-01/batch - v65.0.0
    ️✔️azure-sdk-for-go - batch/mgmt/2015-12-01/batch - v65.0.0
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from 12d012d. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/batch/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] No usable version of the libssl was found
      cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
      cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
      warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 12d012d. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 8.5.5 -> 8.11.0
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.11.0>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-batch [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation PrivateEndpointConnectionOperations.begin_delete
      info	[Changelog]   - Model BatchAccount has a new parameter network_profile
      info	[Changelog]   - Model BatchAccount has a new parameter node_management_endpoint
      info	[Changelog]   - Model BatchAccountCreateParameters has a new parameter network_profile
      info	[Changelog]   - Model BatchAccountUpdateParameters has a new parameter network_profile
      info	[Changelog]   - Model BatchAccountUpdateParameters has a new parameter public_network_access
      info	[Changelog]   - Model PrivateEndpointConnection has a new parameter group_ids
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 12d012d. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
      cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
      cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
      cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
      cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
      cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
      cmderr	[generate.py] [ForkJoinPool-1-worker-3] INFO com.azure.core.test.implementation.TestingHelpers - Environment variable 'AZURE_TEST_MODE' has not been set yet. Using 'Playback' mode.
    • ️✔️azure-resourcemanager-batch [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 12d012d. SDK Automation 14.0.0
      command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️batch/mgmt/2022-01-01/batch [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️batch/mgmt/2021-06-01/batch [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️batch/mgmt/2021-01-01/batch [View full logs
      info	[Changelog] This is a new package
      info	[Changelog]
    • ️✔️batch/mgmt/2020-09-01/batch [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️batch/mgmt/2020-05-01/batch [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️batch/mgmt/2020-03-01/batch [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️batch/mgmt/2019-08-01/batch [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️batch/mgmt/2019-04-01/batch [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️batch/mgmt/2018-12-01/batch [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️batch/mgmt/2017-09-01/batch [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️batch/mgmt/2017-05-01/batch [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️batch/mgmt/2017-01-01/batch [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    • ️✔️batch/mgmt/2015-12-01/batch [View full logs
      info	[Changelog] ### Other Changes
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 12d012d. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armbatch [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New const `EndpointAccessDefaultActionDeny`
      info	[Changelog] - New const `EndpointAccessDefaultActionAllow`
      info	[Changelog] - New const `PrivateEndpointConnectionProvisioningStateCancelled`
      info	[Changelog] - New const `PrivateEndpointConnectionProvisioningStateCreating`
      info	[Changelog] - New const `PrivateEndpointConnectionProvisioningStateDeleting`
      info	[Changelog] - New function `PrivateEndpointConnectionProperties.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `EndpointAccessProfile.MarshalJSON() ([]byte, error)`
      info	[Changelog] - New function `PossibleEndpointAccessDefaultActionValues() []EndpointAccessDefaultAction`
      info	[Changelog] - New function `*PrivateEndpointConnectionClient.BeginDelete(context.Context, string, string, string, *PrivateEndpointConnectionClientBeginDeleteOptions) (*runtime.Poller[PrivateEndpointConnectionClientDeleteResponse], error)`
      info	[Changelog] - New struct `EndpointAccessProfile`
      info	[Changelog] - New struct `IPRule`
      info	[Changelog] - New struct `NetworkProfile`
      info	[Changelog] - New struct `PrivateEndpointConnectionClientBeginDeleteOptions`
      info	[Changelog] - New struct `PrivateEndpointConnectionClientDeleteResponse`
      info	[Changelog] - New field `NetworkProfile` in struct `AccountUpdateProperties`
      info	[Changelog] - New field `PublicNetworkAccess` in struct `AccountUpdateProperties`
      info	[Changelog] - New field `GroupIDs` in struct `PrivateEndpointConnectionProperties`
      info	[Changelog] - New field `NetworkProfile` in struct `AccountCreateProperties`
      info	[Changelog] - New field `NodeManagementEndpoint` in struct `AccountProperties`
      info	[Changelog] - New field `NetworkProfile` in struct `AccountProperties`
      info	[Changelog]
      info	[Changelog] Total 0 breaking change(s), 23 additive change(s).
    ️⚠️ azure-sdk-for-js warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 12d012d. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      cmderr	[automation_init.sh] deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
      cmderr	[automation_init.sh]  [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
      cmderr	[automation_init.sh]  deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
      cmderr	[automation_init.sh]  deprecated @azure/[email protected]: This version has been deprecated, please upgrade to the version tagged as latest
      cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-batch [View full logs]  [Release SDK Changes]
      info	[Changelog] **Features**
      info	[Changelog]
      info	[Changelog]   - Added operation PrivateEndpointConnectionOperations.beginDelete
      info	[Changelog]   - Added operation PrivateEndpointConnectionOperations.beginDeleteAndWait
      info	[Changelog]   - Added Interface EndpointAccessProfile
      info	[Changelog]   - Added Interface IPRule
      info	[Changelog]   - Added Interface NetworkProfile
      info	[Changelog]   - Added Interface PrivateEndpointConnectionDeleteHeaders
      info	[Changelog]   - Added Interface PrivateEndpointConnectionDeleteOptionalParams
      info	[Changelog]   - Added Type Alias EndpointAccessDefaultAction
      info	[Changelog]   - Added Type Alias PrivateEndpointConnectionDeleteResponse
      info	[Changelog]   - Interface BatchAccountCreateParameters has a new optional parameter networkProfile
      info	[Changelog]   - Interface BatchAccountUpdateParameters has a new optional parameter networkProfile
      info	[Changelog]   - Interface BatchAccountUpdateParameters has a new optional parameter publicNetworkAccess
      info	[Changelog]   - Type Alias BatchAccount has a new parameter nodeManagementEndpoint
      info	[Changelog]   - Type Alias BatchAccount has a new parameter networkProfile
      info	[Changelog]   - Type Alias PrivateEndpointConnection has a new parameter groupIds
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 12d012d. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 12d012d. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.Batch [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-workflow-bot
    Copy link

    Hi @paterasMSFT, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    Prettier
    minor
    
    Missing identifier
    @paterasMSFT paterasMSFT force-pushed the mipatera-2022-06-01-batch-management branch from 54c8898 to 4181875 Compare May 11, 2022 17:14
    @paterasMSFT paterasMSFT marked this pull request as ready for review May 11, 2022 17:26
    @openapi-workflow-bot openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 11, 2022
    @rkmanda
    Copy link
    Member

    rkmanda commented May 13, 2022

                "value": "Cancelled",
    

    Canceled


    Refers to: specification/batch/resource-manager/Microsoft.Batch/stable/2022-06-01/BatchManagement.json:3889 in 4181875. [](commit_id = 4181875, deletion_comment = False)

    Copy link
    Member

    @rkmanda rkmanda left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    🕐

    @rkmanda rkmanda added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 13, 2022
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 13, 2022
    @wiboris
    Copy link
    Member

    wiboris commented May 16, 2022

    I removed the 200 response

    @wiboris
    Copy link
    Member

    wiboris commented May 16, 2022

    We already have used Cancelled in other parts of the swagger such as in "BatchAccountProperties" , "provisioningState". "cancelled" is the common spelling outside the US and since we already have other enums spelled this way we should probably keep it consistent.

    @rkmanda rkmanda added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 16, 2022
    @openapi-workflow-bot openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label May 16, 2022
    Copy link
    Member

    @rkmanda rkmanda left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @chunyu3
    Copy link
    Member

    chunyu3 commented May 20, 2022

    Hi @paterasMSFT Would you please resolve the 'ModelValidation' and 'API Readiness check' failure? Thanks

    @paterasMSFT
    Copy link
    Contributor Author

    @chunyu3 I think we're good to go now. The azure-sdk-for-net error is expected.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-SdkBreakingChange-Go-V2 ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-FixRequiredOnFailure
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants