[PostgreSQL] Adding a new privatepreview version for fast-provisioning feature #18978

DaeunYim · 2022-05-09T17:51:11Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Adding getCachedServerName API
Adding additional properties for LocationCapabilities API. There's no change for LocationCapabilities API itself and only introducing a couple of new properties. If this can be an issue for this PR, can be removed

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

…into daeunyim/fast-provisioning-new-api-only2

openapi-workflow-bot · 2022-05-09T17:51:13Z

Hi, @DaeunYim Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2022-05-09T17:51:20Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 1 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
- postgresql/resource-manager/readme.md tag:flexibleserver-2022-03-privatepreview
Linted configuring files (Based on target branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
- postgresql/resource-manager/readme.md tag:default

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ R2066 - PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'getcachedservername' in:'GetCachedServerName_Execute'. Consider updating the operationId Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-privatepreview/getCachedServerName.json#L42

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` R4037 - MissingTypeObject	The schema 'Storage' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-privatepreview/getCachedServerName.json#L138
`❌` R4037 - MissingTypeObject	The schema 'Sku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-privatepreview/getCachedServerName.json#L148
`❌` R4037 - MissingTypeObject	The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.DBforPostgreSQL/preview/2022-03-08-privatepreview/getCachedServerName.json#L174

️⚠️Avocado: 1 Warnings warning [Detail]

Rule	Message
⚠️ MULTIPLE_API_VERSION	The default tag contains multiple API versions swaggers. readme: specification/postgresql/resource-manager/readme.md tag: specification/postgresql/resource-manager/readme.md#tag-package-2020-01-01

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

postgresql/resource-manager/readme.md#flexibleserver-2022-03-privatepreview

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-05-09T17:51:21Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

️✔️azure-sdk-for-go-track2 - armpostgresql - 1.0.1
️✔️azure-sdk-for-go-track2 - armpostgresqlflexibleservers - 1.0.1
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-rdbms - 10.1.0

❌azure-sdk-for-go - postgresql/mgmt/2021-06-01/postgresqlflexibleservers - v65.0.0

️✔️azure-sdk-for-go - postgresql/mgmt/2020-01-01/postgresql - v65.0.0
️✔️azure-sdk-for-go - postgresql/mgmt/2017-12-01/postgresql - v65.0.0
️✔️azure-sdk-for-go - preview/postgresql/mgmt/2021-06-01-preview/postgresqlflexibleservers - v65.0.0
❌azure-sdk-for-go - preview/postgresql/mgmt/2020-11-05-preview/postgresqlflexibleservers - v65.0.0

❌azure-sdk-for-go - preview/postgresql/mgmt/2020-02-14-preview/postgresqlflexibleservers - v65.0.0

️✔️azure-sdk-for-go - preview/postgresql/mgmt/2017-12-01-preview/postgresql - v65.0.0

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from aa42d66. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.

️✔️track2_azure-mgmt-rdbms [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Model CapabilityProperties has a new parameter supported_ha_mode
info	[Changelog]   - Model Configuration has a new parameter documentation_link
info	[Changelog]   - Model Configuration has a new parameter is_config_pending_restart
info	[Changelog]   - Model Configuration has a new parameter is_dynamic_config
info	[Changelog]   - Model Configuration has a new parameter is_read_only
info	[Changelog]   - Model Configuration has a new parameter unit
info	[Changelog]   - Model NameAvailability has a new parameter reason
info	[Changelog]   - Model VirtualNetworkSubnetUsageResult has a new parameter location
info	[Changelog]   - Model VirtualNetworkSubnetUsageResult has a new parameter subscription_id
info	[Changelog]
info	[Changelog] **Breaking changes**
info	[Changelog]
info	[Changelog]   - Model Server no longer has parameter tags_properties_tags

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from aa42d66. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

️✔️azure-resourcemanager-postgresqlflexibleserver [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from aa42d66. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armpostgresql [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️armpostgresqlflexibleservers [View full logs] [Release SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 4e7ac89399ab4aff733785e51eab36175a327746. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armpostgresql [View full logs] [Preview SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️armpostgresqlflexibleservers [View full logs] [Preview SDK Changes]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from aa42d66. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh] deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh]  deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh]  @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  deprecated @azure/[email protected]: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
warn	No file changes detected after generation
warn	No package detected after generation

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from aa42d66. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️postgresql [View full logs]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from aa42d66. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.PostgreSql [View full logs] [Release SDK Changes]
- Az.PostgreSql.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-05-10T02:28:53Z

Hi, @DaeunYim your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

...manager/Microsoft.DBforPostgreSQL/preview/2022-03-08-privatepreview/getCachedServerName.json

raosuhas

raosuhas · 2022-06-07T00:04:52Z

Signing off from ARM side with a minor comment. Please fix if applicable before checkin

DaeunYim · 2022-06-10T20:17:38Z

SDK owners @BigCat20196 @ArcturusZhang Could you approve this PR?

DaeunYim added 15 commits April 15, 2022 10:45

add new files

c34e261

Add getCachedServerName API

5121921

location capability property update

a2a5b2d

revert the wrong change

8e87a72

Add new line and change formats

386ccf1

Merge branch 'main' of https://github.com/Azure/azure-rest-api-specs …

859cac2

…into daeunyim/fast-provisioning-new-api-only2

fix ci issue

5532224

Remove example file

4a32a3f

Re-add example file

42fa372

Added readme files

47fa28f

Add location name

5309a8d

Add definitions for required parameters

784c2fc

Run prettier and handle model validation isue

647f7f7

Remove additional property

1ef8e84

prettier run again

aeda856

DaeunYim requested review from msyyc, BigCat20196, ArcturusZhang and qiaozha as code owners May 9, 2022 17:51

openapi-assignment-bot bot assigned dw511214992 May 9, 2022

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label May 9, 2022

openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 10, 2022

raosuhas reviewed Jun 7, 2022

View reviewed changes

...manager/Microsoft.DBforPostgreSQL/preview/2022-03-08-privatepreview/getCachedServerName.json Show resolved Hide resolved

raosuhas approved these changes Jun 7, 2022

View reviewed changes

raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jun 7, 2022

openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 7, 2022

Merge branch 'main' into daeunyim/fast-provisioning-new-api-only2

9aa4ead

dw511214992 merged commit aa42d66 into Azure:main Jun 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PostgreSQL] Adding a new privatepreview version for fast-provisioning feature #18978

[PostgreSQL] Adding a new privatepreview version for fast-provisioning feature #18978

DaeunYim commented May 9, 2022 •

edited by honghr

Loading

openapi-workflow-bot bot commented May 9, 2022

openapi-pipeline-app bot commented May 9, 2022 •

edited

Loading

openapi-pipeline-app bot commented May 9, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented May 10, 2022

raosuhas left a comment

raosuhas commented Jun 7, 2022

DaeunYim commented Jun 10, 2022

[PostgreSQL] Adding a new privatepreview version for fast-provisioning feature #18978

[PostgreSQL] Adding a new privatepreview version for fast-provisioning feature #18978

Conversation

DaeunYim commented May 9, 2022 • edited by honghr Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented May 9, 2022

openapi-pipeline-app bot commented May 9, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented May 9, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented May 10, 2022

raosuhas left a comment

Choose a reason for hiding this comment

raosuhas commented Jun 7, 2022

DaeunYim commented Jun 10, 2022

DaeunYim commented May 9, 2022 •

edited by honghr

Loading

openapi-pipeline-app bot commented May 9, 2022 •

edited

Loading

openapi-pipeline-app bot commented May 9, 2022 •

edited

Loading