-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cancel endpoint for conversations #19025
Add cancel endpoint for conversations #19025
Conversation
Hi, @bidisha-c Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Generation Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to get clarification on a question first, but otherwise LGTM. I'll ping the two people offline as well.
...n/cognitiveservices/data-plane/Language/preview/2022-05-15-preview/analyzeconversations.json
Show resolved
Hide resolved
...n/cognitiveservices/data-plane/Language/preview/2022-05-15-preview/analyzeconversations.json
Show resolved
Hide resolved
"required": [ | ||
"text", | ||
"lexical", | ||
"itn", | ||
"maskedItn" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this change related, and are these not still required? Even for response objects, we want a list of never-null/missing properties for better code generation. Was this intentional, or just a mistake? I.e. I don't mind unrelated changes in the PR, it just isn't obvious if this was intended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change we noticed while testing. The idea is we need one type to be present (text/lex/itn/maskedItn) but not all are required. Is there an open API construct that allows for this?
...n/cognitiveservices/data-plane/Language/preview/2022-05-15-preview/analyzeconversations.json
Show resolved
Hide resolved
...ane/Language/preview/2022-05-15-preview/examples/SuccessfulAnalyzeTextJobsCancelRequest.json
Show resolved
Hide resolved
...ane/Language/preview/2022-05-15-preview/examples/SuccessfulAnalyzeTextJobsCancelRequest.json
Show resolved
Hide resolved
@lmazuel everything looks good, but that dup symbol error for python generation is occuring again. Can you merge anyway? /cc @weshaggard |
d75e3b3
into
release-cognitiveservices-Language-2022-05-01-preview
* Add cancel endpoint for conversations * Update examples path * Make the input for transcriptConversationItem optional
… to main (#19186) * Updated May-1 preview to include changes from March-1 preview (#18580) * Updated May-1 preview to include changes from March-1 preview * Fixed a missed api version update in an example file Co-authored-by: Abigail Hartman <[email protected]> * [Language API 2022-05-01-Preview]Conversation API Async - Conversational Summarization and Conversational PII (#17847) * Adds base for updating Language from version preview/2022-02-01-preview to version 2022-04-01-preview * Updates readme * Updates API version in new specs and examples * [Language API 2022-04-01-Preview] Feature conversation PII redaction and issue resolution summarization * Add Issue Resolution Summary * Address comments * address pretty chek and spell check issues * address file name mismatch issue * typo * Add IRD updates * Add IRD Schema changes * Response Files content update * Address feedback * Address PR comments * Address comments * Add the May API version * Address comments * Remove 04-01 and address comments * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/common.json Co-authored-by: Heath Stewart <[email protected]> * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/common.json Co-authored-by: Heath Stewart <[email protected]> * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/analyzeconversations.json Co-authored-by: Heath Stewart <[email protected]> * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/analyzeconversations.json Co-authored-by: Heath Stewart <[email protected]> * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/textanalytics.json Co-authored-by: Heath Stewart <[email protected]> * Address feedback V-1. * Address all comments expect model + enum descriptions * Fx validations * Missed files * Conversation Item modality issue * Update PII Task * Address Spec validation errors * Updates * Fix PII issues * Add readonly * Update schema * Updates * Bring back Text Conversation Item * Update example * Space in Json * Address comments * Address one more comments * Fix model validation * Fix * Update spec * Address comments * Move requestStatistics, prebuiltResult, error and warnings object to common * Address circular dependency Co-authored-by: Abigail Hartman <[email protected]> Co-authored-by: Heath Stewart <[email protected]> * Rename version from 2022-05-01-preview to 2022-05-15-preview (#18737) * Update CLU swagger (#18739) Co-authored-by: Chong Tang <[email protected]> * Use azure-sdk-for-net-track2 for validation (#18755) * Bidishac/update field description (#18787) * Update the messaging on the parameter type * Update the documentation of the redactionSource field * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-15-preview/analyzeconversations.json Co-authored-by: Heath Stewart <[email protected]> Co-authored-by: Chong Tang <[email protected]> Co-authored-by: Heath Stewart <[email protected]> * Unify the runtime and authoring APIs (#18837) * unifying single classification and multi classification to return array of class (#18902) * Renaming in 2022-05-15-preview (#18929) Co-authored-by: Chong Tang <[email protected]> * Rename 'summary' in summaryAspects to 'issue' (#18941) * Rename 'summary' in summaryAspects to 'issue' * Merge issues * Update model version value * Merge 2022-05-01-GA authoring updates and "LUIS" string case update into 2022-05-15-preview branch (#18943) * Merge 2022-05-01-GA files changes into 2022-05-15-preview branch * Address Avocado issues and revert case update for Luis * Add the missing error codes * Fix avocado * Avocado fix * Add api-version parameter to cancel job endpoint (#18986) * Add api-version parameter to cancel job endpoint * Fix taskState and jobState * Revert "Fix taskState and jobState" This reverts commit 148dd21. * Update LUIS to Luis in model names (#19012) * Copy QuestionAnswering definitions to common.json and refer them in analyzeconversations.json (#19031) Co-authored-by: Chong Tang <[email protected]> * Added fhir feature updates to 2022-05-15-preview (#19092) Co-authored-by: Abigail Hartman <[email protected]> * Add cancel endpoint for conversations (#19025) * Add cancel endpoint for conversations * Update examples path * Make the input for transcriptConversationItem optional * Bidishac/update enum name (#19149) * Update name to CreditCard * Update entity categories for PII for build * Keep SSN * Revert "Keep SSN" This reverts commit 77a9211. * Update readme.md Co-authored-by: Abigail Hartman <[email protected]> Co-authored-by: Abigail Hartman <[email protected]> Co-authored-by: Bidisha Chakraborty <[email protected]> Co-authored-by: Chong Tang <[email protected]> Co-authored-by: Chong Tang <[email protected]> Co-authored-by: Mohamed Abbas <[email protected]> Co-authored-by: Nourhan <[email protected]>
… to main (#19186) * Updated May-1 preview to include changes from March-1 preview (#18580) * Updated May-1 preview to include changes from March-1 preview * Fixed a missed api version update in an example file Co-authored-by: Abigail Hartman <[email protected]> * [Language API 2022-05-01-Preview]Conversation API Async - Conversational Summarization and Conversational PII (#17847) * Adds base for updating Language from version preview/2022-02-01-preview to version 2022-04-01-preview * Updates readme * Updates API version in new specs and examples * [Language API 2022-04-01-Preview] Feature conversation PII redaction and issue resolution summarization * Add Issue Resolution Summary * Address comments * address pretty chek and spell check issues * address file name mismatch issue * typo * Add IRD updates * Add IRD Schema changes * Response Files content update * Address feedback * Address PR comments * Address comments * Add the May API version * Address comments * Remove 04-01 and address comments * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/common.json Co-authored-by: Heath Stewart <[email protected]> * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/common.json Co-authored-by: Heath Stewart <[email protected]> * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/analyzeconversations.json Co-authored-by: Heath Stewart <[email protected]> * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/analyzeconversations.json Co-authored-by: Heath Stewart <[email protected]> * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/textanalytics.json Co-authored-by: Heath Stewart <[email protected]> * Address feedback V-1. * Address all comments expect model + enum descriptions * Fx validations * Missed files * Conversation Item modality issue * Update PII Task * Address Spec validation errors * Updates * Fix PII issues * Add readonly * Update schema * Updates * Bring back Text Conversation Item * Update example * Space in Json * Address comments * Address one more comments * Fix model validation * Fix * Update spec * Address comments * Move requestStatistics, prebuiltResult, error and warnings object to common * Address circular dependency Co-authored-by: Abigail Hartman <[email protected]> Co-authored-by: Heath Stewart <[email protected]> * Rename version from 2022-05-01-preview to 2022-05-15-preview (#18737) * Update CLU swagger (#18739) Co-authored-by: Chong Tang <[email protected]> * Use azure-sdk-for-net-track2 for validation (#18755) * Bidishac/update field description (#18787) * Update the messaging on the parameter type * Update the documentation of the redactionSource field * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-15-preview/analyzeconversations.json Co-authored-by: Heath Stewart <[email protected]> Co-authored-by: Chong Tang <[email protected]> Co-authored-by: Heath Stewart <[email protected]> * Unify the runtime and authoring APIs (#18837) * unifying single classification and multi classification to return array of class (#18902) * Renaming in 2022-05-15-preview (#18929) Co-authored-by: Chong Tang <[email protected]> * Rename 'summary' in summaryAspects to 'issue' (#18941) * Rename 'summary' in summaryAspects to 'issue' * Merge issues * Update model version value * Merge 2022-05-01-GA authoring updates and "LUIS" string case update into 2022-05-15-preview branch (#18943) * Merge 2022-05-01-GA files changes into 2022-05-15-preview branch * Address Avocado issues and revert case update for Luis * Add the missing error codes * Fix avocado * Avocado fix * Add api-version parameter to cancel job endpoint (#18986) * Add api-version parameter to cancel job endpoint * Fix taskState and jobState * Revert "Fix taskState and jobState" This reverts commit 148dd21. * Update LUIS to Luis in model names (#19012) * Copy QuestionAnswering definitions to common.json and refer them in analyzeconversations.json (#19031) Co-authored-by: Chong Tang <[email protected]> * Added fhir feature updates to 2022-05-15-preview (#19092) Co-authored-by: Abigail Hartman <[email protected]> * Add cancel endpoint for conversations (#19025) * Add cancel endpoint for conversations * Update examples path * Make the input for transcriptConversationItem optional * Bidishac/update enum name (#19149) * Update name to CreditCard * Update entity categories for PII for build * Keep SSN * Revert "Keep SSN" This reverts commit 77a9211. * Update readme.md Co-authored-by: Abigail Hartman <[email protected]> Co-authored-by: Abigail Hartman <[email protected]> Co-authored-by: Bidisha Chakraborty <[email protected]> Co-authored-by: Chong Tang <[email protected]> Co-authored-by: Chong Tang <[email protected]> Co-authored-by: Mohamed Abbas <[email protected]> Co-authored-by: Nourhan <[email protected]>
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.