[EventHub]: Adding status code 202 to Private endpoints PUT #19118

damodaravadhani · 2022-05-18T03:22:04Z

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify -> Adding missing success response code to PUT calls on Private Endpoints
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month. June
If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
- SDK of .NET (need service team to ensure code readiness)
- SDK of Python
- SDK of Java
- SDK of Js
- SDK of Go
- PowerShell
- CLI
- Terraform
- No refresh required for updates in this PR

Contribution checklist:

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[X] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

Removing API(s) in a stable version
Removing properties in a stable version
Removing API version(s) in a stable version
Updating API in a stable or public preview version with Breaking Change Validation errors
Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2022-05-18T03:22:07Z

Hi, @damodaravadhani Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2022-05-18T03:22:07Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 0 Warnings failed [Detail]

Compared Swaggers (Based on Oad v0.9.5)
- current:preview/2022-01-01-preview/namespaces-preview.json compared with base:preview/2022-01-01-preview/namespaces-preview.json

Rule	Message
`❌` 1011 - AddingResponseCode	The new version adds a response code '202'. New: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L426:11

️⚠️LintDiff: 1 Warnings warning [Detail]

Linted configuring files (Based on source branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
- eventhub/resource-manager/readme.md tag:package-2022-01-preview
Linted configuring files (Based on target branch, openapi-validator v1.13.0 , classic-openapi-validator v1.2.4 )
- eventhub/resource-manager/readme.md tag:package-2022-01-preview

The following errors/warnings are introduced by current PR:

Rule	Message
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'PrivateEndpointConnections_CreateOrUpdate' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L373

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` R4037 - MissingTypeObject	The schema 'EHNamespaceListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L672
`❌` R4037 - MissingTypeObject	The schema 'EHNamespace' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L688
`❌` R4037 - MissingTypeObject	The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L703
`❌` R4037 - MissingTypeObject	The schema 'Identity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L857
`❌` R4037 - MissingTypeObject	The schema 'Encryption' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L912
`❌` R4037 - MissingTypeObject	The schema 'KeyVaultProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L942
`❌` R4037 - MissingTypeObject	The schema 'PrivateEndpointConnection' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L965
`❌` R4037 - MissingTypeObject	The schema 'PrivateEndpointConnectionProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L985
`❌` R4037 - MissingTypeObject	The schema 'PrivateEndpoint' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L1014
`❌` R4037 - MissingTypeObject	The schema 'ConnectionState' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L1023
`❌` R4037 - MissingTypeObject	The schema 'PrivateEndpointConnectionListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L1046
`❌` R4037 - MissingTypeObject	The schema 'PrivateLinkResource' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L1062
`❌` R4037 - MissingTypeObject	The schema 'PrivateLinkResourceProperties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L1084
`❌` R4037 - MissingTypeObject	The schema 'PrivateLinkResourcesListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L1107
`❌` R4041 - XmsIdentifierValidation	Missing identifier id in array item property Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L915
⚠️ R1003 - ListInOperationName	Since operation 'PrivateLinkResources_Get' response has model definition 'array', it should be of the form '_list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L542
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L1262
⚠️ R2001 - AvoidNestedProperties	Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L1296
⚠️ R2007 - LongRunningOperationsWithLongRunningExtension	The operation 'Namespaces_Update' returns 202 status code, which indicates a long running operation, please enable 'x-ms-long-running-operation. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L265
⚠️ R2029 - PageableOperation	Based on the response model schema, operation 'PrivateLinkResources_Get' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L538
⚠️ R2029 - PageableOperation	Based on the response model schema, operation 'NetworkSecurityPerimeterConfiguration_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L583
⚠️ R2063 - OperationIdNounConflictingModelNames	OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'NetworkSecurityPerimeterConfigurationModel'. Consider using the plural form of 'NetworkSecurityPerimeterConfiguration' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L587
⚠️ R2066 - PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'reconcile' in:'NetworkSecurityPerimeterConfigurations_CreateOrUpdate'. Consider updating the operationId Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L629
⚠️ R3010 - TrackedResourceListByImmediateParent	The child tracked resource, 'privateEndpointConnections' with immediate parent 'EHNamespace', must have a list by immediate parent operation. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L965
⚠️ R3018 - EnumInsteadOfBoolean	Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: requireInfrastructureEncryption Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L935
⚠️ R4014 - AllResourcesMustHaveGetOperation	The resource 'NetworkSecurityPerimeterConfiguration' does not have get operation, please add it. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L1147
⚠️ R4021 - DescriptionAndTitleMissing	'userAssignedIdentityProperties' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation. Location: Microsoft.EventHub/preview/2022-01-01-preview/namespaces-preview.json#L1123

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️Cross-Version Breaking Changes succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SDK Track2 Validation succeeded [Detail] [Expand]

Validation passes for SDKTrack2Validation

The following tags are being changed in this PR

eventhub/resource-manager/readme.md#package-2022-01-preview

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2022-05-18T03:22:08Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️✔️azure-sdk-for-go-track2 - armeventhub - 1.0.1
️✔️azure-sdk-for-go - eventhub/mgmt/2021-11-01/eventhub - v64.1.0
️✔️azure-sdk-for-go - eventhub/mgmt/2017-04-01/eventhub - v64.1.0
️✔️azure-sdk-for-go - eventhub/mgmt/2015-08-01/eventhub - v64.1.0
️✔️azure-sdk-for-go - preview/eventhub/mgmt/2022-01-01-preview/eventhub - v64.1.0
️✔️azure-sdk-for-go - preview/eventhub/mgmt/2021-01-01-preview/eventhub - v64.1.0
️✔️azure-sdk-for-go - preview/eventhub/mgmt/2018-01-01-preview/eventhub - v64.1.0
️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-eventhub - 10.0.0

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2f87cc0. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn	File azure-sdk-for-net_tmp/initOutput.json not found to read
command	pwsh ./eng/scripts/Automation-Sdk-Generate.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.EventHubs [View full logs] [Release SDK Changes]
- Azure.ResourceManager.EventHubs.1.0.0-alpha.20220519.1.nupkg
- Azure.ResourceManager.EventHubs.1.0.0-alpha.20220519.1.symbols.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 2f87cc0. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️track2_azure-mgmt-eventhub [View full logs] [Release SDK Changes]

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group ApplicationGroupOperations
info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurationOperations
info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurationsOperations
info	[Changelog]   - Model Cluster has a new parameter supports_scaling
info	[Changelog]   - Model EHNamespace has a new parameter minimum_tls_version
info	[Changelog]   - Model EHNamespace has a new parameter public_network_access

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 2f87cc0. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
cmderr	[generate.py] SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
cmderr	[generate.py] SLF4J: Defaulting to no-operation (NOP) logger implementation
cmderr	[generate.py] SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.

️✔️azure-resourcemanager-eventhubs-generated [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2f87cc0. SDK Automation 14.0.0

command	sh ./eng/initScript.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️eventhub/mgmt/2021-11-01/eventhub [View full logs] [Release SDK Changes]
```
info	[Changelog] This is a new package
info	[Changelog]
```

️✔️eventhub/mgmt/2017-04-01/eventhub [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️eventhub/mgmt/2015-08-01/eventhub [View full logs]

info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).

️✔️preview/eventhub/mgmt/2022-01-01-preview/eventhub [View full logs]
```
info	[Changelog] This is a new package
info	[Changelog]
```
️✔️preview/eventhub/mgmt/2021-01-01-preview/eventhub [View full logs]
```
info	[Changelog] This is a new package
info	[Changelog]
```

️✔️preview/eventhub/mgmt/2018-01-01-preview/eventhub [View full logs]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New field `Status` in struct `EHNamespaceProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 1 additive change(s).

️️✔️ azure-sdk-for-go-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2f87cc0. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️armeventhub [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New const `TLSVersionOne2`
info	[Changelog] - New const `MetricIDOutgoingMessages`
info	[Changelog] - New const `NetworkSecurityPerimeterConfigurationProvisioningStateInvalidResponse`
info	[Changelog] - New const `NspAccessRuleDirectionOutbound`
info	[Changelog] - New const `NetworkSecurityPerimeterConfigurationProvisioningStateAccepted`
info	[Changelog] - New const `PublicNetworkAccessSecuredByPerimeter`
info	[Changelog] - New const `ResourceAssociationAccessModeNoAssociationMode`
info	[Changelog] - New const `NetworkSecurityPerimeterConfigurationProvisioningStateDeleted`
info	[Changelog] - New const `PublicNetworkAccessFlagSecuredByPerimeter`
info	[Changelog] - New const `NetworkSecurityPerimeterConfigurationProvisioningStateCanceled`
info	[Changelog] - New const `PublicNetworkAccessDisabled`
info	[Changelog] - New const `NetworkSecurityPerimeterConfigurationProvisioningStateUpdating`
info	[Changelog] - New const `ApplicationGroupPolicyTypeThrottlingPolicy`
info	[Changelog] - New const `NetworkSecurityPerimeterConfigurationProvisioningStateFailed`
info	[Changelog] - New const `NetworkSecurityPerimeterConfigurationProvisioningStateDeleting`
info	[Changelog] - New const `TLSVersionOne0`
info	[Changelog] - New const `MetricIDIncomingMessages`
info	[Changelog] - New const `NspAccessRuleDirectionInbound`
info	[Changelog] - New const `ResourceAssociationAccessModeLearningMode`
info	[Changelog] - New const `MetricIDOutgoingBytes`
info	[Changelog] - New const `NetworkSecurityPerimeterConfigurationProvisioningStateUnknown`
info	[Changelog] - New const `NetworkSecurityPerimeterConfigurationProvisioningStateSucceeded`
info	[Changelog] - New const `ResourceAssociationAccessModeAuditMode`
info	[Changelog] - New const `NetworkSecurityPerimeterConfigurationProvisioningStateSucceededWithIssues`
info	[Changelog] - New const `NetworkSecurityPerimeterConfigurationProvisioningStateCreating`
info	[Changelog] - New const `ResourceAssociationAccessModeEnforcedMode`
info	[Changelog] - New const `ResourceAssociationAccessModeUnspecifiedMode`
info	[Changelog] - New const `MetricIDIncomingBytes`
info	[Changelog] - New const `TLSVersionOne1`
info	[Changelog] - New const `PublicNetworkAccessEnabled`
info	[Changelog] - New function `PossibleTLSVersionValues() []TLSVersion`
info	[Changelog] - New function `*ApplicationGroupProperties.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `*ThrottlingPolicy.GetApplicationGroupPolicy() *ApplicationGroupPolicy`
info	[Changelog] - New function `PossibleNetworkSecurityPerimeterConfigurationProvisioningStateValues() []NetworkSecurityPerimeterConfigurationProvisioningState`
info	[Changelog] - New function `*ApplicationGroupClient.NewListByNamespacePager(string, string, *ApplicationGroupClientListByNamespaceOptions) *runtime.Pager[ApplicationGroupClientListByNamespaceResponse]`
info	[Changelog] - New function `*ThrottlingPolicy.UnmarshalJSON([]byte) error`
info	[Changelog] - New function `ApplicationGroupProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PossibleResourceAssociationAccessModeValues() []ResourceAssociationAccessMode`
info	[Changelog] - New function `PossiblePublicNetworkAccessValues() []PublicNetworkAccess`
info	[Changelog] - New function `NetworkSecurityPerimeterConfigurationProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `NspAccessRuleProperties.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `NewNetworkSecurityPerimeterConfigurationClient(string, azcore.TokenCredential, *arm.ClientOptions) (*NetworkSecurityPerimeterConfigurationClient, error)`
info	[Changelog] - New function `*NetworkSecurityPerimeterConfigurationClient.List(context.Context, string, string, *NetworkSecurityPerimeterConfigurationClientListOptions) (NetworkSecurityPerimeterConfigurationClientListResponse, error)`
info	[Changelog] - New function `NetworkSecurityPerimeterConfiguration.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `*ApplicationGroupClient.CreateOrUpdateApplicationGroup(context.Context, string, string, string, ApplicationGroup, *ApplicationGroupClientCreateOrUpdateApplicationGroupOptions) (ApplicationGroupClientCreateOrUpdateApplicationGroupResponse, error)`
info	[Changelog] - New function `NetworkSecurityPerimeterConfigurationPropertiesProfile.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `NewApplicationGroupClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ApplicationGroupClient, error)`
info	[Changelog] - New function `*ApplicationGroupClient.Delete(context.Context, string, string, string, *ApplicationGroupClientDeleteOptions) (ApplicationGroupClientDeleteResponse, error)`
info	[Changelog] - New function `NewNetworkSecurityPerimeterConfigurationsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*NetworkSecurityPerimeterConfigurationsClient, error)`
info	[Changelog] - New function `PossibleMetricIDValues() []MetricID`
info	[Changelog] - New function `*ApplicationGroupClient.Get(context.Context, string, string, string, *ApplicationGroupClientGetOptions) (ApplicationGroupClientGetResponse, error)`
info	[Changelog] - New function `*ApplicationGroupPolicy.GetApplicationGroupPolicy() *ApplicationGroupPolicy`
info	[Changelog] - New function `ThrottlingPolicy.MarshalJSON() ([]byte, error)`
info	[Changelog] - New function `PossibleApplicationGroupPolicyTypeValues() []ApplicationGroupPolicyType`
info	[Changelog] - New function `*NetworkSecurityPerimeterConfigurationsClient.BeginCreateOrUpdate(context.Context, string, string, string, *NetworkSecurityPerimeterConfigurationsClientBeginCreateOrUpdateOptions) (*runtime.Poller[NetworkSecurityPerimeterConfigurationsClientCreateOrUpdateResponse], error)`
info	[Changelog] - New function `PossibleNspAccessRuleDirectionValues() []NspAccessRuleDirection`
info	[Changelog] - New struct `ApplicationGroup`
info	[Changelog] - New struct `ApplicationGroupClient`
info	[Changelog] - New struct `ApplicationGroupClientCreateOrUpdateApplicationGroupOptions`
info	[Changelog] - New struct `ApplicationGroupClientCreateOrUpdateApplicationGroupResponse`
info	[Changelog] - New struct `ApplicationGroupClientDeleteOptions`
info	[Changelog] - New struct `ApplicationGroupClientDeleteResponse`
info	[Changelog] - New struct `ApplicationGroupClientGetOptions`
info	[Changelog] - New struct `ApplicationGroupClientGetResponse`
info	[Changelog] - New struct `ApplicationGroupClientListByNamespaceOptions`
info	[Changelog] - New struct `ApplicationGroupClientListByNamespaceResponse`
info	[Changelog] - New struct `ApplicationGroupListResult`
info	[Changelog] - New struct `ApplicationGroupPolicy`
info	[Changelog] - New struct `ApplicationGroupProperties`
info	[Changelog] - New struct `NetworkSecurityPerimeter`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfiguration`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationClient`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationClientListOptions`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationClientListResponse`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationList`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationProperties`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationPropertiesProfile`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationPropertiesResourceAssociation`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationsClient`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationsClientBeginCreateOrUpdateOptions`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationsClientCreateOrUpdateResponse`
info	[Changelog] - New struct `NspAccessRule`
info	[Changelog] - New struct `NspAccessRuleProperties`
info	[Changelog] - New struct `NspAccessRulePropertiesSubscriptionsItem`
info	[Changelog] - New struct `ProvisioningIssue`
info	[Changelog] - New struct `ProvisioningIssueProperties`
info	[Changelog] - New struct `ThrottlingPolicy`
info	[Changelog] - New field `PublicNetworkAccess` in struct `EHNamespaceProperties`
info	[Changelog] - New field `MinimumTLSVersion` in struct `EHNamespaceProperties`
info	[Changelog] - New field `SupportsScaling` in struct `ClusterProperties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 121 additive change(s).

️⚠️ azure-sdk-for-js warning [Detail]

⚠️Warning [Logs]Release - Generate from 2f87cc0. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
cmderr	[automation_init.sh]  WARN deprecated [email protected]: The functionality that this package provided is now in @npmcli/arborist
cmderr	[automation_init.sh] deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
cmderr	[automation_init.sh] deprecated @opentelemetry/[email protected]: Package renamed to @opentelemetry/api, see https://github.com/open-telemetry/opentelemetry-js
cmderr	[automation_init.sh]  deprecated @azure/[email protected]: This version has been deprecated, please upgrade to the version tagged as latest
cmderr	[automation_init.sh] npm WARN @octokit/[email protected] requires a peer of @octokit/core@>=3 but none is installed. You must install peer dependencies yourself.
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-eventhub [View full logs] [Release SDK Changes]

azure-arm-eventhub-5.1.0-beta.1.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group ApplicationGroupOperations
info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurationOperations
info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurations
info	[Changelog]   - Added Interface ApplicationGroupCreateOrUpdateApplicationGroupOptionalParams
info	[Changelog]   - Added Interface ApplicationGroupDeleteOptionalParams
info	[Changelog]   - Added Interface ApplicationGroupGetOptionalParams
info	[Changelog]   - Added Interface ApplicationGroupListByNamespaceNextOptionalParams
info	[Changelog]   - Added Interface ApplicationGroupListByNamespaceOptionalParams
info	[Changelog]   - Added Interface ApplicationGroupListResult
info	[Changelog]   - Added Interface ApplicationGroupPolicy
info	[Changelog]   - Added Interface NetworkSecurityPerimeter
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationList
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationListOptionalParams
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationPropertiesProfile
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationPropertiesResourceAssociation
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface NspAccessRule
info	[Changelog]   - Added Interface NspAccessRuleProperties
info	[Changelog]   - Added Interface NspAccessRulePropertiesSubscriptionsItem
info	[Changelog]   - Added Interface ProvisioningIssue
info	[Changelog]   - Added Interface ProvisioningIssueProperties
info	[Changelog]   - Added Type Alias ApplicationGroup
info	[Changelog]   - Added Type Alias ApplicationGroupCreateOrUpdateApplicationGroupResponse
info	[Changelog]   - Added Type Alias ApplicationGroupGetResponse
info	[Changelog]   - Added Type Alias ApplicationGroupListByNamespaceNextResponse
info	[Changelog]   - Added Type Alias ApplicationGroupListByNamespaceResponse
info	[Changelog]   - Added Type Alias ApplicationGroupPolicyType
info	[Changelog]   - Added Type Alias ApplicationGroupPolicyUnion
info	[Changelog]   - Added Type Alias MetricId
info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfiguration
info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationListResponse
info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationProvisioningState
info	[Changelog]   - Added Type Alias NspAccessRuleDirection
info	[Changelog]   - Added Type Alias PublicNetworkAccess
info	[Changelog]   - Added Type Alias ResourceAssociationAccessMode
info	[Changelog]   - Added Type Alias ThrottlingPolicy
info	[Changelog]   - Added Type Alias TlsVersion
info	[Changelog]   - Class EventHubManagementClient has a new parameter applicationGroupOperations
info	[Changelog]   - Class EventHubManagementClient has a new parameter networkSecurityPerimeterConfigurationOperations
info	[Changelog]   - Class EventHubManagementClient has a new parameter networkSecurityPerimeterConfigurations
info	[Changelog]   - Type Alias Cluster has a new parameter supportsScaling
info	[Changelog]   - Type Alias EHNamespace has a new parameter minimumTlsVersion
info	[Changelog]   - Type Alias EHNamespace has a new parameter publicNetworkAccess
info	[Changelog]   - Added Enum KnownApplicationGroupPolicyType
info	[Changelog]   - Added Enum KnownMetricId
info	[Changelog]   - Added Enum KnownNetworkSecurityPerimeterConfigurationProvisioningState
info	[Changelog]   - Added Enum KnownNspAccessRuleDirection
info	[Changelog]   - Added Enum KnownPublicNetworkAccess
info	[Changelog]   - Added Enum KnownResourceAssociationAccessMode
info	[Changelog]   - Added Enum KnownTlsVersion
info	[Changelog]   - Enum KnownPublicNetworkAccessFlag has a new value SecuredByPerimeter
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 2f87cc0. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️eventhub [View full logs]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 2f87cc0. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.EventHub [View full logs] [Release SDK Changes]
- Az.EventHub.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-workflow-bot · 2022-05-18T03:22:08Z

Hi, @damodaravadhani your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]).

openapi-workflow-bot · 2022-05-18T03:24:25Z

Hi @damodaravadhani, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

Task	How to fix	Priority
Avocado	Fix-Avocado	High
Semantic validation	Fix-SemanticValidation-Error	High
Model validation	Fix-ModelValidation-Error	High
LintDiff	Fix-LintDiff	high

If you need further help, please feedback via swagger feedback.

openapi-workflow-bot · 2022-05-18T03:24:29Z

Hi @damodaravadhani, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
If you want to know the production traffic statistic, please see ARM Traffic statistic.
If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

adding status code 202 to Private endpoints PUT

f59463f

damodaravadhani requested review from v-Ajnava and dsouzaarun as code owners May 18, 2022 03:22

openapi-assignment-bot bot assigned ruowan May 18, 2022

openapi-workflow-bot bot added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 18, 2022

openapi-pipeline-app bot added the CI-FixRequiredOnFailure label May 18, 2022

openapi-pipeline-app bot added the BreakingChangeReviewRequired label May 18, 2022

Adding example

f59138f

openapi-pipeline-app bot removed the CI-FixRequiredOnFailure label May 18, 2022

JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 18, 2022

rkmanda removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required ARMReview labels May 18, 2022

ruowan added the ARMReview label May 19, 2022

ruowan approved these changes May 19, 2022

View reviewed changes

ruowan added Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 and removed Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 labels May 19, 2022

ruowan merged commit 2f87cc0 into Azure:main May 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[EventHub]: Adding status code 202 to Private endpoints PUT #19118

[EventHub]: Adding status code 202 to Private endpoints PUT #19118

damodaravadhani commented May 18, 2022 •

edited

Loading

openapi-workflow-bot bot commented May 18, 2022

openapi-pipeline-app bot commented May 18, 2022 •

edited

Loading

openapi-pipeline-app bot commented May 18, 2022 •

edited

Loading

Breaking Changes Tracking

openapi-workflow-bot bot commented May 18, 2022

openapi-workflow-bot bot commented May 18, 2022

openapi-workflow-bot bot commented May 18, 2022

[EventHub]: Adding status code 202 to Private endpoints PUT #19118

[EventHub]: Adding status code 202 to Private endpoints PUT #19118

Conversation

damodaravadhani commented May 18, 2022 • edited Loading

Changelog

Contribution checklist:

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented May 18, 2022

openapi-pipeline-app bot commented May 18, 2022 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented May 18, 2022 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-workflow-bot bot commented May 18, 2022

openapi-workflow-bot bot commented May 18, 2022

openapi-workflow-bot bot commented May 18, 2022

damodaravadhani commented May 18, 2022 •

edited

Loading

openapi-pipeline-app bot commented May 18, 2022 •

edited

Loading

openapi-pipeline-app bot commented May 18, 2022 •

edited

Loading