-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor updates #19374
Minor updates #19374
Conversation
Hi, @paterasMSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
1 similar comment
Hi, @paterasMSFT Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
compared swaggers (via Oad v0.9.6)] | new version | base version |
---|---|---|
BatchManagement.json | 2022-06-01(99f1833) | 2022-06-01(main) |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️
LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v1.13.0) | new version | base version |
---|---|---|
package-2022-06 | package-2022-06(99f1833) | package-2022-06(main) |
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
The child tracked resource, 'applications' with immediate parent 'BatchAccount', must have a list by immediate parent operation. Location: Microsoft.Batch/stable/2022-06-01/BatchManagement.json#L3164 |
|
The child tracked resource, 'versions' with immediate parent 'Application', must have a list by immediate parent operation. Location: Microsoft.Batch/stable/2022-06-01/BatchManagement.json#L3198 |
|
The child tracked resource, 'certificates' with immediate parent 'BatchAccount', must have a list by immediate parent operation. Location: Microsoft.Batch/stable/2022-06-01/BatchManagement.json#L3661 |
|
The child tracked resource, 'detectors' with immediate parent 'BatchAccount', must have a list by immediate parent operation. Location: Microsoft.Batch/stable/2022-06-01/BatchManagement.json#L3759 |
|
The child tracked resource, 'privateLinkResources' with immediate parent 'BatchAccount', must have a list by immediate parent operation. Location: Microsoft.Batch/stable/2022-06-01/BatchManagement.json#L3785 |
|
The child tracked resource, 'privateEndpointConnections' with immediate parent 'BatchAccount', must have a list by immediate parent operation. Location: Microsoft.Batch/stable/2022-06-01/BatchManagement.json#L3829 |
|
The child tracked resource, 'pools' with immediate parent 'BatchAccount', must have a list by immediate parent operation. Location: Microsoft.Batch/stable/2022-06-01/BatchManagement.json#L3978 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️
SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
|:speech_balloon: |"readme":"batch/resource-manager/readme.md",
"tag":"package-2022-06",
"details":"> Installing AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0 -> 1.11.0)"|
|:speech_balloon: |"readme":"batch/resource-manager/readme.md",
"tag":"package-2022-06",
"details":"> Installed AutoRest extension '@microsoft.azure/openapi-validator' (1.11.0->1.11.0)"|
|:speech_balloon: |"readme":"batch/resource-manager/readme.md",
"tag":"package-2022-06",
"details":"> Installing AutoRest extension '@autorest/modelerfour' (4.21.4 -> 4.21.4)"|
|:speech_balloon: |"readme":"batch/resource-manager/readme.md",
"tag":"package-2022-06",
"details":"> Installed AutoRest extension '@autorest/modelerfour' (4.21.4->4.21.4)"|
|:speech_balloon: |"readme":"batch/resource-manager/readme.md",
"tag":"package-2022-06",
"details":"Autorest completed in 12.84s. 0 files generated."|
The following errors/warnings exist before current PR submission:
Rule | Message |
---|---|
"readme":"batch/resource-manager/readme.md", "tag":"package-2022-06", "details":"Using directive.0.suppress which is deprecated and will be removed in the future." |
|
"readme":"batch/resource-manager/readme.md", "tag":"package-2022-06", "details":"Using directive.1.suppress which is deprecated and will be removed in the future." |
|
"readme":"batch/resource-manager/readme.md", "tag":"package-2022-06", "details":"Using directive.2.suppress which is deprecated and will be removed in the future." |
|
"readme":"batch/resource-manager/readme.md", "tag":"package-2022-06", "details":"Using directive.3.suppress which is deprecated and will be removed in the future." |
|
"readme":"batch/resource-manager/readme.md", "tag":"package-2022-06", "details":"Using directive.4.suppress which is deprecated and will be removed in the future." |
|
"readme":"batch/resource-manager/readme.md", "tag":"package-2022-06", "details":"Using directive.5.suppress which is deprecated and will be removed in the future." |
|
"readme":"batch/resource-manager/readme.md", "tag":"package-2022-06", "details":"Using directive.6.suppress which is deprecated and will be removed in the future." |
|
"readme":"batch/resource-manager/readme.md", "tag":"package-2022-06", "details":"Using directive.7.suppress which is deprecated and will be removed in the future." |
|
💬 | "readme":"batch/resource-manager/readme.md", "tag":"package-2022-06", "details":"AutoRest core version selected from configuration: ^3.2.0." |
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
Hi @paterasMSFT, Your PR has some issues. Please fix the CI sequentially by following the order of
|
1 similar comment
Hi @paterasMSFT, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Fixed comments Fixed identifiers Name fix
422c289
to
22e786e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good
Hi, @paterasMSFT your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
specification/batch/resource-manager/Microsoft.Batch/stable/2022-06-01/BatchManagement.json
Show resolved
Hide resolved
@raych1 this PR is ready to be merged (the two failing checks are expected). Can you help me get that done? It's blocking a few things. Thanks! |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Some comments and identifiers from the previous version were accidentally overwritten in this version when it was recently published. This PR reverts those changes.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.