-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compute swagger remove duplicate RP folder #20103
Conversation
Hi, @grizzlytheodore Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
compared swaggers (via Oad v0.9.6)] | new version | base version |
---|---|---|
2022-04-04 | 2022-04-04(da2ba75) | 2022-04-04(main) |
2022-03-01 | 2022-03-01(da2ba75) | 2022-03-01(main) |
2022-03-02 | 2022-03-02(da2ba75) | 2022-03-02(main) |
2022-01-03 | 2022-01-03(da2ba75) | 2022-01-03(main) |
CloudServiceRP | 2022-04-04(da2ba75) | 2022-04-04(main) |
ComputeRP | 2022-03-01(da2ba75) | 2022-03-01(main) |
DiskRP | 2022-03-02(da2ba75) | 2022-03-02(main) |
GalleryRP | 2022-01-03(da2ba75) | 2022-01-03(main) |
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/roleInstances/{roleInstanceName}' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L37:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/roleInstances/{roleInstanceName}/instanceView' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L167:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/roleInstances' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L224:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/roleInstances/{roleInstanceName}/restart' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L291:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/roleInstances/{roleInstanceName}/reimage' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L349:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/roleInstances/{roleInstanceName}/rebuild' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L407:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/roleInstances/{roleInstanceName}/remoteDesktopFile' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L465:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/roles/{roleName}' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L526:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/roles' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L583:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L636:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/instanceView' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L867:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Compute/cloudServices' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L917:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L956:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/start' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1002:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/poweroff' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1053:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/restart' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1104:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/reimage' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1163:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/rebuild' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1222:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/delete' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1281:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/updateDomains/{updateDomain}' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1340:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/updateDomains' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1463:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Compute/locations/{location}/cloudServiceOsVersions/{osVersionName}' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1516:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Compute/locations/{location}/cloudServiceOsVersions' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1566:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Compute/locations/{location}/cloudServiceOsFamilies/{osFamilyName}' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1612:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Compute/locations/{location}/cloudServiceOsFamilies' removed or restructured? Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1662:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/availabilitySets/{availabilitySetName}' removed or restructured? Old: stable/2022-03-01/ComputeRP/availabilitySet.json#L37:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Compute/availabilitySets' removed or restructured? Old: stable/2022-03-01/ComputeRP/availabilitySet.json#L258:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/availabilitySets' removed or restructured? Old: stable/2022-03-01/ComputeRP/availabilitySet.json#L304:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/availabilitySets/{availabilitySetName}/vmSizes' removed or restructured? Old: stable/2022-03-01/ComputeRP/availabilitySet.json#L353:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/capacityReservationGroups/{capacityReservationGroupName}' removed or restructured? Old: stable/2022-03-01/ComputeRP/capacityReservation.json#L37:5 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️🔄
LintDiff inProgress [Detail]
️⚠️
Avocado: 2 Warnings warning [Detail]
Rule | Message |
---|---|
The default tag contains multiple API versions swaggers. readme: specification/compute/resource-manager/readme.md tag: specification/compute/resource-manager/readme.md#tag-package-2022-04-04 |
|
The JSON file has a circular reference. readme: specification/compute/resource-manager/readme.md json: ComputeRP/stable/2022-03-01/virtualMachine.json |
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️❌
ModelValidation: 1 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
SECRET_PROPERTY |
Secret property "adminPassword" cannot be sent in the response Url: ComputeRP/stable/2022-03-01/computeRPCommon.json#L1362:26 ExampleUrl: 2022-03-01/examples/restorePointExamples/RestorePointCollections_Update_MaximumSet_Gen.json#L99:38 |
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️
SDK Track2 Validation: 0 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/da2ba759acb6bc1c01ef3b80c396a6da5603a055/specification/compute/resource-manager/readme.md#tag-package-2022-04-04">compute/resource-manager/readme.md#package-2022-04-04
- "https://github.com/Azure/azure-rest-api-specs/blob/da2ba759acb6bc1c01ef3b80c396a6da5603a055/specification/compute/resource-manager/readme.md#tag-package-2022-04-04-only">compute/resource-manager/readme.md#package-2022-04-04-only
- "https://github.com/Azure/azure-rest-api-specs/blob/da2ba759acb6bc1c01ef3b80c396a6da5603a055/specification/compute/resource-manager/readme.md#tag-package-2022-03-02">compute/resource-manager/readme.md#package-2022-03-02
- "https://github.com/Azure/azure-rest-api-specs/blob/da2ba759acb6bc1c01ef3b80c396a6da5603a055/specification/compute/resource-manager/readme.md#tag-package-2022-03-02-only">compute/resource-manager/readme.md#package-2022-03-02-only
- "https://github.com/Azure/azure-rest-api-specs/blob/da2ba759acb6bc1c01ef3b80c396a6da5603a055/specification/compute/resource-manager/readme.md#tag-package-2022-01-03">compute/resource-manager/readme.md#package-2022-01-03
- "https://github.com/Azure/azure-rest-api-specs/blob/da2ba759acb6bc1c01ef3b80c396a6da5603a055/specification/compute/resource-manager/readme.md#tag-package-2022-01-03-only">compute/resource-manager/readme.md#package-2022-01-03-only
- "https://github.com/Azure/azure-rest-api-specs/blob/da2ba759acb6bc1c01ef3b80c396a6da5603a055/specification/compute/resource-manager/readme.md#tag-package-2022-03-01">compute/resource-manager/readme.md#package-2022-03-01
- "https://github.com/Azure/azure-rest-api-specs/blob/da2ba759acb6bc1c01ef3b80c396a6da5603a055/specification/compute/resource-manager/readme.md#tag-package-2022-03-01-only">compute/resource-manager/readme.md#package-2022-03-01-only
Rule | Message |
---|---|
PreCheck/DuplicateSchema |
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-04-04", "details":"Duplicate Schema named 'PurchasePlan' (1 differences):\n - properties.promotionCode: => "$ref":"#/components/schemas/schemas:1403", "description":"The Offer Promotion Code."; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-04-04", "details":"Error: 1 errors occured -- cannot continue." |
PreCheck/DuplicateSchema |
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-02", "details":"Duplicate Schema named 'PurchasePlan' (1 differences):\n - properties.promotionCode: => "$ref":"#/components/schemas/schemas:1400", "description":"The Offer Promotion Code."; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-02", "details":"Error: 1 errors occured -- cannot continue." |
PreCheck/DuplicateSchema |
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-01-03", "details":"Duplicate Schema named 'PurchasePlan' (1 differences):\n - properties.promotionCode: => "$ref":"#/components/schemas/schemas:1495", "description":"The Offer Promotion Code."; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-01-03", "details":"Error: 1 errors occured -- cannot continue." |
PreCheck/DuplicateSchema |
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-01", "details":"Duplicate Schema named 'PurchasePlan' (1 differences):\n - properties.promotionCode: => "$ref":"#/components/schemas/schemas:1535", "description":"The Offer Promotion Code."; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that." |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-01", "details":"Error: 1 errors occured -- cannot continue." |
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-04-04-only", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-02-only", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-01-03-only", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
|
"readme":"compute/resource-manager/readme.md", "tag":"package-2022-03-01-only", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
Swagger Generation Artifacts
|
Generated ApiView
|
Hi @grizzlytheodore, Your PR has some issues. Please fix the CI sequentially by following the order of
|
Hi @grizzlytheodore, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
NewApiVersionRequired reason: |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
There are errors caused by too long of swagger file path name,
so as requested, updating to remove duplicate RP folder in the path.
Some files were:
Microsoft.Compute/ComputeRP/stable/2022-03-01/ComputeRP/virtualmachine.json
changed to
Microsoft.Compute/ComputeRP/stable/2022-03-01/virtualmachine.json
I have 4 commit that are easy to keep track of what is happening
4,5. updating readme files
The changes I’ve made were easy to test, because the duplicate RP folders are only happening for the 4 RP versions that are in the latest readme tag for generating SDK. So I generated the SDK to see if any changes were made.
And no unexpected changes are made in the generated SDK.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.