Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute swagger remove duplicate RP folder #20103

Merged
merged 5 commits into from
Aug 5, 2022

Conversation

grizzlytheodore
Copy link
Member

@grizzlytheodore grizzlytheodore commented Aug 4, 2022

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

There are errors caused by too long of swagger file path name,
so as requested, updating to remove duplicate RP folder in the path.

Some files were:
Microsoft.Compute/ComputeRP/stable/2022-03-01/ComputeRP/virtualmachine.json
changed to
Microsoft.Compute/ComputeRP/stable/2022-03-01/virtualmachine.json

I have 4 commit that are easy to keep track of what is happening

  1. Moving swagger files out of the inner duplicate RP folder
  2. Updating references in readme file
  3. Updating the moved swagger files where they reference common.json
    4,5. updating readme files

The changes I’ve made were easy to test, because the duplicate RP folders are only happening for the 4 RP versions that are in the latest readme tag for generating SDK. So I generated the SDK to see if any changes were made.
And no unexpected changes are made in the generated SDK.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. If updating an existing version, please select the specific language SDKs and CLIs that must be refreshed after the swagger is published.
    • SDK of .NET (need service team to ensure code readiness)
    • SDK of Python
    • SDK of Java
    • SDK of Js
    • SDK of Go
    • PowerShell
    • CLI
    • Terraform
    • No refresh required for updates in this PR

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following appy to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in a stable version
  • Removing properties in a stable version
  • Removing API version(s) in a stable version
  • Updating API in a stable or public preview version with Breaking Change Validation errors
  • Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @grizzlytheodore Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 4, 2022

    Swagger Validation Report

    ️❌BreakingChange: 672 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.9.6)] new version base version
    2022-04-04 2022-04-04(da2ba75) 2022-04-04(main)
    2022-03-01 2022-03-01(da2ba75) 2022-03-01(main)
    2022-03-02 2022-03-02(da2ba75) 2022-03-02(main)
    2022-01-03 2022-01-03(da2ba75) 2022-01-03(main)
    CloudServiceRP 2022-04-04(da2ba75) 2022-04-04(main)
    ComputeRP 2022-03-01(da2ba75) 2022-03-01(main)
    DiskRP 2022-03-02(da2ba75) 2022-03-02(main)
    GalleryRP 2022-01-03(da2ba75) 2022-01-03(main)

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/roleInstances/{roleInstanceName}' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L37:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/roleInstances/{roleInstanceName}/instanceView' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L167:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/roleInstances' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L224:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/roleInstances/{roleInstanceName}/restart' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L291:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/roleInstances/{roleInstanceName}/reimage' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L349:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/roleInstances/{roleInstanceName}/rebuild' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L407:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/roleInstances/{roleInstanceName}/remoteDesktopFile' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L465:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/roles/{roleName}' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L526:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/roles' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L583:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L636:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/instanceView' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L867:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Compute/cloudServices' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L917:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L956:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/start' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1002:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/poweroff' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1053:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/restart' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1104:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/reimage' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1163:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/rebuild' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1222:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/delete' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1281:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/updateDomains/{updateDomain}' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1340:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/cloudServices/{cloudServiceName}/updateDomains' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1463:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Compute/locations/{location}/cloudServiceOsVersions/{osVersionName}' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1516:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Compute/locations/{location}/cloudServiceOsVersions' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1566:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Compute/locations/{location}/cloudServiceOsFamilies/{osFamilyName}' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1612:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Compute/locations/{location}/cloudServiceOsFamilies' removed or restructured?
    Old: stable/2022-04-04/CloudServiceRP/cloudService.json#L1662:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/availabilitySets/{availabilitySetName}' removed or restructured?
    Old: stable/2022-03-01/ComputeRP/availabilitySet.json#L37:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Compute/availabilitySets' removed or restructured?
    Old: stable/2022-03-01/ComputeRP/availabilitySet.json#L258:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/availabilitySets' removed or restructured?
    Old: stable/2022-03-01/ComputeRP/availabilitySet.json#L304:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/availabilitySets/{availabilitySetName}/vmSizes' removed or restructured?
    Old: stable/2022-03-01/ComputeRP/availabilitySet.json#L353:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Compute/capacityReservationGroups/{capacityReservationGroupName}' removed or restructured?
    Old: stable/2022-03-01/ComputeRP/capacityReservation.json#L37:5
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️🔄LintDiff inProgress [Detail]
    ️⚠️Avocado: 2 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/compute/resource-manager/readme.md
    tag: specification/compute/resource-manager/readme.md#tag-package-2022-04-04
    ⚠️ CIRCULAR_REFERENCE The JSON file has a circular reference.
    readme: specification/compute/resource-manager/readme.md
    json: ComputeRP/stable/2022-03-01/virtualMachine.json
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌ModelValidation: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    SECRET_PROPERTY Secret property "adminPassword" cannot be sent in the response
    Url: ComputeRP/stable/2022-03-01/computeRPCommon.json#L1362:26
    ExampleUrl: 2022-03-01/examples/restorePointExamples/RestorePointCollections_Update_MaximumSet_Gen.json#L99:38
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️⚠️SDK Track2 Validation: 0 Warnings warning [Detail]
    • The following tags are being changed in this PR
      • "https://github.com/Azure/azure-rest-api-specs/blob/da2ba759acb6bc1c01ef3b80c396a6da5603a055/specification/compute/resource-manager/readme.md#tag-package-2022-04-04">compute/resource-manager/readme.md#package-2022-04-04
      • "https://github.com/Azure/azure-rest-api-specs/blob/da2ba759acb6bc1c01ef3b80c396a6da5603a055/specification/compute/resource-manager/readme.md#tag-package-2022-04-04-only">compute/resource-manager/readme.md#package-2022-04-04-only
      • "https://github.com/Azure/azure-rest-api-specs/blob/da2ba759acb6bc1c01ef3b80c396a6da5603a055/specification/compute/resource-manager/readme.md#tag-package-2022-03-02">compute/resource-manager/readme.md#package-2022-03-02
      • "https://github.com/Azure/azure-rest-api-specs/blob/da2ba759acb6bc1c01ef3b80c396a6da5603a055/specification/compute/resource-manager/readme.md#tag-package-2022-03-02-only">compute/resource-manager/readme.md#package-2022-03-02-only
      • "https://github.com/Azure/azure-rest-api-specs/blob/da2ba759acb6bc1c01ef3b80c396a6da5603a055/specification/compute/resource-manager/readme.md#tag-package-2022-01-03">compute/resource-manager/readme.md#package-2022-01-03
      • "https://github.com/Azure/azure-rest-api-specs/blob/da2ba759acb6bc1c01ef3b80c396a6da5603a055/specification/compute/resource-manager/readme.md#tag-package-2022-01-03-only">compute/resource-manager/readme.md#package-2022-01-03-only
      • "https://github.com/Azure/azure-rest-api-specs/blob/da2ba759acb6bc1c01ef3b80c396a6da5603a055/specification/compute/resource-manager/readme.md#tag-package-2022-03-01">compute/resource-manager/readme.md#package-2022-03-01
      • "https://github.com/Azure/azure-rest-api-specs/blob/da2ba759acb6bc1c01ef3b80c396a6da5603a055/specification/compute/resource-manager/readme.md#tag-package-2022-03-01-only">compute/resource-manager/readme.md#package-2022-03-01-only
    The following errors/warnings exist before current PR submission:
    Rule Message
    PreCheck/DuplicateSchema "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-04-04",
    "details":"Duplicate Schema named 'PurchasePlan' (1 differences):\n - properties.promotionCode: => "$ref":"#/components/schemas/schemas:1403",
    "description":"The Offer Promotion Code."; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-04-04",
    "details":"Error: 1 errors occured -- cannot continue."
    PreCheck/DuplicateSchema "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-03-02",
    "details":"Duplicate Schema named 'PurchasePlan' (1 differences):\n - properties.promotionCode: => "$ref":"#/components/schemas/schemas:1400",
    "description":"The Offer Promotion Code."; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-03-02",
    "details":"Error: 1 errors occured -- cannot continue."
    PreCheck/DuplicateSchema "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-01-03",
    "details":"Duplicate Schema named 'PurchasePlan' (1 differences):\n - properties.promotionCode: => "$ref":"#/components/schemas/schemas:1495",
    "description":"The Offer Promotion Code."; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-01-03",
    "details":"Error: 1 errors occured -- cannot continue."
    PreCheck/DuplicateSchema "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-03-01",
    "details":"Duplicate Schema named 'PurchasePlan' (1 differences):\n - properties.promotionCode: => "$ref":"#/components/schemas/schemas:1535",
    "description":"The Offer Promotion Code."; This error can be temporarily avoided by using the 'modelerfour.lenient-model-deduplication' setting. NOTE: This setting will be removed in a future version of @autorest/modelerfour; schemas should be updated to fix this issue sooner than that."
    "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-03-01",
    "details":"Error: 1 errors occured -- cannot continue."
    ⚠️ UnkownSecurityScheme "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-04-04-only",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-03-02-only",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-01-03-only",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ⚠️ UnkownSecurityScheme "readme":"compute/resource-manager/readme.md",
    "tag":"package-2022-03-01-only",
    "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken,
    AzureKey,
    Anonymous"
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 4, 2022

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-js - @azure/arm-compute - 20.0.0
    +	Enum KnownOrchestrationServiceNames no longer has value DummyOrchestrationServiceName
    ️✔️azure-sdk-for-python-track2 - track2_azure-mgmt-compute - 27.2.0
    azure-sdk-for-go - armcompute - 4.0.0
    ️❌ azure-sdk-for-net failed [Detail]
    • Failed [Logs]Release - Generate from a31c376. SDK Automation 14.0.0
      warn	Skip initScript due to not configured
      command	sudo apt-get install -y dotnet-sdk-6.0
      command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/compute/resource-manager/readme.md
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] realpath(): Permission denied
      cmderr	[Autorest] No usable version of the libssl was found
      cmderr	[Autorest] FATAL: csharp/simplifier - FAILED
      cmderr	[Autorest] FATAL: Error: [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      cmderr	[Autorest] Process() cancelled due to exception : [Exception] AutoRest extension '@microsoft.azure/autorest.csharp' terminated.
      error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-net]: autorest
      warn	Skip package processing as generation is failed
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a31c376. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]  config global `--global`, `--local` are deprecated. Use `--location=global` instead.
    • ️✔️track2_azure-mgmt-compute [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from a31c376. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
      cmderr	[automation_generate.sh] npm notice[ERROR] Cannot generate changelog because the codes of local and npm may be the same.
    • ️✔️@azure/arm-compute [View full logs]  [Release SDK Changes]
      info	[Changelog]
      error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from a31c376. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️armcompute [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `SharingProfile.CommunityGalleryInfo` has been changed from `interface{}` to `*CommunityGalleryInfo`
      info	[Changelog]
      info	[Changelog] Total 1 breaking change(s), 0 additive change(s).
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from a31c376. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    • ️✔️compute [View full logs]  [Release Schema Changes]
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from a31c376. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.compute [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Aug 4, 2022

    Generated ApiView

    Language Package Name ApiView Link
    Java azure-resourcemanager-compute-generated Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. If issue still exists, please ask PR assignee for help
    JavaScript @azure/arm-compute Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. If issue still exists, please ask PR assignee for help
    Python track2_azure-mgmt-compute Create ApiView failed. Please ensure your github account in Azure/Microsoft is public and add a comment "/azp run" to re-trigger the CI. If issue still exists, please ask PR assignee for help

    @openapi-workflow-bot
    Copy link

    Hi @grizzlytheodore, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi @grizzlytheodore, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    NewApiVersionRequired reason:

    A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

    EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

    @grizzlytheodore grizzlytheodore changed the title Feature/cplat compute restructure2 compute swagger remove duplicate RP folder Aug 4, 2022
    @grizzlytheodore grizzlytheodore removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 4, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants