[Hub Generated] Review request for Microsoft.MachineLearningServices to add version preview/2022-10-01-preview #20818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… preview/2022-06-01-preview to version 2022-10-01-preview
* Registries public preview 2022-10-01-preview * Fix validation errors * Fix LintDiff and Avocado errors * Fixing prettier errors * Fixing more LintDiff errors * Another LintDiff error * Another Lint error Co-authored-by: Fahd Kamal <[email protected]>
* added schedule api * add updateSchedules to examples parent folder * fix typo * change position of allOf * remove subnet from example compute create * after prettier run * Description change for recurrence freq * point to mfe for common objects * add hash operator * removed triggertype as well * change year * get rid of breaking changes since we didn't change the api Co-authored-by: Naman Agarwal <[email protected]>
* Added CI Os Patching related properties * Updated descriptions as per Dennis's suggestions Co-authored-by: Srivatsa Sinha <[email protected]>
* Added changes to sync with main * Fixed Prettier Check Co-authored-by: maulikjoshi <[email protected]>
* change post call to put * change put to patch * remove updateschedules rest call Co-authored-by: Naman Agarwal <[email protected]>
* Update connection type and auth type * update connection category * update x-ms-secret tag
* Add autologger_settings for CI Add settings to opt-in/out of default mlflow autologger on CIs. * update machinelearningservices.json * Add for command job * fix comma * Add autologger for command job * fix CI failures * Remove mfe.json from PR * Remove whitespace * Update custom-words.txt * Delete incorrect custom-words.txt
* Fixing auto-rest issues in registries * Removing location from the required list Co-authored-by: Fahd Kamal <[email protected]>
* Added mfe.json preview changes * Added resources to Registries and Workspaces folder * removed unwanted resources * removed unwanted resources * Ran prettier check * removed unwanted resources * removed unwanted resources * Added ManagedOnlineDeployment resource * Added files to OnlineDeplyment * Added Model Validation changes * Added mfe.json changes to handle duplicate operation id changes * Updated mfe to fix underscore error * Update title of mfe.json * Renamed name path parameter * Updated examples * Fixed Semantic validations and examples * Fixed Semantic validations and examples * Fixed Semantic validations and examples * Removed name changes from workspaces * Changes related to Model Validation * Changes related to Model validation * Added consumes amd produces in registries.json * Removed changes from registries * Updated parameter mlFlowAutologger to mlflowAutologger in mfe.json * Changed property name to mlflowAutologger Co-authored-by: maulikjoshi <[email protected]>
|
Hi, @Maulik003 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
|
Swagger pipeline can not start as the pull request has merge conflicts. |
|
Swagger pipeline can not start as the pull request has merge conflicts. |
|
Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
|
Hi, @Maulik003 your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board([email protected]). |
openapi-workflow-bot
bot
added
ARMReview
WaitForARMFeedback
Maulik003
changed the title
* Updated custom words to resolve merge conflict * Updated custom words to resolve merge conflict Co-authored-by: maulikjoshi <[email protected]>
|
Swagger pipeline can not start as the pull request has merge conflicts. |
1 similar comment
|
Swagger pipeline can not start as the pull request has merge conflicts. |
|
Swagger pipeline started successfully. If there is ApiView generated, it will be updated in this comment. |
Co-authored-by: maulikjoshi <[email protected]>
Swagger Validation Report
|
| compared swaggers (via Oad v0.9.7)] | new version | base version |
|---|---|---|
| machineLearningServices.json | 2022-10-01-preview(248020b) | 2022-10-01(main) |
| machineLearningServices.json | 2022-10-01-preview(248020b) | 2022-06-01-preview(main) |
| mfe.json | 2022-10-01-preview(248020b) | 2022-10-01(main) |
| mfe.json | 2022-10-01-preview(248020b) | 2022-06-01-preview(main) |
| workspaceFeatures.json | 2022-10-01-preview(248020b) | 2022-10-01(main) |
| workspaceFeatures.json | 2022-10-01-preview(248020b) | 2022-06-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 15 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with the latest preview version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 11 Errors, 77 Warnings failed [Detail]
| compared tags (via openapi-validator v1.13.0) | new version | base version |
|---|---|---|
| package-preview-2022-10 | package-preview-2022-10(248020b) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 15 items are listed, please refer to log for more details.
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json#L10024 |
|
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json#L10089 |
|
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json#L10310 |
|
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json#L10387 |
|
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json#L11535 |
|
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json#L11665 |
|
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json#L14160 |
|
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json#L14178 |
|
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json#L14715 |
|
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json#L14836 |
|
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json#L17417 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json#L14269 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/registries.json#L389 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/registries.json#L554 |
||
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/registries.json#L592 |
The following errors/warnings exist before current PR submission:
Only 15 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json#L9338 |
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json#L9424 |
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json#L11631 |
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json#L13333 |
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json#L15360 |
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json#L15460 |
|
When property is modeled as 'readOnly': true then x-ms-mutability extension can only have 'read' value. When property is modeled as 'readOnly': false then applying x-ms-mutability extension with only 'read' value is not allowed. Extension contains invalid values: 'read'. Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/mfe.json#L16575 |
|
Collection object 'AmlComputeNodesInformation' returned by list operation 'Compute_ListNodes' with 'x-ms-pageable' extension, has no property named 'value'. Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/machineLearningServices.json#L1089 |
| Since operation 'QuotasUpdate' response has model definition 'array', it should be of the form 'list'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/machineLearningServices.json#L567 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/machineLearningServices.json#L3266 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/machineLearningServices.json#L3368 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/machineLearningServices.json#L3463 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/machineLearningServices.json#L3676 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/machineLearningServices.json#L3875 |
|
| Consider using x-ms-client-flatten to provide a better end user experience Location: Microsoft.MachineLearningServices/preview/2022-10-01-preview/machineLearningServices.json#L3896 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The JSON file has a circular reference. readme: specification/machinelearningservices/resource-manager/readme.md json: Microsoft.MachineLearningServices/preview/2022-10-01-preview/machineLearningServices.json |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️⚠️~[Staging] TrafficValidation: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️❌ModelValidation: 10 Errors, 0 Warnings failed [Detail]
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️⚠️SDK Track2 Validation: 1 Warnings warning [Detail]
- The following tags are being changed in this PR
- "https://github.com/Azure/azure-rest-api-specs/blob/248020b016a81f45c2c1cbf8d5310192b84aeb21/specification/machinelearningservices/resource-manager/readme.md#tag-package-preview-2022-10">machinelearningservices/resource-manager/readme.md#package-preview-2022-10
| Rule | Message |
|---|---|
| "readme":"machinelearningservices/resource-manager/readme.md", "tag":"package-preview-2022-10", "details":"Security scheme azure_auth is unknown and will not be processed. Only supported types are AADToken, AzureKey, Anonymous" |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
|
@msyyc @qiaozha @ArcturusZhang could you help confirm the SDK breaking change ? |
mentat9
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
* Resolved merge conflict * Resolved merge conflict Co-authored-by: maulikjoshi <[email protected]>
|
/azp run |
|
Pull request contains merge conflicts. |
…to add version stable/2022-10-01 (#20800) (#20982) * Adds base for updating Microsoft.MachineLearningServices from version stable/2022-05-01 to version 2022-10-01 * Updates readme * Updates API version in new specs and examples * Added readOnly property (#20506) * Added readOnly property * Added changes to sync with main * Fixed Prettier check Co-authored-by: maulikjoshi <[email protected]> * Add schedule related schemas for Compute Instance (#20697) * support for update schedules on Compute Instance * change put to patch * remove update schedules rest call Co-authored-by: Naman Agarwal <[email protected]> * Added mfe.json changes (#20514) * Added mfe.json changes * Added checks related changes * Updated mfe.json to handle online endpoint and deployment changes * Updated mfe.json with AutoRebuild changes Co-authored-by: maulikjoshi <[email protected]> * Removed duplicate definitions and updated with mfe references (#20840) * Removed duplicate definitions and updated with mfe references * Replaced Cron to CronTrigger, Recurrence to RecurrenceTrigger from mfe Co-authored-by: maulikjoshi <[email protected]> Co-authored-by: maulikjoshi <[email protected]> Co-authored-by: Naman Agarwal <[email protected]> Co-authored-by: Naman Agarwal <[email protected]> Co-authored-by: maulikjoshi <[email protected]> Co-authored-by: Naman Agarwal <[email protected]> Co-authored-by: Naman Agarwal <[email protected]>
#20983) * Revert "[Hub Generated] Review request for Microsoft.MachineLearningServices to add version stable/2022-10-01 (#20800) (#20982)" This reverts commit 649ef83. * Updated readme.md to resolve merge conflict Co-authored-by: maulikjoshi <[email protected]>
* Merged readme from main * Added preview tag changes Co-authored-by: maulikjoshi <[email protected]>
AzureRestAPISpecReview
added
the
BreakingChangeReviewRequired
|
Hi @Maulik003, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
weshaggard
deleted the
dev-machinelearningservices-Microsoft.MachineLearningServices-2022-10-01-preview
branch
This was referenced Oct 5, 2022
ghost
pushed a commit
to Azure/azure-resource-manager-schemas
that referenced
this pull request
Oct 6, 2022
…r Microsoft.MachineLearningServices to add version preview/2022-10-01-preview (#2597) Create to sync Azure/azure-rest-api-specs#20818 [ReCreate this PR](https://github.com/azure-resource-manager-schemas/compare/main...azure-sdk:sdkAuto/machinelearningservices?expand=1)
anandanthony
pushed a commit
to anandMicro/azure-rest-api-specs
that referenced
this pull request
Dec 16, 2022
…to add version preview/2022-10-01-preview (Azure#20818) * Adds base for updating Microsoft.MachineLearningServices from version preview/2022-06-01-preview to version 2022-10-01-preview * Updates readme * Updates API version in new specs and examples * Registries public preview 2022-10-01-preview (Azure#20200) * Registries public preview 2022-10-01-preview * Fix validation errors * Fix LintDiff and Avocado errors * Fixing prettier errors * Fixing more LintDiff errors * Another LintDiff error * Another Lint error Co-authored-by: Fahd Kamal <[email protected]> * Added schedule api (Azure#20273) * added schedule api * add updateSchedules to examples parent folder * fix typo * change position of allOf * remove subnet from example compute create * after prettier run * Description change for recurrence freq * point to mfe for common objects * add hash operator * removed triggertype as well * change year * get rid of breaking changes since we didn't change the api Co-authored-by: Naman Agarwal <[email protected]> * Added Compute Instance OS Patching Properties (Azure#20284) * Added CI Os Patching related properties * Updated descriptions as per Dennis's suggestions Co-authored-by: Srivatsa Sinha <[email protected]> * Maulik/sync preview (Azure#20554) * Added changes to sync with main * Fixed Prettier Check Co-authored-by: maulikjoshi <[email protected]> * Remove update schedules REST call for compute instance (Azure#20699) * change post call to put * change put to patch * remove updateschedules rest call Co-authored-by: Naman Agarwal <[email protected]> * Update connection type and auth type (Azure#20493) * Update connection type and auth type * update connection category * update x-ms-secret tag * Add autologger_settings for CI (Azure#20302) * Add autologger_settings for CI Add settings to opt-in/out of default mlflow autologger on CIs. * update machinelearningservices.json * Add for command job * fix comma * Add autologger for command job * fix CI failures * Remove mfe.json from PR * Remove whitespace * Update custom-words.txt * Delete incorrect custom-words.txt * Fixing auto-rest issues in registries (Azure#20772) * Fixing auto-rest issues in registries * Removing location from the required list Co-authored-by: Fahd Kamal <[email protected]> * Maulik/mfe preview changes (Azure#20372) * Added mfe.json preview changes * Added resources to Registries and Workspaces folder * removed unwanted resources * removed unwanted resources * Ran prettier check * removed unwanted resources * removed unwanted resources * Added ManagedOnlineDeployment resource * Added files to OnlineDeplyment * Added Model Validation changes * Added mfe.json changes to handle duplicate operation id changes * Updated mfe to fix underscore error * Update title of mfe.json * Renamed name path parameter * Updated examples * Fixed Semantic validations and examples * Fixed Semantic validations and examples * Fixed Semantic validations and examples * Removed name changes from workspaces * Changes related to Model Validation * Changes related to Model validation * Added consumes amd produces in registries.json * Removed changes from registries * Updated parameter mlFlowAutologger to mlflowAutologger in mfe.json * Changed property name to mlflowAutologger Co-authored-by: maulikjoshi <[email protected]> * Updated custom words to resolve merge conflict (Azure#20833) * Updated custom words to resolve merge conflict * Updated custom words to resolve merge conflict Co-authored-by: maulikjoshi <[email protected]> * Resolved merge conflict (Azure#20845) Co-authored-by: maulikjoshi <[email protected]> * Fixed LintDiff checks (Azure#20847) * Fixed LintDiff checks * Fixed LintDiff checks * Fixed LintDiff checks * Fixed LintDiff checks * Updated examples Co-authored-by: maulikjoshi <[email protected]> * Resolved merge conflict of cutsom-words.txt (Azure#20956) * Resolved merge conflict * Resolved merge conflict Co-authored-by: maulikjoshi <[email protected]> * [Hub Generated] Review request for Microsoft.MachineLearningServices to add version stable/2022-10-01 (Azure#20800) (Azure#20982) * Adds base for updating Microsoft.MachineLearningServices from version stable/2022-05-01 to version 2022-10-01 * Updates readme * Updates API version in new specs and examples * Added readOnly property (Azure#20506) * Added readOnly property * Added changes to sync with main * Fixed Prettier check Co-authored-by: maulikjoshi <[email protected]> * Add schedule related schemas for Compute Instance (Azure#20697) * support for update schedules on Compute Instance * change put to patch * remove update schedules rest call Co-authored-by: Naman Agarwal <[email protected]> * Added mfe.json changes (Azure#20514) * Added mfe.json changes * Added checks related changes * Updated mfe.json to handle online endpoint and deployment changes * Updated mfe.json with AutoRebuild changes Co-authored-by: maulikjoshi <[email protected]> * Removed duplicate definitions and updated with mfe references (Azure#20840) * Removed duplicate definitions and updated with mfe references * Replaced Cron to CronTrigger, Recurrence to RecurrenceTrigger from mfe Co-authored-by: maulikjoshi <[email protected]> Co-authored-by: maulikjoshi <[email protected]> Co-authored-by: Naman Agarwal <[email protected]> Co-authored-by: Naman Agarwal <[email protected]> Co-authored-by: maulikjoshi <[email protected]> Co-authored-by: Naman Agarwal <[email protected]> Co-authored-by: Naman Agarwal <[email protected]> * Revert "[Hub Generated] Review request for Microsoft.MachineLearningS… (Azure#20983) * Revert "[Hub Generated] Review request for Microsoft.MachineLearningServices to add version stable/2022-10-01 (Azure#20800) (Azure#20982)" This reverts commit 649ef83. * Updated readme.md to resolve merge conflict Co-authored-by: maulikjoshi <[email protected]> * Maulik/fix preview (Azure#20994) * Merged readme from main * Added preview tag changes Co-authored-by: maulikjoshi <[email protected]> * shuffle readme tags (Azure#21005) * conflict resolution (Azure#21007) Co-authored-by: fahdkmsft <[email protected]> Co-authored-by: Fahd Kamal <[email protected]> Co-authored-by: Naman Agarwal <[email protected]> Co-authored-by: Naman Agarwal <[email protected]> Co-authored-by: srivatsasinha <[email protected]> Co-authored-by: Srivatsa Sinha <[email protected]> Co-authored-by: maulikjoshi <[email protected]> Co-authored-by: ZhidaLiu <[email protected]> Co-authored-by: prakharg-msft <[email protected]> Co-authored-by: Teddy Todorov <[email protected]>
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.