Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task 16820869: Remove subscription and resource group level test noti… #22279

Merged
merged 5 commits into from
Feb 13, 2023
Merged

Task 16820869: Remove subscription and resource group level test noti… #22279

merged 5 commits into from
Feb 13, 2023

Conversation

thomasp98296
Copy link
Contributor

@thomasp98296 thomasp98296 commented Jan 23, 2023

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

…fication APIs in the new API version 2023-01-01
@openapi-workflow-bot
Copy link

Hi, @thomasp98296 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 23, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 4 Errors, 0 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    actionGroups_API.json 2023-01-01(7b53bb3) 2022-06-01(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Insights/createNotifications' removed or restructured?
    Old: Microsoft.Insights/stable/2022-06-01/actionGroups_API.json#L213:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Insights/createNotifications' removed or restructured?
    Old: Microsoft.Insights/stable/2022-06-01/actionGroups_API.json#L268:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Insights/notificationStatus/{notificationId}' removed or restructured?
    Old: Microsoft.Insights/stable/2022-06-01/actionGroups_API.json#L387:5
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.Insights/notificationStatus/{notificationId}' removed or restructured?
    Old: Microsoft.Insights/stable/2022-06-01/actionGroups_API.json#L423:5
    ️❌CredScan: 0 Errors, 0 Warnings failed [Detail]
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2023-01 package-2023-01(7b53bb3) default(main)
    package-preview-2022-08 package-preview-2022-08(7b53bb3) package-preview-2022-08(main)
    package-composite-v1 package-composite-v1(7b53bb3) package-composite-v1(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ResourceNameRestriction The resource name parameter 'actionGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L39
    ResourceNameRestriction The resource name parameter 'actionGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L39
    ResourceNameRestriction The resource name parameter 'actionGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L39
    ResourceNameRestriction The resource name parameter 'actionGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L213
    ResourceNameRestriction The resource name parameter 'actionGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L213
    ResourceNameRestriction The resource name parameter 'actionGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L213
    OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'ActionGroups' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L220
    OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'ActionGroups' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L220
    OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'ActionGroups' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L220
    ResourceNameRestriction The resource name parameter 'actionGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L274
    ResourceNameRestriction The resource name parameter 'actionGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L274
    ResourceNameRestriction The resource name parameter 'actionGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L274
    OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'ActionGroups' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L277
    OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'ActionGroups' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L277
    OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'ActionGroups' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L277
    ResourceNameRestriction The resource name parameter 'actionGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L391
    ResourceNameRestriction The resource name parameter 'actionGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L391
    ResourceNameRestriction The resource name parameter 'actionGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L391
    DefinitionsPropertiesNamesCamelCase Property name should be camel case.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L519
    DefinitionsPropertiesNamesCamelCase Property name should be camel case.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L519
    DefinitionsPropertiesNamesCamelCase Property name should be camel case.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L519
    DefinitionsPropertiesNamesCamelCase Property name should be camel case.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L523
    DefinitionsPropertiesNamesCamelCase Property name should be camel case.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L523
    DefinitionsPropertiesNamesCamelCase Property name should be camel case.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L523
    DefinitionsPropertiesNamesCamelCase Property name should be camel case.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L527
    DefinitionsPropertiesNamesCamelCase Property name should be camel case.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L527
    DefinitionsPropertiesNamesCamelCase Property name should be camel case.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L527
    DefinitionsPropertiesNamesCamelCase Property name should be camel case.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L531
    DefinitionsPropertiesNamesCamelCase Property name should be camel case.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L531
    DefinitionsPropertiesNamesCamelCase Property name should be camel case.
    Location: Microsoft.Insights/stable/2023-01-01/actionGroups_API.json#L531
    ️❌Avocado: 4 Errors, 1 Warnings failed [Detail]
    Rule Message
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.Insights/createNotifications is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/monitor/resource-manager/readme.md
    json: Microsoft.Insights/stable/2022-06-01/actionGroups_API.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Insights/createNotifications is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/monitor/resource-manager/readme.md
    json: Microsoft.Insights/stable/2022-06-01/actionGroups_API.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.Insights/notificationStatus/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/monitor/resource-manager/readme.md
    json: Microsoft.Insights/stable/2022-06-01/actionGroups_API.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Insights/notificationStatus/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/monitor/resource-manager/readme.md
    json: Microsoft.Insights/stable/2022-06-01/actionGroups_API.json
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/monitor/resource-manager/readme.md
    tag: specification/monitor/resource-manager/readme.md#tag-package-preview-2022-08
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand]
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 23, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/monitor/armmonitor - Approved - 0.9.0
    +	Function `*ActionGroupsClient.BeginCreateNotificationsAtResourceGroupLevel` has been removed
    +	Function `*ActionGroupsClient.BeginPostTestNotifications` has been removed
    +	Function `*ActionGroupsClient.GetTestNotificationsAtResourceGroupLevel` has been removed
    +	Function `*ActionGroupsClient.GetTestNotifications` has been removed
    +	Struct `ActionGroupsClientCreateNotificationsAtResourceGroupLevelResponse` has been removed
    +	Struct `ActionGroupsClientPostTestNotificationsResponse` has been removed

    azure-sdk-for-js - @azure/arm-monitor - Approved - 8.0.0-beta.4
    +	Removed operation ActionGroups.beginPostTestNotifications
    +	Removed operation ActionGroups.beginPostTestNotificationsAndWait
    +	Removed operation ActionGroups.getTestNotifications
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from 47d1d82. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:760
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 760 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • Azure.ResourceManager.Monitor [View full logs]  [Release SDK Changes]
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 47d1d82. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.4.2
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.4.2>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-monitor [View full logs]  [Release SDK Changes]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Model Condition has a new parameter metric_name
      info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter auto_mitigate
      info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter check_workspace_alerts_storage_configured
      info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter identity
      info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter is_workspace_alerts_storage_configured
      info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter public_network_access
      info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter rule_resolve_configuration
      info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter skip_query_validation
      info	[Changelog]   - Model ScheduledQueryRuleResource has a new parameter system_data
      info	[Changelog]   - Model ScheduledQueryRuleResourceCollection has a new parameter next_link
      info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter auto_mitigate
      info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter check_workspace_alerts_storage_configured
      info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter identity
      info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter is_workspace_alerts_storage_configured
      info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter public_network_access
      info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter rule_resolve_configuration
      info	[Changelog]   - Model ScheduledQueryRuleResourcePatch has a new parameter skip_query_validation
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 47d1d82. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/monitor/armmonitor [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Function `*ActionGroupsClient.BeginCreateNotificationsAtResourceGroupLevel` has been removed
      info	[Changelog] - Function `*ActionGroupsClient.GetTestNotifications` has been removed
      info	[Changelog] - Function `*ActionGroupsClient.GetTestNotificationsAtResourceGroupLevel` has been removed
      info	[Changelog] - Function `*ActionGroupsClient.BeginPostTestNotifications` has been removed
      info	[Changelog] - Struct `ActionGroupsClientCreateNotificationsAtResourceGroupLevelResponse` has been removed
      info	[Changelog] - Struct `ActionGroupsClientPostTestNotificationsResponse` has been removed
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New type alias `ActionType` with values `ActionTypeInternal`
      info	[Changelog] - New type alias `IdentityType` with values `IdentityTypeNone`, `IdentityTypeSystemAssigned`, `IdentityTypeUserAssigned`
      info	[Changelog] - New type alias `Origin` with values `OriginSystem`, `OriginUser`, `OriginUserSystem`
      info	[Changelog] - New type alias `ProvisioningState` with values `ProvisioningStateCanceled`, `ProvisioningStateCreating`, `ProvisioningStateDeleting`, `ProvisioningStateFailed`, `ProvisioningStateSucceeded`
      info	[Changelog] - New type alias `PublicNetworkAccess` with values `PublicNetworkAccessDisabled`, `PublicNetworkAccessEnabled`, `PublicNetworkAccessSecuredByPerimeter`
      info	[Changelog] - New function `NewAzureMonitorWorkspacesClient(string, azcore.TokenCredential, *arm.ClientOptions) (*AzureMonitorWorkspacesClient, error)`
      info	[Changelog] - New function `*AzureMonitorWorkspacesClient.Create(context.Context, string, string, AzureMonitorWorkspaceResource, *AzureMonitorWorkspacesClientCreateOptions) (AzureMonitorWorkspacesClientCreateResponse, error)`
      info	[Changelog] - New function `*AzureMonitorWorkspacesClient.Delete(context.Context, string, string, *AzureMonitorWorkspacesClientDeleteOptions) (AzureMonitorWorkspacesClientDeleteResponse, error)`
      info	[Changelog] - New function `*AzureMonitorWorkspacesClient.Get(context.Context, string, string, *AzureMonitorWorkspacesClientGetOptions) (AzureMonitorWorkspacesClientGetResponse, error)`
      info	[Changelog] - New function `*AzureMonitorWorkspacesClient.NewListByResourceGroupPager(string, *AzureMonitorWorkspacesClientListByResourceGroupOptions) *runtime.Pager[AzureMonitorWorkspacesClientListByResourceGroupResponse]`
      info	[Changelog] - New function `*AzureMonitorWorkspacesClient.NewListBySubscriptionPager(*AzureMonitorWorkspacesClientListBySubscriptionOptions) *runtime.Pager[AzureMonitorWorkspacesClientListBySubscriptionResponse]`
      info	[Changelog] - New function `*AzureMonitorWorkspacesClient.Update(context.Context, string, string, *AzureMonitorWorkspacesClientUpdateOptions) (AzureMonitorWorkspacesClientUpdateResponse, error)`
      info	[Changelog] - New function `NewOperationsForMonitorClient(azcore.TokenCredential, *arm.ClientOptions) (*OperationsForMonitorClient, error)`
      info	[Changelog] - New function `*OperationsForMonitorClient.NewListPager(*OperationsForMonitorClientListOptions) *runtime.Pager[OperationsForMonitorClientListResponse]`
      info	[Changelog] - New struct `AzureMonitorWorkspace`
      info	[Changelog] - New struct `AzureMonitorWorkspaceDefaultIngestionSettings`
      info	[Changelog] - New struct `AzureMonitorWorkspaceMetrics`
      info	[Changelog] - New struct `AzureMonitorWorkspaceResource`
      info	[Changelog] - New struct `AzureMonitorWorkspaceResourceForUpdate`
      info	[Changelog] - New struct `AzureMonitorWorkspaceResourceListResult`
      info	[Changelog] - New struct `AzureMonitorWorkspaceResourceProperties`
      info	[Changelog] - New struct `AzureMonitorWorkspacesClient`
      info	[Changelog] - New struct `AzureMonitorWorkspacesClientListByResourceGroupResponse`
      info	[Changelog] - New struct `AzureMonitorWorkspacesClientListBySubscriptionResponse`
      info	[Changelog] - New struct `ErrorDetailAutoGenerated`
      info	[Changelog] - New struct `ErrorResponseAutoGenerated2`
      info	[Changelog] - New struct `Identity`
      info	[Changelog] - New struct `IngestionSettings`
      info	[Changelog] - New struct `Metrics`
      info	[Changelog] - New struct `OperationAutoGenerated`
      info	[Changelog] - New struct `OperationDisplayAutoGenerated`
      info	[Changelog] - New struct `OperationListResultAutoGenerated`
      info	[Changelog] - New struct `OperationsForMonitorClient`
      info	[Changelog] - New struct `OperationsForMonitorClientListResponse`
      info	[Changelog] - New struct `ResourceAutoGenerated5`
      info	[Changelog] - New struct `RuleResolveConfiguration`
      info	[Changelog] - New struct `TrackedResourceAutoGenerated`
      info	[Changelog] - New struct `UserIdentityProperties`
      info	[Changelog] - New field `PublicNetworkAccess` in struct `ScheduledQueryRuleProperties`
      info	[Changelog] - New field `RuleResolveConfiguration` in struct `ScheduledQueryRuleProperties`
      info	[Changelog] - New field `Identity` in struct `ScheduledQueryRuleResource`
      info	[Changelog] - New field `Identity` in struct `ScheduledQueryRuleResourcePatch`
      info	[Changelog]
      info	[Changelog] Total 8 breaking change(s), 80 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 47d1d82. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-monitor [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Interface PrivateLinkResource
      info	[Changelog]   - Added Interface PrivateLinkServiceConnectionState
      info	[Changelog]   - Added Interface ProxyResourceAutoGenerated
      info	[Changelog]   - Added Interface ResourceAutoGenerated2
      info	[Changelog]   - Added Interface ResourceAutoGenerated3
      info	[Changelog]   - Added Interface ResourceAutoGenerated4
      info	[Changelog]   - Added Interface ResourceAutoGenerated5
      info	[Changelog]   - Added Interface RuleEmailAction
      info	[Changelog]   - Added Interface RuleManagementEventDataSource
      info	[Changelog]   - Added Interface RuleMetricDataSource
      info	[Changelog]   - Added Interface RuleResolveConfiguration
      info	[Changelog]   - Added Interface RuleWebhookAction
      info	[Changelog]   - Added Interface ScheduledQueryRuleCriteria
      info	[Changelog]   - Added Interface ScheduledQueryRuleResource
      info	[Changelog]   - Added Interface ScheduledQueryRuleResourceCollection
      info	[Changelog]   - Added Interface ScheduledQueryRuleResourcePatch
      info	[Changelog]   - Added Interface ScheduledQueryRulesListByResourceGroupNextOptionalParams
      info	[Changelog]   - Added Interface ScheduledQueryRulesListBySubscriptionNextOptionalParams
      info	[Changelog]   - Added Interface ScopedResource
      info	[Changelog]   - Added Interface StreamDeclaration
      info	[Changelog]   - Added Interface ThresholdRuleCondition
      info	[Changelog]   - Added Interface TrackedResource
      info	[Changelog]   - Added Interface TrackedResourceAutoGenerated
      info	[Changelog]   - Added Interface UserIdentityProperties
      info	[Changelog]   - Added Interface VMInsightsOnboardingStatus
      info	[Changelog]   - Added Interface WebtestLocationAvailabilityCriteria
      info	[Changelog]   - Added Type Alias AccessMode
      info	[Changelog]   - Added Type Alias ActionGroupsCreateNotificationsAtActionGroupResourceLevelResponse
      info	[Changelog]   - Added Type Alias ActionGroupsGetTestNotificationsAtActionGroupResourceLevelResponse
      info	[Changelog]   - Added Type Alias ActionType
      info	[Changelog]   - Added Type Alias ActivityLogAlertsListByResourceGroupNextResponse
      info	[Changelog]   - Added Type Alias ActivityLogAlertsListBySubscriptionIdNextResponse
      info	[Changelog]   - Added Type Alias AzureMonitorWorkspacesCreateResponse
      info	[Changelog]   - Added Type Alias AzureMonitorWorkspacesGetResponse
      info	[Changelog]   - Added Type Alias AzureMonitorWorkspacesListByResourceGroupNextResponse
      info	[Changelog]   - Added Type Alias AzureMonitorWorkspacesListByResourceGroupResponse
      info	[Changelog]   - Added Type Alias AzureMonitorWorkspacesListBySubscriptionNextResponse
      info	[Changelog]   - Added Type Alias AzureMonitorWorkspacesListBySubscriptionResponse
      info	[Changelog]   - Added Type Alias AzureMonitorWorkspacesUpdateResponse
      info	[Changelog]   - Added Type Alias DataCollectionRuleAssociationsListByDataCollectionEndpointNextResponse
      info	[Changelog]   - Added Type Alias DataCollectionRuleAssociationsListByDataCollectionEndpointResponse
      info	[Changelog]   - Added Type Alias DimensionOperator
      info	[Changelog]   - Added Type Alias IdentityType
      info	[Changelog]   - Added Type Alias Kind
      info	[Changelog]   - Added Type Alias KnownColumnDefinitionType
      info	[Changelog]   - Added Type Alias KnownLogFilesDataSourceFormat
      info	[Changelog]   - Added Type Alias KnownLogFileTextSettingsRecordStartTimestampFormat
      info	[Changelog]   - Added Type Alias MonitorOperationsListNextResponse
      info	[Changelog]   - Added Type Alias MonitorOperationsListResponse
      info	[Changelog]   - Added Type Alias Origin
      info	[Changelog]   - Added Type Alias PredictiveAutoscalePolicyScaleMode
      info	[Changelog]   - Added Type Alias PredictiveMetricGetResponse
      info	[Changelog]   - Added Type Alias PrivateEndpointConnectionProvisioningState
      info	[Changelog]   - Added Type Alias PrivateEndpointServiceConnectionStatus
      info	[Changelog]   - Added Type Alias PublicNetworkAccess
      info	[Changelog]   - Added Type Alias ScheduledQueryRulesListByResourceGroupNextResponse
      info	[Changelog]   - Added Type Alias ScheduledQueryRulesListBySubscriptionNextResponse
      info	[Changelog]   - Added Type Alias TimeAggregation
      info	[Changelog]   - Interface AutoscaleSettingResourcePatch has a new optional parameter predictiveAutoscalePolicy
      info	[Changelog]   - Interface DataCollectionRule has a new optional parameter dataCollectionEndpointId
      info	[Changelog]   - Interface DataCollectionRule has a new optional parameter metadata
      info	[Changelog]   - Interface DataCollectionRule has a new optional parameter streamDeclarations
      info	[Changelog]   - Interface DataCollectionRuleAssociation has a new optional parameter metadata
      info	[Changelog]   - Interface DataCollectionRuleAssociationProxyOnlyResource has a new optional parameter metadata
      info	[Changelog]   - Interface DataCollectionRuleResource has a new optional parameter dataCollectionEndpointId
      info	[Changelog]   - Interface DataCollectionRuleResource has a new optional parameter metadata
      info	[Changelog]   - Interface DataCollectionRuleResource has a new optional parameter streamDeclarations
      info	[Changelog]   - Interface DataFlow has a new optional parameter outputStream
      info	[Changelog]   - Interface DataFlow has a new optional parameter transformKql
      info	[Changelog]   - Interface DataSourcesSpec has a new optional parameter iisLogs
      info	[Changelog]   - Interface DataSourcesSpec has a new optional parameter logFiles
      info	[Changelog]   - Interface LogSettings has a new optional parameter categoryGroup
      info	[Changelog]   - Interface Resource has a new optional parameter systemData
      info	[Changelog]   - Added Enum KnownAccessMode
      info	[Changelog]   - Added Enum KnownActionType
      info	[Changelog]   - Added Enum KnownCategoryType
      info	[Changelog]   - Added Enum KnownDimensionOperator
      info	[Changelog]   - Added Enum KnownKind
      info	[Changelog]   - Added Enum KnownKnownColumnDefinitionType
      info	[Changelog]   - Added Enum KnownKnownLogFilesDataSourceFormat
      info	[Changelog]   - Added Enum KnownKnownLogFileTextSettingsRecordStartTimestampFormat
      info	[Changelog]   - Added Enum KnownOrigin
      info	[Changelog]   - Added Enum KnownPrivateEndpointConnectionProvisioningState
      info	[Changelog]   - Added Enum KnownPrivateEndpointServiceConnectionStatus
      info	[Changelog]   - Added Enum KnownPublicNetworkAccess
      info	[Changelog]   - Added Enum KnownTimeAggregation
      info	[Changelog]   - Enum KnownProvisioningState has a new value Creating
      info	[Changelog]   - Enum KnownProvisioningState has a new value Deleting
      info	[Changelog]   - Added function getContinuationToken
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation group Metrics
      info	[Changelog]   - Removed operation ActionGroups.beginPostTestNotifications
      info	[Changelog]   - Removed operation ActionGroups.beginPostTestNotificationsAndWait
      info	[Changelog]   - Removed operation ActionGroups.getTestNotifications
      info	[Changelog]   - Operation ActivityLogAlerts.update has a new signature
      info	[Changelog]   - Operation ScheduledQueryRules.createOrUpdate has a new signature
      info	[Changelog]   - Operation ScheduledQueryRules.update has a new signature
      info	[Changelog]   - Interface ActivityLogsListNextOptionalParams no longer has parameter select
      info	[Changelog]   - Interface AzureResource no longer has parameter identity
      info	[Changelog]   - Interface AzureResource no longer has parameter kind
      info	[Changelog]   - Interface PrivateEndpointConnectionListResult no longer has parameter nextLink
      info	[Changelog]   - Interface PrivateLinkResourceListResult no longer has parameter nextLink
      info	[Changelog]   - Interface ResourceAutoGenerated no longer has parameter etag
      info	[Changelog]   - Interface ResourceAutoGenerated no longer has parameter kind
      info	[Changelog]   - Interface ScheduledQueryRulesListByResourceGroupOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface ScheduledQueryRulesListBySubscriptionOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface TenantActivityLogsListNextOptionalParams no longer has parameter filter
      info	[Changelog]   - Interface TenantActivityLogsListNextOptionalParams no longer has parameter select
      info	[Changelog]   - Type of parameter operator of interface Dimension is changed from Operator to DimensionOperator
      info	[Changelog]   - Type of parameter error of interface ErrorContract is changed from ErrorResponse to ErrorResponseDetails
      info	[Changelog]   - Type of parameter error of interface OperationStatus is changed from ErrorResponseCommon to ErrorDetail
      info	[Changelog]   - Class MonitorClient no longer has parameter metrics
      info	[Changelog]   - Removed Enum KnownConditionalOperator
      info	[Changelog]   - Removed Enum KnownEnabled
      info	[Changelog]   - Removed Enum KnownMetricTriggerType
      info	[Changelog]   - Removed Enum KnownQueryType
      info	[Changelog]   - Enum KnownOperator no longer has value Include
      info	[Changelog]   - Enum KnownProvisioningState no longer has value Deploying
    ️❌ azure-resource-manager-schemas failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 47d1d82. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]  WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      cannot force update branch 'sdkAuto/monitor' as it is the current HEAD of the repository.
      Error: cannot force update branch 'sdkAuto/monitor' as it is the current HEAD of the repository.
    • ️✔️monitor [View full logs]  [Release Schema Changes]
    • ️✔️monitor [View full logs
      error	Fatal error: cannot force update branch 'sdkAuto/monitor' as it is the current HEAD of the repository.
      error	The following packages are still pending:
      error		monitor
      error		monitor
    ️❌ azure-powershell failed [Detail]
    • Failed [Logs]Release - Generate from 47d1d82. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • Az.monitor [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Jan 23, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/monitor/armmonitor https://apiview.dev/Assemblies/Review/e7eaecc520494e539c2f25bfa36167cd
    Java azure-resourcemanager-monitor-generated https://apiview.dev/Assemblies/Review/a0194b31accb4928b525d2ca066c8bd5
    JavaScript @azure/arm-monitor https://apiview.dev/Assemblies/Review/c36f238757dd4b59bfd7a68932957098

    @openapi-workflow-bot
    Copy link

    Hi @thomasp98296, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    Hi @thomasp98296, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi, @thomasp98296, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    @thomasp98296
    Copy link
    Contributor Author

    Hi @thomasp98296, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki. If you want to know the production traffic statistic, please see ARM Traffic statistic. If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback. Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @ArcturusZhang they already reviewed and approved here. Can we please proceed?

    Scenario 16406001: Remove Test Notifications APIs from ActionGroup RP

    @mikekistler mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 10, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 10, 2023
    @zizw123
    Copy link

    zizw123 commented Feb 10, 2023

    Hi, @thomasp98296, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    Please check this and update the PR, thanks

    @zizw123 zizw123 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 10, 2023
    @openapi-workflow-bot
    Copy link

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 10, 2023
    @thomasp98296 thomasp98296 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 10, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 10, 2023
    @thomasp98296 thomasp98296 removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 10, 2023
    @tadelesh tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label Feb 13, 2023
    @ArcturusZhang
    Copy link
    Member

    Avocado is reporting that some APIs are missing and those are exactly the ones removed in this PR. Suppressed it since it is expected and approved

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-Avocado Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-FixRequiredOnFailure CI-MissingBaseCommit Monitor Monitor, Monitor Ingestion, Monitor Query new-api-version resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    7 participants