Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications Resource #2228

Merged
merged 2 commits into from
Jan 10, 2018
Merged

Notifications Resource #2228

merged 2 commits into from
Jan 10, 2018

Conversation

solankisamir
Copy link
Member

@solankisamir solankisamir commented Jan 9, 2018 •
edited
Loading

Added REST api Swagger for /notifications resource. The previous attempt was made in #1682. The issues in the REST api have been fixed.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

💡 Please review potentially introduced Error(s)/Warning(s): Analysis Report 💡

File: specification/apimanagement/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 6

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@azuresdkciprbot
Copy link

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/apimanagement/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 2
After the PR: Warning(s): 0 Error(s): 2

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@jianghaolu jianghaolu added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 10, 2018
@jianghaolu
Copy link
Contributor

There are 2 RPC violations - please review @ravbhatnagar @simongdavies

@solankisamir
Copy link
Member Author

solankisamir commented Jan 10, 2018 •
edited
Loading

For RPC violation we have issues opened upon us, which we are fixing in the next api-version 2018-01-01
#1987
#1881
#1847

@jianghaolu jianghaolu merged commit 21ecc34 into Azure:master Jan 10, 2018
@solankisamir solankisamir deleted the apim_notifications branch January 10, 2018 21:59
@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-python

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-ruby

1 similar comment
@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-ruby

@AutorestCI
Copy link

No modification for AutorestCI/azure-sdk-for-python

mccleanp pushed a commit that referenced this pull request Mar 23, 2022
Wandisco.Fusion syncing swagger definitions (#2228)
29d6e9a 
* Wandisco.Fusion syncing swagger definitions

* Added Wandisco and keytab to custom-words.txt

* Formatted changes with prettier

* Formatted by prettier with Azure configuration

Co-authored-by: Tim Mullender <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianghaolu jianghaolu jianghaolu approved these changes

Assignees

@jianghaolu jianghaolu

Labels
WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@solankisamir @azuresdkciprbot @jianghaolu @AutorestCI