Update all variations of "MonitoringAccount" to "AzureMonitorWorkspaces" #22328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @jasondavis-MS Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| monitoringAccounts_API.json | 2021-06-03-preview(77830b8) | 2021-06-03-preview(main) |
| operations_API.json | 2021-06-03-preview(77830b8) | 2021-06-03-preview(main) |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-preview-2022-08 | package-preview-2022-08(77830b8) | package-preview-2022-08(main) |
| package-composite-v1 | package-composite-v1(77830b8) | package-composite-v1(main) |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| The API version:2021-06-03-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L6 |
|
| The API version:2021-06-03-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L6 |
|
| The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation. Location: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L7 |
|
| The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation. Location: Microsoft.Monitor/preview/2021-06-03-preview/monitoringAccounts_API.json#L7 |
|
| The API version:2021-06-03-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Monitor/preview/2021-06-03-preview/operations_API.json#L6 |
|
| The API version:2021-06-03-preview having been in a preview state over one year , please move it to GA or retire. Location: Microsoft.Monitor/preview/2021-06-03-preview/operations_API.json#L6 |
|
| The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation. Location: Microsoft.Monitor/preview/2021-06-03-preview/operations_API.json#L7 |
|
| The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation. Location: Microsoft.Monitor/preview/2021-06-03-preview/operations_API.json#L7 |
|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Monitor/preview/2021-06-03-preview/operations_API.json#L59 |
|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Monitor/preview/2021-06-03-preview/operations_API.json#L59 |
️⚠️Avocado: 1 Warnings warning [Detail]
| Rule | Message |
|---|---|
| The default tag contains multiple API versions swaggers. readme: specification/monitor/resource-manager/readme.md tag: specification/monitor/resource-manager/readme.md#tag-package-preview-2022-08 |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 121 Errors, 0 Warnings failed [Detail]
Tag package-preview-2022-08; Prod region: Deployed
Test run on region: centralindia; Operation coverage: total: 110, untested: 0, failed: 75, passed: 35
Service API Readiness Test failed. Check pipeline artifact for detail report.
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
statusCode: 400, errorCode: LocationNotAvailableForResourceType, errorMessage: The provided location 'centralindia' is not available for resource type 'microsoft.insights/privateLinkScopes'. List of available regions for the resource type is 'global'. Source: runtime OperationId: PrivateLinkScopes_CreateOrUpdate |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'microsoft.insights/privateLinkScopes/scopenam1ynwhp' under resource group 'apiTest-RAANAK-22328' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: PrivateLinkScopes_Get |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'microsoft.insights/privateLinkScopes/scopenam1ynwhp' under resource group 'apiTest-RAANAK-22328' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: PrivateLinkScopes_UpdateTags |
|
statusCode: 400, errorCode: LocationNotAvailableForResourceType, errorMessage: The provided location 'centralindia' is not available for resource type 'microsoft.insights/actiongroups'. List of available regions for the resource type is 'global,swedencentral,germanywestcentral,northcentralus,southcentralus,eastus2euap,centraluseuap'. Source: runtime OperationId: ActionGroups_CreateOrUpdate |
|
Additional properties not allowed: error Source: response OperationId: ActionGroups_CreateOrUpdate |
|
statusCode: 500, errorCode: undefined, errorMessage: undefined Source: runtime OperationId: ActionGroups_GetTestNotificationsAtResourceGroupLevel |
|
statusCode: 500, errorCode: undefined, errorMessage: undefined Source: runtime OperationId: ActionGroups_GetTestNotifications |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Insights/actiongroups/actiongrm7cu8q' under resource group 'apiTest-RAANAK-22328' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ActionGroups_GetTestNotificationsAtActionGroupResourceLevel |
|
Additional properties not allowed: error Source: response OperationId: ActionGroups_GetTestNotificationsAtActionGroupResourceLevel |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Insights/actiongroups/actiongrm7cu8q' under resource group 'apiTest-RAANAK-22328' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ActionGroups_Get |
|
Additional properties not allowed: error Source: response OperationId: ActionGroups_Get |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Insights/actiongroups/actiongrm7cu8q' under resource group 'apiTest-RAANAK-22328' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ActionGroups_Update |
|
Additional properties not allowed: error Source: response OperationId: ActionGroups_Update |
|
statusCode: 403, errorCode: AuthorizationFailed, errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.Insights/createNotifications/action' over scope '/subscriptions/db5eb68e-73e2-4fa8-b18a-46cd1be4cce5' or the scope is invalid. If access was recently granted, please refresh your credentials. Source: runtime OperationId: ActionGroups_PostTestNotifications |
|
Additional properties not allowed: error Source: response OperationId: ActionGroups_PostTestNotifications |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Insights/actiongroups/actiongrm7cu8q' under resource group 'apiTest-RAANAK-22328' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ActionGroups_EnableReceiver |
|
Additional properties not allowed: error Source: response OperationId: ActionGroups_EnableReceiver |
|
statusCode: 400, errorCode: undefined, errorMessage: undefined Source: runtime OperationId: ActionGroups_CreateNotificationsAtResourceGroupLevel |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Insights/actiongroups/actiongrm7cu8q' under resource group 'apiTest-RAANAK-22328' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: ActionGroups_CreateNotificationsAtActionGroupResourceLevel |
|
Additional properties not allowed: error Source: response OperationId: ActionGroups_CreateNotificationsAtActionGroupResourceLevel |
|
statusCode: 400, errorCode: LocationNotAvailableForResourceType, errorMessage: The provided location 'centralindia' is not available for resource type 'microsoft.insights/metricalerts'. List of available regions for the resource type is 'global,westeurope,northeurope,swedencentral,germanywestcentral,eastus2euap'. Source: runtime OperationId: MetricAlerts_CreateOrUpdate |
|
Object didn't pass validation for format duration: Pt1m Source: request OperationId: MetricAlerts_CreateOrUpdate |
|
Object didn't pass validation for format duration: Pt15m Source: request OperationId: MetricAlerts_CreateOrUpdate |
|
Expected type object but found type array Source: request OperationId: MetricAlerts_CreateOrUpdate |
|
Additional properties not allowed: error Source: response OperationId: MetricAlerts_CreateOrUpdate |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Insights/metricalerts/rulenameskpahf' under resource group 'apiTest-RAANAK-22328' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: MetricAlerts_Get |
|
Additional properties not allowed: error Source: response OperationId: MetricAlerts_Get |
|
statusCode: 404, errorCode: ResourceNotFound, errorMessage: The Resource 'Microsoft.Insights/metricalerts/rulenameskpahf' under resource group 'apiTest-RAANAK-22328' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix Source: runtime OperationId: MetricAlerts_Update |
|
Object didn't pass validation for format duration: Pt1m Source: request OperationId: MetricAlerts_Update |
|
Object didn't pass validation for format duration: Pt15m Source: request OperationId: MetricAlerts_Update |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
ghost
added
the
AzureRestAPISpecReview
added
ARMReview
BreakingChangeReviewRequired
|
Hi @jasondavis-MS, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi @jasondavis-MS, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Jan 26, 2023
AzureRestAPISpecReview
added
ReadyForApiTest
openapi-workflow-bot
bot
removed
the
ARMChangesRequested
sjanamma
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
tadelesh
added
the
Approved-SdkBreakingChange-Go
tadelesh
removed
Approved-SdkBreakingChange-Go
|
|
fengzhou-msft
approved these changes
Feb 9, 2023
openapi-pipeline-app
bot
added
Approved-SdkBreakingChange-Go
This was referenced Feb 9, 2023
aviyerMSFT
pushed a commit
to aviyerMSFT/azure-rest-api-specs
that referenced
this pull request
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Update references to old moniker "MonitoringAccount" to more descriptive "AzureMonitorWorkspaces" in tags, parameter fields, response fields, and file names (excluding "monitoringAccounts_API.json" and Operations JSON files, which will be updated in the near future by @divya-jay)
I'm not really sure
February if not January
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.