Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ConfirmConsentCode to APIM RP #22418

Merged
merged 5 commits into from
Feb 7, 2023
Merged

Add ConfirmConsentCode to APIM RP #22418

merged 5 commits into from
Feb 7, 2023

Conversation

LFZ96
Copy link
Contributor

@LFZ96 LFZ96 commented Feb 1, 2023 •
edited by openapi-workflow-bot bot
Loading

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@LFZ96
Update apimauthorizationproviders.json
d96131f 
Add ConfirmConsentCode endpoint
@openapi-workflow-bot
Copy link

Hi, @LFZ96 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 1, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 4 Errors, 92 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    apimauthorizationproviders.json 2022-08-01(1417a21) 2022-04-01-preview(main)
    definitions.json 2022-08-01(1417a21) 2021-08-01(main)
    definitions.json 2022-08-01(1417a21) 2022-04-01-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ 1025 - RequiredStatusChange The 'required' status changed from the old version('False') to the new version('True').
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L5971:7
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L5073:7
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'document' that was not found in the old version.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L5957:9
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L5059:9
    ❌ 1034 - AddedRequiredProperty The new version has new required property 'document' that was not found in the old version.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L5970:5
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L5072:5
    ❌ 1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L1005:9
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L936:9
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L42:11
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L42:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L61:5
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L61:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L172:11
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L172:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L186:5
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L186:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L217:11
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L217:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L280:5
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L236:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L692:11
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L623:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L711:5
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L642:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L958:11
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L889:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L975:5
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L906:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L1486:11
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L1093:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L1503:5
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L1110:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L1716:5
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L1315:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L1891:11
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L1482:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L1908:5
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L1499:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L2045:5
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L1636:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L2215:11
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L1806:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L2232:5
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L1823:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L2315:11
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L1906:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L2332:5
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L1923:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L2481:11
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L2072:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L2498:5
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L2089:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L2642:11
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L2233:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L2659:5
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L2250:5
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L2799:11
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L2390:11
    ⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L2816:5
    Old: Microsoft.ApiManagement/stable/2021-08-01/definitions.json#L2407:5


    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'count' renamed or removed?
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L1397:7
    Old: Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json#L1343:7
    ⚠️ 1033 - RemovedProperty The new version is missing a property found in the old version. Was 'count' renamed or removed?
    New: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L1397:7
    Old: Microsoft.ApiManagement/preview/2022-04-01-preview/definitions.json#L1343:7
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2022-08 package-2022-08(1417a21) package-2022-08(release-apimangement-2022-08-01)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ GetCollectionResponseSchema The response in the GET collection operation 'AuthorizationProvider_ListByService' does not match the response definition in the individual GET operation 'AuthorizationProvider_Get' .
    Location: Microsoft.ApiManagement/stable/2022-08-01/apimauthorizationproviders.json#L37
    ❌ GetCollectionResponseSchema The response in the GET collection operation 'Authorization_ListByAuthorizationProvider' does not match the response definition in the individual GET operation 'Authorization_Get' .
    Location: Microsoft.ApiManagement/stable/2022-08-01/apimauthorizationproviders.json#L275
    ❌ OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'Authorization' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    Location: Microsoft.ApiManagement/stable/2022-08-01/apimauthorizationproviders.json#L280
    ❌ GetCollectionResponseSchema The response in the GET collection operation 'AuthorizationAccessPolicy_ListByAuthorization' does not match the response definition in the individual GET operation 'AuthorizationAccessPolicy_Get' .
    Location: Microsoft.ApiManagement/stable/2022-08-01/apimauthorizationproviders.json#L645
    ❌ MissingTypeObject The schema 'AccessInformationCollection' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L38
    ❌ MissingTypeObject The schema 'AccessInformationContract' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L61
    ❌ MissingTypeObject The schema 'AccessInformationContractProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L76
    ❌ MissingTypeObject The schema 'AccessInformationSecretsContract' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L93
    ❌ MissingTypeObject The schema 'AccessInformationCreateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L118
    ❌ MissingTypeObject The schema 'AccessInformationCreateParameterProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L128
    ❌ MissingTypeObject The schema 'AccessInformationUpdateParameters' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L149
    ❌ MissingTypeObject The schema 'AccessInformationUpdateParameterProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L159
    ❌ MissingTypeObject The schema 'TenantSettingsCollection' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L168
    ❌ MissingTypeObject The schema 'TenantSettingsContract' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L186
    ❌ MissingTypeObject The schema 'TenantSettingsContractProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L201
    ❌ MissingTypeObject The schema 'ApiCollection' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L213
    ❌ MissingTypeObject The schema 'ApiContract' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L280
    ❌ MissingTypeObject The schema 'ApiContractProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L295
    ❌ MissingTypeObject The schema 'ApiCreateOrUpdateParameter' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L351
    ❌ MissingTypeObject The schema 'ApiCreateOrUpdateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L361
    ❌ MissingTypeObject The schema 'ApiEntityBaseContract' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L518
    ❌ MissingTypeObject The schema 'ApiExportResult' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L632
    ❌ MissingTypeObject The schema 'ApiReleaseCollection' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L688
    ❌ MissingTypeObject The schema 'ApiReleaseContract' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L711
    ❌ MissingTypeObject The schema 'ApiReleaseContractProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L726
    ❌ MissingTypeObject The schema 'ApiRevisionCollection' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L751
    ❌ MissingTypeObject The schema 'ApiRevisionContract' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L777
    ❌ MissingTypeObject The schema 'ApiRevisionInfoContract' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L827
    ❌ MissingTypeObject The schema 'ApiTagResourceContractProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L850
    ❌ MissingTypeObject The schema 'ApiUpdateContract' is considered an object but without a 'type:object', please add the missing 'type:object'.
    Location: Microsoft.ApiManagement/stable/2022-08-01/definitions.json#L899
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 1, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-net-track2 failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-go failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-sdk-for-python-track2 failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

    Only 0 items are rendered, please refer to log for more details.

    ️⚠️ azure-resource-manager-schemas warning [Detail]

    Only 0 items are rendered, please refer to log for more details.

    ️❌ azure-powershell failed [Detail]

    Only 0 items are rendered, please refer to log for more details.

    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the API Management label Feb 1, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 1, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    swagger Microsoft.ApiManagement https://apiview.dev/Assemblies/Review/8fc49c53775a4932b36495ab296d6845
    JavaScript @azure/arm-apimanagement https://apiview.dev/Assemblies/Review/dc6eb46b262e408494e24744f3cf3291

    @LFZ96 LFZ96 marked this pull request as ready for review February 1, 2023 22:46
    @AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-FixRequiredOnFailure resource-manager labels Feb 1, 2023
    @openapi-workflow-bot
    Copy link

    Hi @LFZ96, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @openapi-workflow-bot
    Copy link

    Hi @LFZ96, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    This was referenced Feb 1, 2023
    Closed
    Closed
    Closed
    @azure-sdk azure-sdk mentioned this pull request Feb 1, 2023
    Draft
    @mikekistler mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Feb 2, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 2, 2023
    @solankisamir solankisamir added the 2022-08-01 APIM 2022-08-01 PRs label Feb 2, 2023
    @leni-msft leni-msft mentioned this pull request Feb 3, 2023
    Closed
    11 tasks
    @sjanamma sjanamma added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 5, 2023
    @openapi-workflow-bot
    Copy link

    Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove ARMChangesRequested

    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 5, 2023
    @LFZ96
    Update definitions.json
    743fdcb 
    Remove count property
    @LFZ96 LFZ96 requested review from sjanamma and removed request for solankisamir February 5, 2023 03:21
    @live1206 live1206 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Feb 6, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 6, 2023
    @sjanamma sjanamma added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Feb 6, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 6, 2023
    @solankisamir
    Copy link
    Member

    @live1206 can you please review and merge this PR?

    @live1206 live1206 merged commit d27cd75 into Azure:release-apimangement-2022-08-01 Feb 7, 2023
    lirenhe pushed a commit that referenced this pull request Feb 14, 2023
    @solankisamir @tadelesh
    @hoonality @malincrist @changlong-liu @LFZ96
    Release apimangement 2022-08 01 (#22313)
    2f17a90 
    * Release api management 2022 08 01 (#21169)

* add base for 2022-08-01

* updates readme.md

* update api-version and examples

* resolve Go SDK breaking change

* update examples to fix model definition

Co-authored-by: Chenjie Shi <[email protected]>

* Adding Resolver Entities to documentation (#21352)

* merging in resolver entities

* adding resolver updates

* fixed policy examples that were missing a policyId param

* fixed typo that added a nested properties prop

* fixed description for API Resolvers List, filter query

* fixed error in definitions for resolvers

* fixed example that had an incorrect response definition

* added missing json file references

* fix for linting errors

* ref fixes and undoing bad merge overwrites

* fix typo

* wiki for apis and products  (#21595)

* wiki for apis and products

* prettier; fixed spellchecks

* Fixed spelling

* Updated path

Co-authored-by: changlong-liu <[email protected]>

* code review changes; gihub checks fixes

* fixed conact name and paths

* added properties back

* added contract properties objects

* fixed lint

* changed example to match the definition

* prettier

* code review changes

* added paths and examples for wiki collections

* Added x-ms-pageable

* removed count

Co-authored-by: changlong-liu <[email protected]>

* Add ConfirmConsentCode to APIM RP (#22418)

* Update apimauthorizationproviders.json

Add ConfirmConsentCode endpoint

* Update definitions.json

* Create ApiManagementPostAuthorizationConfirmConsentCodeRequest.json

* Update definitions.json

Remove count property

* Update apimauthorizationproviders.json

* [2022-08-01] Fix Linter Errors (#22537)

* linter errors

* prettier

* v2

* fix error response duplicate schema

* type object

* prettier

* sync data from current ga version

* remove duplicate parameter

* type object

---------

Co-authored-by: Chenjie Shi <[email protected]>
Co-authored-by: hoonality <[email protected]>
Co-authored-by: malincrist <[email protected]>
Co-authored-by: changlong-liu <[email protected]>
Co-authored-by: Logan Zipkes <[email protected]>
    aviyerMSFT pushed a commit to aviyerMSFT/azure-rest-api-specs that referenced this pull request Mar 22, 2023
    @solankisamir @tadelesh
    @hoonality @malincrist @changlong-liu @LFZ96 @aviyerMSFT
    Release apimangement 2022-08 01 (Azure#22313)
    4a59ba6 
    * Release api management 2022 08 01 (Azure#21169)

* add base for 2022-08-01

* updates readme.md

* update api-version and examples

* resolve Go SDK breaking change

* update examples to fix model definition

Co-authored-by: Chenjie Shi <[email protected]>

* Adding Resolver Entities to documentation (Azure#21352)

* merging in resolver entities

* adding resolver updates

* fixed policy examples that were missing a policyId param

* fixed typo that added a nested properties prop

* fixed description for API Resolvers List, filter query

* fixed error in definitions for resolvers

* fixed example that had an incorrect response definition

* added missing json file references

* fix for linting errors

* ref fixes and undoing bad merge overwrites

* fix typo

* wiki for apis and products  (Azure#21595)

* wiki for apis and products

* prettier; fixed spellchecks

* Fixed spelling

* Updated path

Co-authored-by: changlong-liu <[email protected]>

* code review changes; gihub checks fixes

* fixed conact name and paths

* added properties back

* added contract properties objects

* fixed lint

* changed example to match the definition

* prettier

* code review changes

* added paths and examples for wiki collections

* Added x-ms-pageable

* removed count

Co-authored-by: changlong-liu <[email protected]>

* Add ConfirmConsentCode to APIM RP (Azure#22418)

* Update apimauthorizationproviders.json

Add ConfirmConsentCode endpoint

* Update definitions.json

* Create ApiManagementPostAuthorizationConfirmConsentCodeRequest.json

* Update definitions.json

Remove count property

* Update apimauthorizationproviders.json

* [2022-08-01] Fix Linter Errors (Azure#22537)

* linter errors

* prettier

* v2

* fix error response duplicate schema

* type object

* prettier

* sync data from current ga version

* remove duplicate parameter

* type object

---------

Co-authored-by: Chenjie Shi <[email protected]>
Co-authored-by: hoonality <[email protected]>
Co-authored-by: malincrist <[email protected]>
Co-authored-by: changlong-liu <[email protected]>
Co-authored-by: Logan Zipkes <[email protected]>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @live1206 live1206 live1206 approved these changes

    @sjanamma sjanamma Awaiting requested review from sjanamma

    Assignees

    @live1206 live1206

    Labels
    2022-08-01 APIM 2022-08-01 PRs API Management Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-JavaScript CI-FixRequiredOnFailure resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    6 participants
    @LFZ96 @solankisamir @live1206 @sjanamma @AzureRestAPISpecReview @mikekistler