release 2023 02 01 #22474
Merged
release 2023 02 01 #22474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/2022-11-01 to version 2023-02-01
…re#22196) * add alert details override changes and PUT example * add missing brace * add closing brace for alertDetailsOverride * add dynamic properties to 200 response * add dynamic details to 201 response --------- Co-authored-by: ShaniFelig <[email protected]>
* Release Metadata 2023-02-01 stable version. * Fix Swagger spec validation errors. * Revert Metadata service version to 2022-12-01-preview * Bring back changes for version 2023-02-01
|
Hi, @anat-gilenson Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| AlertRules.json | 2023-02-01(2d7d423) | 2022-11-01(main) |
| AlertRules.json | 2023-02-01(2d7d423) | 2023-02-01-preview(main) |
| AutomationRules.json | 2023-02-01(2d7d423) | 2022-11-01(main) |
| AutomationRules.json | 2023-02-01(2d7d423) | 2023-02-01-preview(main) |
| Bookmarks.json | 2023-02-01(2d7d423) | 2022-11-01(main) |
| Bookmarks.json | 2023-02-01(2d7d423) | 2023-02-01-preview(main) |
| DataConnectors.json | 2023-02-01(2d7d423) | 2022-11-01(main) |
| Incidents.json | 2023-02-01(2d7d423) | 2022-11-01(main) |
| Incidents.json | 2023-02-01(2d7d423) | 2023-02-01-preview(main) |
| Metadata.json | 2023-02-01(2d7d423) | 2023-02-01-preview(main) |
| OnboardingStates.json | 2023-02-01(2d7d423) | 2022-11-01(main) |
| OnboardingStates.json | 2023-02-01(2d7d423) | 2023-02-01-preview(main) |
| SecurityMLAnalyticsSettings.json | 2023-02-01(2d7d423) | 2022-11-01(main) |
| SecurityMLAnalyticsSettings.json | 2023-02-01(2d7d423) | 2023-02-01-preview(main) |
| ThreatIntelligence.json | 2023-02-01(2d7d423) | 2022-11-01(main) |
| ThreatIntelligence.json | 2023-02-01(2d7d423) | 2023-02-01-preview(main) |
| Watchlists.json | 2023-02-01(2d7d423) | 2022-11-01(main) |
| Watchlists.json | 2023-02-01(2d7d423) | 2023-02-01-preview(main) |
| AlertTypes.json | 2023-02-01(2d7d423) | 2022-11-01(main) |
| AlertTypes.json | 2023-02-01(2d7d423) | 2023-02-01-preview(main) |
| EntityTypes.json | 2023-02-01(2d7d423) | 2022-11-01(main) |
| EntityTypes.json | 2023-02-01(2d7d423) | 2023-02-01-preview(main) |
| IncidentTypes.json | 2023-02-01(2d7d423) | 2022-11-01(main) |
| IncidentTypes.json | 2023-02-01(2d7d423) | 2023-02-01-preview(main) |
| operations.json | 2023-02-01(2d7d423) | 2022-11-01(main) |
| operations.json | 2023-02-01(2d7d423) | 2023-02-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 26 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. New: Microsoft.SecurityInsights/stable/2023-02-01/ThreatIntelligence.json#L49:9 Old: Microsoft.SecurityInsights/stable/2022-11-01/ThreatIntelligence.json#L49:9 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
|
The new version has a different type '' than the previous one 'object'. Old: stable/2022-11-01/common/EntityTypes.json#L2272:11 |
The following breaking changes are detected by comparison with the latest preview version:
Only 26 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/incidents/{incidentIdentifier}/runPlaybook' removed or restructured? Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/AutomationRules.json#L220:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/bookmarks/{bookmarkId}/relations' removed or restructured? Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/Bookmarks.json#L222:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/bookmarks/{bookmarkId}/expand' removed or restructured? Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/Bookmarks.json#L283:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/bookmarks/{bookmarkId}/relations/{relationName}' removed or restructured? Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/Bookmarks.json#L331:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/incidents/{incidentId}/createTeam' removed or restructured? Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/Incidents.json#L218:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/incidents/{incidentId}/tasks' removed or restructured? Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/Incidents.json#L856:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.OperationalInsights/workspaces/{workspaceName}/providers/Microsoft.SecurityInsights/incidents/{incidentId}/tasks/{incidentTaskId}' removed or restructured? Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/Incidents.json#L907:5 |
|
| The new version is missing a definition that was found in the old version. Was 'MLBehaviorAnalyticsAlertRule' removed or renamed? New: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L522:3 Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/AlertRules.json#L577:3 |
|
| The new version is missing a definition that was found in the old version. Was 'MLBehaviorAnalyticsAlertRuleProperties' removed or renamed? New: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L522:3 Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/AlertRules.json#L577:3 |
|
| The new version is missing a definition that was found in the old version. Was 'MLBehaviorAnalyticsAlertRuleTemplate' removed or renamed? New: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L522:3 Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/AlertRules.json#L577:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ThreatIntelligenceAlertRule' removed or renamed? New: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L522:3 Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/AlertRules.json#L577:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ThreatIntelligenceAlertRuleProperties' removed or renamed? New: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L522:3 Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/AlertRules.json#L577:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ThreatIntelligenceAlertRuleTemplate' removed or renamed? New: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L522:3 Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/AlertRules.json#L577:3 |
|
| The new version is missing a definition that was found in the old version. Was 'NrtAlertRuleProperties' removed or renamed? New: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L522:3 Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/AlertRules.json#L577:3 |
|
| The new version is missing a definition that was found in the old version. Was 'NrtAlertRuleTemplate' removed or renamed? New: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L522:3 Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/AlertRules.json#L577:3 |
|
| The new version is missing a definition that was found in the old version. Was 'NrtAlertRule' removed or renamed? New: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L522:3 Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/AlertRules.json#L577:3 |
|
| The new version is missing a definition that was found in the old version. Was 'SentinelEntitiesMappings' removed or renamed? New: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L522:3 Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/AlertRules.json#L577:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AddIncidentTaskActionProperties' removed or renamed? New: Microsoft.SecurityInsights/stable/2023-02-01/AutomationRules.json#L224:3 Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/AutomationRules.json#L282:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AutomationRuleAddIncidentTaskAction' removed or renamed? New: Microsoft.SecurityInsights/stable/2023-02-01/AutomationRules.json#L224:3 Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/AutomationRules.json#L282:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AutomationRuleBooleanCondition' removed or renamed? New: Microsoft.SecurityInsights/stable/2023-02-01/AutomationRules.json#L224:3 Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/AutomationRules.json#L282:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AutomationRuleBooleanConditionSupportedOperator' removed or renamed? New: Microsoft.SecurityInsights/stable/2023-02-01/AutomationRules.json#L224:3 Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/AutomationRules.json#L282:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AutomationRulePropertyArrayConditionSupportedArrayConditionType' removed or renamed? New: Microsoft.SecurityInsights/stable/2023-02-01/AutomationRules.json#L224:3 Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/AutomationRules.json#L282:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AutomationRulePropertyArrayConditionSupportedArrayType' removed or renamed? New: Microsoft.SecurityInsights/stable/2023-02-01/AutomationRules.json#L224:3 Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/AutomationRules.json#L282:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AutomationRulePropertyArrayValuesCondition' removed or renamed? New: Microsoft.SecurityInsights/stable/2023-02-01/AutomationRules.json#L224:3 Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/AutomationRules.json#L282:3 |
|
| The new version is missing a definition that was found in the old version. Was 'BooleanConditionProperties' removed or renamed? New: Microsoft.SecurityInsights/stable/2023-02-01/AutomationRules.json#L224:3 Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/AutomationRules.json#L282:3 |
|
| The new version is missing a definition that was found in the old version. Was 'ManualTriggerRequestBody' removed or renamed? New: Microsoft.SecurityInsights/stable/2023-02-01/AutomationRules.json#L224:3 Old: Microsoft.SecurityInsights/preview/2023-02-01-preview/AutomationRules.json#L282:3 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 1 Warnings warning [Detail]
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-2023-02 | package-2023-02(2d7d423) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation. Location: Microsoft.SecurityInsights/stable/2023-02-01/AutomationRules.json#L7 |
The following errors/warnings exist before current PR submission:
Only 26 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The delete response body must be empty. Location: Microsoft.SecurityInsights/stable/2023-02-01/AutomationRules.json#L151 |
|
The delete response body must be empty. Location: Microsoft.SecurityInsights/stable/2023-02-01/AutomationRules.json#L157 |
|
Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.SecurityInsights/stable/2023-02-01/AutomationRules.json#L1001 |
|
The resource name parameter 'relationName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2023-02-01/Incidents.json#L640 |
|
The resource name parameter 'sentinelOnboardingStateName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2023-02-01/OnboardingStates.json#L37 |
|
The resource name parameter 'settingsResourceName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/stable/2023-02-01/SecurityMLAnalyticsSettings.json#L82 |
|
Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.SecurityInsights/stable/2023-02-01/SecurityMLAnalyticsSettings.json#L390 |
|
Path for 'post' method on a resource type MUST follow valid resource naming. Location: Microsoft.SecurityInsights/stable/2023-02-01/ThreatIntelligence.json#L37 |
|
Only 202 is the supported response code for POST async response. Location: Microsoft.SecurityInsights/stable/2023-02-01/ThreatIntelligence.json#L73 |
|
Path for 'post' method on a resource type MUST follow valid resource naming. Location: Microsoft.SecurityInsights/stable/2023-02-01/ThreatIntelligence.json#L285 |
|
Path for 'post' method on a resource type MUST follow valid resource naming. Location: Microsoft.SecurityInsights/stable/2023-02-01/ThreatIntelligence.json#L375 |
|
Path for 'post' method on a resource type MUST follow valid resource naming. Location: Microsoft.SecurityInsights/stable/2023-02-01/ThreatIntelligence.json#L420 |
|
The 'watchlistAlias' already appears in the path, please don't repeat it in the request body. Location: Microsoft.SecurityInsights/stable/2023-02-01/Watchlists.json#L199 |
|
The 'watchlistItemId' already appears in the path, please don't repeat it in the request body. Location: Microsoft.SecurityInsights/stable/2023-02-01/Watchlists.json#L399 |
| A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Actions_CreateOrUpdate' Request Model: 'parameters[6].schema' Response Model: 'responses[200].schema' Location: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L329 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L827 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L1027 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L1336 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L1353 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L1357 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L1469 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L1484 |
|
| Schema should have a description or title. Location: Microsoft.SecurityInsights/stable/2023-02-01/AutomationRules.json#L248 |
|
| Schema should have a description or title. Location: Microsoft.SecurityInsights/stable/2023-02-01/AutomationRules.json#L370 |
|
| Schema should have a description or title. Location: Microsoft.SecurityInsights/stable/2023-02-01/AutomationRules.json#L402 |
|
| Schema should have a description or title. Location: Microsoft.SecurityInsights/stable/2023-02-01/AutomationRules.json#L419 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️❌PoliCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Click detail for error messages. Exception contact [email protected] or https://aka.ms/swaggersupport. |
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
CI-FixRequiredOnFailure
CI-MissingBaseCommit
new-api-version
resource-manager
WaitForARMFeedback
|
Hi @anat-gilenson, Your PR has some issues. Please fix the CI sequentially by following the order of
|
|
Hi, @anat-gilenson, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
This was referenced Feb 6, 2023
Closed
Closed
[AutoPR azure-resourcemanager-securityinsights] release 2023 02 01
azure-sdk/azure-sdk-for-java#3711
Closed
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
|
Hi @anat-gilenson, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
This PR is labelled with breaking change, please get it reviewed first and then come back for ARM review |
zizw123
added
the
ARMChangesRequested
|
Please ensure to respond feedbacks from the ARM API reviewer. When you are ready to continue the ARM API review, please remove |
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
The changes in this PR is approved in other PRs, and this PR only aggreates them to merge to main branch. So we don't need to review it again. |
dw511214992
added
the
Approved-BreakingChange
dw511214992
approved these changes
Feb 22, 2023
This was referenced Feb 22, 2023
aviyerMSFT
pushed a commit
to aviyerMSFT/azure-rest-api-specs
that referenced
this pull request
Mar 22, 2023
* Adds base for updating Microsoft.SecurityInsights from version stable/2022-11-01 to version 2023-02-01 * Updates readme * Updates API version in new specs and examples * Provider sync properties (Azure#22198) * Alert Rules - add alert details override changes and PUT example (Azure#22196) * add alert details override changes and PUT example * add missing brace * add closing brace for alertDetailsOverride * add dynamic properties to 200 response * add dynamic details to 201 response --------- Co-authored-by: ShaniFelig <[email protected]> * Release Metadata 2023-02-01 stable version. (Azure#22161) * Release Metadata 2023-02-01 stable version. * Fix Swagger spec validation errors. * Revert Metadata service version to 2022-12-01-preview * Bring back changes for version 2023-02-01 * Fix model validation --------- Co-authored-by: Dor Siso <[email protected]> Co-authored-by: ShaniFelig <[email protected]> Co-authored-by: ShaniFelig <[email protected]> Co-authored-by: Samuel Kuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note all PRs to this branch have already been reviewed and approved by Swagger team and ARM. No need for addition ARM review.