Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update sample #22709

Merged
merged 2 commits into from
Feb 20, 2023
Merged

update sample #22709

merged 2 commits into from
Feb 20, 2023

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented Feb 20, 2023

@openapi-workflow-bot
Copy link

Hi, @msyyc Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 20, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️️✔️LintDiff succeeded [Detail] [Expand] 
    Validation passes for LintDiff.
    ️️✔️Avocado succeeded [Detail] [Expand] 
    Validation passes for Avocado.
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 20, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking


    ❌azure-sdk-for-js - @azure/arm-storage - 19.0.0
    +	Interface BlobContainersListNextOptionalParams no longer has parameter filter
+	Interface BlobContainersListNextOptionalParams no longer has parameter include
+	Interface BlobContainersListNextOptionalParams no longer has parameter maxpagesize
+	Interface EncryptionScopesListNextOptionalParams no longer has parameter filter
+	Interface EncryptionScopesListNextOptionalParams no longer has parameter include
+	Interface EncryptionScopesListNextOptionalParams no longer has parameter maxpagesize
+	Interface FileSharesListNextOptionalParams no longer has parameter expand
+	Interface FileSharesListNextOptionalParams no longer has parameter filter
+	Interface FileSharesListNextOptionalParams no longer has parameter maxpagesize
+	Interface QueueListNextOptionalParams no longer has parameter filter
+	Interface QueueListNextOptionalParams no longer has parameter maxpagesize

    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b9fb4f9. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.Storage [View full logs]  [Release SDK Changes] 
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b9fb4f9. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.5.0
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.5.0>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-storage [View full logs]  [Release SDK Changes] 
      info	[Changelog]
    ️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b9fb4f9. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/storage/armstorage [View full logs]  [Release SDK Changes] 
      info	[Changelog] ### Other Changes
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 0 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b9fb4f9. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-storage [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface BlobContainersListNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface BlobContainersListNextOptionalParams no longer has parameter include
info	[Changelog]   - Interface BlobContainersListNextOptionalParams no longer has parameter maxpagesize
info	[Changelog]   - Interface EncryptionScopesListNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface EncryptionScopesListNextOptionalParams no longer has parameter include
info	[Changelog]   - Interface EncryptionScopesListNextOptionalParams no longer has parameter maxpagesize
info	[Changelog]   - Interface FileSharesListNextOptionalParams no longer has parameter expand
info	[Changelog]   - Interface FileSharesListNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface FileSharesListNextOptionalParams no longer has parameter maxpagesize
info	[Changelog]   - Interface QueueListNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface QueueListNextOptionalParams no longer has parameter maxpagesize
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from b9fb4f9. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation
    • ️✔️storage [View full logs] 
    ️️✔️ azure-powershell succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from b9fb4f9. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    • ️✔️Az.Storage [View full logs]  [Release SDK Changes]
    Posted by Swagger Pipeline | How to fix these errors?

    @msyyc msyyc self-assigned this Feb 20, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Feb 20, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/storage/armstorage There is no API change compared with the previous version
    Java azure-resourcemanager-storage-generated https://apiview.dev/Assemblies/Review/d17d2b5f316a4c439f70f1078262da38
    .Net Azure.ResourceManager.Storage There is no API change compared with the previous version
    JavaScript @azure/arm-storage https://apiview.dev/Assemblies/Review/94ba427a56fe4a8da87adf13ba4769c8

    @ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Feb 20, 2023
    @azure-sdk azure-sdk mentioned this pull request Feb 20, 2023
    Closed
    This was referenced Feb 20, 2023
    Closed
    Closed
    This was referenced Feb 20, 2023
    Closed
    Closed
    @azure-sdk azure-sdk mentioned this pull request Feb 20, 2023
    Closed
    @msyyc msyyc merged commit b9fb4f9 into main Feb 20, 2023
    @msyyc msyyc deleted the storage-fix-sample branch February 20, 2023 07:11
    This was referenced Feb 20, 2023
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    aviyerMSFT pushed a commit to aviyerMSFT/azure-rest-api-specs that referenced this pull request Mar 22, 2023
    @msyyc @aviyerMSFT
    update sample (Azure#22709)
    ece8efe 
    * update sample

* update sample value
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @Wzb123456789 Wzb123456789 Wzb123456789 approved these changes

    @JasonYang-MSFT JasonYang-MSFT Awaiting requested review from JasonYang-MSFT

    Assignees

    @msyyc msyyc

    Labels
    CI-BreakingChange-JavaScript resource-manager Storage Storage Service (Queues, Blobs, Files)
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    4 participants
    @msyyc @Wzb123456789 @AzureRestAPISpecReview @jianyexi