[Hub Generated] Review request for Microsoft.Monitor to add version stable/2023-04-03 #23107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-03-preview to version 2023-04-03
|
Hi, @jasondavis-MS Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
Swagger Generation Artifacts
|
Generated ApiView
|
ghost
added
the
This was referenced Mar 15, 2023
This was referenced Mar 15, 2023
|
/azp run unifiedPipeline |
|
No pipelines are associated with this pull request. |
Swagger Generation Artifacts
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mikekistler
added
the
Approved-BreakingChange
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tadelesh
reviewed
Apr 14, 2023
tadelesh
reviewed
Apr 14, 2023
...ion/monitor/resource-manager/Microsoft.Monitor/stable/2023-04-03/monitoringAccounts_API.json
Show resolved
Hide resolved
|
202 change looks good, signing off from ARM side again |
tadelesh
added
the
Approved-SdkBreakingChange-Go
ArcturusZhang
approved these changes
Apr 18, 2023
ArcturusZhang
deleted the
jasondavis-MS-monitor-Microsoft.Monitor-2023-04-03
branch
This was referenced Apr 18, 2023
JoshLove-msft
pushed a commit
to JoshLove-msft/azure-rest-api-specs
that referenced
this pull request
Apr 25, 2023
…table/2023-04-03 (Azure#23107) * Adds base for updating Microsoft.Monitor from version preview/2021-06-03-preview to version 2023-04-03 * Updates readme * Updates API version in new specs and examples * add publicNetworkAccess * add PrivateEndpointConnections * add PrivateEndpointConnections subclasses * give PrivateEndpointConnectionProperties.ProvisioningState enum vals * give publicNetworkAccess an enum * add privateEndpointConnections and publicNetworkAccess to Create example * add PrivateEndpointConnection and PublicNetworkAccess to other examples * attempt to fix XmsIdentifierValidation linter error * attempt to fix ArrayMustHaveType linter error * attempt to fix XmsEnumValidation and retry XmsIdentifierValidation errors * attempt to fix MISSING_APIS_IN_DEFAULT_TAG * use common-type for PrivateEndpointConnection ref, remove nested fields * update Create and Delete responses for async operations * further async update * Revert "further async update" This reverts commit c9c17da. * Revert "update Create and Delete responses for async operations" This reverts commit c0b1031. * remove 201 from Create, 200 and 204 from Delete, add 202 to Delete * readd 204 to Delete * make corresponding response updates to API * add x-ms-long-running-operation: true to Delete * add x-ms-long-running-operation-options for Delete * try to fix Lro errors * try to fix errors * try to fix errors * attempt fix again * try again * continue * continue * once more * another try * last one for real * last one v2 * just one more * last or second to last one, guaranteed * attempt cleanup * Revert "attempt cleanup" This reverts commit 0fc498f. * reintroduce 201 response for PUT * remove double readme entry * resolve Go SDK duplication schema issue * revert change --------- Co-authored-by: James Lai <[email protected]> Co-authored-by: Chenjie Shi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.