[EventHub] NSP contract Inherits the ProxyResource definition instead of Resource #23543

schaudhari6254888 · 2023-04-13T05:34:09Z

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?
- new service onboarding
- new API version
- update existing version for new feature
- update existing version to fix swagger quality issue in s360
- Other, please clarify
When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

I commit to follow the Breaking Change Policy of "no breaking changes"
I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs

Adding new properties

All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
- Adding a new service
- Adding new API(s)
- Adding a new API version
  -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

openapi-workflow-bot · 2023-04-13T05:34:12Z

Hi, @schaudhari6254888 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

openapi-pipeline-app · 2023-04-13T05:34:13Z

Swagger Validation Report

️❌BreakingChange: 1 Errors, 2 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
namespaces-preview.json	2022-10-01-preview(90ede5c)	2022-10-01-preview(main)

Rule	Message
`❌` 1040 - AddedReadOnlyPropertyInResponse	The new version has a new read-only property 'location' in response that was not found in the old version. New: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L1151:7 Old: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L1151:7
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L1141:11 Old: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L1141:11
⚠️ 1032 - DifferentAllOf	The new version has a different 'allOf' property than the previous one. New: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L1147:5 Old: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L1147:5

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.0.0)	new version	base version
package-2022-10-preview	package-2022-10-preview(90ede5c)	package-2022-10-preview(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L118
`❌` CreateOperationAsyncResponseValidation	An async PUT operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L119
`❌` LongRunningResponseStatusCode	A 'put' operation 'Namespaces_CreateOrUpdate' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 201. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L119
`❌` CreateOperationAsyncResponseValidation	Only 201 is the supported response code for PUT async response. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L169
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L169
`❌` DeleteOperationAsyncResponseValidation	An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L181
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L210
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property name. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L283
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property type. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L283
`❌` UnSupportedPatchProperties	The patch operation body parameter schema should not contains property location. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L283
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L312
`❌` ResourceNameRestriction	The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L324
`❌` ResourceNameRestriction	The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L372
`❌` ResourceNameRestriction	The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L372
`❌` TrackedResourcePatchOperation	Tracked resource 'PrivateEndpointConnection' must have patch operation that at least supports the update of tags. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L372
`❌` CreateOperationAsyncResponseValidation	Only 201 is the supported response code for PUT async response. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L426
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L426
`❌` DeleteOperationAsyncResponseValidation	An async DELETE operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L440
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L475
`❌` ResourceNameRestriction	The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L537
`❌` ResourceNameRestriction	The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L582
`❌` ResourceNameRestriction	The resource name parameter 'namespaceName' should be defined with a 'pattern' restriction. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L624
`❌` ResourceNameRestriction	The resource name parameter 'resourceAssociationName' should be defined with a 'pattern' restriction. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L624
`❌` PostOperationAsyncResponseValidation	An async POST operation must set long running operation options 'x-ms-long-running-operation-options' Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L625
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L657
`❌` MissingTypeObject	The schema 'EHNamespaceListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L672
`❌` MissingTypeObject	The schema 'EHNamespace' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L688
`❌` MissingTypeObject	The schema 'properties' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L703
`❌` MissingTypeObject	The schema 'Identity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L857
`❌` MissingTypeObject	The schema 'Encryption' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.EventHub/preview/2022-10-01-preview/namespaces-preview.json#L912

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

API Test is not triggered due to precheck failure. Check pipeline log for details.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-13T05:34:14Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

❌azure-sdk-for-js - @azure/arm-eventhub - 6.0.0-beta.1

+	Interface ConsumerGroupsListByEventHubNextOptionalParams no longer has parameter skip
+	Interface ConsumerGroupsListByEventHubNextOptionalParams no longer has parameter top
+	Interface EventHubsListByNamespaceNextOptionalParams no longer has parameter skip
+	Interface EventHubsListByNamespaceNextOptionalParams no longer has parameter top
+	Interface SchemaRegistryListByNamespaceNextOptionalParams no longer has parameter skip
+	Interface SchemaRegistryListByNamespaceNextOptionalParams no longer has parameter top

❌azure-sdk-for-python-track2 - track2_azure-mgmt-eventhub - 11.0.0b1

-	Model NetworkSecurityPerimeterConfiguration no longer has parameter location

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 25925cc. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.ResourceManager.EventHubs [View full logs] [Release SDK Changes]
- Azure.ResourceManager.EventHubs.1.1.0-alpha.20230413.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs]Release - Generate from 25925cc. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.0 -> 9.6.4
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.4>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-eventhub [View full logs] [Release SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model Eventhub has a new parameter retention_description
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Model NetworkSecurityPerimeterConfiguration no longer has parameter tags

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 25925cc. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-eventhubs-generated [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 25925cc. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/eventhub/armeventhub [View full logs] [Release SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `PublicNetworkAccessFlagSecuredByPerimeter` added to enum type `PublicNetworkAccessFlag`
info	[Changelog] - New enum type `ApplicationGroupPolicyType` with values `ApplicationGroupPolicyTypeThrottlingPolicy`
info	[Changelog] - New enum type `CleanupPolicyRetentionDescription` with values `CleanupPolicyRetentionDescriptionCompaction`, `CleanupPolicyRetentionDescriptionDelete`
info	[Changelog] - New enum type `MetricID` with values `MetricIDIncomingBytes`, `MetricIDIncomingMessages`, `MetricIDOutgoingBytes`, `MetricIDOutgoingMessages`
info	[Changelog] - New enum type `NetworkSecurityPerimeterConfigurationProvisioningState` with values `NetworkSecurityPerimeterConfigurationProvisioningStateAccepted`, `NetworkSecurityPerimeterConfigurationProvisioningStateCanceled`, `NetworkSecurityPerimeterConfigurationProvisioningStateCreating`, `NetworkSecurityPerimeterConfigurationProvisioningStateDeleted`, `NetworkSecurityPerimeterConfigurationProvisioningStateDeleting`, `NetworkSecurityPerimeterConfigurationProvisioningStateFailed`, `NetworkSecurityPerimeterConfigurationProvisioningStateInvalidResponse`, `NetworkSecurityPerimeterConfigurationProvisioningStateSucceeded`, `NetworkSecurityPerimeterConfigurationProvisioningStateSucceededWithIssues`, `NetworkSecurityPerimeterConfigurationProvisioningStateUnknown`, `NetworkSecurityPerimeterConfigurationProvisioningStateUpdating`
info	[Changelog] - New enum type `NspAccessRuleDirection` with values `NspAccessRuleDirectionInbound`, `NspAccessRuleDirectionOutbound`
info	[Changelog] - New enum type `PublicNetworkAccess` with values `PublicNetworkAccessDisabled`, `PublicNetworkAccessEnabled`, `PublicNetworkAccessSecuredByPerimeter`
info	[Changelog] - New enum type `ResourceAssociationAccessMode` with values `ResourceAssociationAccessModeAuditMode`, `ResourceAssociationAccessModeEnforcedMode`, `ResourceAssociationAccessModeLearningMode`, `ResourceAssociationAccessModeNoAssociationMode`, `ResourceAssociationAccessModeUnspecifiedMode`
info	[Changelog] - New enum type `TLSVersion` with values `TLSVersionOne0`, `TLSVersionOne1`, `TLSVersionOne2`
info	[Changelog] - New function `NewApplicationGroupClient(string, azcore.TokenCredential, *arm.ClientOptions) (*ApplicationGroupClient, error)`
info	[Changelog] - New function `*ApplicationGroupClient.CreateOrUpdateApplicationGroup(context.Context, string, string, string, ApplicationGroup, *ApplicationGroupClientCreateOrUpdateApplicationGroupOptions) (ApplicationGroupClientCreateOrUpdateApplicationGroupResponse, error)`
info	[Changelog] - New function `*ApplicationGroupClient.Delete(context.Context, string, string, string, *ApplicationGroupClientDeleteOptions) (ApplicationGroupClientDeleteResponse, error)`
info	[Changelog] - New function `*ApplicationGroupClient.Get(context.Context, string, string, string, *ApplicationGroupClientGetOptions) (ApplicationGroupClientGetResponse, error)`
info	[Changelog] - New function `*ApplicationGroupClient.NewListByNamespacePager(string, string, *ApplicationGroupClientListByNamespaceOptions) *runtime.Pager[ApplicationGroupClientListByNamespaceResponse]`
info	[Changelog] - New function `*ApplicationGroupPolicy.GetApplicationGroupPolicy() *ApplicationGroupPolicy`
info	[Changelog] - New function `*ClientFactory.NewApplicationGroupClient() *ApplicationGroupClient`
info	[Changelog] - New function `*ClientFactory.NewNetworkSecurityPerimeterConfigurationClient() *NetworkSecurityPerimeterConfigurationClient`
info	[Changelog] - New function `*ClientFactory.NewNetworkSecurityPerimeterConfigurationsClient() *NetworkSecurityPerimeterConfigurationsClient`
info	[Changelog] - New function `*ThrottlingPolicy.GetApplicationGroupPolicy() *ApplicationGroupPolicy`
info	[Changelog] - New function `NewNetworkSecurityPerimeterConfigurationClient(string, azcore.TokenCredential, *arm.ClientOptions) (*NetworkSecurityPerimeterConfigurationClient, error)`
info	[Changelog] - New function `*NetworkSecurityPerimeterConfigurationClient.List(context.Context, string, string, *NetworkSecurityPerimeterConfigurationClientListOptions) (NetworkSecurityPerimeterConfigurationClientListResponse, error)`
info	[Changelog] - New function `NewNetworkSecurityPerimeterConfigurationsClient(string, azcore.TokenCredential, *arm.ClientOptions) (*NetworkSecurityPerimeterConfigurationsClient, error)`
info	[Changelog] - New function `*NetworkSecurityPerimeterConfigurationsClient.BeginCreateOrUpdate(context.Context, string, string, string, *NetworkSecurityPerimeterConfigurationsClientBeginCreateOrUpdateOptions) (*runtime.Poller[NetworkSecurityPerimeterConfigurationsClientCreateOrUpdateResponse], error)`
info	[Changelog] - New struct `ApplicationGroup`
info	[Changelog] - New struct `ApplicationGroupListResult`
info	[Changelog] - New struct `ApplicationGroupProperties`
info	[Changelog] - New struct `NetworkSecurityPerimeter`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfiguration`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationList`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationProperties`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationPropertiesProfile`
info	[Changelog] - New struct `NetworkSecurityPerimeterConfigurationPropertiesResourceAssociation`
info	[Changelog] - New struct `NspAccessRule`
info	[Changelog] - New struct `NspAccessRuleProperties`
info	[Changelog] - New struct `NspAccessRulePropertiesSubscriptionsItem`
info	[Changelog] - New struct `ProvisioningIssue`
info	[Changelog] - New struct `ProvisioningIssueProperties`
info	[Changelog] - New struct `RetentionDescription`
info	[Changelog] - New struct `ThrottlingPolicy`
info	[Changelog] - New field `SupportsScaling` in struct `ClusterProperties`
info	[Changelog] - New field `MinimumTLSVersion` in struct `EHNamespaceProperties`
info	[Changelog] - New field `PublicNetworkAccess` in struct `EHNamespaceProperties`
info	[Changelog] - New field `RetentionDescription` in struct `Properties`
info	[Changelog]
info	[Changelog] Total 0 breaking change(s), 90 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 25925cc. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-eventhub [View full logs] [Release SDK Changes] Breaking Change Detected

azure-arm-eventhub-6.0.0-beta.1.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation group ApplicationGroupOperations
info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurationOperations
info	[Changelog]   - Added operation group NetworkSecurityPerimeterConfigurations
info	[Changelog]   - Added Interface ApplicationGroup
info	[Changelog]   - Added Interface ApplicationGroupCreateOrUpdateApplicationGroupOptionalParams
info	[Changelog]   - Added Interface ApplicationGroupDeleteOptionalParams
info	[Changelog]   - Added Interface ApplicationGroupGetOptionalParams
info	[Changelog]   - Added Interface ApplicationGroupListByNamespaceNextOptionalParams
info	[Changelog]   - Added Interface ApplicationGroupListByNamespaceOptionalParams
info	[Changelog]   - Added Interface ApplicationGroupListResult
info	[Changelog]   - Added Interface ApplicationGroupPolicy
info	[Changelog]   - Added Interface NetworkSecurityPerimeter
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfiguration
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationList
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationListOptionalParams
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationPropertiesProfile
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationPropertiesResourceAssociation
info	[Changelog]   - Added Interface NetworkSecurityPerimeterConfigurationsCreateOrUpdateOptionalParams
info	[Changelog]   - Added Interface NspAccessRule
info	[Changelog]   - Added Interface NspAccessRuleProperties
info	[Changelog]   - Added Interface NspAccessRulePropertiesSubscriptionsItem
info	[Changelog]   - Added Interface ProvisioningIssue
info	[Changelog]   - Added Interface ProvisioningIssueProperties
info	[Changelog]   - Added Interface RetentionDescription
info	[Changelog]   - Added Interface ThrottlingPolicy
info	[Changelog]   - Added Type Alias ApplicationGroupCreateOrUpdateApplicationGroupResponse
info	[Changelog]   - Added Type Alias ApplicationGroupGetResponse
info	[Changelog]   - Added Type Alias ApplicationGroupListByNamespaceNextResponse
info	[Changelog]   - Added Type Alias ApplicationGroupListByNamespaceResponse
info	[Changelog]   - Added Type Alias ApplicationGroupPolicyType
info	[Changelog]   - Added Type Alias ApplicationGroupPolicyUnion
info	[Changelog]   - Added Type Alias CleanupPolicyRetentionDescription
info	[Changelog]   - Added Type Alias MetricId
info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationListResponse
info	[Changelog]   - Added Type Alias NetworkSecurityPerimeterConfigurationProvisioningState
info	[Changelog]   - Added Type Alias NspAccessRuleDirection
info	[Changelog]   - Added Type Alias PublicNetworkAccess
info	[Changelog]   - Added Type Alias ResourceAssociationAccessMode
info	[Changelog]   - Added Type Alias TlsVersion
info	[Changelog]   - Interface Cluster has a new optional parameter supportsScaling
info	[Changelog]   - Interface EHNamespace has a new optional parameter minimumTlsVersion
info	[Changelog]   - Interface EHNamespace has a new optional parameter publicNetworkAccess
info	[Changelog]   - Interface Eventhub has a new optional parameter retentionDescription
info	[Changelog]   - Added Enum KnownApplicationGroupPolicyType
info	[Changelog]   - Added Enum KnownCleanupPolicyRetentionDescription
info	[Changelog]   - Added Enum KnownMetricId
info	[Changelog]   - Added Enum KnownNetworkSecurityPerimeterConfigurationProvisioningState
info	[Changelog]   - Added Enum KnownNspAccessRuleDirection
info	[Changelog]   - Added Enum KnownPublicNetworkAccess
info	[Changelog]   - Added Enum KnownResourceAssociationAccessMode
info	[Changelog]   - Added Enum KnownTlsVersion
info	[Changelog]   - Enum KnownPublicNetworkAccessFlag has a new value SecuredByPerimeter
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Interface ConsumerGroupsListByEventHubNextOptionalParams no longer has parameter skip
info	[Changelog]   - Interface ConsumerGroupsListByEventHubNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface EventHubsListByNamespaceNextOptionalParams no longer has parameter skip
info	[Changelog]   - Interface EventHubsListByNamespaceNextOptionalParams no longer has parameter top
info	[Changelog]   - Interface SchemaRegistryListByNamespaceNextOptionalParams no longer has parameter skip
info	[Changelog]   - Interface SchemaRegistryListByNamespaceNextOptionalParams no longer has parameter top

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs]Release - Generate from 25925cc. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh]  WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️eventhub [View full logs]

️️✔️ azure-powershell succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 25925cc. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.eventhub.DefaultTag [View full logs] [Release SDK Changes]
- Az.EventHub.0.1.0.nupkg

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-04-13T05:34:14Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/eventhub/armeventhub	https://apiview.dev/Assemblies/Review/9872c2e157da43a69d11ca272d053f5e
Java	azure-resourcemanager-eventhubs-generated	https://apiview.dev/Assemblies/Review/99e95174c4bb4b2e8ee996d9ebc854dd
.Net	Azure.ResourceManager.EventHubs	https://apiview.dev/Assemblies/Review/ef2d26d1323a45acba06e886ffa0d40f
JavaScript	@azure/arm-eventhub	https://apiview.dev/Assemblies/Review/9333b4e372214e62bdc568d118ec0b83

openapi-workflow-bot · 2023-04-13T05:42:50Z

NewApiVersionRequired reason:

A service’s API is a contract with customers and is represented by using the api-version query parameter. Changes such as adding an optional property to a request/response or introducing a new operation is a change to the service’s contract and therefore requires a new api-version value. This is critically important for documentation, client libraries, and customer support.

EXAMPLE: if a customer calls a service in the public cloud using api-version=2020-07-27, the new property or operation may exist but if they call the service in a government cloud, air-gapped cloud, or Azure Stack Hub cloud using the same api-version, the property or operation may not exist. Because there is no clear relationship between the service api-version and the new property/operation, customers can’t trust the documentation and Azure customer have difficulty helping customers diagnose issues. In addition, each client library version documents the service version it supports. When an optional property or new operation is added to a service and its Swagger, new client libraries must be produced to expose this functionality to customers. Without updating the api-version, it is unclear to customers which version of a client library supports these new features.

UPdates

90ede5c

ghost added the Event Hubs label Apr 13, 2023

azure-sdk mentioned this pull request Apr 13, 2023

[AutoPR sdk/resourcemanager/eventhub/armeventhub] [EventHub] NSP contract Inherits the ProxyResource definition instead of Resource azure-sdk/azure-sdk-for-go#5280

Closed

AzureRestAPISpecReview added NewApiVersionRequired resource-manager labels Apr 13, 2023

openapi-pipeline-app bot added the CI-BreakingChange-JavaScript label Apr 13, 2023

azure-sdk mentioned this pull request Apr 13, 2023

[AutoPR track2_azure-mgmt-eventhub] [EventHub] NSP contract Inherits the ProxyResource definition instead of Resource azure-sdk/azure-sdk-for-python#3294

Closed

openapi-pipeline-app bot added the CI-BreakingChange-Python-Track2 label Apr 13, 2023

schaudhari6254888 marked this pull request as ready for review April 13, 2023 07:11

schaudhari6254888 requested review from v-Ajnava, dsouzaarun and damodaravadhani as code owners April 13, 2023 07:11

openapi-assignment-bot bot assigned tadelesh Apr 13, 2023

raych1 assigned zedy-wj Apr 13, 2023

mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Apr 13, 2023

tadelesh approved these changes Apr 13, 2023

View reviewed changes

tadelesh merged commit 25925cc into Azure:main Apr 13, 2023

JoshLove-msft pushed a commit to JoshLove-msft/azure-rest-api-specs that referenced this pull request Apr 25, 2023

UPdates (Azure#23543)

b6b56c2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[EventHub] NSP contract Inherits the ProxyResource definition instead of Resource #23543

[EventHub] NSP contract Inherits the ProxyResource definition instead of Resource #23543

schaudhari6254888 commented Apr 13, 2023 •

edited by openapi-workflow-bot bot

Loading

openapi-workflow-bot bot commented Apr 13, 2023

openapi-pipeline-app bot commented Apr 13, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 13, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Apr 13, 2023 •

edited

Loading

openapi-workflow-bot bot commented Apr 13, 2023

[EventHub] NSP contract Inherits the ProxyResource definition instead of Resource #23543

[EventHub] NSP contract Inherits the ProxyResource definition instead of Resource #23543

Conversation

schaudhari6254888 commented Apr 13, 2023 • edited by openapi-workflow-bot bot Loading

ARM API Information (Control Plane)

Changelog

Contribution checklist (MS Employees Only):

ARM API Review Checklist

Breaking Change Review Checklist

openapi-workflow-bot bot commented Apr 13, 2023

openapi-pipeline-app bot commented Apr 13, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Apr 13, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Apr 13, 2023 • edited Loading

Generated ApiView

openapi-workflow-bot bot commented Apr 13, 2023

schaudhari6254888 commented Apr 13, 2023 •

edited by openapi-workflow-bot bot

Loading

openapi-pipeline-app bot commented Apr 13, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 13, 2023 •

edited

Loading

openapi-pipeline-app bot commented Apr 13, 2023 •

edited

Loading