Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.Cdn to add version stable/2023-05-01 #23615

Merged
merged 8 commits into from
May 24, 2023

Conversation

gubalasu
Copy link
Member

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM API Information (Control Plane)

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @gubalasu Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

  • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 18, 2023

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand]
    There are no breaking changes.
    ️❌Breaking Change(Cross-Version): 5 Errors, 2 Warnings failed [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    afdx.json 2023-05-01(19f2135) 2021-06-01(main)
    afdx.json 2023-05-01(19f2135) 2022-11-01-preview(main)
    cdn.json 2023-05-01(19f2135) 2021-06-01(main)
    cdn.json 2023-05-01(19f2135) 2022-11-01-preview(main)
    cdnwebapplicationfirewall.json 2023-05-01(19f2135) 2021-06-01(main)
    cdnwebapplicationfirewall.json 2023-05-01(19f2135) 2022-11-01-preview(main)

    The following breaking changes are detected by comparison with the latest stable version:

    Rule Message
    1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.Cdn/validateSecret' removed or restructured?
    Old: Microsoft.Cdn/stable/2021-06-01/afdx.json#L3242:5
    1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
    New: Microsoft.Cdn/stable/2023-05-01/afdx.json#L5829:9
    Old: Microsoft.Cdn/stable/2021-06-01/afdx.json#L5497:9
    1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
    New: Microsoft.Cdn/stable/2023-05-01/afdx.json#L5849:15
    Old: Microsoft.Cdn/stable/2021-06-01/afdx.json#L5513:15
    1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
    New: Microsoft.Cdn/stable/2023-05-01/afdx.json#L6062:9
    Old: Microsoft.Cdn/stable/2021-06-01/afdx.json#L5722:9
    1048 - AddedXmsEnum The new version adds a x-ms-enum extension.
    New: Microsoft.Cdn/stable/2023-05-01/afdx.json#L6082:15
    Old: Microsoft.Cdn/stable/2021-06-01/afdx.json#L5738:15


    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1011 - AddingResponseCode The new version adds a response code '202'.
    New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L392:11
    ⚠️ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
    New: Microsoft.Cdn/stable/2023-05-01/cdn.json#L354:7
    Old: Microsoft.Cdn/preview/2022-11-01-preview/cdn.json#L354:7
    ️️✔️CredScan succeeded [Detail] [Expand]
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.0.0) new version base version
    package-2023-05 package-2023-05(19f2135) default(main)

    The following errors/warnings exist before current PR submission:

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L136
    ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L185
    ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L357
    ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L406
    ResourceNameRestriction The resource name parameter 'customDomainName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L406
    RepeatedPathInfo The 'profileName' already appears in the path, please don't repeat it in the request body.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L473
    CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L521
    LroLocationHeader A 202 response should include an Location response header.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L521
    DeleteOperationAsyncResponseValidation An async DELETE operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L614
    ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L678
    ResourceNameRestriction The resource name parameter 'customDomainName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L678
    PostOperationAsyncResponseValidation An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L679
    ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L740
    ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L789
    ResourceNameRestriction The resource name parameter 'endpointName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L789
    RepeatedPathInfo The 'profileName' already appears in the path, please don't repeat it in the request body.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L856
    CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L899
    DeleteOperationAsyncResponseValidation An async DELETE operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L997
    ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L1061
    ResourceNameRestriction The resource name parameter 'endpointName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L1061
    PostOperationAsyncResponseValidation An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options'
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L1062
    ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L1132
    ResourceNameRestriction The resource name parameter 'endpointName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L1132
    ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L1188
    ResourceNameRestriction The resource name parameter 'endpointName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L1188
    ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L1250
    ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L1299
    ResourceNameRestriction The resource name parameter 'originGroupName' should be defined with a 'pattern' restriction.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L1299
    RepeatedPathInfo The 'profileName' already appears in the path, please don't repeat it in the request body.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L1366
    CreateOperationAsyncResponseValidation Only 201 is the supported response code for PUT async response.
    Location: Microsoft.Cdn/stable/2023-05-01/afdx.json#L1409
    ️❌Avocado: 4 Errors, 0 Warnings failed [Detail]
    Rule Message
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Cdn/CdnWebApplicationFirewallPolicies is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/cdn/resource-manager/readme.md
    json: Microsoft.Cdn/stable/2020-09-01/cdnwebapplicationfirewall.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.Cdn/CdnWebApplicationFirewallPolicies/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/cdn/resource-manager/readme.md
    json: Microsoft.Cdn/stable/2020-09-01/cdnwebapplicationfirewall.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.Cdn/CdnWebApplicationFirewallManagedRuleSets is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/cdn/resource-manager/readme.md
    json: Microsoft.Cdn/stable/2020-09-01/cdnwebapplicationfirewall.json
    MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.Cdn/validateSecret is not in the default tag. Please make sure the missing API swaggers are in the default tag.
    readme: specification/cdn/resource-manager/readme.md
    json: Microsoft.Cdn/stable/2021-06-01/afdx.json
    ️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
    Rule Message
    API Readiness check failed. Please make sure your service is deployed. "code: InvalidResourceType,
    message: The resource type 'operations' could not be found in the namespace 'Microsoft.Cdn' for api version '2023-05-01'. The supported api-versions are '2015-06-01,
    2016-04-02,
    2016-10-02,
    2017-04-02,
    2017-10-12,
    2018-04-02,
    2019-04-15,
    2019-06-15-preview,
    2019-12-31,
    2020-03-31,
    2020-04-15,
    2020-09-01,
    2021-06-01,
    2022-05-01-preview,
    2022-11-01-preview,
    2023-02-01-preview'."
    ️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]

    API Test is not triggered due to precheck failure. Check pipeline log for details.

    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️❌ModelValidation: 52 Errors, 0 Warnings failed [Detail]

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5324:36
    ExampleUrl: stable/2023-05-01/examples/Endpoints_ListByProfile.json#L30:33
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5306:26
    ExampleUrl: stable/2023-05-01/examples/Endpoints_ListByProfile.json#L28:17
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5418:41
    ExampleUrl: stable/2023-05-01/examples/Endpoints_ListByProfile.json#L44:33
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5400:31
    ExampleUrl: stable/2023-05-01/examples/Endpoints_ListByProfile.json#L42:17
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5324:36
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Get.json#L29:29
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5306:26
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Get.json#L27:13
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5418:41
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Get.json#L43:29
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5400:31
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Get.json#L41:13
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5324:36
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L158:29
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5324:36
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L170:29
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5306:26
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L156:13
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5306:26
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L168:13
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5418:41
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L184:29
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5400:31
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L182:13
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5324:36
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L294:29
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5324:36
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L306:29
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5306:26
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L292:13
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5306:26
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L304:13
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5418:41
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L320:29
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5400:31
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L318:13
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5324:36
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L433:29
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5324:36
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L445:29
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5306:26
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L431:13
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5306:26
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L443:13
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5418:41
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L459:29
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5400:31
    ExampleUrl: stable/2023-05-01/examples/Endpoints_Create.json#L457:13
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5324:36
    ExampleUrl: stable/2023-05-01/examples/Endpoints_ListByProfile.json#L30:33
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5306:26
    ExampleUrl: stable/2023-05-01/examples/Endpoints_ListByProfile.json#L28:17
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5418:41
    ExampleUrl: stable/2023-05-01/examples/Endpoints_ListByProfile.json#L44:33
    MISSING_RESOURCE_ID id is required to return in response of GET/PUT resource calls but not being provided
    Url: Microsoft.Cdn/stable/2023-05-01/cdn.json#L5400:31
    ExampleUrl: stable/2023-05-01/examples/Endpoints_ListByProfile.json#L42:17
    ️️✔️SemanticValidation succeeded [Detail] [Expand]
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand]
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand]
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand]
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand]
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand]
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand]
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 18, 2023

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand]
     Please click here to preview with your @microsoft account. 
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/cdn/armcdn - Approved - 2.0.0
    +	Enum `MetricsResponseGranularity` has been removed
    +	Enum `MetricsResponseSeriesItemUnit` has been removed
    +	Enum `WafMetricsResponseGranularity` has been removed
    +	Enum `WafMetricsResponseSeriesItemUnit` has been removed
    +	Function `*ClientFactory.NewValidateClient` has been removed
    +	Function `*ValidateClient.Secret` has been removed
    +	Function `NewValidateClient` has been removed
    +	Operation `*CustomDomainsClient.DisableCustomHTTPS` has been changed to LRO, use `*CustomDomainsClient.BeginDisableCustomHTTPS` instead.
    +	Operation `*CustomDomainsClient.EnableCustomHTTPS` has been changed to LRO, use `*CustomDomainsClient.BeginEnableCustomHTTPS` instead.
    +	Type of `EndpointProperties.CustomDomains` has been changed from `[]*CustomDomain` to `[]*DeepCreatedCustomDomain`
    +	Type of `MetricsResponse.Granularity` has been changed from `*MetricsResponseGranularity` to `*MetricsGranularity`
    +	Type of `MetricsResponseSeriesItem.Unit` has been changed from `*MetricsResponseSeriesItemUnit` to `*MetricsSeriesUnit`
    +	Type of `WafMetricsResponse.Granularity` has been changed from `*WafMetricsResponseGranularity` to `*WafMetricsGranularity`
    +	Type of `WafMetricsResponseSeriesItem.Unit` has been changed from `*WafMetricsResponseSeriesItemUnit` to `*WafMetricsSeriesUnit`
    azure-sdk-for-python-track2 - track2_azure-mgmt-cdn - Approved - 12.0.0
    +	Removed operation group ValidateOperations
    +	Renamed operation CustomDomainsOperations.disable_custom_https to CustomDomainsOperations.begin_disable_custom_https
    +	Renamed operation CustomDomainsOperations.enable_custom_https to CustomDomainsOperations.begin_enable_custom_https
    azure-sdk-for-js - @azure/arm-cdn - Approved - 9.0.0
    +	Class CdnManagementClient no longer has parameter validate
    +	Removed Enum KnownMetricsResponseGranularity
    +	Removed Enum KnownMetricsResponseSeriesItemUnit
    +	Removed Enum KnownWafMetricsResponseGranularity
    +	Removed operation group Validate
    +	Type of parameter granularity of interface MetricsResponse is changed from MetricsResponseGranularity to MetricsGranularity
    +	Type of parameter granularity of interface WafMetricsResponse is changed from WafMetricsResponseGranularity to WafMetricsGranularity
    +	Type of parameter unit of interface MetricsResponseSeriesItem is changed from MetricsResponseSeriesItemUnit to MetricsSeriesUnit
    +	Type of parameter unit of interface WafMetricsResponseSeriesItem is changed from "count" to WafMetricsSeriesUnit
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2b5927f. SDK Automation 14.0.0
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
      cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
      command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
      cmderr	[automation_generate.sh]
      cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.7
      cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.7>
      cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
      cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-cdn [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog]   - Added operation AFDProfilesOperations.begin_upgrade
      info	[Changelog]   - Added operation AFDProfilesOperations.check_endpoint_name_availability
      info	[Changelog]   - Added operation AFDProfilesOperations.validate_secret
      info	[Changelog]   - Added operation ProfilesOperations.begin_can_migrate
      info	[Changelog]   - Added operation ProfilesOperations.begin_migrate
      info	[Changelog]   - Added operation ProfilesOperations.begin_migration_commit
      info	[Changelog]   - Model AFDDomain has a new parameter extended_properties
      info	[Changelog]   - Model AFDDomainProperties has a new parameter extended_properties
      info	[Changelog]   - Model AzureFirstPartyManagedCertificateParameters has a new parameter certificate_authority
      info	[Changelog]   - Model AzureFirstPartyManagedCertificateParameters has a new parameter expiration_date
      info	[Changelog]   - Model AzureFirstPartyManagedCertificateParameters has a new parameter secret_source
      info	[Changelog]   - Model AzureFirstPartyManagedCertificateParameters has a new parameter subject
      info	[Changelog]   - Model AzureFirstPartyManagedCertificateParameters has a new parameter subject_alternative_names
      info	[Changelog]   - Model AzureFirstPartyManagedCertificateParameters has a new parameter thumbprint
      info	[Changelog]   - Model CdnWebApplicationFirewallPolicy has a new parameter extended_properties
      info	[Changelog]   - Model Profile has a new parameter extended_properties
      info	[Changelog]   - Model Profile has a new parameter identity
      info	[Changelog]   - Model ProfileUpdateParameters has a new parameter identity
      info	[Changelog]
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog]   - Removed operation group ValidateOperations
      info	[Changelog]   - Renamed operation CustomDomainsOperations.disable_custom_https to CustomDomainsOperations.begin_disable_custom_https
      info	[Changelog]   - Renamed operation CustomDomainsOperations.enable_custom_https to CustomDomainsOperations.begin_enable_custom_https
    ️⚠️ azure-sdk-for-java warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2b5927f. SDK Automation 14.0.0
      command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
      cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
      command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
    • ️✔️azure-resourcemanager-cdn-generated [View full logs]  [Release SDK Changes]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2b5927f. SDK Automation 14.0.0
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
      command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/cdn/armcdn [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
      info	[Changelog]
      info	[Changelog] - Type of `EndpointProperties.CustomDomains` has been changed from `[]*CustomDomain` to `[]*DeepCreatedCustomDomain`
      info	[Changelog] - Type of `MetricsResponse.Granularity` has been changed from `*MetricsResponseGranularity` to `*MetricsGranularity`
      info	[Changelog] - Type of `MetricsResponseSeriesItem.Unit` has been changed from `*MetricsResponseSeriesItemUnit` to `*MetricsSeriesUnit`
      info	[Changelog] - Type of `WafMetricsResponse.Granularity` has been changed from `*WafMetricsResponseGranularity` to `*WafMetricsGranularity`
      info	[Changelog] - Type of `WafMetricsResponseSeriesItem.Unit` has been changed from `*WafMetricsResponseSeriesItemUnit` to `*WafMetricsSeriesUnit`
      info	[Changelog] - Enum `MetricsResponseGranularity` has been removed
      info	[Changelog] - Enum `MetricsResponseSeriesItemUnit` has been removed
      info	[Changelog] - Enum `WafMetricsResponseGranularity` has been removed
      info	[Changelog] - Enum `WafMetricsResponseSeriesItemUnit` has been removed
      info	[Changelog] - Function `*ClientFactory.NewValidateClient` has been removed
      info	[Changelog] - Function `NewValidateClient` has been removed
      info	[Changelog] - Function `*ValidateClient.Secret` has been removed
      info	[Changelog] - Operation `*CustomDomainsClient.DisableCustomHTTPS` has been changed to LRO, use `*CustomDomainsClient.BeginDisableCustomHTTPS` instead.
      info	[Changelog] - Operation `*CustomDomainsClient.EnableCustomHTTPS` has been changed to LRO, use `*CustomDomainsClient.BeginEnableCustomHTTPS` instead.
      info	[Changelog]
      info	[Changelog] ### Features Added
      info	[Changelog]
      info	[Changelog] - New value `ProfileResourceStateAbortingMigration`, `ProfileResourceStateCommittingMigration`, `ProfileResourceStateMigrated`, `ProfileResourceStateMigrating`, `ProfileResourceStatePendingMigrationCommit` added to enum type `ProfileResourceState`
      info	[Changelog] - New enum type `CanMigrateDefaultSKU` with values `CanMigrateDefaultSKUPremiumAzureFrontDoor`, `CanMigrateDefaultSKUStandardAzureFrontDoor`
      info	[Changelog] - New enum type `ManagedServiceIdentityType` with values `ManagedServiceIdentityTypeNone`, `ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned`, `ManagedServiceIdentityTypeUserAssigned`
      info	[Changelog] - New enum type `MetricsGranularity` with values `MetricsGranularityP1D`, `MetricsGranularityPT1H`, `MetricsGranularityPT5M`
      info	[Changelog] - New enum type `MetricsSeriesUnit` with values `MetricsSeriesUnitBitsPerSecond`, `MetricsSeriesUnitBytes`, `MetricsSeriesUnitCount`, `MetricsSeriesUnitMilliSeconds`
      info	[Changelog] - New enum type `WafMetricsGranularity` with values `WafMetricsGranularityP1D`, `WafMetricsGranularityPT1H`, `WafMetricsGranularityPT5M`
      info	[Changelog] - New enum type `WafMetricsSeriesUnit` with values `WafMetricsSeriesUnitCount`
      info	[Changelog] - New function `*AFDProfilesClient.CheckEndpointNameAvailability(context.Context, string, string, CheckEndpointNameAvailabilityInput, *AFDProfilesClientCheckEndpointNameAvailabilityOptions) (AFDProfilesClientCheckEndpointNameAvailabilityResponse, error)`
      info	[Changelog] - New function `*AFDProfilesClient.BeginUpgrade(context.Context, string, string, ProfileUpgradeParameters, *AFDProfilesClientBeginUpgradeOptions) (*runtime.Poller[AFDProfilesClientUpgradeResponse], error)`
      info	[Changelog] - New function `*AFDProfilesClient.ValidateSecret(context.Context, string, string, ValidateSecretInput, *AFDProfilesClientValidateSecretOptions) (AFDProfilesClientValidateSecretResponse, error)`
      info	[Changelog] - New function `*ProfilesClient.BeginCanMigrate(context.Context, string, CanMigrateParameters, *ProfilesClientBeginCanMigrateOptions) (*runtime.Poller[ProfilesClientCanMigrateResponse], error)`
      info	[Changelog] - New function `*ProfilesClient.BeginMigrate(context.Context, string, MigrationParameters, *ProfilesClientBeginMigrateOptions) (*runtime.Poller[ProfilesClientMigrateResponse], error)`
      info	[Changelog] - New function `*ProfilesClient.BeginMigrationCommit(context.Context, string, string, *ProfilesClientBeginMigrationCommitOptions) (*runtime.Poller[ProfilesClientMigrationCommitResponse], error)`
      info	[Changelog] - New struct `CanMigrateParameters`
      info	[Changelog] - New struct `CanMigrateResult`
      info	[Changelog] - New struct `DeepCreatedCustomDomain`
      info	[Changelog] - New struct `DeepCreatedCustomDomainProperties`
      info	[Changelog] - New struct `ManagedServiceIdentity`
      info	[Changelog] - New struct `MigrateResult`
      info	[Changelog] - New struct `MigrationErrorType`
      info	[Changelog] - New struct `MigrationParameters`
      info	[Changelog] - New struct `MigrationWebApplicationFirewallMapping`
      info	[Changelog] - New struct `ProfileChangeSKUWafMapping`
      info	[Changelog] - New struct `ProfileUpgradeParameters`
      info	[Changelog] - New struct `UserAssignedIdentity`
      info	[Changelog] - New field `ExtendedProperties` in struct `AFDDomainProperties`
      info	[Changelog] - New field `CertificateAuthority`, `ExpirationDate`, `SecretSource`, `Subject`, `SubjectAlternativeNames`, `Thumbprint` in struct `AzureFirstPartyManagedCertificateParameters`
      info	[Changelog] - New field `Identity` in struct `Profile`
      info	[Changelog] - New field `ExtendedProperties` in struct `ProfileProperties`
      info	[Changelog] - New field `Identity` in struct `ProfileUpdateParameters`
      info	[Changelog] - New field `ExtendedProperties` in struct `WebApplicationFirewallPolicyProperties`
      info	[Changelog]
      info	[Changelog] Total 14 breaking change(s), 64 additive change(s).
    ️❌ azure-sdk-for-net-track2 failed [Detail]
    • Failed [Logs]Release - Generate from 2b5927f. SDK Automation 14.0.0
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
      command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to build sdk. exit code: False
      cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    • Azure.ResourceManager.Cdn [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.Cdn.Models.MetricsResponseGranularity' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cdn/Azure.ResourceManager.Cdn/src/Azure.ResourceManager.Cdn.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Nullable<Azure.ResourceManager.Cdn.Models.MetricsResponseSeriesItemUnit> Azure.ResourceManager.Cdn.Models.MetricsResponseSeriesItem.Unit.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cdn/Azure.ResourceManager.Cdn/src/Azure.ResourceManager.Cdn.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.Cdn.Models.MetricsResponseSeriesItemUnit' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cdn/Azure.ResourceManager.Cdn/src/Azure.ResourceManager.Cdn.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Nullable<Azure.ResourceManager.Cdn.Models.WafMetricsResponseGranularity> Azure.ResourceManager.Cdn.Models.WafMetricsResponse.Granularity.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cdn/Azure.ResourceManager.Cdn/src/Azure.ResourceManager.Cdn.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.Cdn.Models.WafMetricsResponseGranularity' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cdn/Azure.ResourceManager.Cdn/src/Azure.ResourceManager.Cdn.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public System.Nullable<Azure.ResourceManager.Cdn.Models.WafMetricsResponseSeriesItemUnit> Azure.ResourceManager.Cdn.Models.WafMetricsResponseSeriesItem.Unit.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cdn/Azure.ResourceManager.Cdn/src/Azure.ResourceManager.Cdn.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.Cdn.Models.WafMetricsResponseSeriesItemUnit' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cdn/Azure.ResourceManager.Cdn/src/Azure.ResourceManager.Cdn.csproj::TargetFramework=netstandard2.0],
      info	[Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.Cdn/Debug/netstandard2.0/Azure.ResourceManager.Cdn.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/cdn/Azure.ResourceManager.Cdn/src/Azure.ResourceManager.Cdn.csproj::TargetFramework=netstandard2.0]
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 2b5927f. SDK Automation 14.0.0
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
      warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
      command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-cdn [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added operation Profiles.beginCanMigrate
      info	[Changelog]   - Added operation Profiles.beginCanMigrateAndWait
      info	[Changelog]   - Added operation Profiles.beginMigrate
      info	[Changelog]   - Added operation Profiles.beginMigrateAndWait
      info	[Changelog]   - Added operation Profiles.beginMigrationCommit
      info	[Changelog]   - Added operation Profiles.beginMigrationCommitAndWait
      info	[Changelog]   - Added Interface AfdCustomDomainsCreateHeaders
      info	[Changelog]   - Added Interface AfdCustomDomainsDeleteHeaders
      info	[Changelog]   - Added Interface AfdCustomDomainsRefreshValidationTokenHeaders
      info	[Changelog]   - Added Interface AfdCustomDomainsUpdateHeaders
      info	[Changelog]   - Added Interface AfdEndpointsCreateHeaders
      info	[Changelog]   - Added Interface AfdEndpointsDeleteHeaders
      info	[Changelog]   - Added Interface AfdEndpointsPurgeContentHeaders
      info	[Changelog]   - Added Interface AfdEndpointsUpdateHeaders
      info	[Changelog]   - Added Interface AfdOriginGroupsCreateHeaders
      info	[Changelog]   - Added Interface AfdOriginGroupsDeleteHeaders
      info	[Changelog]   - Added Interface AfdOriginGroupsUpdateHeaders
      info	[Changelog]   - Added Interface AfdOriginsCreateHeaders
      info	[Changelog]   - Added Interface AfdOriginsDeleteHeaders
      info	[Changelog]   - Added Interface AfdOriginsUpdateHeaders
      info	[Changelog]   - Added Interface AfdProfilesCheckEndpointNameAvailabilityOptionalParams
      info	[Changelog]   - Added Interface AfdProfilesUpgradeHeaders
      info	[Changelog]   - Added Interface AfdProfilesUpgradeOptionalParams
      info	[Changelog]   - Added Interface AfdProfilesValidateSecretOptionalParams
      info	[Changelog]   - Added Interface CanMigrateParameters
      info	[Changelog]   - Added Interface CanMigrateResult
      info	[Changelog]   - Added Interface CustomDomainsCreateHeaders
      info	[Changelog]   - Added Interface CustomDomainsDeleteHeaders
      info	[Changelog]   - Added Interface CustomDomainsDisableCustomHttpsHeaders
      info	[Changelog]   - Added Interface CustomDomainsEnableCustomHttpsHeaders
      info	[Changelog]   - Added Interface EndpointsCreateHeaders
      info	[Changelog]   - Added Interface EndpointsDeleteHeaders
      info	[Changelog]   - Added Interface EndpointsLoadContentHeaders
      info	[Changelog]   - Added Interface EndpointsPurgeContentHeaders
      info	[Changelog]   - Added Interface EndpointsStartHeaders
      info	[Changelog]   - Added Interface EndpointsStopHeaders
      info	[Changelog]   - Added Interface EndpointsUpdateHeaders
      info	[Changelog]   - Added Interface ManagedServiceIdentity
      info	[Changelog]   - Added Interface MigrateResult
      info	[Changelog]   - Added Interface MigrationErrorType
      info	[Changelog]   - Added Interface MigrationParameters
      info	[Changelog]   - Added Interface MigrationWebApplicationFirewallMapping
      info	[Changelog]   - Added Interface OriginGroupsCreateHeaders
      info	[Changelog]   - Added Interface OriginGroupsDeleteHeaders
      info	[Changelog]   - Added Interface OriginGroupsUpdateHeaders
      info	[Changelog]   - Added Interface OriginsCreateHeaders
      info	[Changelog]   - Added Interface OriginsDeleteHeaders
      info	[Changelog]   - Added Interface OriginsUpdateHeaders
      info	[Changelog]   - Added Interface PoliciesCreateOrUpdateHeaders
      info	[Changelog]   - Added Interface PoliciesUpdateHeaders
      info	[Changelog]   - Added Interface ProfileChangeSkuWafMapping
      info	[Changelog]   - Added Interface ProfilesCanMigrateHeaders
      info	[Changelog]   - Added Interface ProfilesCanMigrateOptionalParams
      info	[Changelog]   - Added Interface ProfilesCreateHeaders
      info	[Changelog]   - Added Interface ProfilesDeleteHeaders
      info	[Changelog]   - Added Interface ProfilesMigrateHeaders
      info	[Changelog]   - Added Interface ProfilesMigrateOptionalParams
      info	[Changelog]   - Added Interface ProfilesMigrationCommitHeaders
      info	[Changelog]   - Added Interface ProfilesMigrationCommitOptionalParams
      info	[Changelog]   - Added Interface ProfilesUpdateHeaders
      info	[Changelog]   - Added Interface ProfileUpgradeParameters
      info	[Changelog]   - Added Interface RoutesCreateHeaders
      info	[Changelog]   - Added Interface RoutesDeleteHeaders
      info	[Changelog]   - Added Interface RoutesUpdateHeaders
      info	[Changelog]   - Added Interface RulesCreateHeaders
      info	[Changelog]   - Added Interface RulesDeleteHeaders
      info	[Changelog]   - Added Interface RuleSetsDeleteHeaders
      info	[Changelog]   - Added Interface RulesUpdateHeaders
      info	[Changelog]   - Added Interface SecretsCreateHeaders
      info	[Changelog]   - Added Interface SecretsDeleteHeaders
      info	[Changelog]   - Added Interface SecurityPoliciesCreateHeaders
      info	[Changelog]   - Added Interface SecurityPoliciesDeleteHeaders
      info	[Changelog]   - Added Interface SecurityPoliciesPatchHeaders
      info	[Changelog]   - Added Interface UserAssignedIdentity
      info	[Changelog]   - Added Type Alias AfdProfilesCheckEndpointNameAvailabilityResponse
      info	[Changelog]   - Added Type Alias AfdProfilesUpgradeResponse
      info	[Changelog]   - Added Type Alias AfdProfilesValidateSecretResponse
      info	[Changelog]   - Added Type Alias CanMigrateDefaultSku
      info	[Changelog]   - Added Type Alias ManagedServiceIdentityType
      info	[Changelog]   - Added Type Alias MetricsGranularity
      info	[Changelog]   - Added Type Alias MetricsSeriesUnit
      info	[Changelog]   - Added Type Alias ProfilesCanMigrateResponse
      info	[Changelog]   - Added Type Alias ProfilesMigrateResponse
      info	[Changelog]   - Added Type Alias WafMetricsGranularity
      info	[Changelog]   - Added Type Alias WafMetricsSeriesUnit
      info	[Changelog]   - Interface AFDDomain has a new optional parameter extendedProperties
      info	[Changelog]   - Interface AFDDomainProperties has a new optional parameter extendedProperties
      info	[Changelog]   - Interface AzureFirstPartyManagedCertificateParameters has a new optional parameter certificateAuthority
      info	[Changelog]   - Interface AzureFirstPartyManagedCertificateParameters has a new optional parameter expirationDate
      info	[Changelog]   - Interface AzureFirstPartyManagedCertificateParameters has a new optional parameter secretSource
      info	[Changelog]   - Interface AzureFirstPartyManagedCertificateParameters has a new optional parameter subject
      info	[Changelog]   - Interface AzureFirstPartyManagedCertificateParameters has a new optional parameter subjectAlternativeNames
      info	[Changelog]   - Interface AzureFirstPartyManagedCertificateParameters has a new optional parameter thumbprint
      info	[Changelog]   - Interface CdnWebApplicationFirewallPolicy has a new optional parameter extendedProperties
      info	[Changelog]   - Interface Profile has a new optional parameter extendedProperties
      info	[Changelog]   - Interface Profile has a new optional parameter identity
      info	[Changelog]   - Interface ProfileUpdateParameters has a new optional parameter identity
      info	[Changelog]   - Added Enum KnownCanMigrateDefaultSku
      info	[Changelog]   - Added Enum KnownManagedServiceIdentityType
      info	[Changelog]   - Added Enum KnownMetricsGranularity
      info	[Changelog]   - Added Enum KnownMetricsSeriesUnit
      info	[Changelog]   - Added Enum KnownWafMetricsGranularity
      info	[Changelog]   - Added Enum KnownWafMetricsSeriesUnit
      info	[Changelog]   - Enum KnownProfileResourceState has a new value AbortingMigration
      info	[Changelog]   - Enum KnownProfileResourceState has a new value CommittingMigration
      info	[Changelog]   - Enum KnownProfileResourceState has a new value Migrated
      info	[Changelog]   - Enum KnownProfileResourceState has a new value Migrating
      info	[Changelog]   - Enum KnownProfileResourceState has a new value PendingMigrationCommit
      info	[Changelog]
      info	[Changelog] **Breaking Changes**
      info	[Changelog]
      info	[Changelog]   - Removed operation group Validate
      info	[Changelog]   - Type of parameter granularity of interface MetricsResponse is changed from MetricsResponseGranularity to MetricsGranularity
      info	[Changelog]   - Type of parameter unit of interface MetricsResponseSeriesItem is changed from MetricsResponseSeriesItemUnit to MetricsSeriesUnit
      info	[Changelog]   - Type of parameter granularity of interface WafMetricsResponse is changed from WafMetricsResponseGranularity to WafMetricsGranularity
      info	[Changelog]   - Type of parameter unit of interface WafMetricsResponseSeriesItem is changed from "count" to WafMetricsSeriesUnit
      info	[Changelog]   - Class CdnManagementClient no longer has parameter validate
      info	[Changelog]   - Removed Enum KnownMetricsResponseGranularity
      info	[Changelog]   - Removed Enum KnownMetricsResponseSeriesItemUnit
      info	[Changelog]   - Removed Enum KnownWafMetricsResponseGranularity
    ️⚠️ azure-resource-manager-schemas warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 2b5927f. Schema Automation 14.0.0
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
      cmderr	[initScript.sh]
      cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
      cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
      cmderr	[initScript.sh] npm WARN old lockfile
      cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
      cmderr	[initScript.sh] npm WARN old lockfile
      warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
      command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
      warn	No file changes detected after generation
      warn	Skip detect changed packages
    ️❌ azure-powershell failed [Detail]
    • Pipeline Framework Failed [Logs]Release - Generate from 2b5927f. SDK Automation 14.0.0
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
      command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
      SSL error: syscall failure: Broken pipe
      Error: SSL error: syscall failure: Broken pipe
    • Az.cdn.DefaultTag [View full logs
      error	Fatal error: SSL error: syscall failure: Broken pipe
      error	The following packages are still pending:
      error		Az.cdn.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the Network - CDN label Apr 18, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 18, 2023

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/cdn/armcdn https://apiview.dev/Assemblies/Review/c00bde9b71c74bc4bba885bb0f871bb0
    .Net Azure.ResourceManager.Cdn https://apiview.dev/Assemblies/Review/91591547816a4ac2ac8fc86bd58f6551
    Java azure-resourcemanager-cdn-generated https://apiview.dev/Assemblies/Review/82301d9f092f453f9e381d5cd93f4753
    JavaScript @azure/arm-cdn https://apiview.dev/Assemblies/Review/d11496a1be00485a8643fcc34152dee0

    @openapi-workflow-bot
    Copy link

    Hi @gubalasu, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review.
    Action: To initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
    If you want to know the production traffic statistic, please see ARM Traffic statistic.
    If you think it is false positive breaking change, please provide the reasons in the PR comment, report to Swagger Tooling Team via https://aka.ms/swaggerfeedback.
    Note: To avoid breaking change, you can refer to Shift Left Solution for detecting breaking change in early phase at your service code repository.

    @gubalasu
    Copy link
    Member Author

    /azp run unifiedPipeline

    @azure-pipelines
    Copy link

    No pipelines are associated with this pull request.

    @openapi-pipeline-app
    Copy link

    Swagger Generation Artifacts

    ️🔄ApiDocPreview inProgress [Detail]
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    azure-sdk-for-go - sdk/resourcemanager/cdn/armcdn - 2.0.0
    +	Function `*ClientFactory.NewValidateClient` has been removed
    +	Function `*ValidateClient.Secret` has been removed
    +	Function `NewValidateClient` has been removed
    +	Operation `*CustomDomainsClient.DisableCustomHTTPS` has been changed to LRO, use `*CustomDomainsClient.BeginDisableCustomHTTPS` instead.
    +	Operation `*CustomDomainsClient.EnableCustomHTTPS` has been changed to LRO, use `*CustomDomainsClient.BeginEnableCustomHTTPS` instead.
    +	Type alias `MetricsResponseGranularity` has been removed
    +	Type alias `MetricsResponseSeriesItemUnit` has been removed
    +	Type alias `WafMetricsResponseGranularity` has been removed
    +	Type alias `WafMetricsResponseSeriesItemUnit` has been removed
    +	Type of `EndpointProperties.CustomDomains` has been changed from `[]*CustomDomain` to `[]*DeepCreatedCustomDomain`
    +	Type of `MetricsResponse.Granularity` has been changed from `*MetricsResponseGranularity` to `*MetricsGranularity`
    +	Type of `MetricsResponseSeriesItem.Unit` has been changed from `*MetricsResponseSeriesItemUnit` to `*MetricsSeriesUnit`
    +	Type of `WafMetricsResponse.Granularity` has been changed from `*WafMetricsResponseGranularity` to `*WafMetricsGranularity`
    +	Type of `WafMetricsResponseSeriesItem.Unit` has been changed from `*WafMetricsResponseSeriesItemUnit` to `*WafMetricsSeriesUnit`
    azure-sdk-for-python-track2 - track2_azure-mgmt-cdn - 12.1.0b1
    +	Removed operation group ValidateOperations
    +	Renamed operation CustomDomainsOperations.disable_custom_https to CustomDomainsOperations.begin_disable_custom_https
    +	Renamed operation CustomDomainsOperations.enable_custom_https to CustomDomainsOperations.begin_enable_custom_https
    azure-sdk-for-js - @azure/arm-cdn - 9.0.0
    +	Class CdnManagementClient no longer has parameter validate
    +	Removed Enum KnownMetricsResponseGranularity
    +	Removed Enum KnownMetricsResponseSeriesItemUnit
    +	Removed Enum KnownWafMetricsResponseGranularity
    +	Removed operation group Validate
    +	Type of parameter granularity of interface MetricsResponse is changed from MetricsResponseGranularity to MetricsGranularity
    +	Type of parameter granularity of interface WafMetricsResponse is changed from WafMetricsResponseGranularity to WafMetricsGranularity
    +	Type of parameter unit of interface MetricsResponseSeriesItem is changed from MetricsResponseSeriesItemUnit to MetricsSeriesUnit
    +	Type of parameter unit of interface WafMetricsResponseSeriesItem is changed from "count" to WafMetricsSeriesUnit
    ️⌛ azure-sdk-for-python-track2 pending [Detail]
    ️⌛ azure-sdk-for-java pending [Detail]
    ️⌛ azure-sdk-for-go pending [Detail]
    ️⌛ azure-sdk-for-net-track2 pending [Detail]
    ️⌛ azure-sdk-for-js pending [Detail]
    ️🔄 azure-resource-manager-schemas inProgress [Detail]
    ️⌛ azure-powershell pending [Detail]
    Posted by Swagger Pipeline | How to fix these errors?

    @gubalasu gubalasu marked this pull request as ready for review April 20, 2023 05:24
    @openapi-workflow-bot
    Copy link

    Hi @gubalasu, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
    If you need further help, please feedback via swagger feedback.

    @gubalasu
    Copy link
    Member Author

    Waiting to do breaking change review
    https://msazure.visualstudio.com/One/_workitems/edit/22295859

    @mikekistler
    Copy link
    Member

    Breaking change previously reviewed and approved in #20979

    @mikekistler mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label May 15, 2023
    @openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 15, 2023
    @raosuhas raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 15, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 15, 2023
    @lirenhe
    Copy link
    Member

    lirenhe commented May 22, 2023

    @gubalasu, please fix the tooling check error for 'Swagger Avocado' & Swagger ModelValidation. Those are required for merging the PR. Thanks

    @lirenhe
    Copy link
    Member

    lirenhe commented May 22, 2023

    @weidongxu-microsoft, @qiaozha, @tadelesh, could you help to check the SDK breaking changes for this PR?

    @weidongxu-microsoft
    Copy link
    Member

    Remove path may cause some problem, but so far it is not exposed in convenience API in Java.

    x-ms-enum change maybe fine, I assume m4 default to modelAsString=true

    @gubalasu
    Copy link
    Member Author

    SDK errors are not because of the changes in this PR. Rather it was carried over from older ones. These are already approved in an older version: https://github.com/Azure/azure-rest-api-specs/pull/23493/checks?check_run_id=12625114723
    @lirenhe Is this enough to merge this? Or we still need approval from the other folks?

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Approved-Avocado Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-ModelValidation Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-FixRequiredOnFailure Network - CDN new-api-version resource-manager
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    9 participants