Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new test notification APIs for Tenant Action Groups #23714

Merged
merged 10 commits into from
May 15, 2023
Merged

Add new test notification APIs for Tenant Action Groups #23714

merged 10 commits into from
May 15, 2023

Conversation

thomasp98296
Copy link
Contributor

@thomasp98296 thomasp98296 commented Apr 25, 2023 •
edited
Loading

ARM API Information (Control Plane)

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.

Changelog

Add a changelog entry for this PR by answering the following questions:

  1. What's the purpose of the update?
    • new service onboarding
    • new API version
    • update existing version for new feature
    • update existing version to fix swagger quality issue in s360
    • Other, please clarify
  2. When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
  3. When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
  4. By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

Applicability: ⚠️

If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

  • Change to data plane APIs
  • Adding new properties
  • All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

  • Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

    • Adding a new service
    • Adding new API(s)
    • Adding a new API version
      -[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

  • Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.

NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)

Please follow the link to find more details on PR review process.

@openapi-workflow-bot
Copy link

Hi, @thomasp98296 Thanks for your PR. I am workflow bot for review process. Here are some small tips.

  • Please ensure to do self-check against checklists in first PR comment.
  • PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.
  • For specs comparison cross API versions, Use API Specs Comparison Report Generator
  • If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

    • Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 25, 2023 •
    edited
    Loading

    Swagger Validation Report

    ️️✔️BreakingChange succeeded [Detail] [Expand] 
    There are no breaking changes.
    ️⚠️Breaking Change(Cross-Version): 5 Warnings warning [Detail]
    compared swaggers (via Oad v0.10.4)] new version base version
    tenantActionGroups_API.json 2023-05-01-preview(a4e0a89) 2023-03-01-preview(main)

    The following breaking changes are detected by comparison with the latest preview version:

    Rule Message
    ⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Insights/preview/2023-05-01-preview/tenantActionGroups_API.json#L48:9
    Old: Microsoft.Insights/preview/2023-03-01-preview/tenantActionGroups_API.json#L48:9
    ⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Insights/preview/2023-05-01-preview/tenantActionGroups_API.json#L100:9
    Old: Microsoft.Insights/preview/2023-03-01-preview/tenantActionGroups_API.json#L100:9
    ⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Insights/preview/2023-05-01-preview/tenantActionGroups_API.json#L137:9
    Old: Microsoft.Insights/preview/2023-03-01-preview/tenantActionGroups_API.json#L137:9
    ⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Insights/preview/2023-05-01-preview/tenantActionGroups_API.json#L169:9
    Old: Microsoft.Insights/preview/2023-03-01-preview/tenantActionGroups_API.json#L169:9
    ⚠️ 1036 - ConstraintChanged The new version has a different 'pattern' value than the previous one.
    New: Microsoft.Insights/preview/2023-05-01-preview/tenantActionGroups_API.json#L834:5
    Old: Microsoft.Insights/preview/2023-03-01-preview/tenantActionGroups_API.json#L600:5
    ️️✔️CredScan succeeded [Detail] [Expand] 
    There is no credential detected.
    ️⚠️LintDiff: 0 Warnings warning [Detail]
    compared tags (via openapi-validator v2.1.1) new version base version
    package-2023-04 package-2023-04(a4e0a89) package-2023-04(main)

    The following errors/warnings exist before current PR submission:

    Rule Message
    ❌ PathForPutOperation The path for 'put' operation must be under a subscription and resource group.
    Location: Microsoft.Insights/preview/2023-05-01-preview/tenantActionGroups_API.json#L39
    ❌ TopLevelResourcesListBySubscription The top-level resource 'TenantActionGroupResource' does not have list by subscription operation, please add it.
    Location: Microsoft.Insights/preview/2023-05-01-preview/tenantActionGroups_API.json#L528
    ⚠️ DeprecatedXmsCodeGenerationSetting The x-ms-code-generation-setting extension is being deprecated. Please remove it and move settings to readme file for code generation.
    Location: Microsoft.Insights/preview/2023-05-01-preview/tenantActionGroups_API.json#L5
    ⚠️ RequiredReadOnlySystemData The response of operation:'TenantActionGroups_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Insights/preview/2023-05-01-preview/tenantActionGroups_API.json#L40
    ⚠️ RequiredReadOnlySystemData The response of operation:'TenantActionGroups_Get' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Insights/preview/2023-05-01-preview/tenantActionGroups_API.json#L92
    ⚠️ RequiredReadOnlySystemData The response of operation:'TenantActionGroups_Update' is defined without 'systemData'. Consider adding the systemData to the response.
    Location: Microsoft.Insights/preview/2023-05-01-preview/tenantActionGroups_API.json#L166
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Insights/preview/2023-05-01-preview/tenantActionGroups_API.json#L570
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Insights/preview/2023-05-01-preview/tenantActionGroups_API.json#L643
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Insights/preview/2023-05-01-preview/tenantActionGroups_API.json#L699
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Insights/preview/2023-05-01-preview/tenantActionGroups_API.json#L704
    ⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
    Location: Microsoft.Insights/preview/2023-05-01-preview/tenantActionGroups_API.json#L817
    ️⚠️Avocado: 1 Warnings warning [Detail]
    Rule Message
    ⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
    readme: specification/monitor/resource-manager/readme.md
    tag: specification/monitor/resource-manager/readme.md#tag-package-2023-04
    ️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
    ️❌~[Staging] ServiceAPIReadinessTest: 132 Errors, 0 Warnings failed [Detail]

    Tag package-2023-04; Prod region: Deployed

    Test run on region: westcentralus; Operation coverage: total: 116, untested: 0, failed: 78, passed: 38

    Service API Readiness Test failed. Check pipeline artifact for detail report.

    Only 30 items are listed, please refer to log for more details.

    Rule Message
    ❌ CLIENT_ERROR statusCode: 400,
    errorCode: LocationNotAvailableForResourceType,
    errorMessage: The provided location 'westcentralus' is not available for resource type 'microsoft.insights/privateLinkScopes'. List of available regions for the resource type is 'global'.
    Source: runtime
    OperationId: PrivateLinkScopes_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'microsoft.insights/privateLinkScopes/scopenamwh04kd' under resource group 'apiTest-WnBuRx-23714' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: PrivateLinkScopes_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'microsoft.insights/privateLinkScopes/scopenamwh04kd' under resource group 'apiTest-WnBuRx-23714' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: PrivateLinkScopes_UpdateTags
    ❌ CLIENT_ERROR statusCode: 400,
    errorCode: LocationNotAvailableForResourceType,
    errorMessage: The provided location 'westcentralus' is not available for resource type 'microsoft.insights/actiongroups'. List of available regions for the resource type is 'global,swedencentral,germanywestcentral,northcentralus,southcentralus,eastus2euap,centraluseuap'.
    Source: runtime
    OperationId: ActionGroups_CreateOrUpdate
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: ActionGroups_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Insights/actiongroups/actiongri05t1a' under resource group 'apiTest-WnBuRx-23714' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: ActionGroups_GetTestNotificationsAtActionGroupResourceLevel
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: ActionGroups_GetTestNotificationsAtActionGroupResourceLevel
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Insights/actiongroups/actiongri05t1a' under resource group 'apiTest-WnBuRx-23714' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: ActionGroups_Get
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: ActionGroups_Get
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Insights/actiongroups/actiongri05t1a' under resource group 'apiTest-WnBuRx-23714' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: ActionGroups_Update
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: ActionGroups_Update
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Insights/actiongroups/actiongri05t1a' under resource group 'apiTest-WnBuRx-23714' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: ActionGroups_EnableReceiver
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: ActionGroups_EnableReceiver
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Insights/actiongroups/actiongri05t1a' under resource group 'apiTest-WnBuRx-23714' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: ActionGroups_CreateNotificationsAtActionGroupResourceLevel
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: ActionGroups_CreateNotificationsAtActionGroupResourceLevel
    ❌ CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.Insights/tenantActionGroups/write' over scope '/providers/Microsoft.Management/managementGroups/managemeqrgu4m/providers/Microsoft.Insights/tenantActionGroups/tenantac79uwd6' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: TenantActionGroups_CreateOrUpdate
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: TenantActionGroups_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.Insights/tenantActionGroups/read' over scope '/providers/Microsoft.Management/managementGroups/managemeqrgu4m/providers/Microsoft.Insights' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: TenantActionGroups_ListByManagementGroupId
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: TenantActionGroups_ListByManagementGroupId
    ❌ CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.Insights/tenantActionGroups/read' over scope '/providers/Microsoft.Management/managementGroups/managemeqrgu4m/providers/Microsoft.Insights/tenantActionGroups/tenantac79uwd6' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: TenantActionGroups_Get
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: TenantActionGroups_Get
    ❌ CLIENT_ERROR statusCode: 403,
    errorCode: AuthorizationFailed,
    errorMessage: The client '7904a8be-825f-480e-a728-80a70579dba4' with object id '7904a8be-825f-480e-a728-80a70579dba4' does not have authorization to perform action 'Microsoft.Insights/tenantActionGroups/write' over scope '/providers/Microsoft.Management/managementGroups/managemeqrgu4m/providers/Microsoft.Insights/tenantActionGroups/tenantac79uwd6' or the scope is invalid. If access was recently granted, please refresh your credentials.
    Source: runtime
    OperationId: TenantActionGroups_Update
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: TenantActionGroups_Update
    ❌ CLIENT_ERROR statusCode: 400,
    errorCode: LocationNotAvailableForResourceType,
    errorMessage: The provided location 'westcentralus' is not available for resource type 'microsoft.insights/metricalerts'. List of available regions for the resource type is 'global,westeurope,northeurope,swedencentral,germanywestcentral,eastus2euap'.
    Source: runtime
    OperationId: MetricAlerts_CreateOrUpdate
    ❌ INVALID_FORMAT Object didn't pass validation for format duration: Pt1m
    Source: request
    OperationId: MetricAlerts_CreateOrUpdate
    ❌ INVALID_FORMAT Object didn't pass validation for format duration: Pt15m
    Source: request
    OperationId: MetricAlerts_CreateOrUpdate
    ❌ INVALID_TYPE Expected type object but found type array
    Source: request
    OperationId: MetricAlerts_CreateOrUpdate
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: MetricAlerts_CreateOrUpdate
    ❌ CLIENT_ERROR statusCode: 404,
    errorCode: ResourceNotFound,
    errorMessage: The Resource 'Microsoft.Insights/metricalerts/rulenamecpj5zl' under resource group 'apiTest-WnBuRx-23714' was not found. For more details please go to https://aka.ms/ARMResourceNotFoundFix
    Source: runtime
    OperationId: MetricAlerts_Get
    ❌ OBJECT_ADDITIONAL_PROPERTIES Additional properties not allowed: error
    Source: response
    OperationId: MetricAlerts_Get
    ️️✔️SwaggerAPIView succeeded [Detail] [Expand]
    ️️✔️CadlAPIView succeeded [Detail] [Expand]
    ️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
    ️️✔️ModelValidation succeeded [Detail] [Expand] 
    Validation passes for ModelValidation.
    ️️✔️SemanticValidation succeeded [Detail] [Expand] 
    Validation passes for SemanticValidation.
    ️️✔️PoliCheck succeeded [Detail] [Expand] 
    Validation passed for PoliCheck.
    ️️✔️PrettierCheck succeeded [Detail] [Expand] 
    Validation passes for PrettierCheck.
    ️️✔️SpellCheck succeeded [Detail] [Expand] 
    Validation passes for SpellCheck.
    ️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
    Validation passes for Lint(RPaaS).
    ️️✔️CadlValidation succeeded [Detail] [Expand] 
    Validation passes for CadlValidation.
    ️️✔️TypeSpec Validation succeeded [Detail] [Expand] 
    Validation passes for TypeSpec Validation.
    ️️✔️PR Summary succeeded [Detail] [Expand] 
    Validation passes for Summary.
    Posted by Swagger Pipeline | How to fix these errors?

    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 25, 2023 •
    edited
    Loading

    Swagger Generation Artifacts

    ️️✔️ApiDocPreview succeeded [Detail] [Expand] 
     Please click here to preview with your @microsoft account.
    ️❌SDK Breaking Change Tracking failed [Detail]

    Breaking Changes Tracking

    ❌azure-sdk-for-go - sdk/resourcemanager/monitor/armmonitor - Approved - 0.10.0
    -	Field `PublicNetworkAccess` of struct `ScheduledQueryRuleProperties` has been removed
-	Type alias `PublicNetworkAccess` has been removed
+	Field `ActionType`, `IsDataAction`, `Origin` of struct `OperationAutoGenerated` has been removed
+	Field `Code`, `Message` of struct `ErrorResponse` has been removed
+	Field `Description` of struct `OperationDisplayAutoGenerated` has been removed
+	Field `Location`, `Tags` of struct `ResourceAutoGenerated` has been removed
+	Field `Location`, `Tags` of struct `Resource` has been removed
+	Field `OperationListResultAutoGenerated` of struct `OperationsForMonitorClientListResponse` has been removed
+	Field `OperationListResult` of struct `OperationsClientListResponse` has been removed
+	Field `PrivateEndpointConnection` of struct `PrivateEndpointConnectionsClientCreateOrUpdateResponse` has been removed
+	Field `PrivateEndpointConnection` of struct `PrivateEndpointConnectionsClientGetResponse` has been removed
+	Field `SystemData` of struct `ResourceAutoGenerated5` has been removed
+	Field `SystemData` of struct `TrackedResourceAutoGenerated` has been removed
+	Function `*PrivateEndpointConnectionsClient.BeginCreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, PrivateEndpointConnection, *PrivateEndpointConnectionsClientBeginCreateOrUpdateOptions)` to `(context.Context, string, string, string, PrivateEndpointConnectionAutoGenerated, *PrivateEndpointConnectionsClientBeginCreateOrUpdateOptions)`
+	Operation `*AzureMonitorWorkspacesClient.Delete` has been changed to LRO, use `*AzureMonitorWorkspacesClient.BeginDelete` instead.
+	Type of `AzureMonitorPrivateLinkScopeProperties.PrivateEndpointConnections` has been changed from `[]*PrivateEndpointConnection` to `[]*PrivateEndpointConnectionAutoGenerated`
+	Type of `DefaultErrorResponse.Error` has been changed from `*ErrorDetail` to `*ErrorDetailAutoGenerated`
+	Type of `ErrorContract.Error` has been changed from `*ErrorResponse` to `*ErrorResponseAutoGenerated`
+	Type of `ErrorResponseCommonV2.Error` has been changed from `*ErrorDetail` to `*ErrorDetailAutoGenerated`
+	Type of `OperationStatus.Error` has been changed from `*ErrorDetail` to `*ErrorDetailAutoGenerated`
+	Type of `PrivateEndpointConnectionListResult.Value` has been changed from `[]*PrivateEndpointConnection` to `[]*PrivateEndpointConnectionAutoGenerated`
    ❌azure-sdk-for-js - @azure/arm-monitor - Approved - 8.0.0-beta.5
    +	Interface ErrorResponse no longer has parameter code
+	Interface ErrorResponse no longer has parameter message
+	Interface Resource no longer has parameter location
+	Interface Resource no longer has parameter tags
+	Interface ResourceAutoGenerated no longer has parameter location
+	Interface ResourceAutoGenerated no longer has parameter tags
+	Operation PrivateEndpointConnections.beginCreateOrUpdate has a new signature
+	Operation PrivateEndpointConnections.beginCreateOrUpdateAndWait has a new signature
-	Type of parameter error of interface OperationStatus is changed from ErrorResponseCommon to ErrorDetail
+	Type of parameter error of interface ErrorContract is changed from ErrorResponse to ErrorResponseAutoGenerated
+	Type of parameter error of interface ErrorResponseCommonV2 is changed from ErrorDetail to ErrorDetailAutoGenerated
+	Type of parameter error of interface OperationStatus is changed from ErrorResponseCommon to ErrorDetailAutoGenerated
+	Type of parameter value of interface PrivateEndpointConnectionListResult is changed from PrivateEndpointConnection[] to PrivateEndpointConnectionAutoGenerated[]

    ️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 9f1fc4e. SDK Automation 14.0.0 
      command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    • ️✔️Azure.ResourceManager.Monitor [View full logs]  [Release SDK Changes] 
      info	[Changelog]
    ️⚠️ azure-sdk-for-python-track2 warning [Detail]
    • ⚠️Warning [Logs]Release - Generate from 9f1fc4e. SDK Automation 14.0.0 
      command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.6
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.6>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice
    • ️✔️track2_azure-mgmt-monitor [View full logs]  [Release SDK Changes] 
      info	[Changelog]
    ️⚠️ azure-sdk-for-java warning [Detail]
    ️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 9f1fc4e. SDK Automation 14.0.0 
      command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
    • ️✔️sdk/resourcemanager/monitor/armmonitor [View full logs]  [Release SDK Changes] Breaking Change Detected
      info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Function `*PrivateEndpointConnectionsClient.BeginCreateOrUpdate` parameter(s) have been changed from `(context.Context, string, string, string, PrivateEndpointConnection, *PrivateEndpointConnectionsClientBeginCreateOrUpdateOptions)` to `(context.Context, string, string, string, PrivateEndpointConnectionAutoGenerated, *PrivateEndpointConnectionsClientBeginCreateOrUpdateOptions)`
info	[Changelog] - Type of `AzureMonitorPrivateLinkScopeProperties.PrivateEndpointConnections` has been changed from `[]*PrivateEndpointConnection` to `[]*PrivateEndpointConnectionAutoGenerated`
info	[Changelog] - Type of `DefaultErrorResponse.Error` has been changed from `*ErrorDetail` to `*ErrorDetailAutoGenerated`
info	[Changelog] - Type of `ErrorContract.Error` has been changed from `*ErrorResponse` to `*ErrorResponseAutoGenerated`
info	[Changelog] - Type of `ErrorResponseCommonV2.Error` has been changed from `*ErrorDetail` to `*ErrorDetailAutoGenerated`
info	[Changelog] - Type of `OperationStatus.Error` has been changed from `*ErrorDetail` to `*ErrorDetailAutoGenerated`
info	[Changelog] - Type of `PrivateEndpointConnectionListResult.Value` has been changed from `[]*PrivateEndpointConnection` to `[]*PrivateEndpointConnectionAutoGenerated`
info	[Changelog] - Operation `*AzureMonitorWorkspacesClient.Delete` has been changed to LRO, use `*AzureMonitorWorkspacesClient.BeginDelete` instead.
info	[Changelog] - Field `Code`, `Message` of struct `ErrorResponse` has been removed
info	[Changelog] - Field `ActionType`, `IsDataAction`, `Origin` of struct `OperationAutoGenerated` has been removed
info	[Changelog] - Field `Description` of struct `OperationDisplayAutoGenerated` has been removed
info	[Changelog] - Field `OperationListResult` of struct `OperationsClientListResponse` has been removed
info	[Changelog] - Field `OperationListResultAutoGenerated` of struct `OperationsForMonitorClientListResponse` has been removed
info	[Changelog] - Field `PrivateEndpointConnection` of struct `PrivateEndpointConnectionsClientCreateOrUpdateResponse` has been removed
info	[Changelog] - Field `PrivateEndpointConnection` of struct `PrivateEndpointConnectionsClientGetResponse` has been removed
info	[Changelog] - Field `Location`, `Tags` of struct `Resource` has been removed
info	[Changelog] - Field `Location`, `Tags` of struct `ResourceAutoGenerated` has been removed
info	[Changelog] - Field `SystemData` of struct `ResourceAutoGenerated5` has been removed
info	[Changelog] - Field `SystemData` of struct `TrackedResourceAutoGenerated` has been removed
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New function `NewClient(azcore.TokenCredential, *arm.ClientOptions) (*Client, error)`
info	[Changelog] - New function `*Client.BeginCreateNotificationsAtTenantActionGroupResourceLevel(context.Context, string, string, string, TenantNotificationRequestBody, *ClientBeginCreateNotificationsAtTenantActionGroupResourceLevelOptions) (*runtime.Poller[ClientCreateNotificationsAtTenantActionGroupResourceLevelResponse], error)`
info	[Changelog] - New function `*Client.GetTestNotificationsAtTenantActionGroupResourceLevel(context.Context, string, string, string, string, *ClientGetTestNotificationsAtTenantActionGroupResourceLevelOptions) (ClientGetTestNotificationsAtTenantActionGroupResourceLevelResponse, error)`
info	[Changelog] - New function `*ClientFactory.NewClient() *Client`
info	[Changelog] - New struct `ActionDetailAutoGenerated`
info	[Changelog] - New struct `ErrorResponseAutoGenerated3`
info	[Changelog] - New struct `PrivateEndpointAutoGenerated`
info	[Changelog] - New struct `PrivateEndpointConnectionAutoGenerated`
info	[Changelog] - New struct `PrivateEndpointConnectionPropertiesAutoGenerated`
info	[Changelog] - New struct `ResourceAutoGenerated6`
info	[Changelog] - New struct `TenantNotificationRequestBody`
info	[Changelog] - New struct `TestNotificationDetailsResponseAutoGenerated`
info	[Changelog] - New field `PrivateEndpointConnections`, `PublicNetworkAccess` in struct `AzureMonitorWorkspace`
info	[Changelog] - New field `PrivateEndpointConnections`, `PublicNetworkAccess` in struct `AzureMonitorWorkspaceResourceProperties`
info	[Changelog] - New field `Error` in struct `ErrorResponse`
info	[Changelog] - New field `ActionType`, `IsDataAction`, `Origin` in struct `Operation`
info	[Changelog] - New field `Description` in struct `OperationDisplay`
info	[Changelog] - New anonymous field `OperationListResultAutoGenerated` in struct `OperationsClientListResponse`
info	[Changelog] - New anonymous field `OperationListResult` in struct `OperationsForMonitorClientListResponse`
info	[Changelog] - New field `SystemData` in struct `PrivateEndpointConnection`
info	[Changelog] - New field `GroupIDs` in struct `PrivateEndpointConnectionProperties`
info	[Changelog] - New anonymous field `PrivateEndpointConnectionAutoGenerated` in struct `PrivateEndpointConnectionsClientCreateOrUpdateResponse`
info	[Changelog] - New anonymous field `PrivateEndpointConnectionAutoGenerated` in struct `PrivateEndpointConnectionsClientGetResponse`
info	[Changelog] - New field `SystemData` in struct `ResourceAutoGenerated`
info	[Changelog] - New field `SystemData` in struct `ResourceAutoGenerated2`
info	[Changelog] - New field `Location`, `Tags` in struct `ResourceAutoGenerated3`
info	[Changelog] - New field `SystemData` in struct `TrackedResource`
info	[Changelog]
info	[Changelog] Total 19 breaking change(s), 35 additive change(s).
    ️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    • ️✔️Succeeded [Logs]Release - Generate from 9f1fc4e. SDK Automation 14.0.0 
      command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
    • ️✔️@azure/arm-monitor [View full logs]  [Release SDK Changes] Breaking Change Detected
      Only show 120 items here, please refer to log for details.
      info	[Changelog]   - Added Type Alias ScheduledQueryRulesListByResourceGroupNextResponse
info	[Changelog]   - Added Type Alias ScheduledQueryRulesListBySubscriptionNextResponse
info	[Changelog]   - Added Type Alias TenantActionGroupsCreateOrUpdateResponse
info	[Changelog]   - Added Type Alias TenantActionGroupsGetResponse
info	[Changelog]   - Added Type Alias TenantActionGroupsListByManagementGroupIdResponse
info	[Changelog]   - Added Type Alias TenantActionGroupsUpdateResponse
info	[Changelog]   - Added Type Alias TimeAggregation
info	[Changelog]   - Added Type Alias Unit
info	[Changelog]   - Interface AutoscaleSettingResourcePatch has a new optional parameter predictiveAutoscalePolicy
info	[Changelog]   - Interface DataCollectionEndpoint has a new optional parameter failoverConfiguration
info	[Changelog]   - Interface DataCollectionEndpoint has a new optional parameter metadata
info	[Changelog]   - Interface DataCollectionEndpoint has a new optional parameter metricsIngestion
info	[Changelog]   - Interface DataCollectionEndpoint has a new optional parameter privateLinkScopedResources
info	[Changelog]   - Interface DataCollectionEndpointResource has a new optional parameter failoverConfiguration
info	[Changelog]   - Interface DataCollectionEndpointResource has a new optional parameter identity
info	[Changelog]   - Interface DataCollectionEndpointResource has a new optional parameter metadata
info	[Changelog]   - Interface DataCollectionEndpointResource has a new optional parameter metricsIngestion
info	[Changelog]   - Interface DataCollectionEndpointResource has a new optional parameter privateLinkScopedResources
info	[Changelog]   - Interface DataCollectionRule has a new optional parameter dataCollectionEndpointId
info	[Changelog]   - Interface DataCollectionRule has a new optional parameter metadata
info	[Changelog]   - Interface DataCollectionRule has a new optional parameter streamDeclarations
info	[Changelog]   - Interface DataCollectionRuleAssociation has a new optional parameter metadata
info	[Changelog]   - Interface DataCollectionRuleAssociationProxyOnlyResource has a new optional parameter metadata
info	[Changelog]   - Interface DataCollectionRuleResource has a new optional parameter dataCollectionEndpointId
info	[Changelog]   - Interface DataCollectionRuleResource has a new optional parameter identity
info	[Changelog]   - Interface DataCollectionRuleResource has a new optional parameter metadata
info	[Changelog]   - Interface DataCollectionRuleResource has a new optional parameter streamDeclarations
info	[Changelog]   - Interface DataFlow has a new optional parameter builtInTransform
info	[Changelog]   - Interface DataFlow has a new optional parameter outputStream
info	[Changelog]   - Interface DataFlow has a new optional parameter transformKql
info	[Changelog]   - Interface DataSourcesSpec has a new optional parameter dataImports
info	[Changelog]   - Interface DataSourcesSpec has a new optional parameter iisLogs
info	[Changelog]   - Interface DataSourcesSpec has a new optional parameter logFiles
info	[Changelog]   - Interface DataSourcesSpec has a new optional parameter platformTelemetry
info	[Changelog]   - Interface DataSourcesSpec has a new optional parameter prometheusForwarder
info	[Changelog]   - Interface DataSourcesSpec has a new optional parameter windowsFirewallLogs
info	[Changelog]   - Interface DestinationsSpec has a new optional parameter eventHubs
info	[Changelog]   - Interface DestinationsSpec has a new optional parameter eventHubsDirect
info	[Changelog]   - Interface DestinationsSpec has a new optional parameter monitoringAccounts
info	[Changelog]   - Interface DestinationsSpec has a new optional parameter storageAccounts
info	[Changelog]   - Interface DestinationsSpec has a new optional parameter storageBlobsDirect
info	[Changelog]   - Interface DestinationsSpec has a new optional parameter storageTablesDirect
info	[Changelog]   - Interface ErrorResponse has a new optional parameter error
info	[Changelog]   - Interface LogSettings has a new optional parameter categoryGroup
info	[Changelog]   - Interface MetricsListOptionalParams has a new optional parameter autoAdjustTimegrain
info	[Changelog]   - Interface MetricsListOptionalParams has a new optional parameter validateDimensions
info	[Changelog]   - Interface Operation has a new optional parameter actionType
info	[Changelog]   - Interface Operation has a new optional parameter isDataAction
info	[Changelog]   - Interface Operation has a new optional parameter origin
info	[Changelog]   - Interface OperationDisplay has a new optional parameter description
info	[Changelog]   - Interface Resource has a new optional parameter systemData
info	[Changelog]   - Interface ResourceAutoGenerated has a new optional parameter systemData
info	[Changelog]   - Interface ResourceForUpdate has a new optional parameter identity
info	[Changelog]   - Added Enum KnownAccessMode
info	[Changelog]   - Added Enum KnownActionType
info	[Changelog]   - Added Enum KnownCategoryType
info	[Changelog]   - Added Enum KnownDimensionOperator
info	[Changelog]   - Added Enum KnownKind
info	[Changelog]   - Added Enum KnownKnownColumnDefinitionType
info	[Changelog]   - Added Enum KnownKnownLocationSpecProvisioningStatus
info	[Changelog]   - Added Enum KnownKnownLogFilesDataSourceFormat
info	[Changelog]   - Added Enum KnownKnownLogFileTextSettingsRecordStartTimestampFormat
info	[Changelog]   - Added Enum KnownKnownPrometheusForwarderDataSourceStreams
info	[Changelog]   - Added Enum KnownManagedServiceIdentityType
info	[Changelog]   - Added Enum KnownMetricAggregationType
info	[Changelog]   - Added Enum KnownMetricResultType
info	[Changelog]   - Added Enum KnownOrigin
info	[Changelog]   - Added Enum KnownPrivateEndpointConnectionProvisioningState
info	[Changelog]   - Added Enum KnownPrivateEndpointServiceConnectionStatus
info	[Changelog]   - Added Enum KnownPublicNetworkAccess
info	[Changelog]   - Added Enum KnownTimeAggregation
info	[Changelog]   - Enum KnownKnownDataCollectionEndpointProvisioningState has a new value Canceled
info	[Changelog]   - Enum KnownKnownDataCollectionRuleAssociationProvisioningState has a new value Canceled
info	[Changelog]   - Enum KnownKnownDataCollectionRuleProvisioningState has a new value Canceled
info	[Changelog]   - Enum KnownKnownPublicNetworkAccessOptions has a new value SecuredByPerimeter
info	[Changelog]   - Enum KnownProvisioningState has a new value Creating
info	[Changelog]   - Enum KnownProvisioningState has a new value Deleting
info	[Changelog]   - Added function getContinuationToken
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed operation group Metrics
info	[Changelog]   - Removed operation ActionGroups.beginPostTestNotifications
info	[Changelog]   - Removed operation ActionGroups.beginPostTestNotificationsAndWait
info	[Changelog]   - Removed operation ActionGroups.getTestNotifications
info	[Changelog]   - Operation ActivityLogAlerts.update has a new signature
info	[Changelog]   - Operation PrivateEndpointConnections.beginCreateOrUpdate has a new signature
info	[Changelog]   - Operation PrivateEndpointConnections.beginCreateOrUpdateAndWait has a new signature
info	[Changelog]   - Operation ScheduledQueryRules.createOrUpdate has a new signature
info	[Changelog]   - Operation ScheduledQueryRules.update has a new signature
info	[Changelog]   - Interface ActivityLogsListNextOptionalParams no longer has parameter select
info	[Changelog]   - Interface AzureResource no longer has parameter identity
info	[Changelog]   - Interface AzureResource no longer has parameter kind
info	[Changelog]   - Interface ErrorResponse no longer has parameter code
info	[Changelog]   - Interface ErrorResponse no longer has parameter message
info	[Changelog]   - Interface PrivateEndpointConnectionListResult no longer has parameter nextLink
info	[Changelog]   - Interface PrivateLinkResourceListResult no longer has parameter nextLink
info	[Changelog]   - Interface Resource no longer has parameter location
info	[Changelog]   - Interface Resource no longer has parameter tags
info	[Changelog]   - Interface ResourceAutoGenerated no longer has parameter etag
info	[Changelog]   - Interface ResourceAutoGenerated no longer has parameter kind
info	[Changelog]   - Interface ResourceAutoGenerated no longer has parameter location
info	[Changelog]   - Interface ResourceAutoGenerated no longer has parameter tags
info	[Changelog]   - Interface ScheduledQueryRulesListByResourceGroupOptionalParams no longer has parameter filter
info	[Changelog]   - Interface ScheduledQueryRulesListBySubscriptionOptionalParams no longer has parameter filter
info	[Changelog]   - Interface TenantActivityLogsListNextOptionalParams no longer has parameter filter
info	[Changelog]   - Interface TenantActivityLogsListNextOptionalParams no longer has parameter select
info	[Changelog]   - Type of parameter operator of interface Dimension is changed from Operator to DimensionOperator
info	[Changelog]   - Type of parameter error of interface ErrorContract is changed from ErrorResponse to ErrorResponseAutoGenerated
info	[Changelog]   - Type of parameter error of interface ErrorResponseCommonV2 is changed from ErrorDetail to ErrorDetailAutoGenerated
info	[Changelog]   - Type of parameter unit of interface Metric is changed from MetricUnit to Unit
info	[Changelog]   - Type of parameter error of interface OperationStatus is changed from ErrorResponseCommon to ErrorDetailAutoGenerated
info	[Changelog]   - Type of parameter value of interface PrivateEndpointConnectionListResult is changed from PrivateEndpointConnection[] to PrivateEndpointConnectionAutoGenerated[]
info	[Changelog]   - Class MonitorClient no longer has parameter metrics
info	[Changelog]   - Removed Enum KnownConditionalOperator
info	[Changelog]   - Removed Enum KnownEnabled
info	[Changelog]   - Removed Enum KnownMetricTriggerType
info	[Changelog]   - Removed Enum KnownQueryType
info	[Changelog]   - Enum KnownOperator no longer has value Include
info	[Changelog]   - Enum KnownProvisioningState no longer has value Deploying
    ️❌ azure-resource-manager-schemas failed [Detail]
    • ❌Pipeline Framework Failed [Logs]Release - Generate from 9f1fc4e. Schema Automation 14.0.0 
      command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm,
cmderr	[initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry.
cmderr	[initScript.sh] npm WARN old lockfile
cmderr	[initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient...
cmderr	[initScript.sh] npm WARN old lockfile
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cannot force update branch 'sdkAuto/monitor' as it is the current HEAD of the repository.
Error: cannot force update branch 'sdkAuto/monitor' as it is the current HEAD of the repository.
    • ️✔️monitor [View full logs]  [Release Schema Changes]
    • ️✔️monitor [View full logs]  
      error	Fatal error: cannot force update branch 'sdkAuto/monitor' as it is the current HEAD of the repository.
error	The following packages are still pending:
error		monitor
error		monitor
    ️❌ azure-powershell failed [Detail]
    • ❌Pipeline Framework Failed [Logs]Release - Generate from 9f1fc4e. SDK Automation 14.0.0 
      command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe
    • ❌Az.monitor.DefaultTag [View full logs]  
      error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.monitor.DefaultTag
    Posted by Swagger Pipeline | How to fix these errors?

    @ghost ghost added the Monitor Monitor, Monitor Ingestion, Monitor Query label Apr 25, 2023
    @openapi-pipeline-app
    Copy link

    openapi-pipeline-app bot commented Apr 25, 2023 •
    edited
    Loading

    Generated ApiView

    Language Package Name ApiView Link
    Go sdk/resourcemanager/monitor/armmonitor https://apiview.dev/Assemblies/Review/3459989f4eac4b938d6398ec9f20001d
    Java azure-resourcemanager-monitor-generated https://apiview.dev/Assemblies/Review/1413ba1216ed496abd88ca238f0f12a6
    .Net Azure.ResourceManager.Monitor There is no API change compared with the previous version
    JavaScript @azure/arm-monitor https://apiview.dev/Assemblies/Review/7917978ede55461f87e83d44d23f5d8a

    @azure-sdk azure-sdk mentioned this pull request Apr 25, 2023
    Closed
    @openapi-workflow-bot
    Copy link

    Hi @thomasp98296, Your PR has some issues. Please fix the CI sequentially by following the order of Avocado, semantic validation, model validation, breaking change, lintDiff. If you have any questions, please post your questions in this channel https://aka.ms/swaggersupport.

    TaskHow to fixPriority
    AvocadoFix-AvocadoHigh
    Semantic validationFix-SemanticValidation-ErrorHigh
    Model validationFix-ModelValidation-ErrorHigh
    LintDiffFix-LintDiffhigh
     If you need further help, please feedback via swagger feedback.

    @openapi-workflow-bot
    Copy link

    Hi, @thomasp98296, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline

    This was referenced Apr 25, 2023
    Closed
    Closed
    Closed
    Closed
    Closed
    @raych1 raych1 requested a review from keryul April 26, 2023 02:10
    @pilor pilor added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Apr 26, 2023
    @openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 26, 2023
    @thomasp98296
    Copy link
    Contributor Author

    thomasp98296 commented May 1, 2023 •
    edited
    Loading

    @raych1 hi Ray, could you please advise the next step for this PR? Thank you!

    @keryul could you please help? Thank you!

    @keryul
    Copy link
    Contributor

    keryul commented May 8, 2023

    @thomasp98296 can you fix the LintDiff error?

    @azure-sdk azure-sdk mentioned this pull request May 11, 2023
    Draft
    @AzureRestAPISpecReview AzureRestAPISpecReview added ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test and removed CI-FixRequiredOnFailure labels May 11, 2023
    @thomasp98296
    Copy link
    Contributor Author

    @thomasp98296 can you fix the LintDiff error?

    @keryul I went ahead and fix it. Could you please help to proceed? Thanks!

    @keryul keryul added the Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates label May 12, 2023
    @thomasp98296
    Copy link
    Contributor Author

    @thomasp98296 can you fix the LintDiff error?

    @keryul I went ahead and fix it. Could you please help to proceed? Thanks!

    @keryul , is there anything else needed from me or it should be good to merge? If good, can you please merge it? Thanks!

    @ArcturusZhang
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @tadelesh tadelesh added the Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go label May 15, 2023
    @ArcturusZhang ArcturusZhang merged commit 9f1fc4e into Azure:main May 15, 2023
    This was referenced May 15, 2023
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

    @keryul keryul Awaiting requested review from keryul

    Assignees

    @ArcturusZhang ArcturusZhang

    @keryul keryul

    Labels
    Approved-OkToMerge <valid label in PR review process>add this label when assignee approve to merge the updates Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-JavaScript CI-MissingBaseCommit Monitor Monitor, Monitor Ingestion, Monitor Query new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    7 participants
    @thomasp98296 @keryul @ArcturusZhang @pilor @tadelesh @AzureRestAPISpecReview @qiaozha