-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing API version #23821
removing API version #23821
Conversation
Hi, @sasank-chaganty Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
compared swaggers (via Oad v0.10.4)] | new version | base version |
---|---|---|
activeDirectoryConnectors.json | 2023-03-15-preview(a434c27) | 2023-03-15-preview(main) |
azurearcdata.json | 2023-03-15-preview(a434c27) | 2023-03-15-preview(main) |
common.json | 2023-03-15-preview(a434c27) | 2023-03-15-preview(main) |
dataControllers.json | 2023-03-15-preview(a434c27) | 2023-03-15-preview(main) |
failoverGroups.json | 2023-03-15-preview(a434c27) | 2023-03-15-preview(main) |
operations.json | 2023-03-15-preview(a434c27) | 2023-03-15-preview(main) |
postgresInstances.json | 2023-03-15-preview(a434c27) | 2023-03-15-preview(main) |
sqlAvailabilityGroups.json | 2023-03-15-preview(a434c27) | 2023-03-15-preview(main) |
sqlManagedInstances.json | 2023-03-15-preview(a434c27) | 2023-03-15-preview(main) |
sqlServerAvailabilityGroups.json | 2023-03-15-preview(a434c27) | 2023-03-15-preview(main) |
sqlServerDatabases.json | 2023-03-15-preview(a434c27) | 2023-03-15-preview(main) |
sqlServerInstances.json | 2023-03-15-preview(a434c27) | 2023-03-15-preview(main) |
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/providers/Microsoft.AzureArcData/operations' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L19:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AzureArcData/sqlManagedInstances' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L55:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/sqlManagedInstances' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L94:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/sqlManagedInstances/{sqlManagedInstanceName}' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L137:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/sqlManagedInstances/{sqlManagedInstanceName}/failoverGroups' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L331:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/sqlManagedInstances/{sqlManagedInstanceName}/failoverGroups/{failoverGroupName}' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L376:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AzureArcData/sqlServerInstances' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L530:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/sqlServerInstances' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L569:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/sqlServerInstances/{sqlServerInstanceName}' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L612:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AzureArcData/sqlAvailabilityGroups' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L806:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/sqlAvailabilityGroups' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L845:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/sqlAvailabilityGroups/{sqlAvailabilityGroupName}' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L888:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AzureArcData/dataControllers' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L1082:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/dataControllers' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L1121:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/dataControllers/{dataControllerName}' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L1163:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/dataControllers/{dataControllerName}/activeDirectoryConnectors' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L1364:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/dataControllers/{dataControllerName}/activeDirectoryConnectors/{activeDirectoryConnectorName}' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L1409:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/Microsoft.AzureArcData/postgresInstances' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L1563:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/postgresInstances' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L1602:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/postgresInstances/{postgresInstanceName}' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L1645:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/sqlServerInstances/{sqlServerInstanceName}/sqlAvailabilityGroups/{sqlAvailabilityGroupName}' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/sqlServerAvailabilityGroups.json#L19:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/sqlServerInstances/{sqlServerInstanceName}/sqlAvailabilityGroups' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/sqlServerAvailabilityGroups.json#L211:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/sqlAvailabilityGroups/{sqlAvailabilityGroupName}/sqlServerInstances/{sqlServerInstanceName}' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/sqlServerAvailabilityGroups.json#L256:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/sqlAvailabilityGroups/{sqlAvailabilityGroupName}/sqlServerInstances' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/sqlServerAvailabilityGroups.json#L448:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/sqlAvailabilityGroups/{sqlAvailabilityGroupName}/databases/{sqlAvailabilityGroupDatabaseName}' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/sqlServerAvailabilityGroups.json#L493:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/sqlAvailabilityGroups/{sqlAvailabilityGroupName}/databases' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/sqlServerAvailabilityGroups.json#L685:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/sqlServerInstances/{sqlServerInstanceName}/databases/{databaseName}' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/sqlServerDatabases.json#L19:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.AzureArcData/sqlServerInstances/{sqlServerInstanceName}/databases' removed or restructured? Old: Microsoft.AzureArcData/preview/2023-03-15-preview/sqlServerDatabases.json#L211:5 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'PostgresInstanceSku' removed or renamed? New: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L31:3 Old: azure-rest-api-specs/blob/main/revision#L5122:2 |
1006 - RemovedDefinition |
The new version is missing a definition that was found in the old version. Was 'BasicLoginInformation' removed or renamed? New: Microsoft.AzureArcData/preview/2023-03-15-preview/azurearcdata.json#L31:3 Old: azure-rest-api-specs/blob/main/revision#L5122:2 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️
LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
compared tags (via openapi-validator v2.0.1) | new version | base version |
---|---|---|
default | default(a434c27) | default(main) |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️
~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]
Validation passes for ServiceAPIReadinessTest.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
CadlAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️
ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️
PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️
SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️
TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
Hi @sasank-chaganty, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
Thanks for taking care of this. |
@JeffreyRichter Could you help take a look at the breaking change of this PR ? Thanks |
I see a ton of removed paths and definitions in an already shipped preview api-version. |
@JeffreyRichter |
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
What's the purpose of the update?
When are you targeting to deploy the new service/feature to public regions? NOT deploying
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.