Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.ContainerService/aks to add version preview/2023-06-02-preview #24922

address ARM review comments (#25005)

df617e7
Select commit
Loading
Failed to load commit list.
Merged

[Hub Generated] Review request for Microsoft.ContainerService/aks to add version preview/2023-06-02-preview #24922

address ARM review comments (#25005)
df617e7
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / ~[Staging] Swagger LintDiff succeeded Jul 28, 2023 in 7m 17s

~[Staging] Swagger LintDiff succeeded

ppe/LintDiff
View more details.

Details

compared tags (via openapi-validator vbeta) new version base version
package-preview-2023-06 package-preview-2023-06(df617e7) default(main)
default default(df617e7) default(main)

The following errors/warnings exist before current PR submission:

Rule Message
PrivateEndpointResourceSchemaValidation The private endpoint model 'PrivateLinkResourcesListResult' schema does not conform to the common type definition.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L2093
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'resolveprivatelinkserviceid' in:'ResolvePrivateLinkServiceId_POST'. Consider updating the operationId
Location: aks/preview/2023-06-02-preview/managedClusters.json#L2118
⚠️ PageableOperation Based on the response model schema, operation 'PrivateLinkResources_List' might be pageable. Consider adding the x-ms-pageable extension.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L2071
⚠️ RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_Update' is defined without 'systemData'. Consider adding the systemData to the response.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1893
⚠️ RequiredReadOnlySystemData The response of operation:'PrivateEndpointConnections_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1845
⚠️ PageableOperation Based on the response model schema, operation 'PrivateEndpointConnections_List' might be pageable. Consider adding the x-ms-pageable extension.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1802
⚠️ RequiredReadOnlySystemData The response of operation:'AgentPools_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1129
⚠️ RequiredReadOnlySystemData The response of operation:'AgentPools_Get' is defined without 'systemData'. Consider adding the systemData to the response.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1079
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster
Location: aks/preview/2023-06-02-preview/managedClusters.json#L502
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster
Location: aks/preview/2023-06-02-preview/managedClusters.json#L460
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster
Location: aks/preview/2023-06-02-preview/managedClusters.json#L415
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Managed Cluster
Location: aks/preview/2023-06-02-preview/managedClusters.json#L367
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'listcredential' in:'ManagedClusters_GetAccessProfile'. Consider updating the operationId
Location: aks/preview/2023-06-02-preview/managedClusters.json#L284
⚠️ PageableOperation Based on the response model schema, operation 'ManagedClusters_ListKubernetesVersions' might be pageable. Consider adding the x-ms-pageable extension.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L116