[Hub Generated] Review request for Microsoft.AzureStackHCI to add version stable/2023-06-01 #25004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @prateekprshr-nith! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| arcSettings.json | 2023-06-01(12b3503) | 2023-03-01(main) |
| arcSettings.json | 2023-06-01(12b3503) | 2022-12-15-preview(main) |
| clusters.json | 2023-06-01(12b3503) | 2023-03-01(main) |
| clusters.json | 2023-06-01(12b3503) | 2022-12-15-preview(main) |
| extensions.json | 2023-06-01(12b3503) | 2023-03-01(main) |
| extensions.json | 2023-06-01(12b3503) | 2022-12-15-preview(main) |
| offers.json | 2023-06-01(12b3503) | 2023-03-01(main) |
| offers.json | 2023-06-01(12b3503) | 2022-12-15-preview(main) |
| operations.json | 2023-06-01(12b3503) | 2023-03-01(main) |
| operations.json | 2023-06-01(12b3503) | 2022-12-15-preview(main) |
| publishers.json | 2023-06-01(12b3503) | 2023-03-01(main) |
| publishers.json | 2023-06-01(12b3503) | 2022-12-15-preview(main) |
| skus.json | 2023-06-01(12b3503) | 2023-03-01(main) |
| skus.json | 2023-06-01(12b3503) | 2022-12-15-preview(main) |
| updateRuns.json | 2023-06-01(12b3503) | 2023-03-01(main) |
| updateRuns.json | 2023-06-01(12b3503) | 2022-12-15-preview(main) |
| updateSummaries.json | 2023-06-01(12b3503) | 2023-03-01(main) |
| updateSummaries.json | 2023-06-01(12b3503) | 2022-12-15-preview(main) |
| updates.json | 2023-06-01(12b3503) | 2023-03-01(main) |
| updates.json | 2023-06-01(12b3503) | 2022-12-15-preview(main) |
The following breaking changes are detected by comparison with the latest preview version:
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 8 Errors, 8 Warnings failed [Detail]
| compared tags (via openapi-validator v2.1.4) | new version | base version |
|---|---|---|
| package-2023-06 | package-2023-06(12b3503) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
Missing identifier id in array item property Location: Microsoft.AzureStackHCI/stable/2023-06-01/arcSettings.json#L607 |
|
|
Missing identifier id in array item property Location: Microsoft.AzureStackHCI/stable/2023-06-01/extensions.json#L437 |
|
|
Tracked resource 'UpdateRun' must have patch operation that at least supports the update of tags. Location: Microsoft.AzureStackHCI/stable/2023-06-01/updateRuns.json#L255 |
RPC-Patch-V1-03 |
|
Tracked resource 'Update' must have patch operation that at least supports the update of tags. Location: Microsoft.AzureStackHCI/stable/2023-06-01/updates.json#L313 |
RPC-Patch-V1-03 |
|
Missing identifier id in array item property Location: Microsoft.AzureStackHCI/stable/2023-06-01/updates.json#L427 |
|
|
The schema 'PrecheckResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AzureStackHCI/stable/2023-06-01/updates.json#L553 |
|
|
Tracked resource 'UpdateSummaries' must have patch operation that at least supports the update of tags. Location: Microsoft.AzureStackHCI/stable/2023-06-01/updateSummaries.json#L235 |
RPC-Patch-V1-03 |
|
The schema 'PrecheckResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.AzureStackHCI/stable/2023-06-01/updateSummaries.json#L389 |
|
| OperationId should contain the verb: 'createarcidentity' in:'ArcSettings_CreateIdentity'. Consider updating the operationId Location: Microsoft.AzureStackHCI/stable/2023-06-01/arcSettings.json#L316 |
||
| OperationId should contain the verb: 'createclusteridentity' in:'Clusters_CreateIdentity'. Consider updating the operationId Location: Microsoft.AzureStackHCI/stable/2023-06-01/clusters.json#L359 |
||
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Create cluster Identity Location: Microsoft.AzureStackHCI/stable/2023-06-01/clusters.json#L410 |
||
| Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.AzureStackHCI/stable/2023-06-01/operations.json#L38 |
||
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Update runs under cluster resource Location: Microsoft.AzureStackHCI/stable/2023-06-01/updateRuns.json#L228 |
||
| OperationId should contain the verb: 'apply' in:'Updates_Post'. Consider updating the operationId Location: Microsoft.AzureStackHCI/stable/2023-06-01/updates.json#L39 |
||
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: List available updates Location: Microsoft.AzureStackHCI/stable/2023-06-01/updates.json#L121 |
||
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get Update summaries under cluster resource Location: Microsoft.AzureStackHCI/stable/2023-06-01/updateSummaries.json#L207 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
|
This was referenced Jul 27, 2023
added 2 commits
July 27, 2023 10:53
AzureRestAPISpecReview
added
ARMReview
ReadyForApiTest
visingla-ms
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
prateekprshr-nith
added
the
DoNotMerge
|
/azp run unifiedPipeline |
|
No commit pushedDate could be found for PR 25004 in repo Azure/azure-rest-api-specs |
|
Hi, @prateekprshr-nith. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
|
Hi, @prateekprshr-nith. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
prateekprshr-nith
removed
the
DoNotMerge
Next Steps to Merge |
…ureStackHCI-2023-06-01
|
Automatic PR validation started. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛. |
openapi-pipeline-app
bot
added
the
DoNotMerge
prateekprshr-nith
removed
the
DoNotMerge
|
Hi @rkmanda, thank you. Regarding the errors in These issues were not reported in the last iteration when |
rkmanda
approved these changes
Aug 29, 2023
rkmanda
deleted the
prateekprshr-nith-azurestackhci-Microsoft.AzureStackHCI-2023-06-01
branch
|
Swagger pipeline restarted successfully, please wait for status update in this comment. |
openapi-pipeline-app
bot
added
the
DoNotMerge
This was referenced Aug 29, 2023
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
…sion stable/2023-06-01 (#25004) * Adds base for updating Microsoft.AzureStackHCI from version stable/2023-03-01 to version 2023-06-01 * Updates readme * Updates API version in new specs and examples * Added changes for `2023-06-01` * Added `x-ms-identifiers` * Fixed prettier issue --------- Co-authored-by: Prateek Prasher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.
ARM API changes review
ARMReviewlabel.ARMReviewlabel, if appropriate.If this happens, proceed according to guidance given in GitHub comments also added by the automation.
Breaking change review
If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.
Getting help
and https://aka.ms/ci-fix.