Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address ARM review comments #25005

Merged
merged 8 commits into from
Jul 28, 2023

Update specification/containerservice/resource-manager/Microsoft.Cont…

819aedd
Select commit
Loading
Failed to load commit list.
Merged

address ARM review comments #25005

Update specification/containerservice/resource-manager/Microsoft.Cont…
819aedd
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff succeeded Jul 27, 2023 in 4m 45s

Swagger LintDiff succeeded

LintDiff
View more details.

Details

compared tags (via openapi-validator v2.1.3) new version base version
package-preview-2023-06 package-preview-2023-06(819aedd) package-preview-2023-06(FumingZhang-containerservice-Microsoft.ContainerService-2023-06-02-preview)

The following errors/warnings exist before current PR submission:
Only 50 items are listed, please refer to log for more details.

Rule Message
❌ OperationsApiResponseSchema The response schema of operations API '/providers/Microsoft.ContainerService/operations' does not match the ARM specification. Please standardize the schema.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L52
❌ OperationsApiSchemaUsesCommonTypes Operations API path must follow the schema provided in the common types.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L53
❌ ParametersInPointGet Query parameter resource-type should be removed. Point Get's MUST not have query parameters other than api version.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L80
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L103
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L137
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L260
❌ ResourceNameRestriction The resource name parameter 'roleName' should be defined with a 'pattern' restriction.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L278
❌ ParametersInPost server-fqdn is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L336
❌ ParametersInPost server-fqdn is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L381
❌ ParametersInPost format is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L381
❌ ParametersInPost server-fqdn is a query parameter. Post operation must not contain any query parameter other than api-version.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L429
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L553
❌ PatchResponseCode LRO PATCH must have 200 and 202 return codes.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L648
❌ PatchIdentityProperty The patch operation body parameter schema should contain property 'identity'.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L667
❌ PatchSkuProperty The patch operation body parameter schema should contain property 'sku'.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L667
❌ LroPatch202 The async patch operation should return 202.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L677
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L687
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L737
❌ ResourceNameRestriction The resource name parameter 'configName' should be defined with a 'pattern' restriction.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L797
❌ LroPostReturn A LRO POST operation must have both 200 & 202 return codes.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L967
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1018
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1181
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1298
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1347
❌ OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'AgentPools' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1370
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1390
❌ LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1409
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1455
❌ LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1471
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1518
❌ LroPostReturn A LRO POST operation must have both 200 & 202 return codes.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1534
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1575
❌ LroPostReturn A LRO POST operation must have both 200 & 202 return codes.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1591
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1628
❌ LroPostReturn A LRO POST operation must have both 200 & 202 return codes.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1644
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1680
❌ LroPostReturn A LRO POST operation must have both 200 & 202 return codes.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1696
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1733
❌ LroPostReturn A LRO POST operation must have both 200 & 202 return codes.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1749
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1786
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1826
❌ ResourceNameRestriction The resource name parameter 'privateEndpointConnectionName' should be defined with a 'pattern' restriction.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1844
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L1992
❌ LroPostReturn 200 response for a LRO POST operation must have a response schema specified.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L2005
❌ LroPostReturn 202 response for a LRO POST operation must not have a response schema specified.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L2005
❌ LroLocationHeader A 202 response should include an Location response header.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L2042
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L2055
❌ PrivateEndpointResourceSchemaValidation The private endpoint model 'PrivateLinkResourcesListResult' schema does not conform to the common type definition.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L2093
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L2095
❌ LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: aks/preview/2023-06-02-preview/managedClusters.json#L2214
View more details on openapi-pipeline-app