[Hub Generated] Publish private branch 'AddNewApiVersion' #25030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/13385 |
Swagger Validation Report
|
| compared tags (via openapi-validator v2.1.3) | new version | base version |
|---|---|---|
| package-2023-06-preview | package-2023-06-preview(4d77d96) | default(main) |
| default | default(4d77d96) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json#L1119 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json#L1317 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json#L1324 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json#L1334 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json#L1338 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json#L1351 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json#L1725 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json#L2043 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json#L2064 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json#L2075 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json#L2136 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json#L2245 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json#L2796 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json#L2862 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json#L2935 |
️❌Avocado: 14 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.HDInsight/clusterpools/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/hdinsight/resource-manager/readme.md json: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.HDInsight/clusterpools is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/hdinsight/resource-manager/readme.md json: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.HDInsight/clusterpools is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/hdinsight/resource-manager/readme.md json: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.HDInsight/clusterpools/{}/clusters is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/hdinsight/resource-manager/readme.md json: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.HDInsight/clusterpools/{}/clusters/{}/resize is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/hdinsight/resource-manager/readme.md json: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.HDInsight/clusterpools/{}/clusters/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/hdinsight/resource-manager/readme.md json: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.HDInsight/clusterpools/{}/clusters/{}/runJob is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/hdinsight/resource-manager/readme.md json: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.HDInsight/clusterpools/{}/clusters/{}/jobs is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/hdinsight/resource-manager/readme.md json: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.HDInsight/clusterpools/{}/clusters/{}/serviceConfigs is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/hdinsight/resource-manager/readme.md json: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json |
|
The default tag does not contains the latest API version. Please make sure the latest api version swaggers are in the default tag. readme: specification/hdinsight/resource-manager/readme.md json: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.HDInsight/clusterpools/{}/clusters/{}/instanceViews is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/hdinsight/resource-manager/readme.md json: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.HDInsight/clusterpools/{}/clusters/{}/instanceViews/default is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/hdinsight/resource-manager/readme.md json: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.HDInsight/locations/{}/availableClusterPoolVersions is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/hdinsight/resource-manager/readme.md json: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.HDInsight/locations/{}/availableClusterVersions is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/hdinsight/resource-manager/readme.md json: HDInsightOnAks/preview/2023-06-01-preview/hdinsight.json |
️❌ApiReadinessCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
"code: InvalidResourceType, message: The resource type 'operations' could not be found in the namespace 'Microsoft.HDInsight' for api version '2023-06-01-preview'. The supported api-versions are '2015-03-01-preview, 2018-06-01-preview, 2021-06-01, 2023-04-15-preview, 2021-09-15-preview'." |
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
|
Hi, @aim-for-better! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
CI-FixRequiredOnFailure
new-api-version
resource-manager
RPaaS
SuppressionReviewRequired
WaitForARMFeedback
|
Hi @aim-for-better! Your PR has some issues. Please fix the CI issues, if present, in following order:
If you need further help, please reach out on the Teams channel aka.ms/azsdk/support/specreview-channel. |
|
Hi @aim-for-better, one or multiple validation error/warning suppression(s) is detected in your PR. Please follow the Swagger-Suppression-Process to get approval. |
|
Hi team, gentle reminder if you approved #24940 then you can skip this PR. |
This was referenced Jul 28, 2023
This was referenced Jul 28, 2023
aim-for-better
force-pushed
the
published/Azure/azure-rest-api-specs-pr/AddNewApiVersion
branch
from
5987324
to
4d77d96
Compare
8 tasks
visingla-ms
added
the
ARMChangesRequested
|
Please address or respond to feedback from the ARM API reviewer. |
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
Thank you for adding this comment. We have already reviewed the other PR, so I believe this needs to be closed/drafted. |
|
Hi team, I closed this one due to #24940 is ARM signed off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can request review from an ARM API Review board.
ARM API changes review
ARMReviewlabel.ARMReviewlabel, if appropriate.If this happens, proceed according to guidance given in GitHub comments also added by the automation.
Breaking change review
If you have any breaking changes as defined in the Breaking Change Policy,
follow the process outlined in the High-level Breaking Change Process doc.
Getting help
and https://aka.ms/ci-fix.