App protect cdn 20223 08 01 preview #25197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neelesh06
requested review from
weshaggard,
mikeharder,
konrad-jamrozik,
msyyc,
tadelesh,
qiaozha,
pjohari-ms,
Sandido,
dkulkarni-ms,
haagha,
madewithsmiles,
MS-syh2qs,
grizzlytheodore,
hyonholee,
bojunehsu,
johanste,
jorinmejia,
yunheMsft,
jessicl-ms,
t-bzhan,
orieldar and
a team
as code owners
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| FormRecognizer.json | 2022-08-31(c008a71) | 2022-08-31(main) |
| desktopvirtualization.json | 2019-01-23-preview(c008a71) | 2019-01-23-preview(main) |
| desktopvirtualization.json | 2019-09-24-preview(c008a71) | 2019-09-24-preview(main) |
| desktopvirtualization.json | 2019-12-10-preview(c008a71) | 2019-12-10-preview(main) |
| oucontainer.json | 2017-06-01(c008a71) | 2017-06-01(main) |
| oucontainer.json | 2020-01-01(c008a71) | 2020-01-01(main) |
| domainservices.json | 2021-03-01(c008a71) | 2021-03-01(main) |
| oucontainer.json | 2021-03-01(c008a71) | 2021-03-01(main) |
️❌Breaking Change(Cross-Version): 2 Errors, 0 Warnings failed [Detail]
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
|
"new":"https://github.com/Azure/azure-rest-api-specs/blob/c008a71aebeef195b8ac95fab078ae9d667fe8d2/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-08-01-preview/afdx.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cdn/resource-manager/Microsoft.Cdn/stable/2023-05-01/afdx.json", "details":"Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.57/common/temp/node_modules/.pnpm/@Azure[email protected]/node_modules/autorest/dist/app.js" --v2 --input-file=specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-08-01-preview/afdx.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp\nERROR: Syntax Error Encountered: Unexpected token in JSON\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-08-01-preview/afdx.json:358:2\nERROR: Referenced file 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-08-01-preview/cdn.json' not found\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-08-01-preview/afdx.json:449:10 ($.definitions.SecurityPolicyWebApplicationFirewallParameters.properties.wafPolicy["$ref"])\nFATAL: " |
The following breaking changes are detected by comparison with the latest preview version:
| Rule | Message |
|---|---|
|
"new":"https://github.com/Azure/azure-rest-api-specs/blob/c008a71aebeef195b8ac95fab078ae9d667fe8d2/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-08-01-preview/afdx.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cdn/resource-manager/Microsoft.Cdn/preview/2022-11-01-preview/afdx.json", "details":"Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.57/common/temp/node_modules/.pnpm/@Azure[email protected]/node_modules/autorest/dist/app.js" --v2 --input-file=specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-08-01-preview/afdx.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp\nERROR: Syntax Error Encountered: Unexpected token in JSON\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-08-01-preview/afdx.json:358:2\nERROR: Referenced file 'file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-08-01-preview/cdn.json' not found\n - file:///mnt/vss/_work/1/azure-rest-api-specs/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-08-01-preview/afdx.json:449:10 ($.definitions.SecurityPolicyWebApplicationFirewallParameters.properties.wafPolicy["$ref"])\nFATAL: " |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️LintDiff succeeded [Detail]
| Rule | Message |
|---|---|
|
"details":""stack":"ResolverError: Error reading file \"/mnt/vss/_work/1/azure-rest-api-specs/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-08-01-preview/cdn.json\"\n at onError (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.57/common/temp/node_modules/.pnpm/@APIDevTools[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/parse.js:92:16)", "code":"ERESOLVER", "message":"Error reading file \"/mnt/vss/_work/1/azure-rest-api-specs/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-08-01-preview/cdn.json\"", "source":"/mnt/vss/_work/1/azure-rest-api-specs/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-08-01-preview/cdn.json", "path":null, "name":"ResolverError", "footprint":"null+/mnt/vss/_work/1/azure-rest-api-specs/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-08-01-preview/cdn.json+ERESOLVER+Error reading file \"/mnt/vss/_work/1/azure-rest-api-specs/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-08-01-preview/cdn.json\""" |
️❌Avocado: 11 Errors, 4 Warnings failed [Detail]
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 0 Errors, 0 Warnings failed [Detail]
️❌SemanticValidation: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Json parsing error: unexpected token JsonUrl: Microsoft.Cdn/preview/2023-08-01-preview/afdx.json#L358:3 |
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌PrettierCheck: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
Code style issues found path: Microsoft.Cdn/preview/2023-08-01-preview/afdx.json |
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail]
| Rule | Message |
|---|---|
|
"details":""stack":"ResolverError: Error reading file \"/mnt/vss/_work/1/azure-rest-api-specs/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-08-01-preview/cdn.json\"\n at onError (/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.57/common/temp/node_modules/.pnpm/@APIDevTools[email protected]/node_modules/@apidevtools/json-schema-ref-parser/lib/parse.js:92:16)\n at processTicksAndRejections (internal/process/task_queues.js:95:5)", "code":"ERESOLVER", "message":"Error reading file \"/mnt/vss/_work/1/azure-rest-api-specs/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-08-01-preview/cdn.json\"", "source":"/mnt/vss/_work/1/azure-rest-api-specs/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-08-01-preview/cdn.json", "path":null, "name":"ResolverError", "footprint":"null+/mnt/vss/_work/1/azure-rest-api-specs/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-08-01-preview/cdn.json+ERESOLVER+Error reading file \"/mnt/vss/_work/1/azure-rest-api-specs/specification/cdn/resource-manager/Microsoft.Cdn/preview/2023-08-01-preview/cdn.json\""" |
️❌PR Summary: 0 Errors, 0 Warnings failed [Detail]
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
|
Hi @neelesh06, this service has enabled Service API Toolset. All spec updates MUST be initiated from service ADO project repo, so that to guarantee it to be the source of truth., please review this pull request if it's intentional or reject it if it's not expected. Normally, all the specification or example changes should start with PR created in ADO. |
Generated ApiView
|
This was referenced Aug 7, 2023
Draft
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 7, 2023
|
@neelesh06: Something is wrong with this PR, there are too many changes. Did you have a bad merge or are you targeting the wrong branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.