Adding SubscriptionId and ResourceGroup for Azure Datastore #25289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @ChunyuMSFT! Thank you for your pull request. To help get your PR merged: Generated ApiView comment added to this PR. You can use ApiView to show API versions diff. |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| mfe.json | 2023-10-01(edacef4) | 2023-04-01(main) |
| mfe.json | 2023-10-01(edacef4) | 2023-06-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
| The new version has a different 'allOf' property than the previous one. New: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L9389:5 Old: Microsoft.MachineLearningServices/stable/2023-04-01/mfe.json#L9389:5 |
|
| The new version has a different 'allOf' property than the previous one. New: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L9452:5 Old: Microsoft.MachineLearningServices/stable/2023-04-01/mfe.json#L9449:5 |
|
| The new version has a different 'allOf' property than the previous one. New: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L9490:5 Old: Microsoft.MachineLearningServices/stable/2023-04-01/mfe.json#L9484:5 |
|
| The new version has a different 'allOf' property than the previous one. New: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L9576:5 Old: Microsoft.MachineLearningServices/stable/2023-04-01/mfe.json#L9550:5 |
The following breaking changes are detected by comparison with the latest preview version:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/registries/{registryName}/models/{modelName}/versions/{version}/package' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L3204:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/featuresets' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L6713:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/featuresets/{featuresetName}/versions/{featuresetVersion}/features' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L6823:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/featuresets/{featuresetName}/versions/{featuresetVersion}/features/{featureName}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L6907:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/featuresets/{name}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L6975:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/featuresets/{name}/versions' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L7186:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/featuresets/{name}/versions/{version}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L7315:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/featuresets/{name}/versions/{version}/backfill' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L7547:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/featuresets/{name}/versions/{version}/listMaterializationJobs' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L7638:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/featurestoreEntities' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L7721:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/featurestoreEntities/{name}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L7831:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/featurestoreEntities/{name}/versions' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L8042:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/featurestoreEntities/{name}/versions/{version}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L8171:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L8865:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs/{id}' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L8923:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs/{id}/exportLabels' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L9123:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs/{id}/pause' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L9207:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/labelingJobs/{id}/resume' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L9256:5 |
|
| The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.MachineLearningServices/workspaces/{workspaceName}/models/{name}/versions/{version}/package' removed or restructured? Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L9914:5 |
|
| The new version is missing a definition that was found in the old version. Was 'AllFeatures' removed or renamed? New: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8985:3 Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L11435:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AmlTokenComputeIdentity' removed or renamed? New: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8985:3 Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L11435:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AutoDeleteCondition' removed or renamed? New: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8985:3 Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L11435:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AutoDeleteSetting' removed or renamed? New: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8985:3 Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L11435:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AutologgerSettings' removed or renamed? New: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8985:3 Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L11435:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AzMonMonitoringAlertNotificationSettings' removed or renamed? New: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8985:3 Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L11435:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AzureDevOpsWebhook' removed or renamed? New: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8985:3 Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L11435:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AzureMLBatchInferencingServer' removed or renamed? New: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8985:3 Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L11435:3 |
|
| The new version is missing a definition that was found in the old version. Was 'AzureMLOnlineInferencingServer' removed or renamed? New: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8985:3 Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L11435:3 |
|
| The new version is missing a definition that was found in the old version. Was 'BaseEnvironmentId' removed or renamed? New: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8985:3 Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L11435:3 |
|
| The new version is missing a definition that was found in the old version. Was 'BaseEnvironmentSource' removed or renamed? New: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8985:3 Old: Microsoft.MachineLearningServices/preview/2023-06-01-preview/mfe.json#L11435:3 |
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.1.4) | new version | base version |
|---|---|---|
| package-2023-10 | package-2023-10(edacef4) | package-2023-10(release-machinelearningservices-Microsoft.MachineLearningServices-2023-10-01) |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L1428 |
|
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L1428 |
|
200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L1757 |
|
201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L1757 |
|
The resource name parameter 'endpointName' should be defined with a 'pattern' restriction. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L3322 |
|
The patch operation body parameter schema should contain property 'sku'. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L3481 |
|
The resource name parameter 'endpointName' should be defined with a 'pattern' restriction. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L3618 |
|
The resource name parameter 'endpointName' should be defined with a 'pattern' restriction. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L3689 |
|
The resource name parameter 'deploymentName' should be defined with a 'pattern' restriction. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L3689 |
|
The patch operation body parameter schema should contain property 'identity'. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L3870 |
|
The patch operation body parameter schema should contain property 'sku'. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L3870 |
|
The resource name parameter 'endpointName' should be defined with a 'pattern' restriction. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L4015 |
|
200 response for a LRO POST operation must have a response schema specified. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L6905 |
|
The resource name parameter 'endpointName' should be defined with a 'pattern' restriction. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L7663 |
|
The patch operation body parameter schema should contain property 'sku'. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L7821 |
|
The resource name parameter 'endpointName' should be defined with a 'pattern' restriction. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L7958 |
|
The resource name parameter 'endpointName' should be defined with a 'pattern' restriction. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8029 |
|
The resource name parameter 'deploymentName' should be defined with a 'pattern' restriction. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8029 |
|
The patch operation body parameter schema should contain property 'identity'. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8213 |
|
The resource name parameter 'endpointName' should be defined with a 'pattern' restriction. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8364 |
|
The resource name parameter 'deploymentName' should be defined with a 'pattern' restriction. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8364 |
|
The resource name parameter 'endpointName' should be defined with a 'pattern' restriction. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8435 |
|
The resource name parameter 'deploymentName' should be defined with a 'pattern' restriction. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8435 |
|
The resource name parameter 'endpointName' should be defined with a 'pattern' restriction. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8510 |
|
The resource name parameter 'endpointName' should be defined with a 'pattern' restriction. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8562 |
|
200 response for a LRO POST operation must have a response schema specified. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8563 |
|
The resource name parameter 'endpointName' should be defined with a 'pattern' restriction. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L8643 |
|
Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L10095 |
|
Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L10114 |
|
Usage of Guid is not recommended. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json#L14205 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
resource-manager
WaitForARMFeedback
This was referenced Aug 12, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
Next Steps to Merge |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| "resourceGroup": { | ||
| "description": "Azure Resource Group name", | ||
| "type": "string", | ||
| "x-nullable": true |
There was a problem hiding this comment.
I thought "x-nullable" just makes the "null" as acceptable value? How to mark omit null value in swagger? I think it's implementation behavior instead of something in swagger?
There was a problem hiding this comment.
We prefer implementations to not rely on the value null if they don't have to.
...arningservices/resource-manager/Microsoft.MachineLearningServices/stable/2023-10-01/mfe.json
Show resolved
Hide resolved
TimLovellSmith
added
the
ARMChangesRequested
|
Please address or respond to feedback from the ARM API reviewer. |
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
ChunyuMSFT
removed
the
ARMChangesRequested
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
ms-henglu
added
the
ARMSignedOff
openapi-workflow-bot
bot
removed
the
WaitForARMFeedback
|
/pr RequestMerge |
ms-henglu
approved these changes
Aug 23, 2023
ms-henglu
merged commit c9dfd1b
into
Azure:release-machinelearningservices-Microsoft.MachineLearningServices-2023-10-01
25 of 26 checks passed
6 tasks
kseager
pushed a commit
to kseager/azure-rest-api-specs
that referenced
this pull request
Oct 4, 2023
kseager
pushed a commit
to kseager/azure-rest-api-specs
that referenced
this pull request
Oct 6, 2023
rkmanda
pushed a commit
that referenced
this pull request
Oct 16, 2023
…023 10 01 shadow (#26104) * Adds base for updating Microsoft.MachineLearningServices from version stable/2023-04-01 to version 2023-10-01 * fix rebase * Updates API version in new specs and examples * mfe.json update description to fix linting errors (#24968) Co-authored-by: Kayla Ames <[email protected]> * add headers for start/stop/restart compute examples (#25072) * Adding SubscriptionId and ResourceGroup for Azure Datastore (#25289) * Add query param in list job api (#25374) Co-authored-by: Shail Paragbhai Shah <[email protected]> * [MachineLearning]Try fixing some lint error in 10-01 version (#25519) * Try fixing some lint error * bug fix * remove unused definition * Update Example * adding queue settings to Oct 2023 stable api version (#25765) * adding queue settings to Oct 2023 stable api version * update new line --------- Co-authored-by: Aaheli Chattopadhyay <[email protected]> * remove job priority (#25775) Co-authored-by: Aaheli Chattopadhyay <[email protected]> * Adding MachineLearningService workspace resource publish API and registry datareference API (#25619) * Adding machinelearningservices workspace publish and registry datareference API * minimize diff * minor updates on put job api summary * remove two unneeded APIs * remove extra adding long running annotation * Add managed Vnet to stable version (#25729) * Add managed Vnet to stable version * update missing parameter * Update missing ref * meaningless commit trigger pipeline again * Revert "meaningless commit trigger pipeline again" This reverts commit baa386b. * add missing ref * Update example version * trigger pipeline * Revert "trigger pipeline" This reverts commit f989c4c. * add force to purge parameter * trigger pipeline * Revert "trigger pipeline" This reverts commit 42ea0f8. * Update examples * Add format and update examples * [Model Monitoring][GA] - Add model monitoring scenarios (#25801) * Add model monitoring scenarios * add * add * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * add ws vnet properties (#25882) Co-authored-by: Aaheli Chattopadhyay <[email protected]> * Fix circular reference 2023-10-01 (#25879) * TriggerType->ComputeTriggerType * RecurrenceFrequency->ComputeRecurrenceFrequency * RecurrenceSchedule->ComputeRecurrenceSchedule * description --------- Co-authored-by: Kayla Ames <[email protected]> * Adding proxy resource (#25904) Co-authored-by: Shail Paragbhai Shah <[email protected]> * Add feature store api's to GA version (#25594) * Add examples * Adding feature store GA api's * Sync examples * Add examples * Converting to ProxyResource --------- Co-authored-by: Shail Paragbhai Shah <[email protected]> * add serverless compute settings (#26012) Co-authored-by: Aaheli Chattopadhyay <[email protected]> * [MachineLearningService]Add featurestore property to stable version (#26121) * Add workspace kind and featureStoreSettings * add description * Add description for ComputeRuntimeDti * remove featurestore settings for lint * remove Kind * Revert "remove featurestore settings for lint" This reverts commit f4d7ae3. * Update readme fix --------- Co-authored-by: Kayla Ames <[email protected]> Co-authored-by: libc16 <[email protected]> Co-authored-by: Chunyu Li <[email protected]> Co-authored-by: shail2208 <[email protected]> Co-authored-by: Shail Paragbhai Shah <[email protected]> Co-authored-by: ZhidaLiu <[email protected]> Co-authored-by: ac923 <[email protected]> Co-authored-by: Aaheli Chattopadhyay <[email protected]> Co-authored-by: chaoyu-msft <[email protected]> Co-authored-by: Mathieu St-Louis <[email protected]>
jnlycklama
pushed a commit
that referenced
this pull request
Nov 8, 2023
…023 10 01 shadow (#26104) * Adds base for updating Microsoft.MachineLearningServices from version stable/2023-04-01 to version 2023-10-01 * fix rebase * Updates API version in new specs and examples * mfe.json update description to fix linting errors (#24968) Co-authored-by: Kayla Ames <[email protected]> * add headers for start/stop/restart compute examples (#25072) * Adding SubscriptionId and ResourceGroup for Azure Datastore (#25289) * Add query param in list job api (#25374) Co-authored-by: Shail Paragbhai Shah <[email protected]> * [MachineLearning]Try fixing some lint error in 10-01 version (#25519) * Try fixing some lint error * bug fix * remove unused definition * Update Example * adding queue settings to Oct 2023 stable api version (#25765) * adding queue settings to Oct 2023 stable api version * update new line --------- Co-authored-by: Aaheli Chattopadhyay <[email protected]> * remove job priority (#25775) Co-authored-by: Aaheli Chattopadhyay <[email protected]> * Adding MachineLearningService workspace resource publish API and registry datareference API (#25619) * Adding machinelearningservices workspace publish and registry datareference API * minimize diff * minor updates on put job api summary * remove two unneeded APIs * remove extra adding long running annotation * Add managed Vnet to stable version (#25729) * Add managed Vnet to stable version * update missing parameter * Update missing ref * meaningless commit trigger pipeline again * Revert "meaningless commit trigger pipeline again" This reverts commit baa386b. * add missing ref * Update example version * trigger pipeline * Revert "trigger pipeline" This reverts commit f989c4c. * add force to purge parameter * trigger pipeline * Revert "trigger pipeline" This reverts commit 42ea0f8. * Update examples * Add format and update examples * [Model Monitoring][GA] - Add model monitoring scenarios (#25801) * Add model monitoring scenarios * add * add * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * add ws vnet properties (#25882) Co-authored-by: Aaheli Chattopadhyay <[email protected]> * Fix circular reference 2023-10-01 (#25879) * TriggerType->ComputeTriggerType * RecurrenceFrequency->ComputeRecurrenceFrequency * RecurrenceSchedule->ComputeRecurrenceSchedule * description --------- Co-authored-by: Kayla Ames <[email protected]> * Adding proxy resource (#25904) Co-authored-by: Shail Paragbhai Shah <[email protected]> * Add feature store api's to GA version (#25594) * Add examples * Adding feature store GA api's * Sync examples * Add examples * Converting to ProxyResource --------- Co-authored-by: Shail Paragbhai Shah <[email protected]> * add serverless compute settings (#26012) Co-authored-by: Aaheli Chattopadhyay <[email protected]> * [MachineLearningService]Add featurestore property to stable version (#26121) * Add workspace kind and featureStoreSettings * add description * Add description for ComputeRuntimeDti * remove featurestore settings for lint * remove Kind * Revert "remove featurestore settings for lint" This reverts commit f4d7ae3. * Update readme fix --------- Co-authored-by: Kayla Ames <[email protected]> Co-authored-by: libc16 <[email protected]> Co-authored-by: Chunyu Li <[email protected]> Co-authored-by: shail2208 <[email protected]> Co-authored-by: Shail Paragbhai Shah <[email protected]> Co-authored-by: ZhidaLiu <[email protected]> Co-authored-by: ac923 <[email protected]> Co-authored-by: Aaheli Chattopadhyay <[email protected]> Co-authored-by: chaoyu-msft <[email protected]> Co-authored-by: Mathieu St-Louis <[email protected]>
zman-ms
pushed a commit
that referenced
this pull request
Jan 10, 2024
…023 10 01 shadow (#26104) * Adds base for updating Microsoft.MachineLearningServices from version stable/2023-04-01 to version 2023-10-01 * fix rebase * Updates API version in new specs and examples * mfe.json update description to fix linting errors (#24968) Co-authored-by: Kayla Ames <[email protected]> * add headers for start/stop/restart compute examples (#25072) * Adding SubscriptionId and ResourceGroup for Azure Datastore (#25289) * Add query param in list job api (#25374) Co-authored-by: Shail Paragbhai Shah <[email protected]> * [MachineLearning]Try fixing some lint error in 10-01 version (#25519) * Try fixing some lint error * bug fix * remove unused definition * Update Example * adding queue settings to Oct 2023 stable api version (#25765) * adding queue settings to Oct 2023 stable api version * update new line --------- Co-authored-by: Aaheli Chattopadhyay <[email protected]> * remove job priority (#25775) Co-authored-by: Aaheli Chattopadhyay <[email protected]> * Adding MachineLearningService workspace resource publish API and registry datareference API (#25619) * Adding machinelearningservices workspace publish and registry datareference API * minimize diff * minor updates on put job api summary * remove two unneeded APIs * remove extra adding long running annotation * Add managed Vnet to stable version (#25729) * Add managed Vnet to stable version * update missing parameter * Update missing ref * meaningless commit trigger pipeline again * Revert "meaningless commit trigger pipeline again" This reverts commit baa386b. * add missing ref * Update example version * trigger pipeline * Revert "trigger pipeline" This reverts commit f989c4c. * add force to purge parameter * trigger pipeline * Revert "trigger pipeline" This reverts commit 42ea0f8. * Update examples * Add format and update examples * [Model Monitoring][GA] - Add model monitoring scenarios (#25801) * Add model monitoring scenarios * add * add * Update mfe.json * Update mfe.json * Update mfe.json * Update mfe.json * add ws vnet properties (#25882) Co-authored-by: Aaheli Chattopadhyay <[email protected]> * Fix circular reference 2023-10-01 (#25879) * TriggerType->ComputeTriggerType * RecurrenceFrequency->ComputeRecurrenceFrequency * RecurrenceSchedule->ComputeRecurrenceSchedule * description --------- Co-authored-by: Kayla Ames <[email protected]> * Adding proxy resource (#25904) Co-authored-by: Shail Paragbhai Shah <[email protected]> * Add feature store api's to GA version (#25594) * Add examples * Adding feature store GA api's * Sync examples * Add examples * Converting to ProxyResource --------- Co-authored-by: Shail Paragbhai Shah <[email protected]> * add serverless compute settings (#26012) Co-authored-by: Aaheli Chattopadhyay <[email protected]> * [MachineLearningService]Add featurestore property to stable version (#26121) * Add workspace kind and featureStoreSettings * add description * Add description for ComputeRuntimeDti * remove featurestore settings for lint * remove Kind * Revert "remove featurestore settings for lint" This reverts commit f4d7ae3. * Update readme fix --------- Co-authored-by: Kayla Ames <[email protected]> Co-authored-by: libc16 <[email protected]> Co-authored-by: Chunyu Li <[email protected]> Co-authored-by: shail2208 <[email protected]> Co-authored-by: Shail Paragbhai Shah <[email protected]> Co-authored-by: ZhidaLiu <[email protected]> Co-authored-by: ac923 <[email protected]> Co-authored-by: Aaheli Chattopadhyay <[email protected]> Co-authored-by: chaoyu-msft <[email protected]> Co-authored-by: Mathieu St-Louis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
[1] public repo review queue, private repo review queue
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label
ARMChangesRequestedis removed from your PR. This should cause the label
WaitForARMFeedbackto be added.[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue
If you need further help with anything, see
Getting helpsection below.Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.
Breaking changes review (Step 1)
you must follow the breaking changes process.
IMPORTANT This applies even if:
Such claims must be reviewed, and the process is the same.
ARM API changes review (Step 2)
ARMReviewlabel.Getting help
and https://aka.ms/ci-fix.