Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release securityinsights microsoft.security insights 2023 08 01 preview #25370

Conversation

xuhumsft
Copy link
Member

@xuhumsft xuhumsft commented Aug 17, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Getting help

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 17, 2023

Next Steps to Merge

⚠️ This is an experimental comment. It may not always be up-to-date. ⚠️

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 17, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 3 Errors, 12 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
AlertRules.json 2023-08-01-preview(3ddcc7a) 2023-02-01(main)
AlertRules.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
AutomationRules.json 2023-08-01-preview(3ddcc7a) 2023-02-01(main)
AutomationRules.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
BillingStatistics.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
Bookmarks.json 2023-08-01-preview(3ddcc7a) 2023-02-01(main)
Bookmarks.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
ContentPackages.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
ContentProductPackages.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
ContentProductTemplates.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
ContentTemplates.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
Enrichment.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
Entities.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
EntityQueries.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
EntityQueryTemplates.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
FileImports.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
Hunts.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
Incidents.json 2023-08-01-preview(3ddcc7a) 2023-02-01(main)
Incidents.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
Metadata.json 2023-08-01-preview(3ddcc7a) 2023-02-01(main)
Metadata.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
OfficeConsents.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
OnboardingStates.json 2023-08-01-preview(3ddcc7a) 2023-02-01(main)
OnboardingStates.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
Recommendations.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
SecurityMLAnalyticsSettings.json 2023-08-01-preview(3ddcc7a) 2023-02-01(main)
SecurityMLAnalyticsSettings.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
Settings.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
SourceControls.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
ThreatIntelligence.json 2023-08-01-preview(3ddcc7a) 2023-02-01(main)
ThreatIntelligence.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
TriggeredAnalyticsRuleRuns.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
Watchlists.json 2023-08-01-preview(3ddcc7a) 2023-02-01(main)
Watchlists.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
WorkspaceManagerAssignments.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
WorkspaceManagerConfigurations.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
WorkspaceManagerGroups.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
WorkspaceManagerMembers.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
AlertTypes.json 2023-08-01-preview(3ddcc7a) 2023-02-01(main)
AlertTypes.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
ContentCommonTypes.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
EntityTypes.json 2023-08-01-preview(3ddcc7a) 2023-02-01(main)
EntityTypes.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
IncidentTypes.json 2023-08-01-preview(3ddcc7a) 2023-02-01(main)
IncidentTypes.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
RelationTypes.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
ThreatIntelligenceTypes.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
dataConnectorDefinitions.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
dataConnectors.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)
operations.json 2023-08-01-preview(3ddcc7a) 2023-02-01(main)
operations.json 2023-08-01-preview(3ddcc7a) 2023-07-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule Message
1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
New: Microsoft.SecurityInsights/preview/2023-08-01-preview/AlertRules.json#L1576:7
Old: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L1072:7
1025 - RequiredStatusChange The 'required' status changed from the old version('True') to the new version('False').
New: Microsoft.SecurityInsights/preview/2023-08-01-preview/Watchlists.json#L481:7
Old: Microsoft.SecurityInsights/stable/2023-02-01/Watchlists.json#L469:7
1049 - RemovedXmsEnum The new version is missing a 'x-ms-enum' found in the old version.
New: Microsoft.SecurityInsights/preview/2023-08-01-preview/Watchlists.json#L494:9
Old: Microsoft.SecurityInsights/stable/2023-02-01/Watchlists.json#L482:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.SecurityInsights/preview/2023-08-01-preview/Incidents.json#L1315:9
Old: Microsoft.SecurityInsights/stable/2023-02-01/Incidents.json#L1102:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.SecurityInsights/preview/2023-08-01-preview/Incidents.json#L1319:9
Old: Microsoft.SecurityInsights/stable/2023-02-01/Incidents.json#L1138:9
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.SecurityInsights/preview/2023-08-01-preview/Incidents.json#L1312:9
Old: Microsoft.SecurityInsights/stable/2023-02-01/Incidents.json#L1245:9
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.SecurityInsights/preview/2023-08-01-preview/AlertRules.json#L2372:11
Old: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L533:11
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.SecurityInsights/preview/2023-08-01-preview/AlertRules.json#L326:13
Old: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L317:13
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.SecurityInsights/preview/2023-08-01-preview/AlertRules.json#L375:13
Old: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L366:13
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.SecurityInsights/preview/2023-08-01-preview/AlertRules.json#L381:13
Old: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L372:13
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.SecurityInsights/preview/2023-08-01-preview/AlertRules.json#L2331:5
Old: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L579:5
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.SecurityInsights/preview/2023-08-01-preview/AlertRules.json#L1552:9
Old: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L1053:9
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.SecurityInsights/preview/2023-08-01-preview/AlertRules.json#L1569:5
Old: Microsoft.SecurityInsights/stable/2023-02-01/AlertRules.json#L1070:5
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.SecurityInsights/preview/2023-08-01-preview/Metadata.json#L250:9
Old: Microsoft.SecurityInsights/stable/2023-02-01/Metadata.json#L250:9
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.SecurityInsights/preview/2023-08-01-preview/Metadata.json#L325:5
Old: Microsoft.SecurityInsights/stable/2023-02-01/Metadata.json#L325:5
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.4) new version base version
package-preview-2023-08 package-preview-2023-08(3ddcc7a) default(main)

The following errors/warnings exist before current PR submission:

Rule Message
XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/Bookmarks.json#L566
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/EntityQueries.json#L484
XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/EntityQueryTemplates.json#L234
XmsEnumValidation The enum types should have x-ms-enum type extension set with appropriate options.
Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/EntityQueryTemplates.json#L292
XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/Incidents.json#L1245
XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/Incidents.json#L1332
XmsIdentifierValidation Missing identifier id in array item property
Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/operations.json#L83
UniqueXmsEnumName Must not have duplicate name of x-ms-enum extension , make sure every x-ms-enum name unique. The duplicate x-ms-enum name: priority, path: $['RecommendationPriority']
Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/Recommendations.json#L511
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get a template.
Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/ContentTemplates.json#L148
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'dataconnectorscheckrequirements' in:'DataConnectorsCheckRequirements_Post'. Consider updating the operationId
Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/dataConnectors.json#L488
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'gettimeline' in:'EntitiesGetTimeline_list'. Consider updating the operationId
Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/Entities.json#L243
⚠️ PageableOperation Based on the response model schema, operation 'Entities_Queries' might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/Entities.json#L281
⚠️ PageableOperation Based on the response model schema, operation 'SentinelOnboardingStates_List' might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/OnboardingStates.json#L178
⚠️ PageableOperation Based on the response model schema, operation 'GetRecommendations_List' might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/Recommendations.json#L38
⚠️ PageableOperation Based on the response model schema, operation 'ProductSettings_List' might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/Settings.json#L38
⚠️ AllProxyResourcesShouldHaveDelete The resource SourceControl does not have a corresponding delete operation.
Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/SourceControls.json#L343
⚠️ PageableOperation Based on the response model schema, operation 'ThreatIntelligenceIndicatorMetrics_List' might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/ThreatIntelligence.json#L334
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'jobs' in:'WorkspaceManagerAssignmentJobs_Create'. Consider updating the operationId
Location: Microsoft.SecurityInsights/preview/2023-08-01-preview/WorkspaceManagerAssignments.json#L297
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 17, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking

azure-sdk-for-python-track2 - track2_azure-mgmt-securityinsight - Approved - 2.0.0b2
+	Model MSTIDataConnectorDataTypes no longer has parameter bing_safety_phishing_url
+	Model Repository no longer has parameter path_mapping
+	Operation SourceControlsOperations.delete has a new required parameter repository_access
+	Parameter branch of model Repository is now required
+	Parameter logic_app_resource_id of model PlaybookActionProperties is now required
+	Parameter url of model Repository is now required
️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from fe7d9ec. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh] npm notice
    cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.6.7 -> 10.0.0
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.0.0>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-securityinsight [View full logs]  [Release SDK Changes] Breaking Change Detected
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation EntitiesOperations.run_playbook
    info	[Changelog]   - Added operation group AlertRuleOperations
    info	[Changelog]   - Added operation group BillingStatisticsOperations
    info	[Changelog]   - Added operation group ContentPackageOperations
    info	[Changelog]   - Added operation group ContentPackagesOperations
    info	[Changelog]   - Added operation group ContentTemplateOperations
    info	[Changelog]   - Added operation group ContentTemplatesOperations
    info	[Changelog]   - Added operation group DataConnectorDefinitionsOperations
    info	[Changelog]   - Added operation group GetTriggeredAnalyticsRuleRunsOperations
    info	[Changelog]   - Added operation group HuntCommentsOperations
    info	[Changelog]   - Added operation group HuntRelationsOperations
    info	[Changelog]   - Added operation group HuntsOperations
    info	[Changelog]   - Added operation group ProductPackageOperations
    info	[Changelog]   - Added operation group ProductPackagesOperations
    info	[Changelog]   - Added operation group ProductTemplateOperations
    info	[Changelog]   - Added operation group ProductTemplatesOperations
    info	[Changelog]   - Added operation group TriggeredAnalyticsRuleRunOperations
    info	[Changelog]   - Added operation group WorkspaceManagerAssignmentJobsOperations
    info	[Changelog]   - Added operation group WorkspaceManagerAssignmentsOperations
    info	[Changelog]   - Added operation group WorkspaceManagerConfigurationsOperations
    info	[Changelog]   - Added operation group WorkspaceManagerGroupsOperations
    info	[Changelog]   - Added operation group WorkspaceManagerMembersOperations
    info	[Changelog]   - Model MTPDataConnector has a new parameter filtered_providers
    info	[Changelog]   - Model MTPDataConnectorDataTypes has a new parameter alerts
    info	[Changelog]   - Model MTPDataConnectorProperties has a new parameter filtered_providers
    info	[Changelog]   - Model SourceControl has a new parameter pull_request
    info	[Changelog]   - Model SourceControl has a new parameter repository_access
    info	[Changelog]   - Model SourceControl has a new parameter service_principal
    info	[Changelog]
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog]   - Model MSTIDataConnectorDataTypes no longer has parameter bing_safety_phishing_url
    info	[Changelog]   - Model Repository no longer has parameter path_mapping
    info	[Changelog]   - Operation SourceControlsOperations.delete has a new required parameter repository_access
    info	[Changelog]   - Parameter branch of model Repository is now required
    info	[Changelog]   - Parameter logic_app_resource_id of model PlaybookActionProperties is now required
    info	[Changelog]   - Parameter url of model Repository is now required
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from fe7d9ec. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-securityinsight [View full logs]  [Release SDK Changes] Breaking Change Detected
    Only show 120 items here, please refer to log for details.
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter kind of interface Entity is changed from EntityKind to EntityKindEnum
    info	[Changelog]   - Type of parameter additionalData of interface EntityCommonProperties is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface EntityEdges is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter kind of interface EntityQueriesListOptionalParams is changed from Enum13 to Enum20
    info	[Changelog]   - Type of parameter entityKind of interface ExpansionResultAggregation is changed from EntityKind to EntityKindEnum
    info	[Changelog]   - Type of parameter additionalData of interface FileEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface FileHashEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface HostEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface HuntingBookmark is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter entityKind of interface IncidentEntitiesResultsMetadata is changed from EntityKind to EntityKindEnum
    info	[Changelog]   - Type of parameter additionalData of interface IoTDeviceEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface IpEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface MailboxEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface MailClusterEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface MailMessageEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface MalwareEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter kind of interface MetadataModel is changed from Kind to string
    info	[Changelog]   - Type of parameter kind of interface MetadataPatch is changed from Kind to string
    info	[Changelog]   - Type of parameter additionalData of interface NicEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface ProcessEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface RegistryKeyEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface RegistryValueEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface SecurityAlert is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface SecurityGroupEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface SubmissionMailEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface ThreatIntelligenceIndicatorModel is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter kind of interface ThreatIntelligenceInformation is changed from ThreatIntelligenceResourceKindEnum to ThreatIntelligenceResourceInnerKind
    info	[Changelog]   - Type of parameter sortOrder of interface ThreatIntelligenceSortingCriteria is changed from ThreatIntelligenceSortingCriteriaEnum to ThreatIntelligenceSortingOrder
    info	[Changelog]   - Type of parameter additionalData of interface UrlEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter webhookSecretUpdateTime of interface Webhook is changed from string to Date
    info	[Changelog]   - Removed Enum KnownEntityKind
    info	[Changelog]   - Removed Enum KnownEnum13
    info	[Changelog]   - Removed Enum KnownThreatIntelligenceResourceKindEnum
    info	[Changelog]   - Removed Enum KnownThreatIntelligenceSortingCriteriaEnum
    info	[Changelog]   - Enum KnownRepoType no longer has value DevOps
️⚠️ azure-sdk-for-java warning [Detail]
️❌ azure-resource-manager-schemas failed [Detail]
  • Code Generator Failed [Logs]Release - Generate from fe7d9ec. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh]  ERR! code EBADENGINE
    cmderr	[initScript.sh]  Unsupported engine
    cmderr	[initScript.sh] npm ERR! engine Not compatible with your version of node/npm: [email protected]
    cmderr	[initScript.sh] npm ERR! notsup Not compatible with your version of node/npm: [email protected]
    cmderr	[initScript.sh] npm ERR! notsup Required: {"node":"^18.17.0 || >=20.5.0"}
    cmderr	[initScript.sh] npm ERR! notsup Actual:   {"npm":"8.19.4","node":"v16.20.2"}
    cmderr	[initScript.sh]  A complete log of this run can be found in:
    cmderr	[initScript.sh] npm ERR!     /home/cloudtest/.npm/_logs/2023-09-07T16_52_37_659Z-debug-0.log
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(7,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(12,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(15,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the `lib` compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(64,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the `lib` compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(81,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(82,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the `lib` compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(117,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the `lib` compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(118,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the `lib` compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(169,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i @types/node` and then add `node` to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1076:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    cmderr	[generateScript.sh]
    cmderr	[generateScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.0.0
    cmderr	[generateScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.0.0>
    cmderr	[generateScript.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[generateScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Skip package processing as generation is failed
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs]Release - Generate from fe7d9ec. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ⚠️Az.securityinsights.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.securityinsights.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 17, 2023

Generated ApiView

Language Package Name ApiView Link
Java azure-resourcemanager-securityinsights https://apiview.dev/Assemblies/Review/3a2424076bde4deb9cbe4b9c2aa1d241
JavaScript @azure/arm-securityinsight https://apiview.dev/Assemblies/Review/c30f61b71d024aa0a324d9a761a54d0e
.Net Azure.ResourceManager.SecurityInsights There is no API change compared with the previous version

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-MissingBaseCommit new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager labels Aug 17, 2023
@openapi-workflow-bot
Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

@openapi-workflow-bot
Copy link

Hi @xuhumsft! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.

@xuhumsft xuhumsft removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Aug 18, 2023
@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 18, 2023
@rkmanda rkmanda removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 21, 2023
@mikekistler
Copy link
Member

Breaking changes previously reviewed and approved in #23121.

@mikekistler mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 22, 2023
@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 22, 2023
@sjanamma sjanamma added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 31, 2023
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 31, 2023
@sjanamma
Copy link

Copy link

@sjanamma sjanamma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for merging

@mentat9
Copy link
Member

mentat9 commented Sep 5, 2023

@xuhumsft - Your PR needs to pass checks and address the CI-BreakingChange-Python-Track2 label before merge. Add the MergeRequested label back after addressing those items. If you get stuck, you can ask for help in the API Spec Review Teams channel: https://teams.microsoft.com/l/channel/19%3a0351f5f9404446e4b4fd4eaf2c27448d%40thread.skype/API%2520Spec%2520Review?groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47. Pinned comments on that channel identify help contacts for various SDKs.

@raych1
Copy link
Member

raych1 commented Sep 6, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@openapi-pipeline-app
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-JavaScript CI-MissingBaseCommit new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants