Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hub Generated] Review request for Microsoft.ResourceHealth to add version preview/2023-07-01-preview #25447

Conversation

mkatkam
Copy link
Contributor

@mkatkam mkatkam commented Aug 22, 2023

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 22, 2023

Next Steps to Merge

⚠️ This is an experimental comment. It may not always be up-to-date. ⚠️

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 22, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️Breaking Change(Cross-Version): 3 Warnings warning [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
ResourceHealth.json 2023-07-01-preview(6eee1a5) 2022-10-01(main)
ResourceHealth.json 2023-07-01-preview(6eee1a5) 2022-10-01-preview(main)

The following breaking changes are detected by comparison with the latest preview version:

Rule Message
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.ResourceHealth/preview/2023-07-01-preview/ResourceHealth.json#L2139:11
Old: Microsoft.ResourceHealth/preview/2022-10-01-preview/ResourceHealth.json#L1924:11
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.ResourceHealth/preview/2023-07-01-preview/ResourceHealth.json#L1085:13
Old: Microsoft.ResourceHealth/preview/2022-10-01-preview/ResourceHealth.json#L938:13
⚠️ 1032 - DifferentAllOf The new version has a different 'allOf' property than the previous one.
New: Microsoft.ResourceHealth/preview/2023-07-01-preview/ResourceHealth.json#L2149:5
Old: Microsoft.ResourceHealth/preview/2022-10-01-preview/ResourceHealth.json#L1934:5
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.4) new version base version
package-preview-2023-07 package-preview-2023-07(6eee1a5) default(main)

The following errors/warnings exist before current PR submission:

Rule Message
TopLevelResourcesListBySubscription The top-level resource 'MetadataEntity' does not have list by subscription operation, please add it.
Location: Microsoft.ResourceHealth/preview/2023-07-01-preview/ResourceHealth.json#L1615
TopLevelResourcesListBySubscription The top-level resource 'emergingIssuesGetResult' does not have list by subscription operation, please add it.
Location: Microsoft.ResourceHealth/preview/2023-07-01-preview/ResourceHealth.json#L2149
⚠️ PageableOperation Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension.
Location: Microsoft.ResourceHealth/preview/2023-07-01-preview/ResourceHealth.json#L128
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetMetadata
Location: Microsoft.ResourceHealth/preview/2023-07-01-preview/ResourceHealth.json#L326
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ImpactedResourcesGet
Location: Microsoft.ResourceHealth/preview/2023-07-01-preview/ResourceHealth.json#L494
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'listsecurityadvisoryimpactedresources' in:'SecurityAdvisoryImpactedResources_ListBySubscriptionIdAndEventId'. Consider updating the operationId
Location: Microsoft.ResourceHealth/preview/2023-07-01-preview/ResourceHealth.json#L506
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'listsecurityadvisoryimpactedresources' in:'SecurityAdvisoryImpactedResources_ListByTenantIdAndEventId'. Consider updating the operationId
Location: Microsoft.ResourceHealth/preview/2023-07-01-preview/ResourceHealth.json#L551
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'fetcheventdetails' in:'Event_fetchDetailsBySubscriptionIdAndTrackingId'. Consider updating the operationId
Location: Microsoft.ResourceHealth/preview/2023-07-01-preview/ResourceHealth.json#L683
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: ListEventsByTenantId
Location: Microsoft.ResourceHealth/preview/2023-07-01-preview/ResourceHealth.json#L752
⚠️ PostOperationIdContainsUrlVerb OperationId should contain the verb: 'fetcheventdetails' in:'Event_fetchDetailsByTenantIdAndTrackingId'. Consider updating the operationId
Location: Microsoft.ResourceHealth/preview/2023-07-01-preview/ResourceHealth.json#L806
⚠️ UniqueXmsExample Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: GetEmergingIssues
Location: Microsoft.ResourceHealth/preview/2023-07-01-preview/ResourceHealth.json#L1096
️❌Avocado: 1 Errors, 0 Warnings failed [Detail]
Rule Message
MISSING_APIS_IN_DEFAULT_TAG The default tag should contain all APIs. The API path /subscriptions/{}/providers/Microsoft.ResourceHealth/impactedResources is not in the default tag. Please make sure the missing API swaggers are in the default tag.
readme: specification/resourcehealth/resource-manager/readme.md
json: Microsoft.ResourceHealth/preview/2018-08-01/ResourceHealth.json
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 22, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️❌SDK Breaking Change Tracking failed [Detail]

Breaking Changes Tracking


azure-sdk-for-js - @azure/arm-resourcehealth - Approved - 5.0.0-beta.1
+	Class MicrosoftResourceHealth has a new signature

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 31404aa. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/resourcehealth/armresourcehealth [View full logs]  [Release SDK Changes]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New enum type `EventSubTypeValues` with values `EventSubTypeValuesRetirement`
    info	[Changelog] - New field `MaintenanceEndTime`, `MaintenanceStartTime`, `ResourceGroup`, `ResourceName`, `Status` in struct `EventImpactedResourceProperties`
    info	[Changelog] - New field `ArgQuery`, `EventSubType`, `MaintenanceID`, `MaintenanceType` in struct `EventProperties`
    info	[Changelog]
    info	[Changelog] Total 0 breaking change(s), 4 additive change(s).
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 31404aa. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-resourcehealth [View full logs]  [Release SDK Changes] Breaking Change Detected
    info	[Changelog] **Features**
    info	[Changelog]
    info	[Changelog]   - Added Type Alias EventSubTypeValues
    info	[Changelog]   - Interface Event_2 has a new optional parameter argQuery
    info	[Changelog]   - Interface Event_2 has a new optional parameter eventSubType
    info	[Changelog]   - Interface Event_2 has a new optional parameter maintenanceId
    info	[Changelog]   - Interface Event_2 has a new optional parameter maintenanceType
    info	[Changelog]   - Interface EventImpactedResource has a new optional parameter maintenanceEndTime
    info	[Changelog]   - Interface EventImpactedResource has a new optional parameter maintenanceStartTime
    info	[Changelog]   - Interface EventImpactedResource has a new optional parameter resourceGroup
    info	[Changelog]   - Interface EventImpactedResource has a new optional parameter resourceName
    info	[Changelog]   - Interface EventImpactedResource has a new optional parameter status
    info	[Changelog]   - Added Enum KnownEventSubTypeValues
    info	[Changelog]
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Class MicrosoftResourceHealth has a new signature
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 31404aa. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.6.7 -> 10.0.0
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.0.0>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-resourcehealth [View full logs]  [Release SDK Changes]
    info	[Changelog]
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 31404aa. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-resourcehealth [View full logs]  [Release SDK Changes]
️❌ azure-sdk-for-net failed [Detail]
  • Code Generator Failed [Logs]Release - Generate from 31404aa. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	autorest --version=2.0.4421 --csharp --reflect-api-versions --license-header=MICROSOFT_MIT_NO_VERSION [email protected]/[email protected] --csharp-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-net/sdk ../azure-rest-api-specs/specification/resourcehealth/resource-manager/readme.md
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmderr	[Autorest] realpath(): Permission denied
    cmdout	[Autorest] WARNING (PostOperationIdContainsUrlVerb/R2066/SDKViolation): OperationId should contain the verb: 'listsecurityadvisoryimpactedresources' in:'SecurityAdvisoryImpactedResources_ListBySubscriptionIdAndEventId'. Consider updating the operationId
    cmdout	[Autorest] WARNING (PostOperationIdContainsUrlVerb/R2066/SDKViolation): OperationId should contain the verb: 'listsecurityadvisoryimpactedresources' in:'SecurityAdvisoryImpactedResources_ListByTenantIdAndEventId'. Consider updating the operationId
    cmdout	[Autorest] WARNING (PostOperationIdContainsUrlVerb/R2066/SDKViolation): OperationId should contain the verb: 'fetcheventdetails' in:'Event_fetchDetailsBySubscriptionIdAndTrackingId'. Consider updating the operationId
    cmdout	[Autorest] WARNING (PostOperationIdContainsUrlVerb/R2066/SDKViolation): OperationId should contain the verb: 'fetcheventdetails' in:'Event_fetchDetailsByTenantIdAndTrackingId'. Consider updating the operationId
    cmdout	[Autorest] WARNING (PageableOperation/R2029/SDKViolation): Based on the response model schema, operation 'Operations_List' might be pageable. Consider adding the x-ms-pageable extension.
    cmderr	[Autorest] ERROR (BodyTopLevelProperties/R3006/ARMViolation): Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'MetadataEntity' has extra properties ['systemData'].
    cmderr	[Autorest]     - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/preview/2023-07-01-preview/ResourceHealth.json:1618:6 ($.definitions.MetadataEntity.properties)
    cmderr	[Autorest] ERROR (BodyTopLevelProperties/R3006/ARMViolation): Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'eventImpactedResource' has extra properties ['systemData'].
    cmderr	[Autorest]     - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/preview/2023-07-01-preview/ResourceHealth.json:2053:6 ($.definitions.eventImpactedResource.properties)
    cmderr	[Autorest] ERROR (BodyTopLevelProperties/R3006/ARMViolation): Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'event' has extra properties ['systemData'].
    cmderr	[Autorest]     - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/preview/2023-07-01-preview/ResourceHealth.json:1129:6 ($.definitions.event.properties)
    cmderr	[Autorest] ERROR (BodyTopLevelProperties/R3006/ARMViolation): Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'emergingIssuesGetResult' has extra properties ['systemData'].
    cmderr	[Autorest]     - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/preview/2023-07-01-preview/ResourceHealth.json:2152:6 ($.definitions.emergingIssuesGetResult.properties)
    cmderr	[Autorest] ERROR (BodyTopLevelProperties/R3006/ARMViolation): Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'impactedResourceStatus' has extra properties ['systemData'].
    cmderr	[Autorest]     - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/resourcehealth/resource-manager/Microsoft.ResourceHealth/preview/2023-07-01-preview/ResourceHealth.json:1543:6 ($.definitions.impactedResourceStatus.properties)
    cmdout	[Autorest] WARNING (OperationIdNounConflictingModelNames/R2063/SDKViolation): OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'EventsModel'. Consider using the plural form of 'Events' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    cmderr	[Autorest] ERROR (BodyTopLevelProperties/R3006/ARMViolation): Top level properties should be one of name, type, id, location, properties, tags, plan, sku, etag, managedBy, identity, zones. Model definition 'AzureEntityResource' has extra properties ['systemData'].
    cmderr	[Autorest]     - file:///mnt/vss/_work/1/s/azure-rest-api-specs/specification/common-types/resource-management/v3/types.json:43:6 ($.definitions.AzureEntityResource.properties)
    cmdout	[Autorest] WARNING (OperationIdNounConflictingModelNames/R2063/SDKViolation): OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'EventModel'. Consider using the plural form of 'Event' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    cmdout	[Autorest] WARNING (OperationIdNounConflictingModelNames/R2063/SDKViolation): OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'EventModel'. Consider using the plural form of 'Event' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    cmdout	[Autorest] WARNING (OperationIdNounConflictingModelNames/R2063/SDKViolation): OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'EventsModel'. Consider using the plural form of 'Events' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    cmdout	[Autorest] WARNING (OperationIdNounConflictingModelNames/R2063/SDKViolation): OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'EventModel'. Consider using the plural form of 'Event' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    cmdout	[Autorest] WARNING (OperationIdNounConflictingModelNames/R2063/SDKViolation): OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'EventModel'. Consider using the plural form of 'Event' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    cmdout	[Autorest] WARNING (OperationIdNounConflictingModelNames/R2063/SDKViolation): OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'EventsModel'. Consider using the plural form of 'Events' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
    cmdout	[Autorest] WARNING (AvoidNestedProperties/R2001/SDKViolation): Consider using x-ms-client-flatten to provide a better end user experience
    cmdout	[Autorest] WARNING (EnumInsteadOfBoolean/R3018/ARMViolation): Booleans are not descriptive and make them hard to use. Consider using string enums with allowed set of values defined. Property: published
    cmdout	[Autorest] WARNING (DescriptionAndTitleMissing/R4000/SDKViolation): 'identity' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    cmdout	[Autorest] WARNING (DescriptionAndTitleMissing/R4000/SDKViolation): 'sku' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    cmdout	[Autorest] WARNING (DescriptionAndTitleMissing/R4000/SDKViolation): 'plan' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    cmdout	[Autorest] WARNING (DescriptionAndTitleMissing/R4000/SDKViolation): 'tier' model/property lacks 'description' and 'title' property. Consider adding a 'description'/'title' element. Accurate description/title is essential for maintaining reference documentation.
    error	Script return with result [failed] code [6] signal [null] cwd [azure-sdk-for-net]: autorest
    warn	Skip package processing as generation is failed
️❌ azure-resource-manager-schemas failed [Detail]
  • Code Generator Failed [Logs]Release - Generate from 31404aa. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh]  ERR! code EBADENGINE
    cmderr	[initScript.sh]  Unsupported engine
    cmderr	[initScript.sh] npm ERR! engine Not compatible with your version of node/npm: [email protected]
    cmderr	[initScript.sh] npm ERR! notsup Not compatible with your version of node/npm: [email protected]
    cmderr	[initScript.sh] npm ERR! notsup Required: {"node":"^18.17.0 || >=20.5.0"}
    cmderr	[initScript.sh] npm ERR! notsup Actual:   {"npm":"8.19.4","node":"v16.20.2"}
    cmderr	[initScript.sh] ERR! A complete log of this run can be found in:
    cmderr	[initScript.sh] npm ERR!     /home/cloudtest/.npm/_logs/2023-09-08T03_14_25_422Z-debug-0.log
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(7,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(12,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(15,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the `lib` compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(64,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the `lib` compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(81,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(82,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the `lib` compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(117,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the `lib` compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(118,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the `lib` compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(169,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i @types/node` and then add `node` to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1252:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1076:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:911:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    cmderr	[generateScript.sh]  notice
    cmderr	[generateScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.0.0
    cmderr	[generateScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.0.0>
    cmderr	[generateScript.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[generateScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Skip package processing as generation is failed
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs]Release - Generate from 31404aa. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ️✔️Az.resourcehealth.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.resourcehealth.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 22, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/resourcehealth/armresourcehealth https://apiview.dev/Assemblies/Review/1409591164444cf199bfdb11c60d374c
Java azure-resourcemanager-resourcehealth https://apiview.dev/Assemblies/Review/ce8afbe458a5449ca98481224a4da9c0
JavaScript @azure/arm-resourcehealth https://apiview.dev/Assemblies/Review/97544fbfed624fe5adfdc242a82f92b6

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 22, 2023

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

a) Adding maintenance related fields for events
b) Adding maintenance related fields for impacted resources
c) Adding subeventType for events
@mkatkam mkatkam force-pushed the mkatkam-resourcehealth-Microsoft.ResourceHealth-2023-07-01-preview-2 branch from 715d500 to 446c8a3 Compare August 22, 2023 22:03
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 22, 2023

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

…ples, and added more info to the description of maintenance related fields for impacted resources
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 22, 2023

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 22, 2023

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

@abhishek-corp abhishek-corp self-requested a review August 23, 2023 23:02
@abhishek-corp abhishek-corp marked this pull request as ready for review August 23, 2023 23:02
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 23, 2023
@sjanamma sjanamma added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 1, 2023
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 1, 2023
@kazrael2119
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kazrael2119 kazrael2119 added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 4, 2023
@kazrael2119
Copy link
Contributor

add "DoNotMerge" label because go sdk generation failed

@Alancere
Copy link
Member

Alancere commented Sep 5, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Alancere
Copy link
Member

Alancere commented Sep 6, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@mkatkam
Copy link
Contributor Author

mkatkam commented Sep 7, 2023

/pr RequestMerge

@mentat9 mentat9 merged commit 31404aa into main Sep 8, 2023
26 of 30 checks passed
@mentat9 mentat9 deleted the mkatkam-resourcehealth-Microsoft.ResourceHealth-2023-07-01-preview-2 branch September 8, 2023 03:10
@openapi-pipeline-app
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

@openapi-pipeline-app openapi-pipeline-app bot added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Sep 8, 2023
jnlycklama pushed a commit that referenced this pull request Nov 8, 2023
…rsion preview/2023-07-01-preview (#25447)

* Adds base for updating Microsoft.ResourceHealth from version stable/2022-10-01 to version 2023-07-01-preview

* Updates readme

* Updates API version in new specs and examples

* Adding 2023-07-01-preview
a) Adding maintenance related fields for events
b) Adding maintenance related fields for impacted resources
c) Adding subeventType for events

* Added values to maintenance related fields for impacted resource examples, and added more info to the description of maintenance related fields for impacted resources

* Corrected the values of resourceName and resourceGroup of impacted resources in the examples

* Changing maintenanceStatus field to just status

* Used prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-SdkBreakingChange-JavaScript ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-JavaScript DoNotMerge <valid label in PR review process> use to hold merge after approval new-api-version resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants