Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional OData query parameters + mark some properties as Expandable #25958

Conversation

oformaniuk
Copy link
Contributor

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • Updates to the contract to include more OData features.

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 25, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 25, 2023

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
compared swaggers (via Oad v0.10.4)] new version base version
types.json 2.0(eaa5fb3) 2.0(main)
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
compared swaggers (via Oad v0.10.4)] new version base version
ContentPackages.json 2023-10-01-preview(eaa5fb3) 2023-09-01-preview(main)
ContentProductPackages.json 2023-10-01-preview(eaa5fb3) 2023-09-01-preview(main)
ContentProductTemplates.json 2023-10-01-preview(eaa5fb3) 2023-09-01-preview(main)
ContentTemplates.json 2023-10-01-preview(eaa5fb3) 2023-09-01-preview(main)
ContentCommonTypes.json 2023-10-01-preview(eaa5fb3) 2023-09-01-preview(main)
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-preview-2023-10 package-preview-2023-10(eaa5fb3) package-preview-2023-10(release-release-Sentinel-securityinsights-Microsoft.SecurityInsights-2023-10-01-preview)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentPackages.json#L51
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentPackages.json#L54
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentPackages.json#L57
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentPackages.json#L117
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentPackages.json#L120
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentPackages.json#L123
⚠️ PutInOperationName 'PUT' operation 'ContentPackage_Install' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentPackages.json#L157
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentPackages.json#L160
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentPackages.json#L163
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentPackages.json#L166
⚠️ DeleteInOperationName 'DELETE' operation 'ContentPackage_Uninstall' should use method name 'Delete'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentPackages.json#L209
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentPackages.json#L212
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentPackages.json#L215
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentPackages.json#L218
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentProductPackages.json#L51
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentProductPackages.json#L54
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentProductPackages.json#L57
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentProductPackages.json#L108
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentProductPackages.json#L111
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentProductPackages.json#L114
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentProductTemplates.json#L51
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentProductTemplates.json#L54
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentProductTemplates.json#L57
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentProductTemplates.json#L117
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentProductTemplates.json#L120
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentProductTemplates.json#L123
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentTemplates.json#L51
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentTemplates.json#L54
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentTemplates.json#L57
⚠️ PutInOperationName 'PUT' operation 'ContentTemplate_Install' should use method name 'Create'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.SecurityInsights/preview/2023-10-01-preview/ContentTemplates.json#L117
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 25, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️⚠️SDK Breaking Change Tracking warning [Detail]

Breaking Changes Tracking

⚠️azure-sdk-for-js - @azure/arm-securityinsight - Approved - 1.0.0-beta.7
+	Enum KnownRepoType no longer has value DevOps
+	Interface MstiDataConnectorDataTypes no longer has parameter bingSafetyPhishingURL
+	Interface Repository no longer has parameter pathMapping
+	Operation Incidents.createTeam has a new signature
+	Operation SourceControls.delete has a new signature
+	Parameter branch of interface Repository is now required
+	Parameter logicAppResourceId of interface PlaybookActionProperties is now required
+	Parameter url of interface Repository is now required
+	Removed Enum KnownEntityKind
+	Removed Enum KnownEnum13
+	Removed Enum KnownThreatIntelligenceResourceKindEnum
+	Removed Enum KnownThreatIntelligenceSortingCriteriaEnum
+	Type of parameter additionalData of interface AccountEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface AzureResourceEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface CloudApplicationEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface DnsEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface EntityCommonProperties is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface EntityEdges is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface FileEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface FileHashEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface HostEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface HuntingBookmark is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface IoTDeviceEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface IpEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface MailClusterEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface MailMessageEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface MailboxEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface MalwareEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface NicEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface ProcessEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface RegistryKeyEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface RegistryValueEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface SecurityAlert is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface SecurityGroupEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface SubmissionMailEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface ThreatIntelligenceIndicatorModel is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter additionalData of interface UrlEntity is changed from {
        [propertyName: string]: Record;
    } to {
        [propertyName: string]: any;
    }
+	Type of parameter entityKind of interface ExpansionResultAggregation is changed from EntityKind to EntityKindEnum
+	Type of parameter entityKind of interface IncidentEntitiesResultsMetadata is changed from EntityKind to EntityKindEnum
+	Type of parameter kind of interface Entity is changed from EntityKind to EntityKindEnum
+	Type of parameter kind of interface EntityQueriesListOptionalParams is changed from Enum13 to Enum20
+	Type of parameter kind of interface MetadataModel is changed from Kind to string
+	Type of parameter kind of interface MetadataPatch is changed from Kind to string
+	Type of parameter kind of interface ThreatIntelligenceInformation is changed from ThreatIntelligenceResourceKindEnum to ThreatIntelligenceResourceInnerKind
+	Type of parameter sortOrder of interface ThreatIntelligenceSortingCriteria is changed from ThreatIntelligenceSortingCriteriaEnum to ThreatIntelligenceSortingOrder
+	Type of parameter webhookSecretUpdateTime of interface Webhook is changed from string to Date
⚠️azure-sdk-for-python-track2 - track2_azure-mgmt-securityinsight - Approved - 2.0.0b2
+	Model MSTIDataConnectorDataTypes no longer has parameter bing_safety_phishing_url
+	Model Repository no longer has parameter path_mapping
+	Operation SourceControlsOperations.delete has a new required parameter repository_access
+	Parameter branch of model Repository is now required
+	Parameter logic_app_resource_id of model PlaybookActionProperties is now required
+	Parameter url of model Repository is now required

⚠️azure-sdk-for-go - sdk/resourcemanager/appplatform/armappplatform - Approved - 2.0.0-beta.2
+	Field `Instances`, `ResourceRequests` of struct `DevToolPortalProperties` has been removed
⚠️azure-sdk-for-go - sdk/resourcemanager/commerce/armcommerce - Approved - 0.3.0
+	Field `UsageAggregationListResult` of struct `UsageAggregatesClientListResponse` has been removed
+	Struct `InfoField` has been removed



⚠️azure-sdk-for-go - sdk/resourcemanager/datamigration/armdatamigration - Approved - 2.0.0-beta.1
+	Field `ServiceOperationList` of struct `OperationsClientListResponse` has been removed
+	Type of `CheckOCIDriverTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `CommandProperties.CommandType` has been changed from `*string` to `*CommandType`
+	Type of `ConnectToMongoDbTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `ConnectToSourceMySQLTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `ConnectToSourceOracleSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `ConnectToSourcePostgreSQLSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `ConnectToSourceSQLServerSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `ConnectToSourceSQLServerTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `ConnectToTargetAzureDbForMySQLTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `ConnectToTargetAzureDbForPostgreSQLSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `ConnectToTargetOracleAzureDbForPostgreSQLSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `ConnectToTargetSQLDbSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `ConnectToTargetSQLDbTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `ConnectToTargetSQLMISyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `ConnectToTargetSQLMITaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `GetTdeCertificatesSQLTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `GetUserTablesMySQLTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `GetUserTablesOracleTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `GetUserTablesPostgreSQLTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `GetUserTablesSQLSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `GetUserTablesSQLTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `InstallOCIDriverTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `MigrateMISyncCompleteCommandProperties.CommandType` has been changed from `*string` to `*CommandType`
+	Type of `MigrateMongoDbTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `MigrateMySQLAzureDbForMySQLOfflineTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `MigrateMySQLAzureDbForMySQLSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `MigrateOracleAzureDbForPostgreSQLSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `MigratePostgreSQLAzureDbForPostgreSQLSyncDatabaseInput.MigrationSetting` has been changed from `map[string]*string` to `map[string]any`
+	Type of `MigratePostgreSQLAzureDbForPostgreSQLSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `MigrateSQLServerSQLDbSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `MigrateSQLServerSQLDbTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `MigrateSQLServerSQLMISyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `MigrateSQLServerSQLMITaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `MigrateSchemaSQLServerSQLDbTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `MigrateSsisTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `MigrateSyncCompleteCommandProperties.CommandType` has been changed from `*string` to `*CommandType`
+	Type of `MongoDbCancelCommand.CommandType` has been changed from `*string` to `*CommandType`
+	Type of `MongoDbFinishCommand.CommandType` has been changed from `*string` to `*CommandType`
+	Type of `MongoDbRestartCommand.CommandType` has been changed from `*string` to `*CommandType`
+	Type of `ProjectTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `UploadOCIDriverTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `ValidateMigrationInputSQLServerSQLDbSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `ValidateMigrationInputSQLServerSQLMISyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `ValidateMigrationInputSQLServerSQLMITaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `ValidateMongoDbTaskProperties.TaskType` has been changed from `*string` to `*TaskType`
+	Type of `ValidateOracleAzureDbForPostgreSQLSyncTaskProperties.TaskType` has been changed from `*string` to `*TaskType`








⚠️azure-sdk-for-go - sdk/resourcemanager/powerplatform/armpowerplatform - Approved - 0.3.0
+	Operation `*PrivateEndpointConnectionsClient.BeginCreateOrUpdate` has been changed to non-LRO, use `*PrivateEndpointConnectionsClient.CreateOrUpdate` instead.
+	Operation `*PrivateEndpointConnectionsClient.BeginDelete` has been changed to non-LRO, use `*PrivateEndpointConnectionsClient.Delete` instead.



⚠️azure-sdk-for-go - sdk/resourcemanager/securityinsights/armsecurityinsights - Approved - 2.0.0-beta.4
+	Enum `EntityKind` has been removed
+	Enum `Enum13` has been removed
+	Enum `Enum15` has been removed
+	Enum `ThreatIntelligenceResourceKindEnum` has been removed
+	Enum `ThreatIntelligenceSortingCriteriaEnum` has been removed
+	Field `BingSafetyPhishingURL` of struct `MSTIDataConnectorDataTypes` has been removed
+	Field `PathMapping` of struct `Repository` has been removed
+	Function `*IncidentsClient.CreateTeam` parameter(s) have been changed from `(context.Context, string, string, string, TeamProperties, *IncidentsClientCreateTeamOptions)` to `(context.Context, string, string, string, TeamInformation, *IncidentsClientCreateTeamOptions)`
+	Function `*SourceControlsClient.Delete` parameter(s) have been changed from `(context.Context, string, string, string, *SourceControlsClientDeleteOptions)` to `(context.Context, string, string, string, Paths1J3Lu7WSubscriptionsSubscriptionidResourcegroupsResourcegroupnameProvidersMicrosoftOperationalinsightsWorkspacesWorkspacenameProvidersMicrosoftSecurityinsightsSourcecontrolsSourcecontrolidDeletePostRequestbodyContentApplicationJSONSchema, *SourceControlsClientDeleteOptions)`
+	Struct `ContentPathMap` has been removed
+	Struct `MSTIDataConnectorDataTypesBingSafetyPhishingURL` has been removed
+	Struct `TeamProperties` has been removed
+	Type of `AccountEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `AzureResourceEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `CloudApplicationEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `DNSEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `Entity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `EntityQueriesClientListOptions.Kind` has been changed from `*Enum13` to `*Enum20`
+	Type of `EntityQueryTemplatesClientListOptions.Kind` has been changed from `*Enum15` to `*Enum22`
+	Type of `ExpansionResultAggregation.EntityKind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `FileEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `FileHashEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `HostEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `HuntingBookmark.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `IPEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `IncidentEntitiesResultsMetadata.EntityKind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `IoTDeviceEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `MailClusterEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `MailMessageEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `MailboxEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `MalwareEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `MetadataProperties.Kind` has been changed from `*Kind` to `*string`
+	Type of `MetadataPropertiesPatch.Kind` has been changed from `*Kind` to `*string`
+	Type of `NicEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `ProcessEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `RegistryKeyEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `RegistryValueEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `SecurityAlert.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `SecurityGroupEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `SubmissionMailEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `ThreatIntelligenceIndicatorModel.Kind` has been changed from `*ThreatIntelligenceResourceKindEnum` to `*ThreatIntelligenceResourceInnerKind`
+	Type of `ThreatIntelligenceInformation.Kind` has been changed from `*ThreatIntelligenceResourceKindEnum` to `*ThreatIntelligenceResourceInnerKind`
+	Type of `ThreatIntelligenceSortingCriteria.SortOrder` has been changed from `*ThreatIntelligenceSortingCriteriaEnum` to `*ThreatIntelligenceSortingOrder`
+	Type of `URLEntity.Kind` has been changed from `*EntityKind` to `*EntityKindEnum`
+	Type of `Webhook.WebhookSecretUpdateTime` has been changed from `*string` to `*time.Time`
+	`RepoTypeDevOps` from enum `RepoType` has been removed





⚠️azure-sdk-for-python-track2 - track2_azure-mgmt-appplatform - Approved - 8.0.0
+	Model DevToolPortalProperties no longer has parameter instances
+	Model DevToolPortalProperties no longer has parameter resource_requests













️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 881296db70f8817ec981b8252a66b49461f4df87. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  • ️✔️Azure.ResourceManager.SecurityInsights [View full logs]  [Preview SDK Changes]
    info	[Changelog]
️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs] Generate from 881296db70f8817ec981b8252a66b49461f4df87. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.1
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.1>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-securityinsight [View full logs]  [Preview SDK Changes] Breaking Change Detected
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation EntitiesOperations.run_playbook
    info	[Changelog]   - Added operation group AlertRuleOperations
    info	[Changelog]   - Added operation group BillingStatisticsOperations
    info	[Changelog]   - Added operation group ContentPackageOperations
    info	[Changelog]   - Added operation group ContentPackagesOperations
    info	[Changelog]   - Added operation group ContentTemplateOperations
    info	[Changelog]   - Added operation group ContentTemplatesOperations
    info	[Changelog]   - Added operation group DataConnectorDefinitionsOperations
    info	[Changelog]   - Added operation group GetTriggeredAnalyticsRuleRunsOperations
    info	[Changelog]   - Added operation group HuntCommentsOperations
    info	[Changelog]   - Added operation group HuntRelationsOperations
    info	[Changelog]   - Added operation group HuntsOperations
    info	[Changelog]   - Added operation group ProductPackageOperations
    info	[Changelog]   - Added operation group ProductPackagesOperations
    info	[Changelog]   - Added operation group ProductTemplateOperations
    info	[Changelog]   - Added operation group ProductTemplatesOperations
    info	[Changelog]   - Added operation group TriggeredAnalyticsRuleRunOperations
    info	[Changelog]   - Added operation group WorkspaceManagerAssignmentJobsOperations
    info	[Changelog]   - Added operation group WorkspaceManagerAssignmentsOperations
    info	[Changelog]   - Added operation group WorkspaceManagerConfigurationsOperations
    info	[Changelog]   - Added operation group WorkspaceManagerGroupsOperations
    info	[Changelog]   - Added operation group WorkspaceManagerMembersOperations
    info	[Changelog]   - Model MTPDataConnector has a new parameter filtered_providers
    info	[Changelog]   - Model MTPDataConnectorDataTypes has a new parameter alerts
    info	[Changelog]   - Model MTPDataConnectorProperties has a new parameter filtered_providers
    info	[Changelog]   - Model SourceControl has a new parameter pull_request
    info	[Changelog]   - Model SourceControl has a new parameter repository_access
    info	[Changelog]   - Model SourceControl has a new parameter service_principal
    info	[Changelog]
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog]   - Model MSTIDataConnectorDataTypes no longer has parameter bing_safety_phishing_url
    info	[Changelog]   - Model Repository no longer has parameter path_mapping
    info	[Changelog]   - Operation SourceControlsOperations.delete has a new required parameter repository_access
    info	[Changelog]   - Parameter branch of model Repository is now required
    info	[Changelog]   - Parameter logic_app_resource_id of model PlaybookActionProperties is now required
    info	[Changelog]   - Parameter url of model Repository is now required
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs] Generate from 881296db70f8817ec981b8252a66b49461f4df87. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-securityinsight [View full logs]  [Preview SDK Changes] Breaking Change Detected
    Only show 120 items here, please refer to log for details.
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter kind of interface Entity is changed from EntityKind to EntityKindEnum
    info	[Changelog]   - Type of parameter additionalData of interface EntityCommonProperties is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface EntityEdges is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter kind of interface EntityQueriesListOptionalParams is changed from Enum13 to Enum20
    info	[Changelog]   - Type of parameter entityKind of interface ExpansionResultAggregation is changed from EntityKind to EntityKindEnum
    info	[Changelog]   - Type of parameter additionalData of interface FileEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface FileHashEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface HostEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface HuntingBookmark is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter entityKind of interface IncidentEntitiesResultsMetadata is changed from EntityKind to EntityKindEnum
    info	[Changelog]   - Type of parameter additionalData of interface IoTDeviceEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface IpEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface MailboxEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface MailClusterEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface MailMessageEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface MalwareEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter kind of interface MetadataModel is changed from Kind to string
    info	[Changelog]   - Type of parameter kind of interface MetadataPatch is changed from Kind to string
    info	[Changelog]   - Type of parameter additionalData of interface NicEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface ProcessEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface RegistryKeyEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface RegistryValueEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface SecurityAlert is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface SecurityGroupEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface SubmissionMailEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter additionalData of interface ThreatIntelligenceIndicatorModel is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter kind of interface ThreatIntelligenceInformation is changed from ThreatIntelligenceResourceKindEnum to ThreatIntelligenceResourceInnerKind
    info	[Changelog]   - Type of parameter sortOrder of interface ThreatIntelligenceSortingCriteria is changed from ThreatIntelligenceSortingCriteriaEnum to ThreatIntelligenceSortingOrder
    info	[Changelog]   - Type of parameter additionalData of interface UrlEntity is changed from {
    info	[Changelog]         [propertyName: string]: Record<string, unknown>;
    info	[Changelog]     } to {
    info	[Changelog]         [propertyName: string]: any;
    info	[Changelog]     }
    info	[Changelog]   - Type of parameter webhookSecretUpdateTime of interface Webhook is changed from string to Date
    info	[Changelog]   - Removed Enum KnownEntityKind
    info	[Changelog]   - Removed Enum KnownEnum13
    info	[Changelog]   - Removed Enum KnownThreatIntelligenceResourceKindEnum
    info	[Changelog]   - Removed Enum KnownThreatIntelligenceSortingCriteriaEnum
    info	[Changelog]   - Enum KnownRepoType no longer has value DevOps
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs] Generate from 881296db70f8817ec981b8252a66b49461f4df87. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-securityinsights [View full logs]  [Preview SDK Changes]
️❌ azure-resource-manager-schemas failed [Detail]
  • Failed [Logs] Generate from 881296db70f8817ec981b8252a66b49461f4df87. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.1
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.1>
    cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    warn	No file changes detected after generation
  • securityinsights/resource-manager [View full logs
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs] Generate from 881296db70f8817ec981b8252a66b49461f4df87. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ⚠️Az.securityinsights.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.securityinsights.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Sep 25, 2023

Generated ApiView

Language Package Name ApiView Link
Java azure-resourcemanager-securityinsights https://apiview.dev/Assemblies/Review/05facce2e5e1400ea758cd55f0176f9d
.Net Azure.ResourceManager.SecurityInsights There is no API change compared with the previous version
JavaScript @azure/arm-securityinsight https://apiview.dev/Assemblies/Review/9660ed10609f484186fb228b25f2ee20
Swagger Microsoft.SecurityInsights https://apiview.dev/Assemblies/Review/d59f37f5539f43f79a27fe96f6a30938

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 25, 2023
@oformaniuk
Copy link
Contributor Author

/pr RequestMerge

@raosuhas raosuhas added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 28, 2023
@openapi-workflow-bot openapi-workflow-bot bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 28, 2023
@raosuhas
Copy link

/pr RequestMerge

please check step3 in the flowchart above. You need to get the breaking change signoff before requesting merge

@kazrael2119
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@Alancere
Copy link
Member

Hi @oformaniuk , I updated the readme.md configuration on the main branch, please sync it to make sure the 'SDK azure-sdk-for-go' CI works properly

@oformaniuk
Copy link
Contributor Author

oformaniuk commented Sep 28, 2023

Hi @oformaniuk , I updated the readme.md configuration on the main branch, please sync it to make sure the 'SDK azure-sdk-for-go' CI works properly

@Alancere, I'm not sure what change you're referring to. Can you please elaborate more? I do not want to just sync the main as I'm not merging to the main directly but to another protected branch that I do not have permissions to sync.

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review NewApiVersionRequired and removed ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Oct 24, 2023
@openapi-workflow-bot
Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

This was referenced Oct 24, 2023
@ms-henglu ms-henglu added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 25, 2023
@openapi-workflow-bot openapi-workflow-bot bot removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 25, 2023
@ms-henglu
Copy link
Member

Hi @oformaniuk ,

Please get a breaking changes approval from Azure Breaking Changes Reviewers [email protected]. Once you have the approval, we can merge this PR.

@oformaniuk
Copy link
Contributor Author

Hi @oformaniuk ,

Please get a breaking changes approval from Azure Breaking Changes Reviewers [email protected]. Once you have the approval, we can merge this PR.

@ms-henglu, can you please elaborate what changes requires new version assuming that I'm trying to introduce new version - target branch is our new version branch.

@JeffreyRichter JeffreyRichter added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 25, 2023
@ms-henglu ms-henglu merged commit 925d54f into Azure:release-release-Sentinel-securityinsights-Microsoft.SecurityInsights-2023-10-01-preview Oct 26, 2023
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 Approved-SdkBreakingChange-Go Approve the breaking change tracking for azure-sdk-for-go Approved-SdkBreakingChange-JavaScript Approved-SdkBreakingChange-Python ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review CI-BreakingChange-Go CI-BreakingChange-JavaScript NewApiVersionRequired resource-manager RPaaS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants