Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add referenced route paths to resolve the S360 issue #26130

Merged

Conversation

ZianWang02
Copy link
Contributor

@ZianWang02 ZianWang02 commented Oct 9, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 9, 2023

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 9, 2023

Swagger Validation Report

️❌BreakingChange: 2 Errors, 0 Warnings failed [Detail]
compared swaggers (via Oad v0.10.4)] new version base version
afdx.json 2023-07-01-preview(85fb94c) 2023-07-01-preview(main)
Rule Message
1040 - AddedReadOnlyPropertyInResponse The new version has a new read-only property 'referencedRoutePaths' in response that was not found in the old version.
New: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L4706:7
Old: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L4706:7
1045 - AddedOptionalProperty The new version has a new optional property 'referencedRoutePaths' that was not found in the old version.
New: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L4706:7
Old: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L4706:7
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
compared tags (via openapi-validator v2.1.6) new version base version
package-preview-2023-07 package-preview-2023-07(85fb94c) package-preview-2023-07(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L136
ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L185
PostResponseCodes 202 response for a LRO POST operation must not have a response schema specified.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L292
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L347
ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L357
ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L406
ResourceNameRestriction The resource name parameter 'customDomainName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L406
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L458
RepeatedPathInfo The 'profileName' already appears in the path, please don't repeat it in the request body.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L473
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L521
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L530
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L605
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L614
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L668
ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L678
ResourceNameRestriction The resource name parameter 'customDomainName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L678
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L679
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L730
ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L740
ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L789
ResourceNameRestriction The resource name parameter 'endpointName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L789
PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L841
RepeatedPathInfo The 'profileName' already appears in the path, please don't repeat it in the request body.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L856
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L913
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L988
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L997
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L1051
ResourceNameRestriction The resource name parameter 'profileName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L1061
ResourceNameRestriction The resource name parameter 'endpointName' should be defined with a 'pattern' restriction.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L1061
PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.Cdn/preview/2023-07-01-preview/afdx.json#L1062
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 9, 2023

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python-track2 warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 79bd7fe. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
    cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
    cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
    cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
    cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
    cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
    cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
    cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
    cmderr	[automation_init.sh] WARNING: There was an error checking the latest version of pip.
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
    cmderr	[automation_generate.sh]
    cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.0
    cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0>
    cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[automation_generate.sh] npm notice
  • ️✔️track2_azure-mgmt-cdn [View full logs]  [Release SDK Changes] Breaking Change Detected
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation AFDProfilesOperations.begin_upgrade
    info	[Changelog]   - Added operation AFDProfilesOperations.check_endpoint_name_availability
    info	[Changelog]   - Added operation AFDProfilesOperations.validate_secret
    info	[Changelog]   - Added operation ProfilesOperations.begin_can_migrate
    info	[Changelog]   - Added operation ProfilesOperations.begin_migrate
    info	[Changelog]   - Added operation ProfilesOperations.begin_migration_commit
    info	[Changelog]   - Model AFDDomain has a new parameter extended_properties
    info	[Changelog]   - Model AFDDomainProperties has a new parameter extended_properties
    info	[Changelog]   - Model AzureFirstPartyManagedCertificateParameters has a new parameter certificate_authority
    info	[Changelog]   - Model AzureFirstPartyManagedCertificateParameters has a new parameter expiration_date
    info	[Changelog]   - Model AzureFirstPartyManagedCertificateParameters has a new parameter secret_source
    info	[Changelog]   - Model AzureFirstPartyManagedCertificateParameters has a new parameter subject
    info	[Changelog]   - Model AzureFirstPartyManagedCertificateParameters has a new parameter subject_alternative_names
    info	[Changelog]   - Model AzureFirstPartyManagedCertificateParameters has a new parameter thumbprint
    info	[Changelog]   - Model CdnWebApplicationFirewallPolicy has a new parameter extended_properties
    info	[Changelog]   - Model Profile has a new parameter extended_properties
    info	[Changelog]   - Model Profile has a new parameter identity
    info	[Changelog]   - Model ProfileUpdateParameters has a new parameter identity
    info	[Changelog]
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog]   - Removed operation group ValidateOperations
    info	[Changelog]   - Renamed operation CustomDomainsOperations.disable_custom_https to CustomDomainsOperations.begin_disable_custom_https
    info	[Changelog]   - Renamed operation CustomDomainsOperations.enable_custom_https to CustomDomainsOperations.begin_enable_custom_https
️⚠️ azure-sdk-for-java warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 79bd7fe. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3
    cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-cdn-generated [View full logs]  [Release SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 79bd7fe. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/cdn/armcdn [View full logs]  [Release SDK Changes] Breaking Change Detected
    info	[Changelog] ### Breaking Changes
    info	[Changelog]
    info	[Changelog] - Type of `EndpointProperties.CustomDomains` has been changed from `[]*CustomDomain` to `[]*DeepCreatedCustomDomain`
    info	[Changelog] - Type of `MetricsResponse.Granularity` has been changed from `*MetricsResponseGranularity` to `*MetricsGranularity`
    info	[Changelog] - Type of `MetricsResponseSeriesItem.Unit` has been changed from `*MetricsResponseSeriesItemUnit` to `*MetricsSeriesUnit`
    info	[Changelog] - Type of `WafMetricsResponse.Granularity` has been changed from `*WafMetricsResponseGranularity` to `*WafMetricsGranularity`
    info	[Changelog] - Type of `WafMetricsResponseSeriesItem.Unit` has been changed from `*WafMetricsResponseSeriesItemUnit` to `*WafMetricsSeriesUnit`
    info	[Changelog] - Enum `MetricsResponseGranularity` has been removed
    info	[Changelog] - Enum `MetricsResponseSeriesItemUnit` has been removed
    info	[Changelog] - Enum `WafMetricsResponseGranularity` has been removed
    info	[Changelog] - Enum `WafMetricsResponseSeriesItemUnit` has been removed
    info	[Changelog] - Function `*ClientFactory.NewValidateClient` has been removed
    info	[Changelog] - Function `NewValidateClient` has been removed
    info	[Changelog] - Function `*ValidateClient.Secret` has been removed
    info	[Changelog] - Operation `*CustomDomainsClient.DisableCustomHTTPS` has been changed to LRO, use `*CustomDomainsClient.BeginDisableCustomHTTPS` instead.
    info	[Changelog] - Operation `*CustomDomainsClient.EnableCustomHTTPS` has been changed to LRO, use `*CustomDomainsClient.BeginEnableCustomHTTPS` instead.
    info	[Changelog]
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog] - New value `ProfileResourceStateAbortingMigration`, `ProfileResourceStateCommittingMigration`, `ProfileResourceStateMigrated`, `ProfileResourceStateMigrating`, `ProfileResourceStatePendingMigrationCommit` added to enum type `ProfileResourceState`
    info	[Changelog] - New enum type `CanMigrateDefaultSKU` with values `CanMigrateDefaultSKUPremiumAzureFrontDoor`, `CanMigrateDefaultSKUStandardAzureFrontDoor`
    info	[Changelog] - New enum type `ManagedServiceIdentityType` with values `ManagedServiceIdentityTypeNone`, `ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned`, `ManagedServiceIdentityTypeUserAssigned`
    info	[Changelog] - New enum type `MetricsGranularity` with values `MetricsGranularityP1D`, `MetricsGranularityPT1H`, `MetricsGranularityPT5M`
    info	[Changelog] - New enum type `MetricsSeriesUnit` with values `MetricsSeriesUnitBitsPerSecond`, `MetricsSeriesUnitBytes`, `MetricsSeriesUnitCount`, `MetricsSeriesUnitMilliSeconds`
    info	[Changelog] - New enum type `WafMetricsGranularity` with values `WafMetricsGranularityP1D`, `WafMetricsGranularityPT1H`, `WafMetricsGranularityPT5M`
    info	[Changelog] - New enum type `WafMetricsSeriesUnit` with values `WafMetricsSeriesUnitCount`
    info	[Changelog] - New function `*AFDProfilesClient.CheckEndpointNameAvailability(context.Context, string, string, CheckEndpointNameAvailabilityInput, *AFDProfilesClientCheckEndpointNameAvailabilityOptions) (AFDProfilesClientCheckEndpointNameAvailabilityResponse, error)`
    info	[Changelog] - New function `*AFDProfilesClient.BeginUpgrade(context.Context, string, string, ProfileUpgradeParameters, *AFDProfilesClientBeginUpgradeOptions) (*runtime.Poller[AFDProfilesClientUpgradeResponse], error)`
    info	[Changelog] - New function `*AFDProfilesClient.ValidateSecret(context.Context, string, string, ValidateSecretInput, *AFDProfilesClientValidateSecretOptions) (AFDProfilesClientValidateSecretResponse, error)`
    info	[Changelog] - New function `*ProfilesClient.BeginCanMigrate(context.Context, string, CanMigrateParameters, *ProfilesClientBeginCanMigrateOptions) (*runtime.Poller[ProfilesClientCanMigrateResponse], error)`
    info	[Changelog] - New function `*ProfilesClient.BeginMigrate(context.Context, string, MigrationParameters, *ProfilesClientBeginMigrateOptions) (*runtime.Poller[ProfilesClientMigrateResponse], error)`
    info	[Changelog] - New function `*ProfilesClient.BeginMigrationCommit(context.Context, string, string, *ProfilesClientBeginMigrationCommitOptions) (*runtime.Poller[ProfilesClientMigrationCommitResponse], error)`
    info	[Changelog] - New struct `CanMigrateParameters`
    info	[Changelog] - New struct `CanMigrateProperties`
    info	[Changelog] - New struct `CanMigrateResult`
    info	[Changelog] - New struct `DeepCreatedCustomDomain`
    info	[Changelog] - New struct `DeepCreatedCustomDomainProperties`
    info	[Changelog] - New struct `ManagedServiceIdentity`
    info	[Changelog] - New struct `MigrateResult`
    info	[Changelog] - New struct `MigrateResultProperties`
    info	[Changelog] - New struct `MigrationErrorType`
    info	[Changelog] - New struct `MigrationParameters`
    info	[Changelog] - New struct `MigrationWebApplicationFirewallMapping`
    info	[Changelog] - New struct `ProfileChangeSKUWafMapping`
    info	[Changelog] - New struct `ProfileUpgradeParameters`
    info	[Changelog] - New struct `UserAssignedIdentity`
    info	[Changelog] - New field `ExtendedProperties` in struct `AFDDomainProperties`
    info	[Changelog] - New field `CertificateAuthority`, `ExpirationDate`, `SecretSource`, `Subject`, `SubjectAlternativeNames`, `Thumbprint` in struct `AzureFirstPartyManagedCertificateParameters`
    info	[Changelog] - New field `Identity` in struct `Profile`
    info	[Changelog] - New field `ExtendedProperties` in struct `ProfileProperties`
    info	[Changelog] - New field `Identity` in struct `ProfileUpdateParameters`
    info	[Changelog] - New field `ExtendedProperties` in struct `WebApplicationFirewallPolicyProperties`
    info	[Changelog]
    info	[Changelog] Total 14 breaking change(s), 68 additive change(s).
️❌ azure-sdk-for-net-track2 failed [Detail]
  • Failed [Logs]Release - Generate from 79bd7fe. SDK Automation 14.0.0
    command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
    command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
    cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
  • Azure.ResourceManager.Cdn [View full logs]  [Release SDK Changes]
    info	[Changelog]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
  • ️✔️Succeeded [Logs]Release - Generate from 79bd7fe. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-cdn [View full logs]  [Release SDK Changes] Breaking Change Detected
    Only show 120 items here, please refer to log for details.
    info	[Changelog]   - Added operation Profiles.beginCanMigrateAndWait
    info	[Changelog]   - Added operation Profiles.beginMigrate
    info	[Changelog]   - Added operation Profiles.beginMigrateAndWait
    info	[Changelog]   - Added operation Profiles.beginMigrationCommit
    info	[Changelog]   - Added operation Profiles.beginMigrationCommitAndWait
    info	[Changelog]   - Added Interface AfdCustomDomainsCreateHeaders
    info	[Changelog]   - Added Interface AfdCustomDomainsDeleteHeaders
    info	[Changelog]   - Added Interface AfdCustomDomainsRefreshValidationTokenHeaders
    info	[Changelog]   - Added Interface AfdCustomDomainsUpdateHeaders
    info	[Changelog]   - Added Interface AfdEndpointsCreateHeaders
    info	[Changelog]   - Added Interface AfdEndpointsDeleteHeaders
    info	[Changelog]   - Added Interface AfdEndpointsPurgeContentHeaders
    info	[Changelog]   - Added Interface AfdEndpointsUpdateHeaders
    info	[Changelog]   - Added Interface AfdOriginGroupsCreateHeaders
    info	[Changelog]   - Added Interface AfdOriginGroupsDeleteHeaders
    info	[Changelog]   - Added Interface AfdOriginGroupsUpdateHeaders
    info	[Changelog]   - Added Interface AfdOriginsCreateHeaders
    info	[Changelog]   - Added Interface AfdOriginsDeleteHeaders
    info	[Changelog]   - Added Interface AfdOriginsUpdateHeaders
    info	[Changelog]   - Added Interface AfdProfilesCheckEndpointNameAvailabilityOptionalParams
    info	[Changelog]   - Added Interface AfdProfilesUpgradeHeaders
    info	[Changelog]   - Added Interface AfdProfilesUpgradeOptionalParams
    info	[Changelog]   - Added Interface AfdProfilesValidateSecretOptionalParams
    info	[Changelog]   - Added Interface CanMigrateParameters
    info	[Changelog]   - Added Interface CanMigrateResult
    info	[Changelog]   - Added Interface CustomDomainsCreateHeaders
    info	[Changelog]   - Added Interface CustomDomainsDeleteHeaders
    info	[Changelog]   - Added Interface CustomDomainsDisableCustomHttpsHeaders
    info	[Changelog]   - Added Interface CustomDomainsEnableCustomHttpsHeaders
    info	[Changelog]   - Added Interface EndpointsCreateHeaders
    info	[Changelog]   - Added Interface EndpointsDeleteHeaders
    info	[Changelog]   - Added Interface EndpointsLoadContentHeaders
    info	[Changelog]   - Added Interface EndpointsPurgeContentHeaders
    info	[Changelog]   - Added Interface EndpointsStartHeaders
    info	[Changelog]   - Added Interface EndpointsStopHeaders
    info	[Changelog]   - Added Interface EndpointsUpdateHeaders
    info	[Changelog]   - Added Interface ManagedServiceIdentity
    info	[Changelog]   - Added Interface MigrateResult
    info	[Changelog]   - Added Interface MigrationErrorType
    info	[Changelog]   - Added Interface MigrationParameters
    info	[Changelog]   - Added Interface MigrationWebApplicationFirewallMapping
    info	[Changelog]   - Added Interface OriginGroupsCreateHeaders
    info	[Changelog]   - Added Interface OriginGroupsDeleteHeaders
    info	[Changelog]   - Added Interface OriginGroupsUpdateHeaders
    info	[Changelog]   - Added Interface OriginsCreateHeaders
    info	[Changelog]   - Added Interface OriginsDeleteHeaders
    info	[Changelog]   - Added Interface OriginsUpdateHeaders
    info	[Changelog]   - Added Interface PoliciesCreateOrUpdateHeaders
    info	[Changelog]   - Added Interface PoliciesUpdateHeaders
    info	[Changelog]   - Added Interface ProfileChangeSkuWafMapping
    info	[Changelog]   - Added Interface ProfilesCanMigrateHeaders
    info	[Changelog]   - Added Interface ProfilesCanMigrateOptionalParams
    info	[Changelog]   - Added Interface ProfilesCreateHeaders
    info	[Changelog]   - Added Interface ProfilesDeleteHeaders
    info	[Changelog]   - Added Interface ProfilesMigrateHeaders
    info	[Changelog]   - Added Interface ProfilesMigrateOptionalParams
    info	[Changelog]   - Added Interface ProfilesMigrationCommitHeaders
    info	[Changelog]   - Added Interface ProfilesMigrationCommitOptionalParams
    info	[Changelog]   - Added Interface ProfilesUpdateHeaders
    info	[Changelog]   - Added Interface ProfileUpgradeParameters
    info	[Changelog]   - Added Interface RoutesCreateHeaders
    info	[Changelog]   - Added Interface RoutesDeleteHeaders
    info	[Changelog]   - Added Interface RoutesUpdateHeaders
    info	[Changelog]   - Added Interface RulesCreateHeaders
    info	[Changelog]   - Added Interface RulesDeleteHeaders
    info	[Changelog]   - Added Interface RuleSetsDeleteHeaders
    info	[Changelog]   - Added Interface RulesUpdateHeaders
    info	[Changelog]   - Added Interface SecretsCreateHeaders
    info	[Changelog]   - Added Interface SecretsDeleteHeaders
    info	[Changelog]   - Added Interface SecurityPoliciesCreateHeaders
    info	[Changelog]   - Added Interface SecurityPoliciesDeleteHeaders
    info	[Changelog]   - Added Interface SecurityPoliciesPatchHeaders
    info	[Changelog]   - Added Interface UserAssignedIdentity
    info	[Changelog]   - Added Type Alias AfdProfilesCheckEndpointNameAvailabilityResponse
    info	[Changelog]   - Added Type Alias AfdProfilesUpgradeResponse
    info	[Changelog]   - Added Type Alias AfdProfilesValidateSecretResponse
    info	[Changelog]   - Added Type Alias CanMigrateDefaultSku
    info	[Changelog]   - Added Type Alias ManagedServiceIdentityType
    info	[Changelog]   - Added Type Alias MetricsGranularity
    info	[Changelog]   - Added Type Alias MetricsSeriesUnit
    info	[Changelog]   - Added Type Alias ProfilesCanMigrateResponse
    info	[Changelog]   - Added Type Alias ProfilesMigrateResponse
    info	[Changelog]   - Added Type Alias WafMetricsGranularity
    info	[Changelog]   - Added Type Alias WafMetricsSeriesUnit
    info	[Changelog]   - Interface AFDDomain has a new optional parameter extendedProperties
    info	[Changelog]   - Interface AFDDomainProperties has a new optional parameter extendedProperties
    info	[Changelog]   - Interface AzureFirstPartyManagedCertificateParameters has a new optional parameter certificateAuthority
    info	[Changelog]   - Interface AzureFirstPartyManagedCertificateParameters has a new optional parameter expirationDate
    info	[Changelog]   - Interface AzureFirstPartyManagedCertificateParameters has a new optional parameter secretSource
    info	[Changelog]   - Interface AzureFirstPartyManagedCertificateParameters has a new optional parameter subject
    info	[Changelog]   - Interface AzureFirstPartyManagedCertificateParameters has a new optional parameter subjectAlternativeNames
    info	[Changelog]   - Interface AzureFirstPartyManagedCertificateParameters has a new optional parameter thumbprint
    info	[Changelog]   - Interface CdnWebApplicationFirewallPolicy has a new optional parameter extendedProperties
    info	[Changelog]   - Interface Profile has a new optional parameter extendedProperties
    info	[Changelog]   - Interface Profile has a new optional parameter identity
    info	[Changelog]   - Interface ProfileUpdateParameters has a new optional parameter identity
    info	[Changelog]   - Added Enum KnownCanMigrateDefaultSku
    info	[Changelog]   - Added Enum KnownManagedServiceIdentityType
    info	[Changelog]   - Added Enum KnownMetricsGranularity
    info	[Changelog]   - Added Enum KnownMetricsSeriesUnit
    info	[Changelog]   - Added Enum KnownWafMetricsGranularity
    info	[Changelog]   - Added Enum KnownWafMetricsSeriesUnit
    info	[Changelog]   - Enum KnownProfileResourceState has a new value AbortingMigration
    info	[Changelog]   - Enum KnownProfileResourceState has a new value CommittingMigration
    info	[Changelog]   - Enum KnownProfileResourceState has a new value Migrated
    info	[Changelog]   - Enum KnownProfileResourceState has a new value Migrating
    info	[Changelog]   - Enum KnownProfileResourceState has a new value PendingMigrationCommit
    info	[Changelog]
    info	[Changelog] **Breaking Changes**
    info	[Changelog]
    info	[Changelog]   - Removed operation group Validate
    info	[Changelog]   - Class CdnManagementClient has a new signature
    info	[Changelog]   - Type of parameter granularity of interface MetricsResponse is changed from MetricsResponseGranularity to MetricsGranularity
    info	[Changelog]   - Type of parameter unit of interface MetricsResponseSeriesItem is changed from MetricsResponseSeriesItemUnit to MetricsSeriesUnit
    info	[Changelog]   - Type of parameter granularity of interface WafMetricsResponse is changed from WafMetricsResponseGranularity to WafMetricsGranularity
    info	[Changelog]   - Type of parameter unit of interface WafMetricsResponseSeriesItem is changed from "count" to WafMetricsSeriesUnit
    info	[Changelog]   - Class CdnManagementClient no longer has parameter validate
    info	[Changelog]   - Removed Enum KnownMetricsResponseGranularity
    info	[Changelog]   - Removed Enum KnownMetricsResponseSeriesItemUnit
    info	[Changelog]   - Removed Enum KnownWafMetricsResponseGranularity
️⚠️ azure-resource-manager-schemas warning [Detail]
  • ⚠️Warning [Logs]Release - Generate from 79bd7fe. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh]
    cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.0
    cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.0>
    cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
    cmderr	[initScript.sh] npm notice
    warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    warn	No file changes detected after generation
    warn	Skip detect changed packages
️❌ azure-powershell failed [Detail]
  • Pipeline Framework Failed [Logs]Release - Generate from 79bd7fe. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
    SSL error: syscall failure: Broken pipe
    Error: SSL error: syscall failure: Broken pipe
  • ⚠️Az.cdn.DefaultTag [View full logs
    error	Fatal error: SSL error: syscall failure: Broken pipe
    error	The following packages are still pending:
    error		Az.cdn.DefaultTag
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 9, 2023

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/cdn/armcdn https://apiview.dev/Assemblies/Review/5219c4becd3741009306fa9c650218c3
Java azure-resourcemanager-cdn-generated https://apiview.dev/Assemblies/Review/673146dd22d643ed9497fb901ddffebd
JavaScript @azure/arm-cdn https://apiview.dev/Assemblies/Review/296432895c44402cb532bda832bb6b72

@ZianWang02 ZianWang02 changed the title Update afdx.json Add referenced route paths to resolve the S360 issue Oct 9, 2023
@AzureRestAPISpecReview AzureRestAPISpecReview added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview NewApiVersionRequired ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager labels Oct 9, 2023
@openapi-workflow-bot
Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

@ZianWang02
Copy link
Contributor Author

May I know if we can add a read-only property to the request response to resolve the S360 security issue?

@ZianWang02
Copy link
Contributor Author

Could we bypass the breaking change check because there is no SDK released based on version 2023-07-01-preview?

@ms-zhenhua ms-zhenhua added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 12, 2023
@ZianWang02
Copy link
Contributor Author

/pr RequestMerge

@ZianWang02 ZianWang02 added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required WaitForReviewRevisit and removed MergeRequested labels Oct 13, 2023
@ms-zhenhua
Copy link
Contributor

Please reach out to Azure Breaking Changes Reviewers [email protected] to get a breaking changes approval and ARM can review the changes afterwards. Once you have the approval, please remove the ARMChangesRequested label from the PR to make the PR visible to the ARM reviewers.

@ms-zhenhua ms-zhenhua added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 13, 2023
@mikekistler mikekistler added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Oct 13, 2023
@ZianWang02 ZianWang02 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Oct 16, 2023
@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 16, 2023
@ms-zhenhua ms-zhenhua added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 16, 2023
@ZianWang02
Copy link
Contributor Author

/pr RequestMerge

@rkmanda rkmanda merged commit 79bd7fe into Azure:main Oct 16, 2023
28 of 31 checks passed
@openapi-pipeline-app
Copy link

Swagger pipeline restarted successfully, please wait for status update in this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required CI-BreakingChange-Go CI-BreakingChange-JavaScript FixS360 NewApiVersionRequired ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants