Service Fabric Managed Clusters - API version 2023-11-01-preview

[a-santamaria]

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

• New API version. (Such PR should have been generated with OpenAPI Hub).
• Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
• Update existing version to fix swagger quality issues in S360.
• Other, please clarify:
  • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

• I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
• I have reviewed following Resource Provider guidelines, including
  ARM resource provider contract and
  REST guidelines (estimated time: 4 hours).
  I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

• If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
  you must follow the breaking changes process.
  IMPORTANT This applies even if:
  • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
  • You believe there is no need for you to request breaking change approval, for any reason.
    Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

• If this PR is in purview of ARM review then automation will add the ARMReview label.
• If you want to force ARM review, add the label yourself.
• Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

• For general PR approval workflow, see the diagram at the top of this comment.
• For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
  and https://aka.ms/ci-fix.
• If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

[openapi-pipeline-app]

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

[openapi-pipeline-app]

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌Breaking Change(Cross-Version): 17 Errors, 0 Warnings failed [Detail]

compared swaggers (via Oad v0.10.4)]	new version	base version
managedapplication.json	2023-11-01-preview(7542520)	2022-01-01(main)
managedapplication.json	2023-11-01-preview(7542520)	2023-09-01-preview(main)
managedcluster.json	2023-11-01-preview(7542520)	2022-01-01(main)
managedcluster.json	2023-11-01-preview(7542520)	2023-09-01-preview(main)
nodetype.json	2023-11-01-preview(7542520)	2022-01-01(main)
nodetype.json	2023-11-01-preview(7542520)	2023-09-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
❌ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters' removed or restructured? Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L37:5
❌ 1005 - RemovedPath	The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourcegroups/{resourceGroupName}/providers/Microsoft.ServiceFabric/managedClusters/{clusterName}/nodeTypes' removed or restructured? Old: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L37:5
❌ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.ServiceFabric/preview/2023-11-01-preview/nodetype.json#L695:9 Old: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L576:9
❌ 1023 - TypeFormatChanged	The new version has a different format than the previous one. New: Microsoft.ServiceFabric/preview/2023-11-01-preview/nodetype.json#L700:9 Old: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L580:9
❌ 1025 - RequiredStatusChange	The 'required' status changed from the old version('False') to the new version('True'). New: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L1294:7 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1006:7
❌ 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.ServiceFabric/preview/2023-11-01-preview/nodetype.json#L920:7 Old: Microsoft.ServiceFabric/stable/2022-01-01/nodetype.json#L671:7
❌ 1034 - AddedRequiredProperty	The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L1340:11 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1052:11
❌ 1034 - AddedRequiredProperty	The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L150:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L150:13
❌ 1034 - AddedRequiredProperty	The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L187:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L187:13
❌ 1034 - AddedRequiredProperty	The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L208:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L208:13
❌ 1034 - AddedRequiredProperty	The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L214:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L214:13
❌ 1034 - AddedRequiredProperty	The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L275:13 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L265:13
❌ 1034 - AddedRequiredProperty	The new version has new required property 'sku' that was not found in the old version. New: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L1280:5 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L995:5
❌ 1048 - AddedXmsEnum	The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L1470:11 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1178:11
❌ 1048 - AddedXmsEnum	The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L1604:9 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1261:9
❌ 1048 - AddedXmsEnum	The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L871:5 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L719:5
❌ 1048 - AddedXmsEnum	The new version adds a x-ms-enum extension. New: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L1738:5 Old: Microsoft.ServiceFabric/stable/2022-01-01/managedcluster.json#L1311:5

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 10 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.6)	new version	base version
package-2023-11-preview	package-2023-11-preview(7542520)	default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ PostOperationIdContainsUrlVerb	OperationId should contain the verb: 'fetchupgradestatus' in:'Applications_ReadUpgrade'. Consider updating the operationId Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L587
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L590
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L590
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L590
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L647
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L647
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L647
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'api-version'. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L704
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L704
⚠️ ParameterNotUsingCommonTypes	Not using the common-types defined parameter 'subscriptionId'. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L704

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
❌ PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L82
❌ DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L189
❌ LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L223
❌ ProvisioningStateSpecifiedForLROPut	201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L335
❌ PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L335
❌ DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L468
❌ ProvisioningStateSpecifiedForLROPut	201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L808
❌ PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L808
❌ PatchIdentityProperty	The patch operation body parameter schema should contain property 'identity'. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L908
❌ DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L938
❌ ProvisioningStateSpecifiedForLROPut	201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L1094
❌ PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L1094
❌ DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L1230
❌ SystemDataDefinitionsCommonTypes	System data references must utilize common types. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L2063
❌ ProvisioningStateSpecifiedForLROPut	201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L162
❌ PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L162
❌ DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L287
❌ GetCollectionResponseSchema	The response in the GET collection operation 'ManagedClusterVersion_List' does not match the response definition in the individual GET operation 'ManagedClusterVersion_Get' . Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L561
❌ GetCollectionResponseSchema	The response in the GET collection operation 'ManagedClusterVersion_ListByEnvironment' does not match the response definition in the individual GET operation 'ManagedClusterVersion_GetByEnvironment' . Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L601
❌ LroExtension	Operations with a 202 response must specify x-ms-long-running-operation: true. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L777
❌ GetOperation200	The get operation should only return 200. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L807
❌ GetOperation200	The get operation should only return 200. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L816
❌ OperationsApiSchemaUsesCommonTypes	Operations API path must follow the schema provided in the common types. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L854
❌ SystemDataDefinitionsCommonTypes	System data references must utilize common types. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedcluster.json#L2154
❌ PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/nodetype.json#L84
❌ PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/nodetype.json#L154
❌ PostResponseCodes	200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/nodetype.json#L227
❌ ProvisioningStateSpecifiedForLROPut	201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/nodetype.json#L390
❌ PutResponseCodes	Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/nodetype.json#L390
❌ DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/nodetype.json#L542

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account. 

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️❌ azure-sdk-for-net-track2 failed [Detail]

• ❌Failed [Logs]Release - Generate from ce96a72. SDK Automation 14.0.0

  command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
  command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:807
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 807 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:714
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 714 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
  cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

• ❌Azure.ResourceManager.ServiceFabricManagedClusters [View full logs]  [Release SDK Changes]

  info	[Changelog]

️⚠️ azure-sdk-for-python-track2 warning [Detail]

• ⚠️Warning [Logs]Release - Generate from ce96a72. SDK Automation 14.0.0

  command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
  cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
  cmderr	[automation_init.sh] WARNING: azure-devtools 1.2.1 does not provide the extra 'ci-tools'
  cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
  command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  cmderr	[automation_generate.sh]
  cmderr	[automation_generate.sh] npm notice New major version of npm available! 9.8.1 -> 10.2.3
  cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.3>
  cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
  cmderr	[automation_generate.sh] npm notice

• ️✔️track2_azure-mgmt-servicefabricmanagedclusters [View full logs]  [Release SDK Changes]
  • azure_mgmt_servicefabricmanagedclusters-0.1.0-py3-none-any.whl
  • azure-mgmt-servicefabricmanagedclusters-0.1.0.zip

  info	[Changelog] ### Features Added
  info	[Changelog]
  info	[Changelog]   - Added operation ApplicationsOperations.begin_read_upgrade
  info	[Changelog]   - Added operation ApplicationsOperations.begin_resume_upgrade
  info	[Changelog]   - Added operation ApplicationsOperations.begin_start_rollback
  info	[Changelog]   - Added operation group ManagedApplyMaintenanceWindowOperations
  info	[Changelog]   - Added operation group ManagedMaintenanceWindowStatusOperations
  info	[Changelog]   - Model ManagedCluster has a new parameter ddos_protection_plan_id
  info	[Changelog]   - Model ManagedCluster has a new parameter public_i_pv6_prefix_id
  info	[Changelog]   - Model ManagedCluster has a new parameter public_ip_prefix_id
  info	[Changelog]   - Model ManagedCluster has a new parameter upgrade_description
  info	[Changelog]   - Model NodeType has a new parameter additional_network_interface_configurations
  info	[Changelog]   - Model NodeType has a new parameter dscp_configuration_id
  info	[Changelog]   - Model NodeType has a new parameter enable_node_public_i_pv6
  info	[Changelog]   - Model NodeType has a new parameter nat_gateway_id
  info	[Changelog]   - Model NodeType has a new parameter service_artifact_reference_id
  info	[Changelog]   - Model NodeType has a new parameter vm_image_plan
  info	[Changelog]   - Model VMSSExtension has a new parameter setup_order

️⚠️ azure-resource-manager-schemas warning [Detail]

• ⚠️Warning [Logs]Release - Generate from ce96a72. Schema Automation 14.0.0

  command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
  cmderr	[initScript.sh] npm notice
  cmderr	[initScript.sh] npm notice New major version of npm available! 8.19.4 -> 10.2.3
  cmderr	[initScript.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.3>
  cmderr	[initScript.sh] npm notice Run `npm install -g [email protected]` to update!
  cmderr	[initScript.sh] npm notice
  warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
  command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json

• ️✔️servicefabricmanagedclusters [View full logs]  [Release Schema Changes]

️❌ azure-powershell failed [Detail]

• ❌Pipeline Framework Failed [Logs]Release - Generate from ce96a72. SDK Automation 14.0.0

  command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
  command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  SSL error: syscall failure: Broken pipe
  Error: SSL error: syscall failure: Broken pipe

• ⚠️Az.servicefabricmanagedclusters.DefaultTag [View full logs] 

  error	Fatal error: SSL error: syscall failure: Broken pipe
  error	The following packages are still pending:
  error		Az.servicefabricmanagedclusters.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

[openapi-pipeline-app]

Generated ApiView

Language	Package Name	ApiView Link
Swagger	Microsoft.ServiceFabric	https://apiview.dev/Assemblies/Review/857e94791de3473abb90915939fa7945

[openapi-workflow-bot]

Hi @a-santamaria! For review efficiency consideration, when creating a new API version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version.
For more details refer to the wiki.

[openapi-workflow-bot]

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

[a-santamaria]

for LintDiff error with have a work item to fix it this semester https://msazure.visualstudio.com/One/_workitems/edit/24841215 . but its going to take some time because we generate the swagger from an internal repo that currently cant reference the common types.

❌LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above.Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L633
❌ LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above.Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L690
❌ LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above.Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L757
❌ LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above.Location: Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json#L824

Breaking Change(Cross-Version): Those are changes we already got approval in older versions. non are introduced in this new api

[rkmanda]

Please add a suppression for the lint diff errors and provide a link to the work item in the description of the suppression

[rkmanda]

    }

generic properties are not allowed.

---

Refers to: specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json:1433 in 9adf31d. [](commit_id = 9adf31d, deletion_comment = False)

[rkmanda]

    }

same for all other places.

---

In reply to: 1772094825

---

Refers to: specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json:1433 in 732e562. [](commit_id = 732e562, deletion_comment = False)

[rkmanda]

    }

Pl explain why you cannot define a concrete type for the property

---

In reply to: 1772106615

---

Refers to: specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json:1433 in 732e562. [](commit_id = 732e562, deletion_comment = False)

[rkmanda]

    }

generic properties are not allowed.
Refers to: specification/servicefabricmanagedclusters/resource-manager/Microsoft.ServiceFabric/preview/2023-11-01-preview/managedapplication.json:1433 in 9adf31d. [](commit_id = 9adf31d, deletion_comment = False)

@rkmanda thanks for the review. We decided to go with generic object for RuntimeServiceTypeHealthPolicyMap because for historical reasons we already defined ServiceTypeHealthPolicyMap used on the upgradePolicy on ApplicationResourceProperties that way. So we created the same definition for RuntimeServiceTypeHealthPolicyMap for the app actions, but keeping them as separate definitions in case in the future the runtime definitions change, we don't want them to be tied together.
as you can see in the example https://github.com/Azure/azure-rest-api-specs/pull/26178/files#diff-bddcb320f60e156e403b253d2249de57ec774d539c6020fdb885330df6ae414a the property will look like this:

"serviceTypeHealthPolicyMap": {
          "VotingWeb": {
            "maxPercentUnhealthyPartitionsPerService": 13,
            "maxPercentUnhealthyReplicasPerPartition": 14,
            "maxPercentUnhealthyServices": 15
          }
        }

That is how the service fabric runtime defines it and we couldn't model this another way than with generic type in the swagger.

Will there be any validations done on the keys of each of these dictionaries? Or will the dictionary be a pass through to your backend services? Service owned properties MUST be modeled as concrete types. If you would like to stick with your approach, pl book an ARM modeling office hours slot to discuss with the current on-call engineer. https://armwiki.azurewebsites.net/introduction/office_hours.html

ok we removed the action for now and will add it in the next api with concrete types

I see many more properties using additionalProperties. My comment was for all such instances not just this one. Please either provide an exaplanation for why these cannot be concrete types or remove them.

[a-santamaria]

rkmanda

@rkmanda, but they were not introduced on this api, right? we will not change the properties we already have because that would mean breaking changes. Or am I missing a property we introduced in this new api?

[rkmanda]

managedapplication, managedcluster and nodetype all are showing up as newly added json files so its unclear to me what the new changes are.

#26178 (comment)

[rkmanda]

managedapplication, managedcluster and nodetype all are showing up as newly added json files so its unclear to me what the new changes are.

#26178 (comment)

Please come to one of our office hours and we can review this together instead of the back and forth. Either that or please follow the comment on how to create a PR for a new version that make the review easy

[a-santamaria]

managedapplication, managedcluster and nodetype all are showing up as newly added json files so its unclear to me what the new changes are.
#26178 (comment)

Please come to one of our office hours and we can review this together instead of the back and forth. Either that or please follow the comment on how to create a PR for a new version that make the review easy

@rkmanda, please take a look at this commit 7542520. I squashed all the commits that address comments in this pr so its easy to see the changes compared to the old api

[zizw123]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[openapi-pipeline-app]

Swagger pipeline restarted successfully, please wait for status update in this comment.