Web: adding support for computeMode to App Service plans
#2645
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2228,6 +2228,19 @@ | |
| "description": "Family code of the resource SKU.", | ||
| "type": "string" | ||
| }, | ||
| "computeMode": { | ||
| "description": "Shared or dedicated app hosting.", | ||
| "enum": [ | ||
| "Shared", | ||
| "Dedicated", | ||
| "Dynamic" | ||
| ], | ||
| "type": "string", | ||
| "x-ms-enum": { | ||
| "name": "ComputeModeOptions", | ||
| "modelAsString": false | ||
|
There was a problem hiding this comment. Are you sure you want to set There was a problem hiding this comment. Also, you may want to update some of the There was a problem hiding this comment. I copied and paste this from another section below, so I assume that’s intentional ¯_(ツ)_/¯ I can definitely add an example though, sure 👍🏼 There was a problem hiding this comment. As long as you are aware of the implications of breaking changes, we are OK with this. If you think that the value of this enum may change in the future we recommend setting There was a problem hiding this comment. pushed changes to update this and the existing reference to There was a problem hiding this comment. @tombuildsstuff What is the motivation for adding computemode to App Service Plan. You can get that information about dedicated/shared/dynamic from the App Service Plan SKU. https://docs.microsoft.com/en-us/rest/api/appservice/appserviceplans/createorupdate#skudescription Consumption Plan: From: https://docs.microsoft.com/en-us/rest/api/appservice/appserviceplans/getserverfarmskus { |
||
| } | ||
| }, | ||
| "capacity": { | ||
| "format": "int32", | ||
| "description": "Current number of instances assigned to the resource.", | ||
|
|
@@ -2792,4 +2805,4 @@ | |
| ] | ||
| } | ||
| ] | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you are redefining the same enum
ComputeModeOptionsmultiple times but with different values for"modelAsString". What you may do is"modelAsString":truefor each definition ofComputeModeOptionsI'd recommend the former
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I was just trying to debug that 😄
I've gone with the latter for the moment to get the build to pass, and I'll now look into the former :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pushed a change for the former 🤞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dsgouda sorry to pester, but would you be able to advise/explain how I can fix this build on Java and Go, since it appears fine in the Node build?