Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for arm-resource-name-pattern rule #28085

Closed
wants to merge 24 commits into from

Conversation

tjprescott
Copy link
Member

mikeharder and others added 24 commits February 7, 2024 22:58
- openapi3 does not yet support deterministic property ordering
* Add suppressions for no-record rule.

* Additional suppresssions.

* Update supressions.
- Diff HEAD against HEAD~2 instead of HEAD^1 to account for "git merge main"
* regen with readonly page

* missing
* Fixes

* Additional suppressions.

* Fix format
…rule (#28056)

* Test,

* Try this.

* Now THIS!

* Fix missing suppressions.

* Fix format.
* Fix linting issue with devopsinfrastructure in typespec-next

* fix formatting
Copy link

openapi-pipeline-app bot commented Mar 5, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

Copy link

openapi-pipeline-app bot commented Mar 5, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️LintDiff succeeded [Detail] [Expand]
Validation passes for LintDiff.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️⌛Automated merging requirements met pending [Detail]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Mar 5, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

Posted by Swagger Pipeline | How to fix these errors?

Copy link

PR validation pipeline started successfully. If there is ApiView generated, it will be updated in this comment.

tjprescott added a commit to Azure/typespec-azure that referenced this pull request Mar 28, 2024
… `ResourceNamePattern` rule (#359)

Closes Azure/typespec-azure-pr#3903

**REST API Specs** (6 violations)
Azure/azure-rest-api-specs#28085

**OpenAPI Validator PR**
Azure/azure-openapi-validator#669

---------

Co-authored-by: Mark Cowlishaw <[email protected]>
@tjprescott tjprescott closed this Mar 29, 2024
@tjprescott tjprescott deleted the tsp/ResourceNamePatternRule branch March 29, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants